node-mac-recorder 2.18.2 → 2.18.3

package/index.js

@@ -252,6 +252,12 @@ class MacRecorder extends EventEmitter {
 
 						// Recording için display bilgisini sakla (cursor capture için)
 						const targetDisplay = displays.find(d => d.id === targetDisplayId);
+
+						// CRITICAL FIX: Get actual physical dimensions for proper cursor scaling
+						// This fixes cursor coordinate issues on Retina displays during AVFoundation recording
+						const cursorPosition = nativeBinding.getCursorPosition();
+						const displayScalingInfo = cursorPosition.displayInfo;
+
 						this.recordingDisplayInfo = {
 							displayId: targetDisplayId,
 							x: targetDisplay.x,
@@ -261,6 +267,10 @@ class MacRecorder extends EventEmitter {
 							// Add scaling information for cursor coordinate transformation
 							logicalWidth: parseInt(targetDisplay.resolution.split("x")[0]),
 							logicalHeight: parseInt(targetDisplay.resolution.split("x")[1]),
+							// CRITICAL: Add physical dimensions for proper cursor scaling
+							physicalWidth: displayScalingInfo ? displayScalingInfo.physicalWidth : parseInt(targetDisplay.resolution.split("x")[0]),
+							physicalHeight: displayScalingInfo ? displayScalingInfo.physicalHeight : parseInt(targetDisplay.resolution.split("x")[1]),
+							scaleFactor: displayScalingInfo ? displayScalingInfo.scaleFactor : 1.0,
 						};
 					}
 
@@ -298,6 +308,11 @@ class MacRecorder extends EventEmitter {
 				}
 
 				if (targetDisplay) {
+					// CRITICAL FIX: Get actual physical dimensions for proper cursor scaling
+					// This fixes cursor coordinate issues on Retina displays during AVFoundation recording
+					const cursorPosition = nativeBinding.getCursorPosition();
+					const displayScalingInfo = cursorPosition.displayInfo;
+
 					this.recordingDisplayInfo = {
 						displayId: targetDisplay.id,
 						x: targetDisplay.x || 0,
@@ -307,6 +322,10 @@ class MacRecorder extends EventEmitter {
 						// Add scaling information for cursor coordinate transformation
 						logicalWidth: parseInt(targetDisplay.resolution.split("x")[0]),
 						logicalHeight: parseInt(targetDisplay.resolution.split("x")[1]),
+						// CRITICAL: Add physical dimensions for proper cursor scaling
+						physicalWidth: displayScalingInfo ? displayScalingInfo.physicalWidth : parseInt(targetDisplay.resolution.split("x")[0]),
+						physicalHeight: displayScalingInfo ? displayScalingInfo.physicalHeight : parseInt(targetDisplay.resolution.split("x")[1]),
+						scaleFactor: displayScalingInfo ? displayScalingInfo.scaleFactor : 1.0,
 					};
 				}
 			} catch (error) {
@@ -712,6 +731,10 @@ class MacRecorder extends EventEmitter {
 				displayY: options.displayInfo.y || 0,
 				displayWidth: options.displayInfo.width || options.displayInfo.logicalWidth,
 				displayHeight: options.displayInfo.height || options.displayInfo.logicalHeight,
+				// CRITICAL: Add physical dimensions for proper cursor scaling
+				physicalWidth: options.displayInfo.physicalWidth || options.displayInfo.width || options.displayInfo.logicalWidth,
+				physicalHeight: options.displayInfo.physicalHeight || options.displayInfo.height || options.displayInfo.logicalHeight,
+				scaleFactor: options.displayInfo.scaleFactor || 1.0,
 				videoOffsetX: videoOffsetX,
 				videoOffsetY: videoOffsetY,
 				videoWidth: videoWidth,
@@ -730,6 +753,10 @@ class MacRecorder extends EventEmitter {
 				displayY: this.recordingDisplayInfo.y || 0,
 				displayWidth: this.recordingDisplayInfo.width || this.recordingDisplayInfo.logicalWidth,
 				displayHeight: this.recordingDisplayInfo.height || this.recordingDisplayInfo.logicalHeight,
+				// CRITICAL: Include physical dimensions from recording display info
+				physicalWidth: this.recordingDisplayInfo.physicalWidth || this.recordingDisplayInfo.width || this.recordingDisplayInfo.logicalWidth,
+				physicalHeight: this.recordingDisplayInfo.physicalHeight || this.recordingDisplayInfo.height || this.recordingDisplayInfo.logicalHeight,
+				scaleFactor: this.recordingDisplayInfo.scaleFactor || 1.0,
 				videoOffsetX: 0,
 				videoOffsetY: 0,
 				videoWidth: this.recordingDisplayInfo.width || this.recordingDisplayInfo.logicalWidth,
@@ -785,19 +812,32 @@ class MacRecorder extends EventEmitter {
 							const displayRelativeX = position.x - this.cursorDisplayInfo.displayX;
 							const displayRelativeY = position.y - this.cursorDisplayInfo.displayY;
 
+							// CRITICAL FIX: Apply physical scaling for AVFoundation recording
+							// AVFoundation records at physical resolution while cursor coordinates are logical
+							let scaledX = displayRelativeX;
+							let scaledY = displayRelativeY;
+
+							if (this.cursorDisplayInfo.scaleFactor && this.cursorDisplayInfo.scaleFactor > 1.0) {
+								// Scale logical cursor coordinates to match physical video dimensions
+								scaledX = displayRelativeX * this.cursorDisplayInfo.scaleFactor;
+								scaledY = displayRelativeY * this.cursorDisplayInfo.scaleFactor;
+								coordinateSystem = "video-relative-scaled";
+							}
+
 							// Step 2: Transform display-relative → video-relative coordinates
-							x = displayRelativeX - this.cursorDisplayInfo.videoOffsetX;
-							y = displayRelativeY - this.cursorDisplayInfo.videoOffsetY;
-							coordinateSystem = "video-relative";
+							x = scaledX - this.cursorDisplayInfo.videoOffsetX;
+							y = scaledY - this.cursorDisplayInfo.videoOffsetY;
+							coordinateSystem = this.cursorDisplayInfo.scaleFactor > 1.0 ? "video-relative-scaled" : "video-relative";
+
+							// Bounds check for video area (use physical video dimensions for AVFoundation)
+							const videoWidth = this.cursorDisplayInfo.physicalWidth || this.cursorDisplayInfo.videoWidth;
+							const videoHeight = this.cursorDisplayInfo.physicalHeight || this.cursorDisplayInfo.videoHeight;
 
-							// Bounds check for video area (don't skip, just note if outside)
-							const outsideVideo = x < 0 || y < 0 ||
-								x >= this.cursorDisplayInfo.videoWidth ||
-								y >= this.cursorDisplayInfo.videoHeight;
+							const outsideVideo = x < 0 || y < 0 || x >= videoWidth || y >= videoHeight;
 
 							// For debugging - add metadata if cursor is outside video area
 							if (outsideVideo) {
-								coordinateSystem = "video-relative-outside";
+								coordinateSystem = coordinateSystem + "-outside";
 							}
 						}
 
@@ -815,12 +855,19 @@ class MacRecorder extends EventEmitter {
 								width: this.cursorDisplayInfo.videoWidth,
 								height: this.cursorDisplayInfo.videoHeight,
 								offsetX: this.cursorDisplayInfo.videoOffsetX,
-								offsetY: this.cursorDisplayInfo.videoOffsetY
+								offsetY: this.cursorDisplayInfo.videoOffsetY,
+								// CRITICAL: Add physical dimensions for debugging
+								physicalWidth: this.cursorDisplayInfo.physicalWidth,
+								physicalHeight: this.cursorDisplayInfo.physicalHeight
 							} : null,
 							displayInfo: this.cursorDisplayInfo ? {
 								displayId: this.cursorDisplayInfo.displayId,
 								width: this.cursorDisplayInfo.displayWidth,
-								height: this.cursorDisplayInfo.displayHeight
+								height: this.cursorDisplayInfo.displayHeight,
+								// CRITICAL: Add scaling info for debugging AVFoundation cursor issues
+								physicalWidth: this.cursorDisplayInfo.physicalWidth,
+								physicalHeight: this.cursorDisplayInfo.physicalHeight,
+								scaleFactor: this.cursorDisplayInfo.scaleFactor
 							} : null
 						};
 

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.18.2",
+	"version": "2.18.3",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [