node-mac-recorder 2.17.13 → 2.17.14

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.17.13",
+	"version": "2.17.14",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/cursor_tracker.mm

@@ -43,9 +43,9 @@ static NSTimeInterval g_lastCursorCheckTime = 0;
 static int g_sameCursorDetectionCount = 0;
 static NSString *g_pendingCursorType = nil;
 
-// Cursor stability constants
-static const NSTimeInterval CURSOR_STABILITY_THRESHOLD = 0.1; // 100ms
-static const int CURSOR_CONFIRMATION_COUNT = 2; // Need 2 consecutive detections
+// Cursor stability constants - more responsive
+static const NSTimeInterval CURSOR_STABILITY_THRESHOLD = 0.05; // 50ms (faster response)
+static const int CURSOR_CONFIRMATION_COUNT = 1; // Need 1 detection (more responsive)
 
 // Mouse button state tracking
 static bool g_leftMouseDown = false;
@@ -157,13 +157,48 @@ NSString* getCursorType() {
                         [elementRole isEqualToString:@"AXSearchField"]) {
                         contextualCursorType = @"text";
                     }
-                    // POINTER CURSORS - only for interactive elements
+                    // POINTER CURSORS - interactive elements with broader detection
                     else if ([elementRole isEqualToString:@"AXLink"] ||
                              [elementRole isEqualToString:@"AXButton"] ||
                              [elementRole isEqualToString:@"AXMenuItem"] ||
                              [elementRole isEqualToString:@"AXRadioButton"] ||
-                             [elementRole isEqualToString:@"AXCheckBox"]) {
+                             [elementRole isEqualToString:@"AXCheckBox"] ||
+                             [elementRole isEqualToString:@"AXPopUpButton"] ||
+                             [elementRole isEqualToString:@"AXTab"]) {
                         contextualCursorType = @"pointer";
+
+                        // Also check subroles for links and buttons
+                        CFStringRef subrole = NULL;
+                        AXError subroleError = AXUIElementCopyAttributeValue(elementAtPosition, kAXSubroleAttribute, (CFTypeRef*)&subrole);
+                        if (subroleError == kAXErrorSuccess && subrole) {
+                            NSString *elementSubrole = (__bridge_transfer NSString*)subrole;
+                            if ([elementSubrole isEqualToString:@"AXCloseButton"] ||
+                                [elementSubrole isEqualToString:@"AXMinimizeButton"] ||
+                                [elementSubrole isEqualToString:@"AXZoomButton"] ||
+                                [elementSubrole isEqualToString:@"AXToolbarButton"]) {
+                                contextualCursorType = @"pointer";
+                            }
+                        }
+                    }
+                    // WEB ELEMENTS - for web links that might not show as AXLink
+                    else if ([elementRole isEqualToString:@"AXGroup"] ||
+                             [elementRole isEqualToString:@"AXStaticText"]) {
+                        // Check if it's clickable/has action
+                        CFArrayRef actions = NULL;
+                        AXError actionsError = AXUIElementCopyActionNames(elementAtPosition, &actions);
+                        if (actionsError == kAXErrorSuccess && actions) {
+                            CFIndex actionCount = CFArrayGetCount(actions);
+                            for (CFIndex i = 0; i < actionCount; i++) {
+                                CFStringRef action = (CFStringRef)CFArrayGetValueAtIndex(actions, i);
+                                NSString *actionStr = (__bridge NSString*)action;
+                                if ([actionStr isEqualToString:@"AXPress"] ||
+                                    [actionStr isEqualToString:@"AXShowMenu"]) {
+                                    contextualCursorType = @"pointer";
+                                    break;
+                                }
+                            }
+                            CFRelease(actions);
+                        }
                     }
                     // WINDOW BORDER RESIZE - critical for resize detection
                     else if ([elementRole isEqualToString:@"AXWindow"]) {
@@ -239,7 +274,7 @@ NSString* getCursorType() {
             // Layer 3: Intelligent fusion of NSCursor and contextual results
             NSString *detectedCursorType = @"default";
 
-            // Priority logic:
+            // Priority logic with better fallback:
             // 1. If contextual gives resize cursor, always use it (resize has highest priority)
             if (contextualCursorType != nil &&
                 ([contextualCursorType hasSuffix:@"resize"] ||
@@ -247,14 +282,19 @@ NSString* getCursorType() {
                  [contextualCursorType isEqualToString:@"ns-resize"])) {
                 detectedCursorType = contextualCursorType;
             }
-            // 2. If NSCursor gives a definitive answer and no resize context, use it
+            // 2. If NSCursor gives a definitive answer, use it
             else if (nsCursorType != nil) {
                 detectedCursorType = nsCursorType;
             }
-            // 3. If NSCursor is nil/unknown, but contextual is available, use contextual
-            else if (contextualCursorType != nil) {
+            // 3. If contextual gives specific non-resize cursor, use it
+            else if (contextualCursorType != nil &&
+                     ![contextualCursorType isEqualToString:@"default"]) {
                 detectedCursorType = contextualCursorType;
             }
+            // 4. If both are nil or default, use true default
+            else {
+                detectedCursorType = @"default";
+            }
 
             // Layer 4: Stability filtering to prevent oscillation