node-mac-recorder 2.16.6 → 2.16.7

package/.claude/settings.local.json

@@ -49,7 +49,8 @@
       "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing AVFoundation fallback path (macOS 14 simulation)'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testAVFoundationPath() {\n  try {\n    const outputPath = ''./test-output/force-avfoundation-test.mov'';\n    console.log(''📹 Testing AVFoundation (simulating macOS 14)...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started with AVFoundation'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ AVFoundation test completed successfully!'');\n      console.log(''This is how it should work on macOS 14'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestAVFoundationPath();\n\")",
       "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing AVFoundation with detailed debugging'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testWithDebugging() {\n  try {\n    const outputPath = ''./test-output/debug-test.mov'';\n    console.log(''📹 Starting AVFoundation test with debugging...'');\n    console.log(''Expected to see detailed AVFoundation logs in console'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started'');\n      await new Promise(resolve => setTimeout(resolve, 2000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ Test completed'');\n    } else {\n      console.log(''❌ Recording failed - check console logs for AVFoundation details'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestWithDebugging();\n\")",
       "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing macOS 13/14 path (forced AVFoundation)'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testMacOS1314Path() {\n  try {\n    const outputPath = ''./test-output/macos1314-test.mov'';\n    console.log(''📹 Starting test for macOS 13/14 path...'');\n    console.log(''This simulates the exact path macOS 13/14 users will take'');\n    console.log('''');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ SUCCESS: Recording started on macOS 13/14 path!'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ Recording completed successfully!'');\n      console.log(''📁 Output:'', outputPath);\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n    console.log(''This error would be what macOS 13/14 users see'');\n  }\n}\n\ntestMacOS1314Path();\n\")",
-      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing macOS 14 Direct AVFoundation Path'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testDirectAVFoundation() {\n  try {\n    const outputPath = ''./test-output/direct-avfoundation-test.mov'';\n    console.log(''📹 Testing direct AVFoundation path (macOS 14 simulation)...'');\n    console.log(''Expected logs:'');\n    console.log(''  🎯 macOS 14 detected - directly using AVFoundation'');\n    console.log(''  ⏭️ Skipping ScreenCaptureKit completely, jumping to AVFoundation'');\n    console.log(''  🎬 AVFoundation: Starting recording initialization'');\n    console.log('''');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ SUCCESS: Direct AVFoundation path works!'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ Recording completed successfully!'');\n      console.log('''');\n      console.log(''🎉 This is exactly how macOS 14 will work:'');\n      console.log(''✅ No ScreenCaptureKit attempts'');\n      console.log(''✅ Direct AVFoundation usage'');\n      console.log(''✅ No permission errors'');\n    } else {\n      console.log(''❌ Recording failed'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestDirectAVFoundation();\n\")"
+      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing macOS 14 Direct AVFoundation Path'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testDirectAVFoundation() {\n  try {\n    const outputPath = ''./test-output/direct-avfoundation-test.mov'';\n    console.log(''📹 Testing direct AVFoundation path (macOS 14 simulation)...'');\n    console.log(''Expected logs:'');\n    console.log(''  🎯 macOS 14 detected - directly using AVFoundation'');\n    console.log(''  ⏭️ Skipping ScreenCaptureKit completely, jumping to AVFoundation'');\n    console.log(''  🎬 AVFoundation: Starting recording initialization'');\n    console.log('''');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ SUCCESS: Direct AVFoundation path works!'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ Recording completed successfully!'');\n      console.log('''');\n      console.log(''🎉 This is exactly how macOS 14 will work:'');\n      console.log(''✅ No ScreenCaptureKit attempts'');\n      console.log(''✅ Direct AVFoundation usage'');\n      console.log(''✅ No permission errors'');\n    } else {\n      console.log(''❌ Recording failed'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestDirectAVFoundation();\n\")",
+      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🔥 FINAL TEST: macOS 14 Direct AVFoundation (NO ScreenCaptureKit)'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function finalTest() {\n  try {\n    const outputPath = ''./test-output/final-macos14-test.mov'';\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''🎉 SUCCESS: macOS 14 AVFoundation works!'');\n      await new Promise(resolve => setTimeout(resolve, 2000));\n      await recorder.stopRecording();\n      console.log(''✅ Test completed - macOS 14 is FIXED!'');\n    } else {\n      console.log(''❌ Still failed'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\nfinalTest();\n\")"
     ],
     "deny": []
   }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.16.6",
+	"version": "2.16.7",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/mac_recorder.mm

@@ -205,9 +205,9 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
             NSLog(@"🔧 FORCE_AVFOUNDATION environment variable detected - skipping ScreenCaptureKit");
         }
         
-        // Use ScreenCaptureKit only on macOS 15+ for maximum stability
-        // macOS 14/13 should skip ScreenCaptureKit completely and use AVFoundation
-        if (@available(macOS 12.3, *) && isM15Plus && !forceAVFoundation) {
+        // ONLY use ScreenCaptureKit on macOS 15+
+        // macOS 14/13 ALWAYS use AVFoundation - NO ScreenCaptureKit attempts
+        if (isM15Plus && !forceAVFoundation && !isElectron) {
             NSLog(@"✅ macOS 15+ detected - ScreenCaptureKit available with full compatibility");
             
             // Try ScreenCaptureKit with extensive safety measures
@@ -280,40 +280,29 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
                 NSLog(@"❌ Exception during ScreenCaptureKit availability check: %@", availabilityException.reason);
                 return Napi::Boolean::New(env, false);
             }
-        } else if (isM14Plus && !isElectron) {
-            // macOS 14 - directly use AVFoundation, skip all ScreenCaptureKit logic
-            NSLog(@"🎯 macOS 14 detected - directly using AVFoundation for better compatibility");
-            NSLog(@"⏭️ Skipping ScreenCaptureKit completely, jumping to AVFoundation");
-            goto useAVFoundation;
-        } else if (isM13Plus && !isElectron) {
-            // macOS 13 - directly use AVFoundation, skip all ScreenCaptureKit logic  
-            NSLog(@"🎯 macOS 13 detected - directly using AVFoundation (limited features)");
-            NSLog(@"⏭️ Skipping ScreenCaptureKit completely, jumping to AVFoundation");
-            goto useAVFoundation;
         } else {
-            NSLog(@"❌ macOS version too old (< 13.0) or Electron environment - Recording not supported");
-            return Napi::Boolean::New(env, false);
+            // macOS 14/13 or not macOS 15+ - ALWAYS use AVFoundation
+            if (isElectron) {
+                NSLog(@"❌ Electron environment - Recording not supported");
+                return Napi::Boolean::New(env, false);
+            }
+            
+            if (isM14Plus) {
+                NSLog(@"🎯 macOS 14 detected - using AVFoundation (primary method)");
+            } else if (isM13Plus) {
+                NSLog(@"🎯 macOS 13 detected - using AVFoundation (limited features)");  
+            } else {
+                NSLog(@"❌ macOS version too old (< 13.0) - Not supported");
+                return Napi::Boolean::New(env, false);
+            }
+            
+            // DIRECT AVFoundation - NO fallback logic
+            NSLog(@"⏭️ Using AVFoundation directly - no ScreenCaptureKit attempts");
         }
         
-        // AVFoundation fallback logic
+        // AVFoundation recording (either fallback from ScreenCaptureKit or direct)
         useAVFoundation:
-        if (isElectron) {
-            NSLog(@"❌ ScreenCaptureKit failed in Electron - AVFoundation disabled for stability");
-            NSLog(@"❌ Recording not available in Electron when ScreenCaptureKit fails");
-            return Napi::Boolean::New(env, false);
-        }
-        
-        // Try AVFoundation fallback (ScreenCaptureKit failed or macOS 13/14)
-        if (isM15Plus) {
-            NSLog(@"🔄 ScreenCaptureKit failed on macOS 15+ - attempting AVFoundation fallback");
-        } else if (isM14Plus) {
-            NSLog(@"🎥 Using AVFoundation for macOS 14 compatibility (primary method)");
-        } else if (isM13Plus) {
-            NSLog(@"🎥 Using AVFoundation for macOS 13 compatibility (primary method, limited features)");
-        } else {
-            NSLog(@"❌ Unsupported macOS version for AVFoundation");
-            return Napi::Boolean::New(env, false);
-        }
+        NSLog(@"🎥 Starting AVFoundation recording...");
         
         @try {
             NSLog(@"🔧 Attempting AVFoundation recording...");