node-mac-recorder 2.16.5 → 2.16.7

package/.claude/settings.local.json

@@ -48,7 +48,9 @@
       "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing AVFoundation fallback path'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testAVFoundationPath() {\n  try {\n    const outputPath = ''./test-output/force-avfoundation-test.mov'';\n    console.log(''📹 Testing AVFoundation (force mode)...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started'');\n      await new Promise(resolve => setTimeout(resolve, 2000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ AVFoundation test completed!'');\n    } else {\n      console.log(''❌ Recording failed'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestAVFoundationPath();\n\")",
       "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing AVFoundation fallback path (macOS 14 simulation)'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testAVFoundationPath() {\n  try {\n    const outputPath = ''./test-output/force-avfoundation-test.mov'';\n    console.log(''📹 Testing AVFoundation (simulating macOS 14)...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started with AVFoundation'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ AVFoundation test completed successfully!'');\n      console.log(''This is how it should work on macOS 14'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestAVFoundationPath();\n\")",
       "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing AVFoundation with detailed debugging'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testWithDebugging() {\n  try {\n    const outputPath = ''./test-output/debug-test.mov'';\n    console.log(''📹 Starting AVFoundation test with debugging...'');\n    console.log(''Expected to see detailed AVFoundation logs in console'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started'');\n      await new Promise(resolve => setTimeout(resolve, 2000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ Test completed'');\n    } else {\n      console.log(''❌ Recording failed - check console logs for AVFoundation details'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestWithDebugging();\n\")",
-      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing macOS 13/14 path (forced AVFoundation)'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testMacOS1314Path() {\n  try {\n    const outputPath = ''./test-output/macos1314-test.mov'';\n    console.log(''📹 Starting test for macOS 13/14 path...'');\n    console.log(''This simulates the exact path macOS 13/14 users will take'');\n    console.log('''');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ SUCCESS: Recording started on macOS 13/14 path!'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ Recording completed successfully!'');\n      console.log(''📁 Output:'', outputPath);\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n    console.log(''This error would be what macOS 13/14 users see'');\n  }\n}\n\ntestMacOS1314Path();\n\")"
+      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing macOS 13/14 path (forced AVFoundation)'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testMacOS1314Path() {\n  try {\n    const outputPath = ''./test-output/macos1314-test.mov'';\n    console.log(''📹 Starting test for macOS 13/14 path...'');\n    console.log(''This simulates the exact path macOS 13/14 users will take'');\n    console.log('''');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ SUCCESS: Recording started on macOS 13/14 path!'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ Recording completed successfully!'');\n      console.log(''📁 Output:'', outputPath);\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n    console.log(''This error would be what macOS 13/14 users see'');\n  }\n}\n\ntestMacOS1314Path();\n\")",
+      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing macOS 14 Direct AVFoundation Path'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testDirectAVFoundation() {\n  try {\n    const outputPath = ''./test-output/direct-avfoundation-test.mov'';\n    console.log(''📹 Testing direct AVFoundation path (macOS 14 simulation)...'');\n    console.log(''Expected logs:'');\n    console.log(''  🎯 macOS 14 detected - directly using AVFoundation'');\n    console.log(''  ⏭️ Skipping ScreenCaptureKit completely, jumping to AVFoundation'');\n    console.log(''  🎬 AVFoundation: Starting recording initialization'');\n    console.log('''');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ SUCCESS: Direct AVFoundation path works!'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ Recording completed successfully!'');\n      console.log('''');\n      console.log(''🎉 This is exactly how macOS 14 will work:'');\n      console.log(''✅ No ScreenCaptureKit attempts'');\n      console.log(''✅ Direct AVFoundation usage'');\n      console.log(''✅ No permission errors'');\n    } else {\n      console.log(''❌ Recording failed'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestDirectAVFoundation();\n\")",
+      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🔥 FINAL TEST: macOS 14 Direct AVFoundation (NO ScreenCaptureKit)'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function finalTest() {\n  try {\n    const outputPath = ''./test-output/final-macos14-test.mov'';\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''🎉 SUCCESS: macOS 14 AVFoundation works!'');\n      await new Promise(resolve => setTimeout(resolve, 2000));\n      await recorder.stopRecording();\n      console.log(''✅ Test completed - macOS 14 is FIXED!'');\n    } else {\n      console.log(''❌ Still failed'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\nfinalTest();\n\")"
     ],
     "deny": []
   }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.16.5",
+	"version": "2.16.7",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/mac_recorder.mm

@@ -205,9 +205,9 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
             NSLog(@"🔧 FORCE_AVFOUNDATION environment variable detected - skipping ScreenCaptureKit");
         }
         
-        // Use ScreenCaptureKit only on macOS 15+ for maximum stability
-        // macOS 14 should use AVFoundation fallback
-        if (@available(macOS 12.3, *) && isM15Plus && !forceAVFoundation) {
+        // ONLY use ScreenCaptureKit on macOS 15+
+        // macOS 14/13 ALWAYS use AVFoundation - NO ScreenCaptureKit attempts
+        if (isM15Plus && !forceAVFoundation && !isElectron) {
             NSLog(@"✅ macOS 15+ detected - ScreenCaptureKit available with full compatibility");
             
             // Try ScreenCaptureKit with extensive safety measures
@@ -280,37 +280,29 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
                 NSLog(@"❌ Exception during ScreenCaptureKit availability check: %@", availabilityException.reason);
                 return Napi::Boolean::New(env, false);
             }
-        } else if (isM14Plus) {
-            // macOS 14 - directly use AVFoundation for better compatibility
-            NSLog(@"🎯 macOS 14 detected - directly using AVFoundation for better compatibility");
-            // Skip ScreenCaptureKit completely and go directly to AVFoundation
-        } else if (isM13Plus) {
-            // macOS 13 - use AVFoundation (limited features)
-            NSLog(@"🎯 macOS 13 detected - directly using AVFoundation (limited features)");
-            // Skip ScreenCaptureKit completely and go directly to AVFoundation
         } else {
-            NSLog(@"❌ macOS version too old (< 13.0) - Recording not supported");
-            return Napi::Boolean::New(env, false);
+            // macOS 14/13 or not macOS 15+ - ALWAYS use AVFoundation
+            if (isElectron) {
+                NSLog(@"❌ Electron environment - Recording not supported");
+                return Napi::Boolean::New(env, false);
+            }
+            
+            if (isM14Plus) {
+                NSLog(@"🎯 macOS 14 detected - using AVFoundation (primary method)");
+            } else if (isM13Plus) {
+                NSLog(@"🎯 macOS 13 detected - using AVFoundation (limited features)");  
+            } else {
+                NSLog(@"❌ macOS version too old (< 13.0) - Not supported");
+                return Napi::Boolean::New(env, false);
+            }
+            
+            // DIRECT AVFoundation - NO fallback logic
+            NSLog(@"⏭️ Using AVFoundation directly - no ScreenCaptureKit attempts");
         }
         
-        // AVFoundation fallback logic
-        if (isElectron) {
-            NSLog(@"❌ ScreenCaptureKit failed in Electron - AVFoundation disabled for stability");
-            NSLog(@"❌ Recording not available in Electron when ScreenCaptureKit fails");
-            return Napi::Boolean::New(env, false);
-        }
-        
-        // Try AVFoundation fallback (ScreenCaptureKit failed or macOS 13/14)
-        if (isM15Plus) {
-            NSLog(@"🔄 ScreenCaptureKit failed on macOS 15+ - attempting AVFoundation fallback");
-        } else if (isM14Plus) {
-            NSLog(@"🎥 Using AVFoundation for macOS 14 compatibility (primary method)");
-        } else if (isM13Plus) {
-            NSLog(@"🎥 Using AVFoundation for macOS 13 compatibility (primary method, limited features)");
-        } else {
-            NSLog(@"❌ Unsupported macOS version for AVFoundation");
-            return Napi::Boolean::New(env, false);
-        }
+        // AVFoundation recording (either fallback from ScreenCaptureKit or direct)
+        useAVFoundation:
+        NSLog(@"🎥 Starting AVFoundation recording...");
         
         @try {
             NSLog(@"🔧 Attempting AVFoundation recording...");

package/test-console-logs.js

@@ -0,0 +1,81 @@
+const MacRecorder = require('./index');
+
+console.log('🔍 Console Log Detection Test');
+console.log('This test shows which recording method is being used');
+console.log('========================================================');
+
+async function testConsoleOutput() {
+  const recorder = new MacRecorder();
+  
+  try {
+    console.log('📋 Starting recording test...');
+    console.log('Expected to see detailed native logs in Console.app or terminal');
+    console.log('');
+    
+    const outputPath = './test-output/console-log-test.mov';
+    
+    // Create test output directory
+    const fs = require('fs');
+    if (!fs.existsSync('./test-output')) {
+      fs.mkdirSync('./test-output');
+    }
+    
+    console.log('🎬 Calling startRecording...');
+    const result = await recorder.startRecording(outputPath, {
+      captureCursor: false,
+      includeMicrophone: false,
+      includeSystemAudio: false,
+      displayId: 1
+    });
+    
+    if (result) {
+      console.log('✅ Recording started successfully!');
+      console.log('📝 Result:', result);
+      
+      await new Promise(resolve => setTimeout(resolve, 2000));
+      
+      console.log('🛑 Stopping recording...');
+      await recorder.stopRecording();
+      console.log('✅ Recording stopped');
+      
+      // Check what method was used by looking at file size/existence
+      if (fs.existsSync(outputPath)) {
+        const stats = fs.statSync(outputPath);
+        console.log('📁 File created:', stats.size, 'bytes');
+        console.log('');
+        console.log('🎉 SUCCESS: Recording works!');
+      }
+    } else {
+      console.log('❌ Recording failed');
+    }
+    
+  } catch (error) {
+    console.log('❌ JavaScript Error:', error.message);
+    console.log('❌ This is the error your app would see');
+    
+    // Check if it's the old error message
+    if (error.message.includes('ScreenCaptureKit failed')) {
+      console.log('');
+      console.log('🚨 PROBLEM: Still seeing old ScreenCaptureKit error');
+      console.log('   This means the new logic is not being used');
+      console.log('   Possible causes:');
+      console.log('   1. Module not rebuilt properly');
+      console.log('   2. Cache issue');
+      console.log('   3. Wrong macOS version detection');
+    }
+  }
+  
+  console.log('');
+  console.log('📊 If you see this test:');
+  console.log('✅ Module loads correctly');
+  console.log('✅ JavaScript layer works'); 
+  console.log('❓ Check Console.app for native logs');
+  console.log('');
+  console.log('🔍 To see native logs:');
+  console.log('   1. Open Console.app');
+  console.log('   2. Filter by "node" process');
+  console.log('   3. Look for "🎯 Smart Recording Engine Selection"');
+  console.log('   4. Look for "macOS Version:" detection');
+}
+
+testConsoleOutput();

package/test-macos14-forced.js

@@ -0,0 +1,107 @@
+// macOS 14 test simülasyonu - detaylı debug bilgisiyle
+const MacRecorder = require('./index');
+
+console.log('🧪 macOS 14 Forced Test with Detailed Debugging');
+console.log('====================================================');
+console.log('');
+console.log('This test simulates exactly what happens on macOS 14');
+console.log('by forcing the AVFoundation path.');
+console.log('');
+
+// Force AVFoundation environment variable
+process.env.FORCE_AVFOUNDATION = '1';
+
+async function testMacOS14Scenario() {
+  const recorder = new MacRecorder();
+  
+  console.log('📋 Test Configuration:');
+  console.log('  - FORCE_AVFOUNDATION = 1 (simulates macOS 14)');
+  console.log('  - Expected: Skip ScreenCaptureKit, use AVFoundation');
+  console.log('  - Should see: "🎥 Using AVFoundation" logs');
+  console.log('');
+  
+  try {
+    const outputPath = './test-output/macos14-forced.mov';
+    
+    // Create directory
+    const fs = require('fs');
+    if (!fs.existsSync('./test-output')) {
+      fs.mkdirSync('./test-output');
+    }
+    
+    console.log('🎬 Starting recording (macOS 14 simulation)...');
+    console.log('Expected Console Logs:');
+    console.log('  🔧 FORCE_AVFOUNDATION environment variable detected');
+    console.log('  🎯 macOS 14 detected - directly using AVFoundation');
+    console.log('  🎥 Using AVFoundation for macOS 14 compatibility');
+    console.log('  🎬 AVFoundation: Starting recording initialization');
+    console.log('  ✅ AVFoundation recording started successfully');
+    console.log('');
+    
+    const result = await recorder.startRecording(outputPath, {
+      captureCursor: true,
+      includeMicrophone: false,
+      includeSystemAudio: true,
+      displayId: 1
+    });
+    
+    if (result) {
+      console.log('🎉 SUCCESS: macOS 14 path works!');
+      console.log('📁 Output file:', result);
+      console.log('⏱️ Recording for 3 seconds...');
+      
+      await new Promise(resolve => setTimeout(resolve, 3000));
+      
+      console.log('🛑 Stopping recording...');
+      await recorder.stopRecording();
+      
+      // Verify file
+      if (fs.existsSync(outputPath)) {
+        const stats = fs.statSync(outputPath);
+        console.log('✅ Recording file created successfully');
+        console.log('   File size:', Math.round(stats.size / 1024), 'KB');
+        console.log('');
+        console.log('🎉 macOS 14 Recording Test: PASSED ✅');
+        console.log('');
+        console.log('This means on real macOS 14 systems:');
+        console.log('✅ Version detection will work');
+        console.log('✅ AVFoundation will be used as primary method');
+        console.log('✅ No ScreenCaptureKit errors will occur');
+        console.log('✅ Recording will work with 15fps H.264 encoding');
+      } else {
+        console.log('❌ No output file created');
+      }
+      
+    } else {
+      console.log('❌ Recording failed to start');
+    }
+    
+  } catch (error) {
+    console.log('❌ Error:', error.message);
+    
+    // Check if user is getting old error
+    if (error.message.includes('ScreenCaptureKit failed')) {
+      console.log('');
+      console.log('🚨 CRITICAL: You are seeing the OLD error message!');
+      console.log('');
+      console.log('This means:');
+      console.log('❌ You are using an old version of node-mac-recorder');
+      console.log('❌ The new macOS 14/13 compatibility is not active');
+      console.log('');
+      console.log('🔧 To fix this:');
+      console.log('1. Update to the latest version: npm update node-mac-recorder');
+      console.log('2. Or rebuild: npm run build');
+      console.log('3. Or reinstall: npm uninstall node-mac-recorder && npm install node-mac-recorder');
+      console.log('');
+      console.log('Expected NEW error message should be:');
+      console.log('"Recording failed to start. Check permissions, output path, and system compatibility."');
+    } else {
+      console.log('✅ Error message is updated (good sign)');
+    }
+  }
+  
+  // Reset environment
+  delete process.env.FORCE_AVFOUNDATION;
+}
+
+testMacOS14Scenario();