node-mac-recorder 2.16.3 → 2.16.4

package/.claude/settings.local.json

@@ -47,7 +47,8 @@
       "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🧪 Testing Electron safety measures'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testElectronSafety() {\n  try {\n    const outputPath = ''./test-output/electron-safe-test.mov'';\n    console.log(''📹 Starting recording in Electron environment...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started safely in Electron - waiting 3 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Electron safety test completed successfully!'');\n    } else {\n      console.log(''⚠️ Recording failed to start (expected in some cases)'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestElectronSafety();\n\")",
       "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing AVFoundation fallback path'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testAVFoundationPath() {\n  try {\n    const outputPath = ''./test-output/force-avfoundation-test.mov'';\n    console.log(''📹 Testing AVFoundation (force mode)...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started'');\n      await new Promise(resolve => setTimeout(resolve, 2000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ AVFoundation test completed!'');\n    } else {\n      console.log(''❌ Recording failed'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestAVFoundationPath();\n\")",
       "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing AVFoundation fallback path (macOS 14 simulation)'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testAVFoundationPath() {\n  try {\n    const outputPath = ''./test-output/force-avfoundation-test.mov'';\n    console.log(''📹 Testing AVFoundation (simulating macOS 14)...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started with AVFoundation'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ AVFoundation test completed successfully!'');\n      console.log(''This is how it should work on macOS 14'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestAVFoundationPath();\n\")",
-      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing AVFoundation with detailed debugging'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testWithDebugging() {\n  try {\n    const outputPath = ''./test-output/debug-test.mov'';\n    console.log(''📹 Starting AVFoundation test with debugging...'');\n    console.log(''Expected to see detailed AVFoundation logs in console'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started'');\n      await new Promise(resolve => setTimeout(resolve, 2000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ Test completed'');\n    } else {\n      console.log(''❌ Recording failed - check console logs for AVFoundation details'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestWithDebugging();\n\")"
+      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing AVFoundation with detailed debugging'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testWithDebugging() {\n  try {\n    const outputPath = ''./test-output/debug-test.mov'';\n    console.log(''📹 Starting AVFoundation test with debugging...'');\n    console.log(''Expected to see detailed AVFoundation logs in console'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started'');\n      await new Promise(resolve => setTimeout(resolve, 2000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ Test completed'');\n    } else {\n      console.log(''❌ Recording failed - check console logs for AVFoundation details'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestWithDebugging();\n\")",
+      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing macOS 13/14 path (forced AVFoundation)'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testMacOS1314Path() {\n  try {\n    const outputPath = ''./test-output/macos1314-test.mov'';\n    console.log(''📹 Starting test for macOS 13/14 path...'');\n    console.log(''This simulates the exact path macOS 13/14 users will take'');\n    console.log('''');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ SUCCESS: Recording started on macOS 13/14 path!'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ Recording completed successfully!'');\n      console.log(''📁 Output:'', outputPath);\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n    console.log(''This error would be what macOS 13/14 users see'');\n  }\n}\n\ntestMacOS1314Path();\n\")"
     ],
     "deny": []
   }

package/index.js

@@ -406,7 +406,7 @@ class MacRecorder extends EventEmitter {
 				} else {
 					reject(
 						new Error(
-							"ScreenCaptureKit failed to start. Check permissions and try again."
+							"Recording failed to start. Check permissions, output path, and system compatibility."
 						)
 					);
 				}

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.16.3",
+	"version": "2.16.4",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/mac_recorder.mm

@@ -282,10 +282,12 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
             }
         } else if (isM14Plus) {
             // macOS 14 - directly use AVFoundation for better compatibility
-            NSLog(@"🎯 macOS 14 detected - using AVFoundation for better compatibility");
+            NSLog(@"🎯 macOS 14 detected - directly using AVFoundation for better compatibility");
+            // Skip ScreenCaptureKit completely and go directly to AVFoundation
         } else if (isM13Plus) {
             // macOS 13 - use AVFoundation (limited features)
-            NSLog(@"🎯 macOS 13 detected - using AVFoundation (limited features)");
+            NSLog(@"🎯 macOS 13 detected - directly using AVFoundation (limited features)");
+            // Skip ScreenCaptureKit completely and go directly to AVFoundation
         } else {
             NSLog(@"❌ macOS version too old (< 13.0) - Recording not supported");
             return Napi::Boolean::New(env, false);
@@ -302,9 +304,12 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
         if (isM15Plus) {
             NSLog(@"🔄 ScreenCaptureKit failed on macOS 15+ - attempting AVFoundation fallback");
         } else if (isM14Plus) {
-            NSLog(@"🎥 Using AVFoundation for macOS 14 compatibility");
+            NSLog(@"🎥 Using AVFoundation for macOS 14 compatibility (primary method)");
         } else if (isM13Plus) {
-            NSLog(@"🎥 Using AVFoundation for macOS 13 compatibility (limited features)");
+            NSLog(@"🎥 Using AVFoundation for macOS 13 compatibility (primary method, limited features)");
+        } else {
+            NSLog(@"❌ Unsupported macOS version for AVFoundation");
+            return Napi::Boolean::New(env, false);
         }
         
         @try {