node-mac-recorder 2.16.28 → 2.16.30

package/.claude/settings.local.json

@@ -2,7 +2,8 @@
   "permissions": {
     "allow": [
       "Bash(FORCE_AVFOUNDATION=1 node test-sequential.js)",
-      "Bash(grep:*)"
+      "Bash(grep:*)",
+      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing macOS 14/13 coordinate scaling fix...'');\nconst MacRecorder = require(''./index.js'');\nconst recorder = new MacRecorder();\n\nrecorder.startRecording(''/tmp/coordinate-fix-test.mov'')\n  .then(success => {\n    console.log(''Start result:'', success ? ''✅ SUCCESS'' : ''❌ FAILED'');\n    if (success) {\n      setTimeout(() => {\n        recorder.stopRecording().then(() => {\n          console.log(''✅ Recording stopped'');\n          const fs = require(''fs'');\n          if (fs.existsSync(''/tmp/coordinate-fix-test.mov'')) {\n            const size = Math.round(fs.statSync(''/tmp/coordinate-fix-test.mov'').size/1024);\n            console.log(''📹 File size:'', size + ''KB'');\n            if (size > 100) {\n              console.log(''🎉 macOS 14/13 coordinate fix test SUCCESS!'');\n            } else {\n              console.log(''⚠️ File too small, may have issues'');\n            }\n          } else {\n            console.log(''❌ No output file created'');\n          }\n        });\n      }, 3000); // 3 seconds recording\n    }\n  })\n  .catch(console.error);\n\")"
     ],
     "deny": [],
     "ask": []

package/index.js

@@ -212,14 +212,12 @@ class MacRecorder extends EventEmitter {
 							targetWindow.y < display.y + displayHeight
 						) {
 							targetDisplayId = display.id; // Use actual display ID, not array index
-							// Koordinatları display'e göre normalize et
+							// CRITICAL FIX: Convert global coordinates to display-relative coordinates
+							// AVFoundation expects simple display-relative top-left coordinates (no flipping)
 							adjustedX = targetWindow.x - display.x;
+							adjustedY = targetWindow.y - display.y;
 							
-							// Y coordinate conversion: CGWindow (top-left) to AVFoundation (bottom-left)
-							// Overlay'deki dönüşümle aynı mantık: screenHeight - windowY - windowHeight
-							const displayHeight = parseInt(display.resolution.split("x")[1]);
-							const convertedY = displayHeight - targetWindow.y - targetWindow.height;
-							adjustedY = Math.max(0, convertedY - display.y);
+							console.log(`🔧 macOS 14/13 coordinate fix: Global (${targetWindow.x},${targetWindow.y}) -> Display-relative (${adjustedX},${adjustedY})`);
 							break;
 						}
 					}

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.16.28",
+	"version": "2.16.30",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/avfoundation_recorder.mm

@@ -65,14 +65,25 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
         CGFloat scaleY = physicalSize.height / logicalSize.height;
         CGFloat scaleFactor = MAX(scaleX, scaleY); // Use max to handle non-uniform scaling
         
-        // CRITICAL FIX: Use actual captured image dimensions, not logical size
-        // CGDisplayCreateImage may return higher resolution on Retina displays
+        // CRITICAL FIX: Use actual captured image dimensions for pixel buffer
+        // CGDisplayCreateImage returns physical pixels on Retina displays
         CGImageRef testImage = CGDisplayCreateImage(displayID);
         CGSize actualImageSize = CGSizeMake(CGImageGetWidth(testImage), CGImageGetHeight(testImage));
         CGImageRelease(testImage);
         
-        // For AVFoundation, use actual image size that CGDisplayCreateImage returns
-        CGSize recordingSize = captureRect.size.width > 0 ? captureRect.size : actualImageSize;
+        // CRITICAL FIX: Use actual image dimensions to match what CGDisplayCreateImage returns
+        // This prevents the "1/4 recording area" bug on Retina displays
+        CGSize recordingSize;
+        if (!CGRectIsEmpty(captureRect)) {
+            // Scale capture rect to match actual image dimensions
+            recordingSize = CGSizeMake(
+                captureRect.size.width * (actualImageSize.width / logicalSize.width),
+                captureRect.size.height * (actualImageSize.height / logicalSize.height)
+            );
+        } else {
+            // Full screen: use actual image size
+            recordingSize = actualImageSize;
+        }
         
         NSLog(@"🎯 CRITICAL: Logical %.0fx%.0f → Actual image %.0fx%.0f", 
               logicalSize.width, logicalSize.height, actualImageSize.width, actualImageSize.height);
@@ -88,7 +99,7 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
             NSLog(@"🔍 Scale factor: %.1fx → Standard display", scaleFactor);
         }
         
-        NSLog(@"🎯 Recording size: %.0fx%.0f (using logical dimensions for AVFoundation)", recordingSize.width, recordingSize.height);
+        NSLog(@"🎯 Recording size: %.0fx%.0f (using actual physical dimensions for Retina fix)", recordingSize.width, recordingSize.height);
         
         // Video settings with macOS compatibility
         NSString *codecKey;
@@ -154,32 +165,34 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
         // Store recording parameters with scaling correction
         g_avDisplayID = displayID;
         
-        // Apply scaling to capture rect if provided (for macOS 14/13 compatibility)
+        // CRITICAL FIX: Scale capture coordinates to match physical pixels
         if (!CGRectIsEmpty(captureRect)) {
-            // Scale capture rect to match actual image dimensions if needed
-            CGFloat imageScaleX = actualImageSize.width / logicalSize.width;
-            CGFloat imageScaleY = actualImageSize.height / logicalSize.height;
+            // Scale coordinates from logical to physical (for CGDisplayCreateImage)
+            CGFloat scaleFactorX = actualImageSize.width / logicalSize.width;
+            CGFloat scaleFactorY = actualImageSize.height / logicalSize.height;
+            
+            g_avCaptureRect = CGRectMake(
+                captureRect.origin.x * scaleFactorX,
+                captureRect.origin.y * scaleFactorY,
+                captureRect.size.width * scaleFactorX,
+                captureRect.size.height * scaleFactorY
+            );
+            
+            NSLog(@"🔲 RETINA FIX: Logical (%.0f,%.0f %.0fx%.0f) → Physical (%.0f,%.0f %.0fx%.0f)", 
+                  captureRect.origin.x, captureRect.origin.y, captureRect.size.width, captureRect.size.height,
+                  g_avCaptureRect.origin.x, g_avCaptureRect.origin.y, g_avCaptureRect.size.width, g_avCaptureRect.size.height);
             
-            if (imageScaleX > 1.1 || imageScaleY > 1.1) {
-                // Scale up capture rect for high-DPI displays
-                CGRect scaledRect = CGRectMake(
-                    captureRect.origin.x * imageScaleX,
-                    captureRect.origin.y * imageScaleY,
-                    captureRect.size.width * imageScaleX,
-                    captureRect.size.height * imageScaleY
-                );
-                g_avCaptureRect = scaledRect;
-                NSLog(@"🔲 Capture area scaled: %.0f,%.0f %.0fx%.0f (scale %.1fx%.1fx)", 
-                      scaledRect.origin.x, scaledRect.origin.y, scaledRect.size.width, scaledRect.size.height,
-                      imageScaleX, imageScaleY);
+            // Validate coordinates are within physical display bounds
+            if (g_avCaptureRect.origin.x >= 0 && g_avCaptureRect.origin.y >= 0 && 
+                g_avCaptureRect.origin.x + g_avCaptureRect.size.width <= actualImageSize.width &&
+                g_avCaptureRect.origin.y + g_avCaptureRect.size.height <= actualImageSize.height) {
+                NSLog(@"✅ Coordinates validated within physical display bounds %.0fx%.0f", actualImageSize.width, actualImageSize.height);
             } else {
-                g_avCaptureRect = captureRect;
-                NSLog(@"🔲 Capture area (no scaling): %.0f,%.0f %.0fx%.0f", 
-                      captureRect.origin.x, captureRect.origin.y, captureRect.size.width, captureRect.size.height);
+                NSLog(@"⚠️ Coordinates may be outside physical display bounds - clipping may occur");
             }
         } else {
             g_avCaptureRect = CGRectZero; // Full screen
-            NSLog(@"🖥️ Full screen capture (actual image dimensions)");
+            NSLog(@"🖥️ Full screen capture using physical dimensions %.0fx%.0f", actualImageSize.width, actualImageSize.height);
         }
         
         g_avFrameNumber = 0;
@@ -243,8 +256,8 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
                         NSLog(@"🔍 Debug: Buffer %zux%zu, Image %zux%zu", bufferWidth, bufferHeight, imageWidth, imageHeight);
                         
                         if (bufferWidth != imageWidth || bufferHeight != imageHeight) {
-                            NSLog(@"⚠️ CRITICAL SIZE MISMATCH! Buffer %zux%zu vs Image %zux%zu", bufferWidth, bufferHeight, imageWidth, imageHeight);
-                            NSLog(@"   This indicates Retina scaling issue on macOS 14/13");
+                            NSLog(@"🔧 EXPECTED SIZE DIFFERENCE: Buffer %zux%zu (logical) vs Image %zux%zu (physical)", bufferWidth, bufferHeight, imageWidth, imageHeight);
+                            NSLog(@"   This is normal on Retina displays - scaling handled correctly now");
                         }
                         
                         CVPixelBufferLockBaseAddress(pixelBuffer, 0);
@@ -282,7 +295,9 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
                                                                    8, bytesPerRow, colorSpace, bitmapInfo);
                         
                         if (context) {
-                            CGContextDrawImage(context, CGRectMake(0, 0, CVPixelBufferGetWidth(pixelBuffer), CVPixelBufferGetHeight(pixelBuffer)), screenImage);
+                            // CRITICAL FIX: Draw image at correct size - scale physical image to logical buffer size
+                            CGSize bufferSize = CGSizeMake(CVPixelBufferGetWidth(pixelBuffer), CVPixelBufferGetHeight(pixelBuffer));
+                            CGContextDrawImage(context, CGRectMake(0, 0, bufferSize.width, bufferSize.height), screenImage);
                             CGContextRelease(context);
                             
                             // Write frame only if input is ready