node-mac-recorder 2.16.23 → 2.16.24

package/.claude/settings.local.json

@@ -1,7 +1,7 @@
 {
   "permissions": {
     "allow": [
-      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing fixed window selector screen ID mapping...'');\nconst WindowSelector = require(''./window-selector.js'');\nconst selector = new WindowSelector();\n\nconst testResults = [];\n\nselector.checkPermissions().then(perms => {\n  console.log(''✅ Permissions OK'');\n  console.log('''');\n  console.log(''📋 Expected Screen IDs from MacRecorder:'');\n  console.log(''   MacBook (Primary): ID=1, Position=(0,0)'');\n  console.log(''   External Display: ID=3, Position=(-3440,-56)'');\n  console.log('''');\n  \n  return selector.startSelection();\n}).then(() => {\n  console.log(''✅ Window selection started'');\n  console.log(''🎯 Move cursor over windows on BOTH displays to see CGDirectDisplayID mapping logs'');\n  console.log('''');\n  \n  setTimeout(() => {\n    console.log(''⏰ Test complete - stopping window selection'');\n    selector.stopSelection();\n  }, 15000);\n  \n}).catch(console.error);\")"
+      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing external display recording WITH AUDIO - debug version...'');\nconst MacRecorder = require(''./index.js'');\nconst recorder = new MacRecorder();\n\nrecorder.startRecording(''/tmp/external-audio-debug.mov'', {\n  displayId: 3,  // External display\n  includeMicrophone: true,\n  includeSystemAudio: true,\n  captureCursor: true\n})\n  .then(success => {\n    console.log(''Start result:'', success ? ''✅ SUCCESS'' : ''❌ FAILED'');\n    if (success) {\n      setTimeout(() => {\n        console.log(''⏹️ Stopping recording...'');\n        recorder.stopRecording().then(() => {\n          console.log(''✅ Recording stopped'');\n          const fs = require(''fs'');\n          if (fs.existsSync(''/tmp/external-audio-debug.mov'')) {\n            const size = Math.round(fs.statSync(''/tmp/external-audio-debug.mov'').size/1024);\n            console.log(''📹 File size:'', size + ''KB'');\n            if (size > 100) {\n              console.log(''🎉 External display recording with audio SUCCESS!'');\n            } else {\n              console.log(''⚠️ File too small, may have failed'');\n            }\n          } else {\n            console.log(''❌ No output file created'');\n          }\n        });\n      }, 4000); // 4 seconds recording\n    }\n  })\n  .catch(console.error);\n\")"
     ],
     "deny": [],
     "ask": []

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.16.23",
+	"version": "2.16.24",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/screen_capture_kit.mm

@@ -77,6 +77,10 @@ static NSString *g_outputPath = nil;
     NSLog(@"🔧 Config: cursor=%@ mic=%@ system=%@ display=%@ window=%@ crop=%@", 
           captureCursor, includeMicrophone, includeSystemAudio, displayId, windowId, captureRect);
     
+    // CRITICAL DEBUG: Log EXACT audio parameter values
+    NSLog(@"🔍 AUDIO DEBUG: includeMicrophone type=%@ value=%d", [includeMicrophone class], [includeMicrophone boolValue]);
+    NSLog(@"🔍 AUDIO DEBUG: includeSystemAudio type=%@ value=%d", [includeSystemAudio class], [includeSystemAudio boolValue]);
+    
     // Get shareable content
     [SCShareableContent getShareableContentWithCompletionHandler:^(SCShareableContent *content, NSError *contentError) {
         if (contentError) {
@@ -87,6 +91,15 @@ static NSString *g_outputPath = nil;
         NSLog(@"✅ Got %lu displays, %lu windows for pure recording", 
               content.displays.count, content.windows.count);
         
+        // CRITICAL DEBUG: List all available displays in ScreenCaptureKit
+        NSLog(@"🔍 ScreenCaptureKit available displays:");
+        for (SCDisplay *display in content.displays) {
+            NSLog(@"   Display ID=%u, Size=%dx%d, Frame=(%.0f,%.0f,%.0fx%.0f)", 
+                  display.displayID, (int)display.width, (int)display.height,
+                  display.frame.origin.x, display.frame.origin.y,
+                  display.frame.size.width, display.frame.size.height);
+        }
+        
         SCContentFilter *filter = nil;
         NSInteger recordingWidth = 0;
         NSInteger recordingHeight = 0;
@@ -121,12 +134,20 @@ static NSString *g_outputPath = nil;
             
             if (displayId && [displayId integerValue] != 0) {
                 // Find specific display
+                NSLog(@"🎯 Looking for display ID=%@ in ScreenCaptureKit list", displayId);
                 for (SCDisplay *display in content.displays) {
+                    NSLog(@"   Checking display ID=%u vs requested=%u", display.displayID, [displayId unsignedIntValue]);
                     if (display.displayID == [displayId unsignedIntValue]) {
                         targetDisplay = display;
+                        NSLog(@"✅ FOUND matching display ID=%u", display.displayID);
                         break;
                     }
                 }
+                
+                if (!targetDisplay) {
+                    NSLog(@"❌ Display ID=%@ NOT FOUND in ScreenCaptureKit - using first display as fallback", displayId);
+                    targetDisplay = content.displays.firstObject;
+                }
             } else {
                 // Use first display
                 targetDisplay = content.displays.firstObject;
@@ -188,8 +209,10 @@ static NSString *g_outputPath = nil;
               recordingWidth, recordingHeight, shouldShowCursor);
         
         // AUDIO SUPPORT - Enable both microphone and system audio
+        NSLog(@"🔍 AUDIO PROCESSING: includeMicrophone=%@ includeSystemAudio=%@", includeMicrophone, includeSystemAudio);
         BOOL shouldCaptureMic = includeMicrophone ? [includeMicrophone boolValue] : NO;
         BOOL shouldCaptureSystemAudio = includeSystemAudio ? [includeSystemAudio boolValue] : NO;
+        NSLog(@"🔍 AUDIO COMPUTED: shouldCaptureMic=%d shouldCaptureSystemAudio=%d", shouldCaptureMic, shouldCaptureSystemAudio);
         
         // Enable audio if either microphone or system audio is requested
         if (@available(macOS 13.0, *)) {