node-mac-recorder 2.16.22 → 2.16.23

package/.claude/settings.local.json

@@ -1,7 +1,7 @@
 {
   "permissions": {
     "allow": [
-      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🚀 FINAL TEST: Ultra-aggressive external display overlay visibility...'');\nconst WindowSelector = require(''./window-selector.js'');\nconst selector = new WindowSelector();\n\nselector.checkPermissions().then(perms => {\n  console.log(''✅ Permissions OK'');\n  return selector.startSelection();\n}).then(() => {\n  console.log(''✅ Window selection started'');\n  console.log('''');\n  console.log(''🚀 ULTRA-AGGRESSIVE VISIBILITY TEST:'');\n  console.log(''1. External display should show BRIGHT RED button (orderFrontRegardless!)'');  \n  console.log(''2. Button should be above EVERYTHING (kCGMaximumWindowLevel)'');\n  console.log(''3. Try clicking - should see click debug logs'');\n  console.log('''');\n  console.log(''If you STILL cannot see the red button, there is a deeper macOS issue...'');\n  \n  setTimeout(() => {\n    console.log(''⏰ Final test complete'');\n    selector.stopSelection();\n  }, 25000);\n}).catch(console.error);\")"
+      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing fixed window selector screen ID mapping...'');\nconst WindowSelector = require(''./window-selector.js'');\nconst selector = new WindowSelector();\n\nconst testResults = [];\n\nselector.checkPermissions().then(perms => {\n  console.log(''✅ Permissions OK'');\n  console.log('''');\n  console.log(''📋 Expected Screen IDs from MacRecorder:'');\n  console.log(''   MacBook (Primary): ID=1, Position=(0,0)'');\n  console.log(''   External Display: ID=3, Position=(-3440,-56)'');\n  console.log('''');\n  \n  return selector.startSelection();\n}).then(() => {\n  console.log(''✅ Window selection started'');\n  console.log(''🎯 Move cursor over windows on BOTH displays to see CGDirectDisplayID mapping logs'');\n  console.log('''');\n  \n  setTimeout(() => {\n    console.log(''⏰ Test complete - stopping window selection'');\n    selector.stopSelection();\n  }, 15000);\n  \n}).catch(console.error);\")"
     ],
     "deny": [],
     "ask": []

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.16.22",
+	"version": "2.16.23",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/window_selector.mm

@@ -2360,10 +2360,33 @@ Napi::Value GetSelectedWindowInfo(const Napi::CallbackInfo& info) {
             windowScreen = mainScreen;
         }
         
-        // Add screen information
+        // CRITICAL FIX: Add screen information using real CGDirectDisplayID 
         NSRect screenFrame = [windowScreen frame];
-        result.Set("screenId", Napi::Number::New(env, [[windowScreen deviceDescription] objectForKey:@"NSScreenNumber"] ? 
-            [[[windowScreen deviceDescription] objectForKey:@"NSScreenNumber"] intValue] : 0));
+        
+        // Find real CGDirectDisplayID for this screen (matching GetDisplays logic)
+        CGDirectDisplayID realDisplayID = 0;
+        CGDirectDisplayID activeDisplays[32];
+        uint32_t displayCount;
+        CGGetActiveDisplayList(32, activeDisplays, &displayCount);
+        
+        for (uint32_t j = 0; j < displayCount; j++) {
+            CGDirectDisplayID candidateID = activeDisplays[j];
+            CGRect displayBounds = CGDisplayBounds(candidateID);
+            
+            if (fabs(screenFrame.origin.x - displayBounds.origin.x) < 1.0 &&
+                fabs(screenFrame.origin.y - displayBounds.origin.y) < 1.0 &&
+                fabs(screenFrame.size.width - displayBounds.size.width) < 1.0 &&
+                fabs(screenFrame.size.height - displayBounds.size.height) < 1.0) {
+                realDisplayID = candidateID;
+                break;
+            }
+        }
+        
+        NSLog(@"🔍 Window screen mapping: Frame=(%.0f,%.0f,%.0fx%.0f) → CGDirectDisplayID=%u", 
+              screenFrame.origin.x, screenFrame.origin.y, 
+              screenFrame.size.width, screenFrame.size.height, realDisplayID);
+        
+        result.Set("screenId", Napi::Number::New(env, realDisplayID));
         result.Set("screenX", Napi::Number::New(env, (int)screenFrame.origin.x));
         result.Set("screenY", Napi::Number::New(env, (int)screenFrame.origin.y));
         result.Set("screenWidth", Napi::Number::New(env, (int)screenFrame.size.width));