node-mac-recorder 2.16.20 → 2.16.21

package/.claude/settings.local.json

@@ -1,7 +1,7 @@
 {
   "permissions": {
     "allow": [
-      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing multi-screen window selector UI positioning fix...'');\nconst WindowSelector = require(''./window-selector.js'');\nconst selector = new WindowSelector();\n\nselector.checkPermissions().then(perms => {\n  console.log(''Permissions:'', perms);\n  return selector.startSelection();\n}).then(() => {\n  console.log(''✅ Window selection started - CRITICAL TEST:'');\n  console.log(''🖥️ PRIMARY DISPLAY: Move cursor over windows and verify Record/Cancel buttons + logo + title appear'');\n  console.log(''🖥️ EXTERNAL DISPLAY: Move cursor over windows on second screen'');\n  console.log(''📍 VERIFY: UI elements appear on the SAME screen as the window (not just primary)'');\n  console.log(''⚡ This fixes the multi-screen UI positioning bug!'');\n  \n  setTimeout(() => {\n    selector.stopSelection().then(() => {\n      console.log(''✅ Multi-screen UI positioning test complete'');\n    });\n  }, 20000);\n}).catch(console.error);\")"
+      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🎯 FINAL TEST: Multi-screen UI visibility fix...'');\nconst WindowSelector = require(''./window-selector.js'');\nconst selector = new WindowSelector();\n\nselector.checkPermissions().then(perms => {\n  console.log(''✅ Permissions OK'');\n  return selector.startSelection();\n}).then(() => {\n  console.log(''✅ Window selection started'');\n  console.log('''');\n  console.log(''🎯 CRITICAL TEST - Both screens should now have same window level:'');\n  console.log(''1. Move cursor over MacBook screen window → should see buttons + logo + title'');\n  console.log(''2. Move cursor over external display window → should ALSO see buttons + logo + title''); \n  console.log(''3. Check console for \"\"Level=\"\" logs - both should be 2147483631'');\n  console.log('''');\n  console.log(''⚡ If this works, the multi-screen UI positioning bug is FIXED!'');\n  \n  setTimeout(() => {\n    console.log(''⏰ Test complete - check both screens for UI visibility'');\n    selector.stopSelection();\n  }, 25000);\n}).catch(console.error);\")"
     ],
     "deny": [],
     "ask": []

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.16.20",
+	"version": "2.16.21",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/window_selector.mm

@@ -1023,11 +1023,14 @@ void updateOverlay() {
             
             // CRITICAL FIX: Find the select button on the TARGET screen
             NSButton *targetSelectButton = nil;
+            
             for (NSView *subview in [targetOverlay.contentView subviews]) {
-                if ([subview isKindOfClass:[NSButton class]] && 
-                    [[(NSButton*)subview title] isEqualToString:@"Start Record"]) {
-                    targetSelectButton = (NSButton*)subview;
-                    break;
+                if ([subview isKindOfClass:[NSButton class]]) {
+                    NSButton *btn = (NSButton*)subview;
+                    if ([[btn title] isEqualToString:@"Start Record"]) {
+                        targetSelectButton = btn;
+                        break;
+                    }
                 }
             }
             
@@ -1996,7 +1999,7 @@ Napi::Value StartWindowSelection(const Napi::CallbackInfo& info) {
             [screenOverlay setOpaque:NO];
             [screenOverlay setIgnoresMouseEvents:NO];
             [screenOverlay setAcceptsMouseMovedEvents:YES];
-            [screenOverlay setLevel:NSScreenSaverWindowLevel];
+            [screenOverlay setLevel:CGWindowLevelForKey(kCGMaximumWindowLevelKey)]; // CRITICAL FIX: Match highest level
             [screenOverlay setCollectionBehavior:NSWindowCollectionBehaviorCanJoinAllSpaces | NSWindowCollectionBehaviorStationary];
             
             NSLog(@"   Screen %ld: (%.0f,%.0f) %.0fx%.0f → Overlay created", i, screenFrame.origin.x, screenFrame.origin.y, screenFrame.size.width, screenFrame.size.height);