node-mac-recorder 2.16.2 → 2.16.4

package/.claude/settings.local.json

@@ -46,7 +46,9 @@
       "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🧪 Testing version detection and fallback system'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testVersionDetection() {\n  try {\n    const outputPath = ''./test-output/version-detection-test.mov'';\n    console.log(''📹 Starting recording with version detection...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 3 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Version detection test completed successfully!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestVersionDetection();\n\")",
       "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🧪 Testing Electron safety measures'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testElectronSafety() {\n  try {\n    const outputPath = ''./test-output/electron-safe-test.mov'';\n    console.log(''📹 Starting recording in Electron environment...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started safely in Electron - waiting 3 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Electron safety test completed successfully!'');\n    } else {\n      console.log(''⚠️ Recording failed to start (expected in some cases)'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestElectronSafety();\n\")",
       "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing AVFoundation fallback path'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testAVFoundationPath() {\n  try {\n    const outputPath = ''./test-output/force-avfoundation-test.mov'';\n    console.log(''📹 Testing AVFoundation (force mode)...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started'');\n      await new Promise(resolve => setTimeout(resolve, 2000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ AVFoundation test completed!'');\n    } else {\n      console.log(''❌ Recording failed'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestAVFoundationPath();\n\")",
-      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing AVFoundation fallback path (macOS 14 simulation)'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testAVFoundationPath() {\n  try {\n    const outputPath = ''./test-output/force-avfoundation-test.mov'';\n    console.log(''📹 Testing AVFoundation (simulating macOS 14)...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started with AVFoundation'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ AVFoundation test completed successfully!'');\n      console.log(''This is how it should work on macOS 14'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestAVFoundationPath();\n\")"
+      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing AVFoundation fallback path (macOS 14 simulation)'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testAVFoundationPath() {\n  try {\n    const outputPath = ''./test-output/force-avfoundation-test.mov'';\n    console.log(''📹 Testing AVFoundation (simulating macOS 14)...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started with AVFoundation'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ AVFoundation test completed successfully!'');\n      console.log(''This is how it should work on macOS 14'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestAVFoundationPath();\n\")",
+      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing AVFoundation with detailed debugging'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testWithDebugging() {\n  try {\n    const outputPath = ''./test-output/debug-test.mov'';\n    console.log(''📹 Starting AVFoundation test with debugging...'');\n    console.log(''Expected to see detailed AVFoundation logs in console'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started'');\n      await new Promise(resolve => setTimeout(resolve, 2000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ Test completed'');\n    } else {\n      console.log(''❌ Recording failed - check console logs for AVFoundation details'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestWithDebugging();\n\")",
+      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing macOS 13/14 path (forced AVFoundation)'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testMacOS1314Path() {\n  try {\n    const outputPath = ''./test-output/macos1314-test.mov'';\n    console.log(''📹 Starting test for macOS 13/14 path...'');\n    console.log(''This simulates the exact path macOS 13/14 users will take'');\n    console.log('''');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ SUCCESS: Recording started on macOS 13/14 path!'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ Recording completed successfully!'');\n      console.log(''📁 Output:'', outputPath);\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n    console.log(''This error would be what macOS 13/14 users see'');\n  }\n}\n\ntestMacOS1314Path();\n\")"
     ],
     "deny": []
   }

package/debug-macos14.js

@@ -0,0 +1,110 @@
+const MacRecorder = require('./index');
+
+console.log('🧪 macOS 14/13 Debug Test');
+console.log('=========================================');
+console.log('');
+console.log('This script helps debug recording issues on macOS 14 and earlier.');
+console.log('Please run this and share the complete console output.');
+console.log('');
+
+async function debugMacOS14() {
+  const recorder = new MacRecorder();
+  
+  try {
+    // Create test output directory
+    const fs = require('fs');
+    if (!fs.existsSync('./test-output')) {
+      fs.mkdirSync('./test-output');
+    }
+    
+    console.log('📋 System Information:');
+    const os = require('os');
+    console.log('  OS:', os.type(), os.release());
+    console.log('  Architecture:', os.arch());
+    console.log('  Platform:', os.platform());
+    
+    // Check permissions first
+    console.log('');
+    console.log('🔐 Checking Permissions...');
+    try {
+      const permissions = await recorder.checkPermissions();
+      console.log('  Screen Recording Permission:', permissions.screenRecording ? '✅ GRANTED' : '❌ DENIED');
+      console.log('  Accessibility Permission:', permissions.accessibility ? '✅ GRANTED' : '❌ DENIED');
+      
+      if (!permissions.screenRecording) {
+        console.log('');
+        console.log('❌ CRITICAL: Screen Recording permission is DENIED');
+        console.log('   Please grant permission in System Preferences > Security & Privacy > Privacy > Screen Recording');
+        console.log('   Then restart this test.');
+        return;
+      }
+    } catch (permError) {
+      console.log('  Permission check failed:', permError.message);
+    }
+    
+    console.log('');
+    console.log('🎯 Starting Recording Test...');
+    console.log('Expected behavior:');
+    console.log('  • System should detect macOS version');
+    console.log('  • macOS 15+ uses ScreenCaptureKit');  
+    console.log('  • macOS 14/13 uses AVFoundation fallback');
+    console.log('  • You should see detailed logs below');
+    console.log('');
+    
+    const outputPath = './test-output/debug-test.mov';
+    
+    const success = await recorder.startRecording(outputPath, {
+      captureCursor: true,
+      includeMicrophone: false,
+      includeSystemAudio: true,
+      displayId: null // Use primary display
+    });
+    
+    if (success) {
+      console.log('✅ Recording started successfully');
+      console.log('⏱️ Recording for 3 seconds...');
+      
+      await new Promise(resolve => setTimeout(resolve, 3000));
+      
+      console.log('🛑 Stopping recording...');
+      await recorder.stopRecording();
+      
+      // Check if file was created
+      const fs = require('fs');
+      if (fs.existsSync(outputPath)) {
+        const stats = fs.statSync(outputPath);
+        console.log('✅ Recording file created:', outputPath);
+        console.log('   File size:', Math.round(stats.size / 1024), 'KB');
+        console.log('');
+        console.log('🎉 SUCCESS: Recording works on your system!');
+      } else {
+        console.log('❌ Recording file was not created');
+        console.log('   Expected:', outputPath);
+      }
+    } else {
+      console.log('❌ Recording failed to start');
+      console.log('');
+      console.log('🔍 Troubleshooting Steps:');
+      console.log('1. Check console logs above for specific error messages');
+      console.log('2. Verify Screen Recording permission is granted');
+      console.log('3. Try restarting your application');
+      console.log('4. Check if output directory exists and is writable');
+    }
+    
+  } catch (error) {
+    console.log('❌ Error during test:', error.message);
+    if (error.stack) {
+      console.log('Stack trace:', error.stack);
+    }
+  }
+  
+  console.log('');
+  console.log('📞 Support Information:');
+  console.log('If recording still fails, please share:');
+  console.log('1. Complete console output from this test');
+  console.log('2. Your macOS version (System Settings > About)');
+  console.log('3. Permission screenshots from System Settings');
+}
+
+// Run the debug test
+debugMacOS14();

package/index.js

@@ -406,7 +406,7 @@ class MacRecorder extends EventEmitter {
 				} else {
 					reject(
 						new Error(
-							"ScreenCaptureKit failed to start. Check permissions and try again."
+							"Recording failed to start. Check permissions, output path, and system compatibility."
 						)
 					);
 				}

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.16.2",
+	"version": "2.16.4",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/avfoundation_recorder.mm

@@ -32,24 +32,40 @@ bool startAVFoundationRecording(const std::string& outputPath,
     }
     
     @try {
+        NSLog(@"🎬 AVFoundation: Starting recording initialization");
+        
         // Create output URL
         NSString *outputPathStr = [NSString stringWithUTF8String:outputPath.c_str()];
+        NSLog(@"🎬 AVFoundation: Output path string: %@", outputPathStr);
+        
         NSURL *outputURL = [NSURL fileURLWithPath:outputPathStr];
+        NSLog(@"🎬 AVFoundation: Output URL: %@", outputURL);
         
         // Remove existing file
-        [[NSFileManager defaultManager] removeItemAtURL:outputURL error:nil];
+        NSError *removeError = nil;
+        [[NSFileManager defaultManager] removeItemAtURL:outputURL error:&removeError];
+        if (removeError && removeError.code != NSFileNoSuchFileError) {
+            NSLog(@"⚠️ AVFoundation: Warning removing existing file: %@", removeError);
+        }
         
         // Create asset writer
+        NSLog(@"🎬 AVFoundation: Creating AVAssetWriter...");
         NSError *error = nil;
         g_avWriter = [[AVAssetWriter alloc] initWithURL:outputURL fileType:AVFileTypeQuickTimeMovie error:&error];
         if (!g_avWriter || error) {
-            NSLog(@"❌ Failed to create AVAssetWriter: %@", error);
+            NSLog(@"❌ AVFoundation: Failed to create AVAssetWriter: %@", error);
+            NSLog(@"❌ AVFoundation: Output URL was: %@", outputURL);
             return false;
         }
+        NSLog(@"✅ AVFoundation: AVAssetWriter created successfully");
         
         // Get display dimensions
+        NSLog(@"🎬 AVFoundation: Getting display dimensions for display ID %u", displayID);
         CGRect displayBounds = CGDisplayBounds(displayID);
+        NSLog(@"🎬 AVFoundation: Display bounds: %.0f x %.0f", displayBounds.size.width, displayBounds.size.height);
+        
         CGSize recordingSize = captureRect.size.width > 0 ? captureRect.size : displayBounds.size;
+        NSLog(@"🎬 AVFoundation: Recording size: %.0f x %.0f", recordingSize.width, recordingSize.height);
         
         // Video settings
         NSDictionary *videoSettings = @{

package/src/mac_recorder.mm

@@ -282,10 +282,12 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
             }
         } else if (isM14Plus) {
             // macOS 14 - directly use AVFoundation for better compatibility
-            NSLog(@"🎯 macOS 14 detected - using AVFoundation for better compatibility");
+            NSLog(@"🎯 macOS 14 detected - directly using AVFoundation for better compatibility");
+            // Skip ScreenCaptureKit completely and go directly to AVFoundation
         } else if (isM13Plus) {
             // macOS 13 - use AVFoundation (limited features)
-            NSLog(@"🎯 macOS 13 detected - using AVFoundation (limited features)");
+            NSLog(@"🎯 macOS 13 detected - directly using AVFoundation (limited features)");
+            // Skip ScreenCaptureKit completely and go directly to AVFoundation
         } else {
             NSLog(@"❌ macOS version too old (< 13.0) - Recording not supported");
             return Napi::Boolean::New(env, false);
@@ -302,12 +304,23 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
         if (isM15Plus) {
             NSLog(@"🔄 ScreenCaptureKit failed on macOS 15+ - attempting AVFoundation fallback");
         } else if (isM14Plus) {
-            NSLog(@"🎥 Using AVFoundation for macOS 14 compatibility");
+            NSLog(@"🎥 Using AVFoundation for macOS 14 compatibility (primary method)");
         } else if (isM13Plus) {
-            NSLog(@"🎥 Using AVFoundation for macOS 13 compatibility (limited features)");
+            NSLog(@"🎥 Using AVFoundation for macOS 13 compatibility (primary method, limited features)");
+        } else {
+            NSLog(@"❌ Unsupported macOS version for AVFoundation");
+            return Napi::Boolean::New(env, false);
         }
         
         @try {
+            NSLog(@"🔧 Attempting AVFoundation recording...");
+            NSLog(@"🔧 Output path: %s", outputPath.c_str());
+            NSLog(@"🔧 Display ID: %u", displayID);
+            NSLog(@"🔧 Cursor: %s, Mic: %s, System Audio: %s", 
+                  captureCursor ? "YES" : "NO",
+                  includeMicrophone ? "YES" : "NO", 
+                  includeSystemAudio ? "YES" : "NO");
+            
             // Import AVFoundation recording functions (if available)
             extern bool startAVFoundationRecording(const std::string& outputPath, 
                                                    CGDirectDisplayID displayID,
@@ -318,17 +331,23 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
                                                    bool includeSystemAudio,
                                                    NSString* audioDeviceId);
             
-            if (startAVFoundationRecording(outputPath, displayID, windowID, captureRect, 
-                                          captureCursor, includeMicrophone, includeSystemAudio, audioDeviceId)) {
+            NSLog(@"🔧 Calling startAVFoundationRecording...");
+            bool avResult = startAVFoundationRecording(outputPath, displayID, windowID, captureRect, 
+                                                      captureCursor, includeMicrophone, includeSystemAudio, audioDeviceId);
+            NSLog(@"🔧 AVFoundation result: %s", avResult ? "SUCCESS" : "FAILED");
+            
+            if (avResult) {
                 NSLog(@"🎥 RECORDING METHOD: AVFoundation (Fallback)");
                 NSLog(@"✅ AVFoundation recording started successfully");
                 g_isRecording = true;
                 return Napi::Boolean::New(env, true);
             } else {
-                NSLog(@"❌ AVFoundation recording also failed to start");
+                NSLog(@"❌ AVFoundation recording failed to start");
+                NSLog(@"❌ Check permissions and output path validity");
             }
         } @catch (NSException *avException) {
             NSLog(@"❌ Exception during AVFoundation startup: %@", avException.reason);
+            NSLog(@"❌ Stack trace: %@", [avException callStackSymbols]);
         }
         
         // Both ScreenCaptureKit and AVFoundation failed