node-mac-recorder 2.16.18 → 2.16.19

package/.claude/settings.local.json

@@ -1,7 +1,7 @@
 {
   "permissions": {
     "allow": [
-      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing integrated overlay UI elements...'');\nconst WindowSelector = require(''./window-selector.js'');\nconst selector = new WindowSelector();\n\n// Test permission check first\nselector.checkPermissions().then(perms => {\n  console.log(''Permissions:'', perms);\n  \n  // Start window selection to test integrated overlay elements\n  return selector.startSelection();\n}).then(() => {\n  console.log(''✅ Window selection started - UI elements should be integrated into overlay'');\n  console.log(''➡️ Move cursor over windows to test integrated button, logo, and title'');\n  \n  // Auto-stop after 15 seconds for testing\n  setTimeout(() => {\n    selector.stopSelection().then(() => {\n      console.log(''✅ Window selection stopped - test complete'');\n    });\n  }, 15000);\n}).catch(console.error);\n\")"
+      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing UI elements on ALL screens...'');\nconst WindowSelector = require(''./window-selector.js'');\nconst selector = new WindowSelector();\n\nselector.checkPermissions().then(perms => {\n  console.log(''Permissions:'', perms);\n  return selector.startSelection();\n}).then(() => {\n  console.log(''✅ Window selection started - TEST UI elements on BOTH screens'');\n  console.log(''🖥️ Primary display: Move cursor over windows'');\n  console.log(''🖥️ External display: Move cursor over windows'');\n  console.log(''➡️ Check if Record/Cancel buttons + logo + title appear on BOTH displays'');\n  \n  setTimeout(() => {\n    selector.stopSelection().then(() => {\n      console.log(''✅ Test complete'');\n    });\n  }, 20000);\n}).catch(console.error);\n\")"
     ],
     "deny": [],
     "ask": []

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.16.18",
+	"version": "2.16.19",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/window_selector.mm

@@ -88,6 +88,7 @@ void updateScreenOverlays();
 @property (nonatomic) NSRect highlightFrame;
 @property (nonatomic, strong) NSValue *globalOriginOffset; // Store global coordinate offset
 @property (nonatomic, strong) HoverButton *recordButton;
+@property (nonatomic, strong) HoverButton *cancelButton;
 @property (nonatomic, strong) NSImageView *appIconView;
 @property (nonatomic, strong) NSTextField *infoLabel;
 - (void)setHighlightFrame:(NSRect)frame;
@@ -233,6 +234,11 @@ void updateScreenOverlays();
 - (void)setupUIElements {
     NSLog(@"🔧 Setting up integrated UI elements");
     
+    // Ensure delegate exists
+    if (!g_delegate) {
+        NSLog(@"⚠️ No delegate found in setupUIElements, this may cause button click issues");
+    }
+    
     // Create record button
     self.recordButton = [[HoverButton alloc] initWithFrame:NSMakeRect(0, 0, 200, 60)];
     [self.recordButton setTitle:@"Start Recording"];
@@ -249,6 +255,22 @@ void updateScreenOverlays();
     
     [self addSubview:self.recordButton];
     
+    // Create cancel button
+    self.cancelButton = [[HoverButton alloc] initWithFrame:NSMakeRect(0, 0, 120, 40)];
+    [self.cancelButton setTitle:@"Cancel"];
+    [self.cancelButton setFont:[NSFont systemFontOfSize:14.0 weight:NSFontWeightMedium]];
+    [self.cancelButton setBezelStyle:NSBezelStyleRounded];
+    [self.cancelButton setTarget:g_delegate];
+    [self.cancelButton setAction:@selector(cancelButtonClicked:)];
+    
+    // Style the cancel button
+    self.cancelButton.wantsLayer = YES;
+    self.cancelButton.layer.backgroundColor = [[NSColor colorWithRed:0.6 green:0.6 blue:0.6 alpha:0.9] CGColor];
+    self.cancelButton.layer.cornerRadius = 6.0;
+    self.cancelButton.layer.borderWidth = 0.0;
+    
+    [self addSubview:self.cancelButton];
+    
     // Create app icon view
     self.appIconView = [[NSImageView alloc] initWithFrame:NSMakeRect(0, 0, 96, 96)];
     [self.appIconView setImageScaling:NSImageScaleProportionallyUpOrDown];
@@ -307,6 +329,7 @@ void updateScreenOverlays();
     if (NSEqualRects(self.highlightFrame, NSZeroRect)) {
         // Hide elements when no window is highlighted
         [self.recordButton setHidden:YES];
+        [self.cancelButton setHidden:YES];
         [self.appIconView setHidden:YES];
         [self.infoLabel setHidden:YES];
         return;
@@ -314,6 +337,7 @@ void updateScreenOverlays();
     
     // Show elements
     [self.recordButton setHidden:NO];
+    [self.cancelButton setHidden:NO];
     [self.appIconView setHidden:NO];
     [self.infoLabel setHidden:NO];
     
@@ -352,8 +376,16 @@ void updateScreenOverlays();
         windowCenterY + 50  // 50px above window center
     )];
     
-    NSLog(@"📍 UI elements positioned - Button:(%.0f,%.0f) Icon:(%.0f,%.0f) Label:(%.0f,%.0f)",
+    // Position cancel button below record button
+    NSSize cancelButtonSize = self.cancelButton.frame.size;
+    [self.cancelButton setFrameOrigin:NSMakePoint(
+        windowCenterX - (cancelButtonSize.width / 2),
+        windowCenterY - 80  // 80px below window center
+    )];
+    
+    NSLog(@"📍 UI elements positioned - Button:(%.0f,%.0f) Cancel:(%.0f,%.0f) Icon:(%.0f,%.0f) Label:(%.0f,%.0f)",
           self.recordButton.frame.origin.x, self.recordButton.frame.origin.y,
+          self.cancelButton.frame.origin.x, self.cancelButton.frame.origin.y,
           self.appIconView.frame.origin.x, self.appIconView.frame.origin.y,
           self.infoLabel.frame.origin.x, self.infoLabel.frame.origin.y);
 }
@@ -1868,6 +1900,12 @@ Napi::Value StartWindowSelection(const Napi::CallbackInfo& info) {
         
         NSLog(@"🖥️ Creating per-screen overlays for %lu displays", [allScreens count]);
         
+        // Ensure delegate exists for all overlays
+        if (!g_delegate) {
+            g_delegate = [[WindowSelectorDelegate alloc] init];
+            NSLog(@"🎛️ Created global delegate for all overlays");
+        }
+        
         // Create overlay for each screen
         for (NSInteger i = 0; i < [allScreens count]; i++) {
             NSScreen *screen = [allScreens objectAtIndex:i];