node-mac-recorder 2.16.15 → 2.16.16

package/.claude/settings.local.json

@@ -1,7 +1,7 @@
 {
   "permissions": {
     "allow": [
-      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing area recording with scaling...'');\nconst MacRecorder = require(''./index.js'');\nconst recorder = new MacRecorder();\n\nconst options = {\n  captureArea: {\n    x: 200,\n    y: 200, \n    width: 800,\n    height: 600\n  }\n};\n\nrecorder.startRecording(''/tmp/area-scaling-test.mov'', options)\n  .then(success => {\n    console.log(''Area recording:'', success ? ''✅ SUCCESS'' : ''❌ FAILED'');\n    if (success) {\n      setTimeout(() => {\n        recorder.stopRecording().then(() => {\n          console.log(''✅ Area scaling test complete'');\n          const fs = require(''fs'');\n          if (fs.existsSync(''/tmp/area-scaling-test.mov'')) {\n            const size = Math.round(fs.statSync(''/tmp/area-scaling-test.mov'').size/1024);\n            console.log(''📹 File size:'', size + ''KB'');\n          }\n        });\n      }, 2000);\n    }\n  })\n  .catch(console.error);\n\")"
+      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing CRITICAL AVFoundation scaling fix...'');\nconst MacRecorder = require(''./index.js'');\nconst recorder = new MacRecorder();\n\nrecorder.startRecording(''/tmp/critical-scaling-test.mov'')\n  .then(success => {\n    console.log(''Start:'', success ? ''✅ SUCCESS'' : ''❌ FAILED'');\n    if (success) {\n      setTimeout(() => {\n        recorder.stopRecording().then(() => {\n          console.log(''✅ Test complete'');\n          const fs = require(''fs'');\n          if (fs.existsSync(''/tmp/critical-scaling-test.mov'')) {\n            const size = Math.round(fs.statSync(''/tmp/critical-scaling-test.mov'').size/1024);\n            console.log(''📹 File size:'', size + ''KB'');\n          }\n        });\n      }, 3000);\n    }\n  })\n  .catch(console.error);\n\")"
     ],
     "deny": [],
     "ask": []

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.16.15",
+	"version": "2.16.16",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/avfoundation_recorder.mm

@@ -65,8 +65,17 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
         CGFloat scaleY = physicalSize.height / logicalSize.height;
         CGFloat scaleFactor = MAX(scaleX, scaleY); // Use max to handle non-uniform scaling
         
-        // For AVFoundation, use logical size (what CGDisplayCreateImage actually captures)
-        CGSize recordingSize = captureRect.size.width > 0 ? captureRect.size : logicalSize;
+        // CRITICAL FIX: Use actual captured image dimensions, not logical size
+        // CGDisplayCreateImage may return higher resolution on Retina displays
+        CGImageRef testImage = CGDisplayCreateImage(displayID);
+        CGSize actualImageSize = CGSizeMake(CGImageGetWidth(testImage), CGImageGetHeight(testImage));
+        CGImageRelease(testImage);
+        
+        // For AVFoundation, use actual image size that CGDisplayCreateImage returns
+        CGSize recordingSize = captureRect.size.width > 0 ? captureRect.size : actualImageSize;
+        
+        NSLog(@"🎯 CRITICAL: Logical %.0fx%.0f → Actual image %.0fx%.0f", 
+              logicalSize.width, logicalSize.height, actualImageSize.width, actualImageSize.height);
         
         NSLog(@"🖥️ Display bounds (logical): %.0fx%.0f", logicalSize.width, logicalSize.height);
         NSLog(@"🖥️ Display pixels (physical): %.0fx%.0f", physicalSize.width, physicalSize.height);
@@ -147,13 +156,30 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
         
         // Apply scaling to capture rect if provided (for macOS 14/13 compatibility)
         if (!CGRectIsEmpty(captureRect)) {
-            // Note: captureRect comes in logical coordinates, keep as-is for CGDisplayCreateImage
-            g_avCaptureRect = captureRect;
-            NSLog(@"🔲 Capture area (logical): %.0f,%.0f %.0fx%.0f", 
-                  captureRect.origin.x, captureRect.origin.y, captureRect.size.width, captureRect.size.height);
+            // Scale capture rect to match actual image dimensions if needed
+            CGFloat imageScaleX = actualImageSize.width / logicalSize.width;
+            CGFloat imageScaleY = actualImageSize.height / logicalSize.height;
+            
+            if (imageScaleX > 1.1 || imageScaleY > 1.1) {
+                // Scale up capture rect for high-DPI displays
+                CGRect scaledRect = CGRectMake(
+                    captureRect.origin.x * imageScaleX,
+                    captureRect.origin.y * imageScaleY,
+                    captureRect.size.width * imageScaleX,
+                    captureRect.size.height * imageScaleY
+                );
+                g_avCaptureRect = scaledRect;
+                NSLog(@"🔲 Capture area scaled: %.0f,%.0f %.0fx%.0f (scale %.1fx%.1fx)", 
+                      scaledRect.origin.x, scaledRect.origin.y, scaledRect.size.width, scaledRect.size.height,
+                      imageScaleX, imageScaleY);
+            } else {
+                g_avCaptureRect = captureRect;
+                NSLog(@"🔲 Capture area (no scaling): %.0f,%.0f %.0fx%.0f", 
+                      captureRect.origin.x, captureRect.origin.y, captureRect.size.width, captureRect.size.height);
+            }
         } else {
             g_avCaptureRect = CGRectZero; // Full screen
-            NSLog(@"🖥️ Full screen capture (logical bounds)");
+            NSLog(@"🖥️ Full screen capture (actual image dimensions)");
         }
         
         g_avFrameNumber = 0;
@@ -214,8 +240,11 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
                         size_t imageWidth = CGImageGetWidth(screenImage);
                         size_t imageHeight = CGImageGetHeight(screenImage);
                         
+                        NSLog(@"🔍 Debug: Buffer %zux%zu, Image %zux%zu", bufferWidth, bufferHeight, imageWidth, imageHeight);
+                        
                         if (bufferWidth != imageWidth || bufferHeight != imageHeight) {
-                            NSLog(@"⚠️ Size mismatch! Buffer %zux%zu vs Image %zux%zu", bufferWidth, bufferHeight, imageWidth, imageHeight);
+                            NSLog(@"⚠️ CRITICAL SIZE MISMATCH! Buffer %zux%zu vs Image %zux%zu", bufferWidth, bufferHeight, imageWidth, imageHeight);
+                            NSLog(@"   This indicates Retina scaling issue on macOS 14/13");
                         }
                         
                         CVPixelBufferLockBaseAddress(pixelBuffer, 0);

package/src/window_selector.mm

@@ -892,11 +892,21 @@ void updateOverlay() {
                 CGFloat primaryOffsetX = primaryFrame.origin.x - combinedFrame.origin.x;
                 CGFloat primaryOffsetY = primaryFrame.origin.y - combinedFrame.origin.y;
                 
+                NSLog(@"🔧 PRIMARY DEBUG:");
+                NSLog(@"   Primary frame: (%.0f,%.0f) %.0fx%.0f", primaryFrame.origin.x, primaryFrame.origin.y, primaryFrame.size.width, primaryFrame.size.height);
+                NSLog(@"   Combined frame: (%.0f,%.0f) %.0fx%.0f", combinedFrame.origin.x, combinedFrame.origin.y, combinedFrame.size.width, combinedFrame.size.height);
+                NSLog(@"   Primary offset: (%.0f,%.0f)", primaryOffsetX, primaryOffsetY);
+                NSLog(@"   Window coords: (%.0f,%.0f) → Local: (%.0f,%.0f)", (CGFloat)x, (CGFloat)y, x + primaryOffsetX, ([g_overlayView frame].size.height - (y + primaryOffsetY)) - height);
+                
                 localX = x + primaryOffsetX;
                 localY = ([g_overlayView frame].size.height - (y + primaryOffsetY)) - height;
                 
             } else {
                 // Secondary display windows: Apply standard coordinate transformation
+                NSLog(@"🔧 SECONDARY DEBUG:");
+                NSLog(@"   GlobalOffset: (%.0f,%.0f)", globalOffset.x, globalOffset.y);
+                NSLog(@"   Window coords: (%.0f,%.0f) → Local: (%.0f,%.0f)", (CGFloat)x, (CGFloat)y, x - globalOffset.x, ([g_overlayView frame].size.height - (y - globalOffset.y)) - height);
+                
                 localX = x - globalOffset.x;
                 localY = ([g_overlayView frame].size.height - (y - globalOffset.y)) - height;
             }