node-mac-recorder 2.16.14 → 2.16.15

package/.claude/settings.local.json

@@ -1,7 +1,7 @@
 {
   "permissions": {
     "allow": [
-      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing AVFoundation area recording...'');\nconst MacRecorder = require(''./index.js'');\nconst recorder = new MacRecorder();\n\n// Test specific area recording (top-left 500x500)\nconst options = {\n  captureArea: {\n    x: 100,\n    y: 100, \n    width: 500,\n    height: 500\n  }\n};\n\nrecorder.startRecording(''/tmp/area-test.mov'', options)\n  .then(success => {\n    console.log(''Area recording:'', success ? ''✅ SUCCESS'' : ''❌ FAILED'');\n    if (success) {\n      setTimeout(() => {\n        recorder.stopRecording().then(() => {\n          console.log(''✅ Area recording complete'');\n          const fs = require(''fs'');\n          if (fs.existsSync(''/tmp/area-test.mov'')) {\n            const size = Math.round(fs.statSync(''/tmp/area-test.mov'').size/1024);\n            console.log(''📹 File size:'', size + ''KB'');\n          }\n        });\n      }, 2000);\n    }\n  })\n  .catch(console.error);\n\")"
+      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing area recording with scaling...'');\nconst MacRecorder = require(''./index.js'');\nconst recorder = new MacRecorder();\n\nconst options = {\n  captureArea: {\n    x: 200,\n    y: 200, \n    width: 800,\n    height: 600\n  }\n};\n\nrecorder.startRecording(''/tmp/area-scaling-test.mov'', options)\n  .then(success => {\n    console.log(''Area recording:'', success ? ''✅ SUCCESS'' : ''❌ FAILED'');\n    if (success) {\n      setTimeout(() => {\n        recorder.stopRecording().then(() => {\n          console.log(''✅ Area scaling test complete'');\n          const fs = require(''fs'');\n          if (fs.existsSync(''/tmp/area-scaling-test.mov'')) {\n            const size = Math.round(fs.statSync(''/tmp/area-scaling-test.mov'').size/1024);\n            console.log(''📹 File size:'', size + ''KB'');\n          }\n        });\n      }, 2000);\n    }\n  })\n  .catch(console.error);\n\")"
     ],
     "deny": [],
     "ask": []

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.16.14",
+	"version": "2.16.15",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/avfoundation_recorder.mm

@@ -53,14 +53,33 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
             return false;
         }
         
-        // Get display dimensions - use width/height directly to avoid coordinate issues
+        // Get display dimensions with proper scaling for macOS 14/13 compatibility
         CGRect displayBounds = CGDisplayBounds(displayID);
-        CGSize displaySize = CGSizeMake(CGDisplayPixelsWide(displayID), CGDisplayPixelsHigh(displayID));
-        CGSize recordingSize = captureRect.size.width > 0 ? captureRect.size : displaySize;
         
-        NSLog(@"🖥️ Display bounds: %.0f,%.0f %.0fx%.0f", displayBounds.origin.x, displayBounds.origin.y, displayBounds.size.width, displayBounds.size.height);
-        NSLog(@"🖥️ Display pixels: %.0fx%.0f", displaySize.width, displaySize.height);
-        NSLog(@"🎯 Recording size: %.0fx%.0f", recordingSize.width, recordingSize.height);
+        // Get both logical (bounds) and physical (pixels) dimensions
+        CGSize logicalSize = displayBounds.size;
+        CGSize physicalSize = CGSizeMake(CGDisplayPixelsWide(displayID), CGDisplayPixelsHigh(displayID));
+        
+        // Calculate scale factor
+        CGFloat scaleX = physicalSize.width / logicalSize.width;
+        CGFloat scaleY = physicalSize.height / logicalSize.height;
+        CGFloat scaleFactor = MAX(scaleX, scaleY); // Use max to handle non-uniform scaling
+        
+        // For AVFoundation, use logical size (what CGDisplayCreateImage actually captures)
+        CGSize recordingSize = captureRect.size.width > 0 ? captureRect.size : logicalSize;
+        
+        NSLog(@"🖥️ Display bounds (logical): %.0fx%.0f", logicalSize.width, logicalSize.height);
+        NSLog(@"🖥️ Display pixels (physical): %.0fx%.0f", physicalSize.width, physicalSize.height);
+        
+        if (scaleFactor > 1.5) {
+            NSLog(@"🔍 Scale factor: %.1fx → Retina display detected (macOS 14/13 scaling fix applied)", scaleFactor);
+        } else if (scaleFactor > 1.1) {
+            NSLog(@"🔍 Scale factor: %.1fx → Non-standard scaling detected", scaleFactor);
+        } else {
+            NSLog(@"🔍 Scale factor: %.1fx → Standard display", scaleFactor);
+        }
+        
+        NSLog(@"🎯 Recording size: %.0fx%.0f (using logical dimensions for AVFoundation)", recordingSize.width, recordingSize.height);
         
         // Video settings with macOS compatibility
         NSString *codecKey;
@@ -123,9 +142,20 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
         g_avStartTime = CMTimeMakeWithSeconds(CACurrentMediaTime(), 600);
         [g_avWriter startSessionAtSourceTime:g_avStartTime];
         
-        // Store recording parameters
+        // Store recording parameters with scaling correction
         g_avDisplayID = displayID;
-        g_avCaptureRect = captureRect;
+        
+        // Apply scaling to capture rect if provided (for macOS 14/13 compatibility)
+        if (!CGRectIsEmpty(captureRect)) {
+            // Note: captureRect comes in logical coordinates, keep as-is for CGDisplayCreateImage
+            g_avCaptureRect = captureRect;
+            NSLog(@"🔲 Capture area (logical): %.0f,%.0f %.0fx%.0f", 
+                  captureRect.origin.x, captureRect.origin.y, captureRect.size.width, captureRect.size.height);
+        } else {
+            g_avCaptureRect = CGRectZero; // Full screen
+            NSLog(@"🖥️ Full screen capture (logical bounds)");
+        }
+        
         g_avFrameNumber = 0;
         
         // Start capture timer (10 FPS for Electron compatibility)