node-mac-recorder 2.16.13 → 2.16.15

package/.claude/settings.local.json

@@ -1,7 +1,7 @@
 {
   "permissions": {
     "allow": [
-      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing Electron crash fix (macOS 14 simulation)...'');\nconst MacRecorder = require(''./index.js'');\nconst recorder = new MacRecorder();\n\nrecorder.on(''recordingStarted'', (details) => {\n  console.log(''✅ Recording started safely'');\n});\n\nrecorder.on(''stopped'', () => {\n  console.log(''✅ Recording stopped without crash'');\n});\n\nlet recordingStarted = false;\nrecorder.startRecording(''/tmp/crash-fix-test.mov'')\n  .then(success => {\n    console.log(''Start result:'', success ? ''✅ SUCCESS'' : ''❌ FAILED'');\n    if (success) {\n      recordingStarted = true;\n      // Test quick start/stop cycles to stress test memory handling\n      setTimeout(() => {\n        console.log(''⏹️ Quick stop test...'');\n        recorder.stopRecording().then(() => {\n          console.log(''✅ Quick stop completed'');\n          \n          // Test immediate restart\n          setTimeout(() => {\n            console.log(''🔄 Testing immediate restart...'');\n            recorder.startRecording(''/tmp/crash-fix-test2.mov'').then(() => {\n              setTimeout(() => {\n                recorder.stopRecording().then(() => {\n                  console.log(''🎉 Crash fix test completed successfully!'');\n                  const fs = require(''fs'');\n                  const files = [''/tmp/crash-fix-test.mov'', ''/tmp/crash-fix-test2.mov''];\n                  files.forEach(file => {\n                    if (fs.existsSync(file)) {\n                      const size = Math.round(fs.statSync(file).size/1024);\n                      console.log(''📹 '' + file + '':'', size + ''KB'');\n                    }\n                  });\n                });\n              }, 1000);\n            });\n          }, 500);\n        });\n      }, 2000);\n    }\n  })\n  .catch(err => {\n    console.error(''❌ Error:'', err);\n    if (recordingStarted) {\n      recorder.stopRecording();\n    }\n  });\n\")"
+      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing area recording with scaling...'');\nconst MacRecorder = require(''./index.js'');\nconst recorder = new MacRecorder();\n\nconst options = {\n  captureArea: {\n    x: 200,\n    y: 200, \n    width: 800,\n    height: 600\n  }\n};\n\nrecorder.startRecording(''/tmp/area-scaling-test.mov'', options)\n  .then(success => {\n    console.log(''Area recording:'', success ? ''✅ SUCCESS'' : ''❌ FAILED'');\n    if (success) {\n      setTimeout(() => {\n        recorder.stopRecording().then(() => {\n          console.log(''✅ Area scaling test complete'');\n          const fs = require(''fs'');\n          if (fs.existsSync(''/tmp/area-scaling-test.mov'')) {\n            const size = Math.round(fs.statSync(''/tmp/area-scaling-test.mov'').size/1024);\n            console.log(''📹 File size:'', size + ''KB'');\n          }\n        });\n      }, 2000);\n    }\n  })\n  .catch(console.error);\n\")"
     ],
     "deny": [],
     "ask": []

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.16.13",
+	"version": "2.16.15",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/avfoundation_recorder.mm

@@ -53,9 +53,33 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
             return false;
         }
         
-        // Get display dimensions
+        // Get display dimensions with proper scaling for macOS 14/13 compatibility
         CGRect displayBounds = CGDisplayBounds(displayID);
-        CGSize recordingSize = captureRect.size.width > 0 ? captureRect.size : displayBounds.size;
+        
+        // Get both logical (bounds) and physical (pixels) dimensions
+        CGSize logicalSize = displayBounds.size;
+        CGSize physicalSize = CGSizeMake(CGDisplayPixelsWide(displayID), CGDisplayPixelsHigh(displayID));
+        
+        // Calculate scale factor
+        CGFloat scaleX = physicalSize.width / logicalSize.width;
+        CGFloat scaleY = physicalSize.height / logicalSize.height;
+        CGFloat scaleFactor = MAX(scaleX, scaleY); // Use max to handle non-uniform scaling
+        
+        // For AVFoundation, use logical size (what CGDisplayCreateImage actually captures)
+        CGSize recordingSize = captureRect.size.width > 0 ? captureRect.size : logicalSize;
+        
+        NSLog(@"🖥️ Display bounds (logical): %.0fx%.0f", logicalSize.width, logicalSize.height);
+        NSLog(@"🖥️ Display pixels (physical): %.0fx%.0f", physicalSize.width, physicalSize.height);
+        
+        if (scaleFactor > 1.5) {
+            NSLog(@"🔍 Scale factor: %.1fx → Retina display detected (macOS 14/13 scaling fix applied)", scaleFactor);
+        } else if (scaleFactor > 1.1) {
+            NSLog(@"🔍 Scale factor: %.1fx → Non-standard scaling detected", scaleFactor);
+        } else {
+            NSLog(@"🔍 Scale factor: %.1fx → Standard display", scaleFactor);
+        }
+        
+        NSLog(@"🎯 Recording size: %.0fx%.0f (using logical dimensions for AVFoundation)", recordingSize.width, recordingSize.height);
         
         // Video settings with macOS compatibility
         NSString *codecKey;
@@ -118,9 +142,20 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
         g_avStartTime = CMTimeMakeWithSeconds(CACurrentMediaTime(), 600);
         [g_avWriter startSessionAtSourceTime:g_avStartTime];
         
-        // Store recording parameters
+        // Store recording parameters with scaling correction
         g_avDisplayID = displayID;
-        g_avCaptureRect = captureRect;
+        
+        // Apply scaling to capture rect if provided (for macOS 14/13 compatibility)
+        if (!CGRectIsEmpty(captureRect)) {
+            // Note: captureRect comes in logical coordinates, keep as-is for CGDisplayCreateImage
+            g_avCaptureRect = captureRect;
+            NSLog(@"🔲 Capture area (logical): %.0f,%.0f %.0fx%.0f", 
+                  captureRect.origin.x, captureRect.origin.y, captureRect.size.width, captureRect.size.height);
+        } else {
+            g_avCaptureRect = CGRectZero; // Full screen
+            NSLog(@"🖥️ Full screen capture (logical bounds)");
+        }
+        
         g_avFrameNumber = 0;
         
         // Start capture timer (10 FPS for Electron compatibility)
@@ -173,6 +208,16 @@ extern "C" bool startAVFoundationRecording(const std::string& outputPath,
                     CVReturn cvRet = CVPixelBufferPoolCreatePixelBuffer(NULL, localPixelBufferAdaptor.pixelBufferPool, &pixelBuffer);
                     
                     if (cvRet == kCVReturnSuccess && pixelBuffer) {
+                        // Check pixel buffer dimensions match screen image
+                        size_t bufferWidth = CVPixelBufferGetWidth(pixelBuffer);
+                        size_t bufferHeight = CVPixelBufferGetHeight(pixelBuffer);
+                        size_t imageWidth = CGImageGetWidth(screenImage);
+                        size_t imageHeight = CGImageGetHeight(screenImage);
+                        
+                        if (bufferWidth != imageWidth || bufferHeight != imageHeight) {
+                            NSLog(@"⚠️ Size mismatch! Buffer %zux%zu vs Image %zux%zu", bufferWidth, bufferHeight, imageWidth, imageHeight);
+                        }
+                        
                         CVPixelBufferLockBaseAddress(pixelBuffer, 0);
                         
                         void *pixelData = CVPixelBufferGetBaseAddress(pixelBuffer);

package/src/window_selector.mm

@@ -875,25 +875,32 @@ void updateOverlay() {
             }
             
             // Determine if this is a primary display window
-            BOOL isPrimaryDisplayWindow = (x >= 0 && x <= 2048);  // Primary display width
+            NSArray *allScreens = [NSScreen screens];
+            NSScreen *primaryScreen = [allScreens objectAtIndex:0]; // Primary screen
+            NSRect primaryFrame = [primaryScreen frame];
+            BOOL isPrimaryDisplayWindow = (x >= primaryFrame.origin.x && 
+                                         x <= primaryFrame.origin.x + primaryFrame.size.width &&
+                                         y >= primaryFrame.origin.y &&
+                                         y <= primaryFrame.origin.y + primaryFrame.size.height);
             
             CGFloat localX, localY;
             if (isPrimaryDisplayWindow) {
-                // Primary display windows: Offset to their position in the combined overlay
-                // Primary display starts at (3440, 56) within the combined frame
-                localX = x + 3440;  // Primary starts 3440px from overlay origin
-                localY = ([g_overlayView frame].size.height - (y + 56)) - height;  // Y offset for primary
+                // Primary display windows: Calculate dynamic offset from combined frame
+                NSRect combinedFrame = [g_overlayWindow frame];
+                
+                // Calculate primary screen offset within combined frame
+                CGFloat primaryOffsetX = primaryFrame.origin.x - combinedFrame.origin.x;
+                CGFloat primaryOffsetY = primaryFrame.origin.y - combinedFrame.origin.y;
+                
+                localX = x + primaryOffsetX;
+                localY = ([g_overlayView frame].size.height - (y + primaryOffsetY)) - height;
+                
             } else {
                 // Secondary display windows: Apply standard coordinate transformation
                 localX = x - globalOffset.x;
                 localY = ([g_overlayView frame].size.height - (y - globalOffset.y)) - height;
             }
             
-            NSLog(@"🔧 COORDINATE DEBUG: Window (%d, %d) %dx%d [%@]", (int)x, (int)y, (int)width, (int)height, isPrimaryDisplayWindow ? @"PRIMARY" : @"SECONDARY");
-            NSLog(@"   GlobalOffset: (%.0f, %.0f)", globalOffset.x, globalOffset.y);
-            NSLog(@"   LocalCoords: (%.0f, %.0f)", localX, localY);
-            NSLog(@"   ViewFrame: %.0fx%.0f", [g_overlayView frame].size.width, [g_overlayView frame].size.height);
-            
             // Update overlay view window info for highlighting
             [overlayView setWindowInfo:targetWindow];
             [overlayView setHighlightFrame:NSMakeRect(localX, localY, width, height)];