node-mac-recorder 2.16.0 → 2.16.2

package/.claude/settings.local.json

@@ -43,7 +43,10 @@
       "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🎵 Testing both microphone and system audio'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testBothAudio() {\n  try {\n    const outputPath = ''./test-output/both-audio-test.mov'';\n    console.log(''📹 Starting recording with both audio sources...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: true,   // Mikrophone AÇIK\n      includeSystemAudio: true   // Sistem sesi AÇIK\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 5 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 5000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Both audio test completed!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n    console.log(''Stack:'', error.stack);\n  }\n}\n\ntestBothAudio();\n\")",
       "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🎤 Testing microphone only'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testMicrophoneOnly() {\n  try {\n    const outputPath = ''./test-output/microphone-only-test.mov'';\n    console.log(''📹 Starting microphone only recording...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: false,\n      includeMicrophone: true,   // Sadece mikrofon AÇIK\n      includeSystemAudio: false  // Sistem sesi KAPALI\n    });\n    \n    if (success) {\n      console.log(''✅ Microphone recording started - waiting 3 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      console.log(''🛑 Stopping microphone recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Microphone only test completed!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestMicrophoneOnly();\n\")",
       "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🚀 Full stress test - All features + Both audio sources'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function fullStressTest() {\n  try {\n    const outputPath = ''./test-output/full-stress-test.mov'';\n    console.log(''📹 Starting full featured recording (stress test)...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,       // Cursor kayıt\n      includeMicrophone: true,   // Mikrofon kayıt\n      includeSystemAudio: true,  // Sistem sesi kayıt\n      captureArea: {             // Crop area\n        x: 300,\n        y: 300,\n        width: 800,\n        height: 500\n      }\n    });\n    \n    if (success) {\n      console.log(''✅ Full stress test started - waiting 6 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 6000));\n      \n      console.log(''🛑 Stopping full stress test...'');\n      await recorder.stopRecording();\n      console.log(''🎉 FULL STRESS TEST COMPLETED WITHOUT CRASH!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n    console.log(''Stack:'', error.stack);\n  }\n}\n\nfullStressTest();\n\")",
-      "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🧪 Testing version detection and fallback system'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testVersionDetection() {\n  try {\n    const outputPath = ''./test-output/version-detection-test.mov'';\n    console.log(''📹 Starting recording with version detection...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 3 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Version detection test completed successfully!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestVersionDetection();\n\")"
+      "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🧪 Testing version detection and fallback system'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testVersionDetection() {\n  try {\n    const outputPath = ''./test-output/version-detection-test.mov'';\n    console.log(''📹 Starting recording with version detection...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 3 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Version detection test completed successfully!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestVersionDetection();\n\")",
+      "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🧪 Testing Electron safety measures'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testElectronSafety() {\n  try {\n    const outputPath = ''./test-output/electron-safe-test.mov'';\n    console.log(''📹 Starting recording in Electron environment...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started safely in Electron - waiting 3 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Electron safety test completed successfully!'');\n    } else {\n      console.log(''⚠️ Recording failed to start (expected in some cases)'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestElectronSafety();\n\")",
+      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing AVFoundation fallback path'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testAVFoundationPath() {\n  try {\n    const outputPath = ''./test-output/force-avfoundation-test.mov'';\n    console.log(''📹 Testing AVFoundation (force mode)...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started'');\n      await new Promise(resolve => setTimeout(resolve, 2000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ AVFoundation test completed!'');\n    } else {\n      console.log(''❌ Recording failed'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestAVFoundationPath();\n\")",
+      "Bash(FORCE_AVFOUNDATION=1 node -e \"\nconsole.log(''🧪 Testing AVFoundation fallback path (macOS 14 simulation)'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testAVFoundationPath() {\n  try {\n    const outputPath = ''./test-output/force-avfoundation-test.mov'';\n    console.log(''📹 Testing AVFoundation (simulating macOS 14)...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started with AVFoundation'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      await recorder.stopRecording();\n      console.log(''✅ AVFoundation test completed successfully!'');\n      console.log(''This is how it should work on macOS 14'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestAVFoundationPath();\n\")"
     ],
     "deny": []
   }

package/MACOS14_TROUBLESHOOTING.md

@@ -0,0 +1,111 @@
+# macOS 13/14 Recording Troubleshooting Guide
+
+## Expected Behavior by macOS Version
+
+The system automatically detects macOS version and uses the most compatible recording method:
+
+- **macOS 15+**: Uses ScreenCaptureKit (30fps, full features)
+- **macOS 14**: Uses AVFoundation fallback (15fps, stable)
+- **macOS 13**: Uses AVFoundation fallback (15fps, limited features)
+- **macOS < 13**: Not supported
+
+## Debug Steps for macOS 13/14 Issues
+
+### 1. Check Console Logs
+
+When running your application, check for these log messages:
+
+**macOS 14:**
+```
+🖥️ macOS Version: 14.x.x
+🎯 macOS 14 detected - using AVFoundation for better compatibility
+🎥 Using AVFoundation for macOS 14 compatibility
+🎥 RECORDING METHOD: AVFoundation (Fallback)
+```
+
+**macOS 13:**
+```
+🖥️ macOS Version: 13.x.x
+🎯 macOS 13 detected - using AVFoundation (limited features)
+🎥 Using AVFoundation for macOS 13 compatibility (limited features)
+🎥 RECORDING METHOD: AVFoundation (Fallback)
+```
+
+### 2. Test AVFoundation Directly
+
+You can force AVFoundation mode for testing:
+
+```javascript
+// Set environment variable before running
+process.env.FORCE_AVFOUNDATION = "1";
+
+const MacRecorder = require('node-mac-recorder');
+const recorder = new MacRecorder();
+
+async function test() {
+  const success = await recorder.startRecording('./test.mov', {
+    captureCursor: true,
+    includeMicrophone: false,
+    includeSystemAudio: true
+  });
+  
+  if (success) {
+    console.log('✅ AVFoundation recording started');
+    setTimeout(async () => {
+      await recorder.stopRecording();
+      console.log('✅ Recording completed');
+    }, 3000);
+  } else {
+    console.log('❌ Recording failed');
+  }
+}
+
+test();
+```
+
+### 3. Common Issues and Solutions
+
+**Issue**: Recording starts but no video file created
+- **Cause**: Permission issues
+- **Solution**: Check Screen Recording permission in System Preferences
+
+**Issue**: Audio not recorded
+- **Cause**: Microphone permission missing
+- **Solution**: Check Microphone permission in System Preferences
+
+**Issue**: Recording fails silently
+- **Cause**: Invalid display ID or output path
+- **Solution**: Use default display (don't specify displayId) and ensure output directory exists
+
+### 4. Permission Requirements
+
+macOS 14 requires these permissions:
+- ✅ Screen Recording (System Preferences > Privacy & Security)
+- ✅ Microphone (if includeMicrophone: true)
+- ✅ Accessibility (for cursor tracking)
+
+### 5. Technical Details
+
+**AVFoundation Implementation (macOS 14):**
+- Video: H.264 encoding at 15fps
+- Audio: AAC encoding at 44.1kHz
+- Screen capture: CGDisplayCreateImage
+- Memory management: Automatic cleanup
+
+**Differences from ScreenCaptureKit:**
+- Lower frame rate (15fps vs 30fps) for stability
+- No automatic window exclusion
+- Simpler audio routing
+
+**macOS 13 Specific Limitations:**
+- Audio features may have reduced compatibility
+- Some advanced recording options may not work
+- Recommended to test thoroughly on target systems
+
+## Contact
+
+If recording still fails on macOS 14 after following this guide, please provide:
+1. macOS version (`sw_vers`)
+2. Console logs from the application
+3. Permission status screenshots
+4. Minimal reproduction code

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.16.0",
+	"version": "2.16.2",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/mac_recorder.mm

@@ -51,8 +51,14 @@ void cleanupRecording() {
         }
     }
     
-    // AVFoundation cleanup
-    if (isAVFoundationRecording()) {
+    // AVFoundation cleanup (only in non-Electron environments)
+    BOOL isElectron = (NSBundle.mainBundle.bundleIdentifier && 
+                      [NSBundle.mainBundle.bundleIdentifier containsString:@"electron"]) ||
+                     (NSProcessInfo.processInfo.processName && 
+                      [NSProcessInfo.processInfo.processName containsString:@"Electron"]) ||
+                     (NSProcessInfo.processInfo.environment[@"ELECTRON_RUN_AS_NODE"] != nil);
+    
+    if (!isElectron && isAVFoundationRecording()) {
         stopAVFoundationRecording();
     }
     
@@ -186,18 +192,23 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
         
         // Check macOS version for ScreenCaptureKit compatibility
         NSOperatingSystemVersion osVersion = [[NSProcessInfo processInfo] operatingSystemVersion];
-        BOOL isM15Plus = (osVersion.majorVersion > 15 || 
-                          (osVersion.majorVersion == 15 && osVersion.minorVersion >= 0));
-        BOOL isM14Plus = (osVersion.majorVersion > 14 || 
-                          (osVersion.majorVersion == 14 && osVersion.minorVersion >= 0));
+        BOOL isM15Plus = (osVersion.majorVersion >= 15);
+        BOOL isM14Plus = (osVersion.majorVersion >= 14);
+        BOOL isM13Plus = (osVersion.majorVersion >= 13);
         
         NSLog(@"🖥️ macOS Version: %ld.%ld.%ld", 
               (long)osVersion.majorVersion, (long)osVersion.minorVersion, (long)osVersion.patchVersion);
         
-        // Try ScreenCaptureKit on macOS 14+ (with better compatibility on 15+)
-        if (@available(macOS 12.3, *) && isM14Plus) {
-            NSLog(@"✅ macOS 14+ detected - ScreenCaptureKit available with %@ compatibility", 
-                  isM15Plus ? @"full" : @"limited");
+        // Force AVFoundation for debugging/testing
+        BOOL forceAVFoundation = (getenv("FORCE_AVFOUNDATION") != NULL);
+        if (forceAVFoundation) {
+            NSLog(@"🔧 FORCE_AVFOUNDATION environment variable detected - skipping ScreenCaptureKit");
+        }
+        
+        // Use ScreenCaptureKit only on macOS 15+ for maximum stability
+        // macOS 14 should use AVFoundation fallback
+        if (@available(macOS 12.3, *) && isM15Plus && !forceAVFoundation) {
+            NSLog(@"✅ macOS 15+ detected - ScreenCaptureKit available with full compatibility");
             
             // Try ScreenCaptureKit with extensive safety measures
             @try {
@@ -269,13 +280,32 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
                 NSLog(@"❌ Exception during ScreenCaptureKit availability check: %@", availabilityException.reason);
                 return Napi::Boolean::New(env, false);
             }
+        } else if (isM14Plus) {
+            // macOS 14 - directly use AVFoundation for better compatibility
+            NSLog(@"🎯 macOS 14 detected - using AVFoundation for better compatibility");
+        } else if (isM13Plus) {
+            // macOS 13 - use AVFoundation (limited features)
+            NSLog(@"🎯 macOS 13 detected - using AVFoundation (limited features)");
         } else {
-            NSLog(@"❌ macOS version too old for ScreenCaptureKit (< 12.3) - Recording not supported");
+            NSLog(@"❌ macOS version too old (< 13.0) - Recording not supported");
             return Napi::Boolean::New(env, false);
         }
         
-        // If we get here, ScreenCaptureKit failed - try AVFoundation fallback
-        NSLog(@"🔄 ScreenCaptureKit failed - attempting AVFoundation fallback");
+        // AVFoundation fallback logic
+        if (isElectron) {
+            NSLog(@"❌ ScreenCaptureKit failed in Electron - AVFoundation disabled for stability");
+            NSLog(@"❌ Recording not available in Electron when ScreenCaptureKit fails");
+            return Napi::Boolean::New(env, false);
+        }
+        
+        // Try AVFoundation fallback (ScreenCaptureKit failed or macOS 13/14)
+        if (isM15Plus) {
+            NSLog(@"🔄 ScreenCaptureKit failed on macOS 15+ - attempting AVFoundation fallback");
+        } else if (isM14Plus) {
+            NSLog(@"🎥 Using AVFoundation for macOS 14 compatibility");
+        } else if (isM13Plus) {
+            NSLog(@"🎥 Using AVFoundation for macOS 13 compatibility (limited features)");
+        }
         
         @try {
             // Import AVFoundation recording functions (if available)
@@ -327,24 +357,32 @@ Napi::Value StopRecording(const Napi::CallbackInfo& info) {
         }
     }
     
-    // Try AVFoundation fallback
-    extern bool isAVFoundationRecording();
-    extern bool stopAVFoundationRecording();
+    // Try AVFoundation fallback (only in non-Electron environments)
+    BOOL isElectron = (NSBundle.mainBundle.bundleIdentifier && 
+                      [NSBundle.mainBundle.bundleIdentifier containsString:@"electron"]) ||
+                     (NSProcessInfo.processInfo.processName && 
+                      [NSProcessInfo.processInfo.processName containsString:@"Electron"]) ||
+                     (NSProcessInfo.processInfo.environment[@"ELECTRON_RUN_AS_NODE"] != nil);
     
-    @try {
-        if (isAVFoundationRecording()) {
-            NSLog(@"🛑 Stopping AVFoundation recording");
-            if (stopAVFoundationRecording()) {
-                g_isRecording = false;
-                return Napi::Boolean::New(env, true);
-            } else {
-                NSLog(@"❌ Failed to stop AVFoundation recording");
-                g_isRecording = false;
-                return Napi::Boolean::New(env, false);
+    if (!isElectron) {
+        extern bool isAVFoundationRecording();
+        extern bool stopAVFoundationRecording();
+        
+        @try {
+            if (isAVFoundationRecording()) {
+                NSLog(@"🛑 Stopping AVFoundation recording");
+                if (stopAVFoundationRecording()) {
+                    g_isRecording = false;
+                    return Napi::Boolean::New(env, true);
+                } else {
+                    NSLog(@"❌ Failed to stop AVFoundation recording");
+                    g_isRecording = false;
+                    return Napi::Boolean::New(env, false);
+                }
             }
+        } @catch (NSException *exception) {
+            NSLog(@"❌ Exception stopping AVFoundation: %@", exception.reason);
         }
-    } @catch (NSException *exception) {
-        NSLog(@"❌ Exception stopping AVFoundation: %@", exception.reason);
     }
     
     NSLog(@"⚠️ No active recording found to stop");
@@ -606,7 +644,7 @@ Napi::Value GetDisplays(const Napi::CallbackInfo& info) {
 Napi::Value GetRecordingStatus(const Napi::CallbackInfo& info) {
     Napi::Env env = info.Env();
     
-    // Check both recording methods
+    // Check recording methods
     bool isRecording = g_isRecording;
     
     if (@available(macOS 12.3, *)) {
@@ -615,7 +653,14 @@ Napi::Value GetRecordingStatus(const Napi::CallbackInfo& info) {
         }
     }
     
-    if (isAVFoundationRecording()) {
+    // Check AVFoundation only in non-Electron environments
+    BOOL isElectron = (NSBundle.mainBundle.bundleIdentifier && 
+                      [NSBundle.mainBundle.bundleIdentifier containsString:@"electron"]) ||
+                     (NSProcessInfo.processInfo.processName && 
+                      [NSProcessInfo.processInfo.processName containsString:@"Electron"]) ||
+                     (NSProcessInfo.processInfo.environment[@"ELECTRON_RUN_AS_NODE"] != nil);
+    
+    if (!isElectron && isAVFoundationRecording()) {
         isRecording = true;
     }
     

package/test-macos14.js

@@ -0,0 +1,56 @@
+const MacRecorder = require('./index');
+
+async function testMacOS14Recording() {
+  const recorder = new MacRecorder();
+  
+  console.log('🧪 macOS 14 Recording Test');
+  console.log('This will test AVFoundation fallback path when ScreenCaptureKit fails or is not available');
+  console.log('');
+  
+  try {
+    const outputPath = './test-output/macos14-test.mov';
+    
+    console.log('📹 Starting recording test...');
+    console.log('Expected behavior on macOS 14:');
+    console.log('  1. System detects macOS 14.x');
+    console.log('  2. Skips ScreenCaptureKit (only for macOS 15+)');
+    console.log('  3. Uses AVFoundation fallback');
+    console.log('  4. Records at 15fps with H.264 encoding');
+    console.log('');
+    
+    const success = await recorder.startRecording(outputPath, {
+      captureCursor: true,
+      includeMicrophone: false,
+      includeSystemAudio: true,
+      displayId: null // Use main display
+    });
+    
+    if (success) {
+      console.log('✅ Recording started successfully');
+      console.log('⏱️ Recording for 3 seconds...');
+      
+      await new Promise(resolve => setTimeout(resolve, 3000));
+      
+      console.log('🛑 Stopping recording...');
+      await recorder.stopRecording();
+      
+      console.log('✅ macOS 14 test completed successfully!');
+      console.log('📁 Output file: ' + outputPath);
+    } else {
+      console.log('❌ Recording failed to start');
+      console.log('');
+      console.log('Troubleshooting steps:');
+      console.log('1. Check Screen Recording permission in System Preferences');
+      console.log('2. Ensure macOS version is 14.0 or later');
+      console.log('3. Check console logs for detailed error messages');
+    }
+  } catch (error) {
+    console.log('❌ Error during test:', error.message);
+    if (error.stack) {
+      console.log('Stack trace:', error.stack);
+    }
+  }
+}
+
+// Run the test
+testMacOS14Recording();