node-mac-recorder 2.16.0 → 2.16.1

package/.claude/settings.local.json

@@ -43,7 +43,8 @@
       "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🎵 Testing both microphone and system audio'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testBothAudio() {\n  try {\n    const outputPath = ''./test-output/both-audio-test.mov'';\n    console.log(''📹 Starting recording with both audio sources...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: true,   // Mikrophone AÇIK\n      includeSystemAudio: true   // Sistem sesi AÇIK\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 5 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 5000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Both audio test completed!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n    console.log(''Stack:'', error.stack);\n  }\n}\n\ntestBothAudio();\n\")",
       "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🎤 Testing microphone only'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testMicrophoneOnly() {\n  try {\n    const outputPath = ''./test-output/microphone-only-test.mov'';\n    console.log(''📹 Starting microphone only recording...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: false,\n      includeMicrophone: true,   // Sadece mikrofon AÇIK\n      includeSystemAudio: false  // Sistem sesi KAPALI\n    });\n    \n    if (success) {\n      console.log(''✅ Microphone recording started - waiting 3 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      console.log(''🛑 Stopping microphone recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Microphone only test completed!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestMicrophoneOnly();\n\")",
       "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🚀 Full stress test - All features + Both audio sources'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function fullStressTest() {\n  try {\n    const outputPath = ''./test-output/full-stress-test.mov'';\n    console.log(''📹 Starting full featured recording (stress test)...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,       // Cursor kayıt\n      includeMicrophone: true,   // Mikrofon kayıt\n      includeSystemAudio: true,  // Sistem sesi kayıt\n      captureArea: {             // Crop area\n        x: 300,\n        y: 300,\n        width: 800,\n        height: 500\n      }\n    });\n    \n    if (success) {\n      console.log(''✅ Full stress test started - waiting 6 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 6000));\n      \n      console.log(''🛑 Stopping full stress test...'');\n      await recorder.stopRecording();\n      console.log(''🎉 FULL STRESS TEST COMPLETED WITHOUT CRASH!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n    console.log(''Stack:'', error.stack);\n  }\n}\n\nfullStressTest();\n\")",
-      "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🧪 Testing version detection and fallback system'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testVersionDetection() {\n  try {\n    const outputPath = ''./test-output/version-detection-test.mov'';\n    console.log(''📹 Starting recording with version detection...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 3 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Version detection test completed successfully!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestVersionDetection();\n\")"
+      "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🧪 Testing version detection and fallback system'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testVersionDetection() {\n  try {\n    const outputPath = ''./test-output/version-detection-test.mov'';\n    console.log(''📹 Starting recording with version detection...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 3 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Version detection test completed successfully!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestVersionDetection();\n\")",
+      "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🧪 Testing Electron safety measures'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testElectronSafety() {\n  try {\n    const outputPath = ''./test-output/electron-safe-test.mov'';\n    console.log(''📹 Starting recording in Electron environment...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started safely in Electron - waiting 3 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Electron safety test completed successfully!'');\n    } else {\n      console.log(''⚠️ Recording failed to start (expected in some cases)'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestElectronSafety();\n\")"
     ],
     "deny": []
   }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.16.0",
+	"version": "2.16.1",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/mac_recorder.mm

@@ -51,8 +51,14 @@ void cleanupRecording() {
         }
     }
     
-    // AVFoundation cleanup
-    if (isAVFoundationRecording()) {
+    // AVFoundation cleanup (only in non-Electron environments)
+    BOOL isElectron = (NSBundle.mainBundle.bundleIdentifier && 
+                      [NSBundle.mainBundle.bundleIdentifier containsString:@"electron"]) ||
+                     (NSProcessInfo.processInfo.processName && 
+                      [NSProcessInfo.processInfo.processName containsString:@"Electron"]) ||
+                     (NSProcessInfo.processInfo.environment[@"ELECTRON_RUN_AS_NODE"] != nil);
+    
+    if (!isElectron && isAVFoundationRecording()) {
         stopAVFoundationRecording();
     }
     
@@ -274,7 +280,14 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
             return Napi::Boolean::New(env, false);
         }
         
-        // If we get here, ScreenCaptureKit failed - try AVFoundation fallback
+        // If we get here, ScreenCaptureKit failed
+        if (isElectron) {
+            NSLog(@"❌ ScreenCaptureKit failed in Electron - AVFoundation disabled for stability");
+            NSLog(@"❌ Recording not available in Electron when ScreenCaptureKit fails");
+            return Napi::Boolean::New(env, false);
+        }
+        
+        // Try AVFoundation fallback (only in non-Electron environments)
         NSLog(@"🔄 ScreenCaptureKit failed - attempting AVFoundation fallback");
         
         @try {
@@ -327,24 +340,32 @@ Napi::Value StopRecording(const Napi::CallbackInfo& info) {
         }
     }
     
-    // Try AVFoundation fallback
-    extern bool isAVFoundationRecording();
-    extern bool stopAVFoundationRecording();
+    // Try AVFoundation fallback (only in non-Electron environments)
+    BOOL isElectron = (NSBundle.mainBundle.bundleIdentifier && 
+                      [NSBundle.mainBundle.bundleIdentifier containsString:@"electron"]) ||
+                     (NSProcessInfo.processInfo.processName && 
+                      [NSProcessInfo.processInfo.processName containsString:@"Electron"]) ||
+                     (NSProcessInfo.processInfo.environment[@"ELECTRON_RUN_AS_NODE"] != nil);
     
-    @try {
-        if (isAVFoundationRecording()) {
-            NSLog(@"🛑 Stopping AVFoundation recording");
-            if (stopAVFoundationRecording()) {
-                g_isRecording = false;
-                return Napi::Boolean::New(env, true);
-            } else {
-                NSLog(@"❌ Failed to stop AVFoundation recording");
-                g_isRecording = false;
-                return Napi::Boolean::New(env, false);
+    if (!isElectron) {
+        extern bool isAVFoundationRecording();
+        extern bool stopAVFoundationRecording();
+        
+        @try {
+            if (isAVFoundationRecording()) {
+                NSLog(@"🛑 Stopping AVFoundation recording");
+                if (stopAVFoundationRecording()) {
+                    g_isRecording = false;
+                    return Napi::Boolean::New(env, true);
+                } else {
+                    NSLog(@"❌ Failed to stop AVFoundation recording");
+                    g_isRecording = false;
+                    return Napi::Boolean::New(env, false);
+                }
             }
+        } @catch (NSException *exception) {
+            NSLog(@"❌ Exception stopping AVFoundation: %@", exception.reason);
         }
-    } @catch (NSException *exception) {
-        NSLog(@"❌ Exception stopping AVFoundation: %@", exception.reason);
     }
     
     NSLog(@"⚠️ No active recording found to stop");
@@ -606,7 +627,7 @@ Napi::Value GetDisplays(const Napi::CallbackInfo& info) {
 Napi::Value GetRecordingStatus(const Napi::CallbackInfo& info) {
     Napi::Env env = info.Env();
     
-    // Check both recording methods
+    // Check recording methods
     bool isRecording = g_isRecording;
     
     if (@available(macOS 12.3, *)) {
@@ -615,7 +636,14 @@ Napi::Value GetRecordingStatus(const Napi::CallbackInfo& info) {
         }
     }
     
-    if (isAVFoundationRecording()) {
+    // Check AVFoundation only in non-Electron environments
+    BOOL isElectron = (NSBundle.mainBundle.bundleIdentifier && 
+                      [NSBundle.mainBundle.bundleIdentifier containsString:@"electron"]) ||
+                     (NSProcessInfo.processInfo.processName && 
+                      [NSProcessInfo.processInfo.processName containsString:@"Electron"]) ||
+                     (NSProcessInfo.processInfo.environment[@"ELECTRON_RUN_AS_NODE"] != nil);
+    
+    if (!isElectron && isAVFoundationRecording()) {
         isRecording = true;
     }