node-mac-recorder 2.15.7 → 2.15.8

package/.claude/settings.local.json

@@ -39,7 +39,10 @@
       "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🧪 Testing crash fix with null path protection'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testCrashFix() {\n  try {\n    const outputPath = ''./test-output/crash-fix-test.mov'';\n    console.log(''📹 Starting crash fix test...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: true,\n      includeSystemAudio: true,\n      captureArea: {\n        x: 100,\n        y: 100,\n        width: 800,\n        height: 600\n      }\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 3 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Crash fix test completed successfully!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n    console.log(''Stack:'', error.stack);\n  }\n}\n\ntestCrashFix();\n\")",
       "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🏁 Final stability test with all features'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function finalTest() {\n  try {\n    const outputPath = ''./test-output/final-stability-test.mov'';\n    console.log(''📹 Starting final stability test...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: true,\n      includeSystemAudio: true,\n      captureArea: {\n        x: 200,\n        y: 200,\n        width: 600,\n        height: 400\n      }\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 4 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 4000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''🎉 FINAL TEST COMPLETED SUCCESSFULLY - NO CRASH!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\nfinalTest();\n\")",
       "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🎵 Testing system audio only recording'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testSystemAudio() {\n  try {\n    const outputPath = ''./test-output/system-audio-only.mov'';\n    console.log(''📹 Starting system audio only recording...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: false,\n      includeMicrophone: false,  // Mikrophone DEVRE DIŞI  \n      includeSystemAudio: true,  // Sadece sistem sesi AÇIK\n    });\n    \n    if (success) {\n      console.log(''✅ System audio recording started - waiting 4 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 4000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ System audio test completed!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestSystemAudio();\n\")",
-      "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🏁 Final stability test with all features'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function finalTest() {\n  try {\n    const outputPath = ''./test-output/final-stability-test.mov'';\n    console.log(''📹 Starting final stability test...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true,\n      captureArea: {\n        x: 200,\n        y: 200,\n        width: 600,\n        height: 400\n      }\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 4 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 4000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''🎉 FINAL TEST COMPLETED SUCCESSFULLY - NO CRASH!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\nfinalTest();\n\")"
+      "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🏁 Final stability test with all features'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function finalTest() {\n  try {\n    const outputPath = ''./test-output/final-stability-test.mov'';\n    console.log(''📹 Starting final stability test...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true,\n      captureArea: {\n        x: 200,\n        y: 200,\n        width: 600,\n        height: 400\n      }\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 4 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 4000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''🎉 FINAL TEST COMPLETED SUCCESSFULLY - NO CRASH!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\nfinalTest();\n\")",
+      "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🎵 Testing both microphone and system audio'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testBothAudio() {\n  try {\n    const outputPath = ''./test-output/both-audio-test.mov'';\n    console.log(''📹 Starting recording with both audio sources...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: true,   // Mikrophone AÇIK\n      includeSystemAudio: true   // Sistem sesi AÇIK\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 5 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 5000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Both audio test completed!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n    console.log(''Stack:'', error.stack);\n  }\n}\n\ntestBothAudio();\n\")",
+      "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🎤 Testing microphone only'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testMicrophoneOnly() {\n  try {\n    const outputPath = ''./test-output/microphone-only-test.mov'';\n    console.log(''📹 Starting microphone only recording...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: false,\n      includeMicrophone: true,   // Sadece mikrofon AÇIK\n      includeSystemAudio: false  // Sistem sesi KAPALI\n    });\n    \n    if (success) {\n      console.log(''✅ Microphone recording started - waiting 3 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      console.log(''🛑 Stopping microphone recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Microphone only test completed!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestMicrophoneOnly();\n\")",
+      "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🚀 Full stress test - All features + Both audio sources'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function fullStressTest() {\n  try {\n    const outputPath = ''./test-output/full-stress-test.mov'';\n    console.log(''📹 Starting full featured recording (stress test)...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,       // Cursor kayıt\n      includeMicrophone: true,   // Mikrofon kayıt\n      includeSystemAudio: true,  // Sistem sesi kayıt\n      captureArea: {             // Crop area\n        x: 300,\n        y: 300,\n        width: 800,\n        height: 500\n      }\n    });\n    \n    if (success) {\n      console.log(''✅ Full stress test started - waiting 6 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 6000));\n      \n      console.log(''🛑 Stopping full stress test...'');\n      await recorder.stopRecording();\n      console.log(''🎉 FULL STRESS TEST COMPLETED WITHOUT CRASH!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n    console.log(''Stack:'', error.stack);\n  }\n}\n\nfullStressTest();\n\")"
     ],
     "deny": []
   }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.15.7",
+	"version": "2.15.8",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/screen_capture_kit.mm

@@ -187,20 +187,24 @@ static NSString *g_outputPath = nil;
         NSLog(@"🎥 Pure ScreenCapture config: %ldx%ld @ 30fps, cursor=%d", 
               recordingWidth, recordingHeight, shouldShowCursor);
         
-        // AUDIO SUPPORT - Enable only for system audio in Electron
+        // AUDIO SUPPORT - Enable both microphone and system audio
         BOOL shouldCaptureMic = includeMicrophone ? [includeMicrophone boolValue] : NO;
         BOOL shouldCaptureSystemAudio = includeSystemAudio ? [includeSystemAudio boolValue] : NO;
         
-        // Only enable system audio, mic causes crashes in Electron
+        // Enable audio if either microphone or system audio is requested
         if (@available(macOS 13.0, *)) {
-            if (shouldCaptureSystemAudio && !shouldCaptureMic) {
+            if (shouldCaptureMic || shouldCaptureSystemAudio) {
                 streamConfig.capturesAudio = YES;
                 streamConfig.sampleRate = 44100;
                 streamConfig.channelCount = 2;
-                NSLog(@"🎵 System audio only enabled (safe for Electron)");
-            } else if (shouldCaptureMic) {
-                NSLog(@"🚫 Microphone audio disabled in Electron for stability");
-                streamConfig.capturesAudio = NO;
+                
+                if (shouldCaptureMic && shouldCaptureSystemAudio) {
+                    NSLog(@"🎵 Both microphone and system audio enabled");
+                } else if (shouldCaptureMic) {
+                    NSLog(@"🎤 Microphone audio enabled");
+                } else {
+                    NSLog(@"🔊 System audio enabled");
+                }
             } else {
                 streamConfig.capturesAudio = NO;
                 NSLog(@"🔇 Audio disabled");
@@ -236,8 +240,12 @@ static NSString *g_outputPath = nil;
             // Create recording output with correct initializer
             g_recordingOutput = [[SCRecordingOutput alloc] initWithConfiguration:recordingConfig 
                                                                         delegate:nil];
-            if (shouldCaptureSystemAudio && !shouldCaptureMic) {
-                NSLog(@"🔧 Created SCRecordingOutput with system audio only");
+            if (shouldCaptureMic && shouldCaptureSystemAudio) {
+                NSLog(@"🔧 Created SCRecordingOutput with microphone and system audio");
+            } else if (shouldCaptureMic) {
+                NSLog(@"🔧 Created SCRecordingOutput with microphone audio");
+            } else if (shouldCaptureSystemAudio) {
+                NSLog(@"🔧 Created SCRecordingOutput with system audio");
             } else {
                 NSLog(@"🔧 Created SCRecordingOutput (audio disabled)");
             }