node-mac-recorder 2.15.5 → 2.15.7

package/.claude/settings.local.json

@@ -35,7 +35,11 @@
       "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🔍 Testing with proper permissions and Electron env'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function test() {\n  try {\n    const outputPath = ''./test-output/crash-test.mov'';\n    console.log(''📹 Starting recording...'');\n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: false\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 3 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Test completed without crash'');\n    } else {\n      console.log(''❌ Recording start failed'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n    console.log(''Stack:'', error.stack);\n  }\n}\n\ntest();\n\")",
       "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🔍 Debugging frame writing...'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function debugFrameWriting() {\n  try {\n    const outputPath = ''./test-output/frame-debug.mov'';\n    console.log(''📹 Starting debug test...'');\n    \n    const success = await recorder.startRecording(outputPath);\n    \n    if (success) {\n      console.log(''⏱️ Recording for 2 seconds...'');\n      await new Promise(resolve => setTimeout(resolve, 2000));\n      \n      console.log(''🛑 Stopping...'');\n      await recorder.stopRecording();\n      \n      // Wait for finalization\n      await new Promise(resolve => setTimeout(resolve, 1000));\n      \n    } else {\n      console.log(''❌ Failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error);\n  }\n}\n\ndebugFrameWriting();\n\")",
       "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🧪 Testing without AVFoundation - Pure ScreenCaptureKit'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testPureScreenCaptureKit() {\n  try {\n    const outputPath = ''./test-output/pure-sck.mov'';\n    console.log(''📹 Starting pure ScreenCaptureKit test...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: false\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 2 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 2000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Pure ScreenCaptureKit test completed successfully!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n    console.log(''Stack:'', error.stack);\n  }\n}\n\ntestPureScreenCaptureKit();\n\")",
-      "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🎵 Testing audio + crop area recording'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testAudioCropRecording() {\n  try {\n    const outputPath = ''./test-output/audio-crop-test.mov'';\n    console.log(''📹 Starting recording with audio and crop area...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: false,\n      includeMicrophone: true,\n      includeSystemAudio: true,\n      captureArea: {\n        x: 100, \n        y: 100,\n        width: 800,\n        height: 600\n      }\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 3 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Audio + crop test completed successfully!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestAudioCropRecording();\n\")"
+      "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🎵 Testing audio + crop area recording'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testAudioCropRecording() {\n  try {\n    const outputPath = ''./test-output/audio-crop-test.mov'';\n    console.log(''📹 Starting recording with audio and crop area...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: false,\n      includeMicrophone: true,\n      includeSystemAudio: true,\n      captureArea: {\n        x: 100, \n        y: 100,\n        width: 800,\n        height: 600\n      }\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 3 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Audio + crop test completed successfully!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestAudioCropRecording();\n\")",
+      "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🧪 Testing crash fix with null path protection'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testCrashFix() {\n  try {\n    const outputPath = ''./test-output/crash-fix-test.mov'';\n    console.log(''📹 Starting crash fix test...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: true,\n      includeSystemAudio: true,\n      captureArea: {\n        x: 100,\n        y: 100,\n        width: 800,\n        height: 600\n      }\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 3 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Crash fix test completed successfully!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n    console.log(''Stack:'', error.stack);\n  }\n}\n\ntestCrashFix();\n\")",
+      "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🏁 Final stability test with all features'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function finalTest() {\n  try {\n    const outputPath = ''./test-output/final-stability-test.mov'';\n    console.log(''📹 Starting final stability test...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: true,\n      includeSystemAudio: true,\n      captureArea: {\n        x: 200,\n        y: 200,\n        width: 600,\n        height: 400\n      }\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 4 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 4000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''🎉 FINAL TEST COMPLETED SUCCESSFULLY - NO CRASH!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\nfinalTest();\n\")",
+      "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🎵 Testing system audio only recording'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testSystemAudio() {\n  try {\n    const outputPath = ''./test-output/system-audio-only.mov'';\n    console.log(''📹 Starting system audio only recording...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: false,\n      includeMicrophone: false,  // Mikrophone DEVRE DIŞI  \n      includeSystemAudio: true,  // Sadece sistem sesi AÇIK\n    });\n    \n    if (success) {\n      console.log(''✅ System audio recording started - waiting 4 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 4000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ System audio test completed!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestSystemAudio();\n\")",
+      "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🏁 Final stability test with all features'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function finalTest() {\n  try {\n    const outputPath = ''./test-output/final-stability-test.mov'';\n    console.log(''📹 Starting final stability test...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: true,\n      captureArea: {\n        x: 200,\n        y: 200,\n        width: 600,\n        height: 400\n      }\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 4 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 4000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''🎉 FINAL TEST COMPLETED SUCCESSFULLY - NO CRASH!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\nfinalTest();\n\")"
     ],
     "deny": []
   }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.15.5",
+	"version": "2.15.7",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/screen_capture_kit.mm

@@ -58,7 +58,12 @@ static NSString *g_outputPath = nil;
         g_isCleaningUp = NO;
     }
     
-    g_outputPath = config[@"outputPath"];
+    NSString *outputPath = config[@"outputPath"];
+    if (!outputPath || [outputPath length] == 0) {
+        NSLog(@"❌ Invalid output path provided");
+        return NO;
+    }
+    g_outputPath = outputPath;
     
     // Extract configuration options
     NSNumber *displayId = config[@"displayId"];
@@ -182,24 +187,60 @@ static NSString *g_outputPath = nil;
         NSLog(@"🎥 Pure ScreenCapture config: %ldx%ld @ 30fps, cursor=%d", 
               recordingWidth, recordingHeight, shouldShowCursor);
         
-        // AUDIO SUPPORT - Disabled for Electron stability
-        NSLog(@"🔇 Audio capture disabled for Electron compatibility");
-        streamConfig.capturesAudio = NO;
+        // AUDIO SUPPORT - Enable only for system audio in Electron
+        BOOL shouldCaptureMic = includeMicrophone ? [includeMicrophone boolValue] : NO;
+        BOOL shouldCaptureSystemAudio = includeSystemAudio ? [includeSystemAudio boolValue] : NO;
+        
+        // Only enable system audio, mic causes crashes in Electron
+        if (@available(macOS 13.0, *)) {
+            if (shouldCaptureSystemAudio && !shouldCaptureMic) {
+                streamConfig.capturesAudio = YES;
+                streamConfig.sampleRate = 44100;
+                streamConfig.channelCount = 2;
+                NSLog(@"🎵 System audio only enabled (safe for Electron)");
+            } else if (shouldCaptureMic) {
+                NSLog(@"🚫 Microphone audio disabled in Electron for stability");
+                streamConfig.capturesAudio = NO;
+            } else {
+                streamConfig.capturesAudio = NO;
+                NSLog(@"🔇 Audio disabled");
+            }
+        } else {
+            streamConfig.capturesAudio = NO;
+            NSLog(@"🔇 Audio disabled (macOS < 13.0)");
+        }
         
         // Create pure ScreenCaptureKit recording output
-        NSURL *outputURL = [NSURL fileURLWithPath:g_outputPath];
+        // Use local copy to prevent race conditions
+        NSString *safeOutputPath = outputPath;  // Local variable from outer scope
+        if (!safeOutputPath || [safeOutputPath length] == 0) {
+            NSLog(@"❌ Output path is nil or empty");
+            return;
+        }
+        
+        NSURL *outputURL = [NSURL fileURLWithPath:safeOutputPath];
+        if (!outputURL) {
+            NSLog(@"❌ Failed to create output URL from path: %@", safeOutputPath);
+            return;
+        }
+        
         if (@available(macOS 15.0, *)) {
             // Create recording output configuration
             SCRecordingOutputConfiguration *recordingConfig = [[SCRecordingOutputConfiguration alloc] init];
             recordingConfig.outputURL = outputURL;
             recordingConfig.videoCodecType = AVVideoCodecTypeH264;
             
-            // Audio disabled for Electron stability
+            // Audio configuration - using available properties
+            // Note: Specific audio routing handled by ScreenCaptureKit automatically
             
             // Create recording output with correct initializer
             g_recordingOutput = [[SCRecordingOutput alloc] initWithConfiguration:recordingConfig 
                                                                         delegate:nil];
-            NSLog(@"🔧 Created SCRecordingOutput (audio disabled for Electron)");
+            if (shouldCaptureSystemAudio && !shouldCaptureMic) {
+                NSLog(@"🔧 Created SCRecordingOutput with system audio only");
+            } else {
+                NSLog(@"🔧 Created SCRecordingOutput (audio disabled)");
+            }
         }
         
         if (!g_recordingOutput) {