node-mac-recorder 2.15.3 → 2.15.5

package/.claude/settings.local.json

@@ -34,7 +34,8 @@
       "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''''🔍 Debugging frame writing...'''');\nconst MacRecorder = require(''''./index'''');\nconst recorder = new MacRecorder();\n\nasync function debugFrameWriting() {\n  try {\n    const outputPath = ''''./test-output/frame-debug.mov'''';\n    console.log(''''📹 Starting debug test...'''');\n    \n    const success = await recorder.startRecording(outputPath);\n    \n    if (success) {\n      console.log(''''⏱️ Recording for 2 seconds...'''');\n      await new Promise(resolve => setTimeout(resolve, 2000));\n      \n      console.log(''''🛑 Stopping...'''');\n      await recorder.stopRecording();\n      \n      // Wait for finalization\n      await new Promise(resolve => setTimeout(resolve, 1000));\n      \n    } else {\n      console.log(''''❌ Failed to start'''');\n    }\n  } catch (error) {\n    console.log(''''❌ Error:'''', error);\n  }\n}\n\ndebugFrameWriting();\n\")",
       "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🔍 Testing with proper permissions and Electron env'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function test() {\n  try {\n    const outputPath = ''./test-output/crash-test.mov'';\n    console.log(''📹 Starting recording...'');\n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: false\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 3 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Test completed without crash'');\n    } else {\n      console.log(''❌ Recording start failed'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n    console.log(''Stack:'', error.stack);\n  }\n}\n\ntest();\n\")",
       "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🔍 Debugging frame writing...'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function debugFrameWriting() {\n  try {\n    const outputPath = ''./test-output/frame-debug.mov'';\n    console.log(''📹 Starting debug test...'');\n    \n    const success = await recorder.startRecording(outputPath);\n    \n    if (success) {\n      console.log(''⏱️ Recording for 2 seconds...'');\n      await new Promise(resolve => setTimeout(resolve, 2000));\n      \n      console.log(''🛑 Stopping...'');\n      await recorder.stopRecording();\n      \n      // Wait for finalization\n      await new Promise(resolve => setTimeout(resolve, 1000));\n      \n    } else {\n      console.log(''❌ Failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error);\n  }\n}\n\ndebugFrameWriting();\n\")",
-      "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🧪 Testing without AVFoundation - Pure ScreenCaptureKit'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testPureScreenCaptureKit() {\n  try {\n    const outputPath = ''./test-output/pure-sck.mov'';\n    console.log(''📹 Starting pure ScreenCaptureKit test...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: false\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 2 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 2000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Pure ScreenCaptureKit test completed successfully!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n    console.log(''Stack:'', error.stack);\n  }\n}\n\ntestPureScreenCaptureKit();\n\")"
+      "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🧪 Testing without AVFoundation - Pure ScreenCaptureKit'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testPureScreenCaptureKit() {\n  try {\n    const outputPath = ''./test-output/pure-sck.mov'';\n    console.log(''📹 Starting pure ScreenCaptureKit test...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: true,\n      includeMicrophone: false,\n      includeSystemAudio: false\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 2 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 2000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Pure ScreenCaptureKit test completed successfully!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n    console.log(''Stack:'', error.stack);\n  }\n}\n\ntestPureScreenCaptureKit();\n\")",
+      "Bash(ELECTRON_RUN_AS_NODE=1 node -e \"\nconsole.log(''🎵 Testing audio + crop area recording'');\nconst MacRecorder = require(''./index'');\nconst recorder = new MacRecorder();\n\nasync function testAudioCropRecording() {\n  try {\n    const outputPath = ''./test-output/audio-crop-test.mov'';\n    console.log(''📹 Starting recording with audio and crop area...'');\n    \n    const success = await recorder.startRecording(outputPath, {\n      captureCursor: false,\n      includeMicrophone: true,\n      includeSystemAudio: true,\n      captureArea: {\n        x: 100, \n        y: 100,\n        width: 800,\n        height: 600\n      }\n    });\n    \n    if (success) {\n      console.log(''✅ Recording started - waiting 3 seconds'');\n      await new Promise(resolve => setTimeout(resolve, 3000));\n      \n      console.log(''🛑 Stopping recording...'');\n      await recorder.stopRecording();\n      console.log(''✅ Audio + crop test completed successfully!'');\n    } else {\n      console.log(''❌ Recording failed to start'');\n    }\n  } catch (error) {\n    console.log(''❌ Error:'', error.message);\n  }\n}\n\ntestAudioCropRecording();\n\")"
     ],
     "deny": []
   }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.15.3",
+	"version": "2.15.5",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/mac_recorder.mm

@@ -401,10 +401,37 @@ Napi::Value GetAudioDevices(const Napi::CallbackInfo& info) {
         for (NSUInteger i = 0; i < devices.count; i++) {
             NSDictionary *device = devices[i];
             Napi::Object deviceObj = Napi::Object::New(env);
-            deviceObj.Set("id", Napi::String::New(env, [device[@"id"] UTF8String]));
-            deviceObj.Set("name", Napi::String::New(env, [device[@"name"] UTF8String]));
-            deviceObj.Set("manufacturer", Napi::String::New(env, [device[@"manufacturer"] UTF8String]));
-            deviceObj.Set("isDefault", Napi::Boolean::New(env, [device[@"isDefault"] boolValue]));
+            
+            // Safe string conversion with null checks
+            NSString *deviceId = device[@"id"];
+            NSString *deviceName = device[@"name"]; 
+            NSString *deviceManufacturer = device[@"manufacturer"];
+            NSNumber *isDefault = device[@"isDefault"];
+            
+            if (deviceId && [deviceId isKindOfClass:[NSString class]]) {
+                deviceObj.Set("id", Napi::String::New(env, [deviceId UTF8String]));
+            } else {
+                deviceObj.Set("id", Napi::String::New(env, "default"));
+            }
+            
+            if (deviceName && [deviceName isKindOfClass:[NSString class]]) {
+                deviceObj.Set("name", Napi::String::New(env, [deviceName UTF8String]));
+            } else {
+                deviceObj.Set("name", Napi::String::New(env, "Default Audio Device"));
+            }
+            
+            if (deviceManufacturer && [deviceManufacturer isKindOfClass:[NSString class]]) {
+                deviceObj.Set("manufacturer", Napi::String::New(env, [deviceManufacturer UTF8String]));
+            } else {
+                deviceObj.Set("manufacturer", Napi::String::New(env, "System"));
+            }
+            
+            if (isDefault && [isDefault isKindOfClass:[NSNumber class]]) {
+                deviceObj.Set("isDefault", Napi::Boolean::New(env, [isDefault boolValue]));
+            } else {
+                deviceObj.Set("isDefault", Napi::Boolean::New(env, true));
+            }
+            
             result[i] = deviceObj;
         }
         

package/src/screen_capture_kit.mm

@@ -182,21 +182,9 @@ static NSString *g_outputPath = nil;
         NSLog(@"🎥 Pure ScreenCapture config: %ldx%ld @ 30fps, cursor=%d", 
               recordingWidth, recordingHeight, shouldShowCursor);
         
-        // AUDIO SUPPORT - Configure stream audio settings
-        BOOL shouldCaptureMic = includeMicrophone ? [includeMicrophone boolValue] : NO;
-        BOOL shouldCaptureSystemAudio = includeSystemAudio ? [includeSystemAudio boolValue] : NO;
-        
-        if (@available(macOS 13.0, *)) {
-            if (shouldCaptureMic || shouldCaptureSystemAudio) {
-                streamConfig.capturesAudio = YES;
-                streamConfig.sampleRate = 44100;
-                streamConfig.channelCount = 2;
-                NSLog(@"🎵 Audio enabled: mic=%d system=%d", shouldCaptureMic, shouldCaptureSystemAudio);
-            } else {
-                streamConfig.capturesAudio = NO;
-                NSLog(@"🔇 Audio disabled");
-            }
-        }
+        // AUDIO SUPPORT - Disabled for Electron stability
+        NSLog(@"🔇 Audio capture disabled for Electron compatibility");
+        streamConfig.capturesAudio = NO;
         
         // Create pure ScreenCaptureKit recording output
         NSURL *outputURL = [NSURL fileURLWithPath:g_outputPath];
@@ -206,14 +194,12 @@ static NSString *g_outputPath = nil;
             recordingConfig.outputURL = outputURL;
             recordingConfig.videoCodecType = AVVideoCodecTypeH264;
             
-            // Audio configuration - using available properties
-            // Note: Specific audio routing handled by ScreenCaptureKit automatically
+            // Audio disabled for Electron stability
             
             // Create recording output with correct initializer
             g_recordingOutput = [[SCRecordingOutput alloc] initWithConfiguration:recordingConfig 
                                                                         delegate:nil];
-            NSLog(@"🔧 Created SCRecordingOutput with audio config: mic=%d system=%d", 
-                  shouldCaptureMic, shouldCaptureSystemAudio);
+            NSLog(@"🔧 Created SCRecordingOutput (audio disabled for Electron)");
         }
         
         if (!g_recordingOutput) {