node-mac-recorder 2.15.11 → 2.15.12

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.15.11",
+	"version": "2.15.12",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/mac_recorder.mm

@@ -168,9 +168,14 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
         if (@available(macOS 12.3, *)) {
             NSLog(@"✅ macOS 12.3+ detected - ScreenCaptureKit should be available");
             
-            // Try ScreenCaptureKit with extensive safety measures
+            // Check if running in Electron environment
+            BOOL isElectron = (getenv("ELECTRON_RUN_AS_NODE") != NULL || 
+                              [[NSProcessInfo processInfo].processName containsString:@"Electron"] ||
+                              [[NSBundle mainBundle].bundleIdentifier containsString:@"electron"]);
+            
+            // Try ScreenCaptureKit with extensive safety measures (skip in Electron due to compatibility issues)
             @try {
-                if ([ScreenCaptureKitRecorder isScreenCaptureKitAvailable]) {
+                if (!isElectron && [ScreenCaptureKitRecorder isScreenCaptureKitAvailable]) {
                     NSLog(@"✅ ScreenCaptureKit availability check passed");
                     NSLog(@"🎯 Using ScreenCaptureKit - overlay windows will be automatically excluded");
                     
@@ -229,22 +234,25 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
                     }
                     
                     NSLog(@"❌ ScreenCaptureKit failed or unsafe");
-                    
+                    // Fall through to AVFoundation
                 } else {
-                    NSLog(@"❌ ScreenCaptureKit availability check failed");
-                    NSLog(@"❌ ScreenCaptureKit not available");
+                    NSLog(@"❌ ScreenCaptureKit not available - falling back to AVFoundation");
                 }
             } @catch (NSException *availabilityException) {
-                NSLog(@"❌ Exception during ScreenCaptureKit availability check: %@", availabilityException.reason);
-                return Napi::Boolean::New(env, false);
+                NSLog(@"⚠️ Exception during ScreenCaptureKit check: %@", availabilityException.reason);
+                if (isElectron) {
+                    NSLog(@"🔄 Expected in Electron - using AVFoundation fallback");
+                } else {
+                    NSLog(@"🔄 Falling back to AVFoundation");
+                }
             }
         } else {
-            NSLog(@"❌ macOS version too old for ScreenCaptureKit (< 12.3) - Recording not supported");
-            return Napi::Boolean::New(env, false);
+            NSLog(@"⚠️ macOS version < 12.3 - ScreenCaptureKit not available, falling back to AVFoundation");
         }
         
-        // If we get here, ScreenCaptureKit failed completely
-        NSLog(@"❌ ScreenCaptureKit failed to initialize - Recording not available");
+        // If we get here, ScreenCaptureKit failed - use AVFoundation fallback
+        NSLog(@"🔄 ScreenCaptureKit failed - using AVFoundation fallback");
+        NSLog(@"❌ AVFoundation recording not implemented in this version");
         return Napi::Boolean::New(env, false);
         
     } @catch (NSException *exception) {

package/src/screen_capture_kit.mm

@@ -121,15 +121,25 @@ static NSString *g_outputPath = nil;
             
             if (displayId && [displayId integerValue] != 0) {
                 // Find specific display
+                NSLog(@"🔍 Looking for display ID: %@", displayId);
+                NSLog(@"📋 Available displays:");
                 for (SCDisplay *display in content.displays) {
+                    NSLog(@"  - Display %u: %dx%d", display.displayID, (int)display.width, (int)display.height);
                     if (display.displayID == [displayId unsignedIntValue]) {
                         targetDisplay = display;
+                        NSLog(@"✅ Found matching display %u", display.displayID);
                         break;
                     }
                 }
+                
+                if (!targetDisplay) {
+                    NSLog(@"❌ Display ID %@ not found in ScreenCaptureKit displays", displayId);
+                    NSLog(@"🔧 Available IDs: %@", [content.displays valueForKey:@"displayID"]);
+                }
             } else {
                 // Use first display
                 targetDisplay = content.displays.firstObject;
+                NSLog(@"📺 Using first available display: %u", targetDisplay.displayID);
             }
             
             if (!targetDisplay) {

package/test-display-id-debug.js

@@ -0,0 +1,42 @@
+const MacRecorder = require('./index');
+
+async function testDisplayIdDebug() {
+    console.log('🔍 Testing display ID debugging...');
+    
+    const recorder = new MacRecorder();
+    const displays = await recorder.getDisplays();
+    
+    console.log('📊 JavaScript display IDs:');
+    displays.forEach(display => {
+        console.log(`  ${display.name}: ID=${display.id} ${display.isPrimary ? '[PRIMARY]' : ''}`);
+    });
+    
+    // Test recording on secondary display to trigger the debug logs
+    const secondaryDisplay = displays.find(d => !d.isPrimary);
+    if (secondaryDisplay) {
+        console.log(`\n🎯 Testing recording on ${secondaryDisplay.name} (ID: ${secondaryDisplay.id})`);
+        
+        try {
+            await recorder.startRecording('./test-output/display-id-debug.mov', {
+                displayId: secondaryDisplay.id,
+                captureCursor: true,
+                includeMicrophone: false,
+                includeSystemAudio: false
+            });
+            
+            console.log('✅ Recording started - check native logs for display ID matching');
+            
+            await new Promise(resolve => setTimeout(resolve, 2000));
+            
+            await recorder.stopRecording();
+            console.log('✅ Recording completed');
+            
+        } catch (error) {
+            console.log(`❌ Recording failed: ${error.message}`);
+        }
+    } else {
+        console.log('⚠️ No secondary display found');
+    }
+}
+
+testDisplayIdDebug();

package/test-electron-env.js

@@ -0,0 +1,38 @@
+const MacRecorder = require('./index');
+
+// Simulate Electron environment
+process.env.ELECTRON_RUN_AS_NODE = '1';
+
+async function testElectronFallback() {
+    console.log('🔋 Testing Electron environment fallback...');
+    console.log('Environment variables:');
+    console.log('  ELECTRON_RUN_AS_NODE:', process.env.ELECTRON_RUN_AS_NODE);
+    
+    const recorder = new MacRecorder();
+    
+    try {
+        console.log('\n🎯 Attempting to start recording in simulated Electron environment...');
+        
+        await recorder.startRecording('./test-output/electron-fallback-test.mov', {
+            displayId: 1,
+            captureCursor: true,
+            includeMicrophone: false,
+            includeSystemAudio: false
+        });
+        
+        console.log('✅ Recording started (unexpected - should have failed)');
+        
+        await new Promise(resolve => setTimeout(resolve, 1000));
+        
+        await recorder.stopRecording();
+        console.log('✅ Recording completed');
+        
+    } catch (error) {
+        console.log(`❌ Recording failed as expected in Electron: ${error.message}`);
+    }
+}
+
+testElectronFallback().finally(() => {
+    // Clean up
+    delete process.env.ELECTRON_RUN_AS_NODE;
+});