node-mac-recorder 2.13.2 → 2.13.4

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.13.2",
+	"version": "2.13.4",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/mac_recorder.mm

@@ -168,9 +168,9 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
     }
     
     @try {
-        // Use stable AVFoundation approach - ScreenCaptureKit disabled until Electron crash resolved
-        NSLog(@"🔍 Using stable AVFoundation approach (ScreenCaptureKit disabled for Electron compatibility)");
-        if (false) { // Disable ScreenCaptureKit completely for now
+        // Phase 4: Pure ScreenCaptureKit with memory-optimized implementation
+        NSLog(@"🔍 Phase 4: Pure ScreenCaptureKit with Electron-safe memory optimization");
+        if (@available(macOS 12.3, *)) {
             NSLog(@"✅ macOS 12.3+ detected - ScreenCaptureKit should be available");
             if ([ScreenCaptureKitRecorder isScreenCaptureKitAvailable]) {
                 NSLog(@"✅ ScreenCaptureKit availability check passed");

package/src/screen_capture_kit.mm

@@ -26,11 +26,13 @@ static BOOL g_writerStarted = NO;
     if (error) {
         NSLog(@"❌ Stream stopped with error: %@", error);
     } else {
-        NSLog(@"✅ ScreenCaptureKit stream stopped successfully");
+        NSLog(@"✅ ScreenCaptureKit stream stopped successfully in delegate");
     }
     
     // Finalize video writer
+    NSLog(@"🎬 Delegate calling finalizeVideoWriter...");
     [ScreenCaptureKitRecorder finalizeVideoWriter];
+    NSLog(@"🎬 Delegate finished calling finalizeVideoWriter");
 }
 @end
 
@@ -55,18 +57,45 @@ static BOOL g_writerStarted = NO;
             NSLog(@"✅ Electron-safe video writer started");
         }
         
-        // Write sample buffer directly (Electron-safe approach)
-        if (g_writerStarted && g_assetWriterInput.isReadyForMoreMediaData) {
-            CVPixelBufferRef pixelBuffer = CMSampleBufferGetImageBuffer(sampleBuffer);
-            if (pixelBuffer && g_pixelBufferAdaptor) {
-                CMTime presentationTime = CMSampleBufferGetPresentationTimeStamp(sampleBuffer);
-                CMTime relativeTime = CMTimeSubtract(presentationTime, g_startTime);
+        // Ultra-conservative Electron-safe sample buffer processing
+        @autoreleasepool {
+            if (!g_writerStarted || !g_assetWriterInput || !g_pixelBufferAdaptor) {
+                return; // Skip if not ready
+            }
+            
+            // Rate limiting for Electron stability
+            static NSTimeInterval lastProcessTime = 0;
+            NSTimeInterval currentTime = [NSDate timeIntervalSinceReferenceDate];
+            if (currentTime - lastProcessTime < 0.1) { // Max 10 FPS for stability
+                return;
+            }
+            lastProcessTime = currentTime;
+            
+            if (g_assetWriterInput.isReadyForMoreMediaData) {
+                CVPixelBufferRef pixelBuffer = CMSampleBufferGetImageBuffer(sampleBuffer);
                 
-                BOOL success = [g_pixelBufferAdaptor appendPixelBuffer:pixelBuffer withPresentationTime:relativeTime];
-                if (success) {
-                    g_currentTime = relativeTime;
-                } else {
-                    NSLog(@"⚠️ Failed to append pixel buffer");
+                if (pixelBuffer && g_pixelBufferAdaptor) {
+                    // Ultra-conservative validation
+                    size_t width = CVPixelBufferGetWidth(pixelBuffer);
+                    size_t height = CVPixelBufferGetHeight(pixelBuffer);
+                    
+                    if (width == 1280 && height == 720) { // Exact match only
+                        CMTime presentationTime = CMSampleBufferGetPresentationTimeStamp(sampleBuffer);
+                        CMTime relativeTime = CMTimeSubtract(presentationTime, g_startTime);
+                        
+                        // Conservative time validation
+                        if (CMTimeGetSeconds(relativeTime) >= 0 && CMTimeGetSeconds(relativeTime) < 30) {
+                            BOOL success = [g_pixelBufferAdaptor appendPixelBuffer:pixelBuffer withPresentationTime:relativeTime];
+                            if (success) {
+                                g_currentTime = relativeTime;
+                                static int safeFrameCount = 0;
+                                safeFrameCount++;
+                                if (safeFrameCount % 10 == 0) {
+                                    NSLog(@"✅ Electron-safe: %d frames", safeFrameCount);
+                                }
+                            }
+                        }
+                    }
                 }
             }
         }
@@ -108,12 +137,14 @@ static BOOL g_writerStarted = NO;
         // Simple content filter - no exclusions for now
         SCContentFilter *filter = [[SCContentFilter alloc] initWithDisplay:targetDisplay excludingWindows:@[]];
         
-        // Stream configuration
+        // Electron-optimized stream configuration (lower resource usage)
         SCStreamConfiguration *streamConfig = [[SCStreamConfiguration alloc] init];
         streamConfig.width = 1280;
         streamConfig.height = 720;
-        streamConfig.minimumFrameInterval = CMTimeMake(1, 30);
+        streamConfig.minimumFrameInterval = CMTimeMake(1, 10); // 10 FPS for stability
         streamConfig.pixelFormat = kCVPixelFormatType_32BGRA;
+        streamConfig.capturesAudio = NO; // Disable audio for simplicity
+        streamConfig.excludesCurrentProcessAudio = YES;
         
         // Create Electron-safe delegates
         g_streamDelegate = [[ElectronSafeDelegate alloc] init];
@@ -153,7 +184,11 @@ static BOOL g_writerStarted = NO;
         } else {
             NSLog(@"✅ ScreenCaptureKit stream stopped in completion handler");
         }
-        // Video finalization happens in delegate
+        
+        // Finalize video since delegate might not be called
+        NSLog(@"🎬 Completion handler calling finalizeVideoWriter...");
+        [ScreenCaptureKitRecorder finalizeVideoWriter];
+        NSLog(@"🎬 Completion handler finished calling finalizeVideoWriter");
     }];
 }
 
@@ -178,19 +213,20 @@ static BOOL g_writerStarted = NO;
         return;
     }
     
-    // Electron-safe video settings
+    // Ultra-conservative Electron video settings
     NSDictionary *videoSettings = @{
         AVVideoCodecKey: AVVideoCodecTypeH264,
         AVVideoWidthKey: @1280,
         AVVideoHeightKey: @720,
         AVVideoCompressionPropertiesKey: @{
-            AVVideoAverageBitRateKey: @(1280 * 720 * 2),
-            AVVideoMaxKeyFrameIntervalKey: @30
+            AVVideoAverageBitRateKey: @(1280 * 720 * 1), // Lower bitrate
+            AVVideoMaxKeyFrameIntervalKey: @10,
+            AVVideoProfileLevelKey: AVVideoProfileLevelH264BaselineAutoLevel
         }
     };
     
     g_assetWriterInput = [AVAssetWriterInput assetWriterInputWithMediaType:AVMediaTypeVideo outputSettings:videoSettings];
-    g_assetWriterInput.expectsMediaDataInRealTime = YES; // Important for live capture
+    g_assetWriterInput.expectsMediaDataInRealTime = NO; // Safer for Electron
     
     // Pixel buffer attributes matching ScreenCaptureKit format
     NSDictionary *pixelBufferAttributes = @{
@@ -210,25 +246,29 @@ static BOOL g_writerStarted = NO;
 }
 
 + (void)finalizeVideoWriter {
-    NSLog(@"🎬 Finalizing Electron-safe video writer");
+    NSLog(@"🎬 Finalizing video writer - writer: %p, started: %d", g_assetWriter, g_writerStarted);
     
     if (!g_assetWriter || !g_writerStarted) {
-        NSLog(@"⚠️ Video writer not started, cleaning up");
+        NSLog(@"⚠️ Video writer not started properly - writer: %p, started: %d", g_assetWriter, g_writerStarted);
         [ScreenCaptureKitRecorder cleanupVideoWriter];
         return;
     }
     
+    NSLog(@"🎬 Marking input as finished and finalizing...");
     [g_assetWriterInput markAsFinished];
     
     [g_assetWriter finishWritingWithCompletionHandler:^{
+        NSLog(@"🎬 Finalization completion handler called");
         if (g_assetWriter.status == AVAssetWriterStatusCompleted) {
-            NSLog(@"✅ Electron-safe video created successfully: %@", g_outputPath);
+            NSLog(@"✅ Video finalization successful: %@", g_outputPath);
         } else {
-            NSLog(@"❌ Video creation failed: %@", g_assetWriter.error);
+            NSLog(@"❌ Video finalization failed - status: %ld, error: %@", (long)g_assetWriter.status, g_assetWriter.error);
         }
         
         [ScreenCaptureKitRecorder cleanupVideoWriter];
     }];
+    
+    NSLog(@"🎬 Finalization request submitted, waiting for completion...");
 }
 
 + (void)cleanupVideoWriter {