node-mac-recorder 2.12.0 → 2.12.2

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.12.0",
+	"version": "2.12.2",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/mac_recorder.mm

@@ -161,8 +161,11 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
     
     @try {
         // Try ScreenCaptureKit first (macOS 12.3+)
+        NSLog(@"🔍 System Version Check - macOS availability for ScreenCaptureKit");
         if (@available(macOS 12.3, *)) {
+            NSLog(@"✅ macOS 12.3+ detected - ScreenCaptureKit should be available");
             if ([ScreenCaptureKitRecorder isScreenCaptureKitAvailable]) {
+                NSLog(@"✅ ScreenCaptureKit availability check passed");
                 NSLog(@"🎯 Using ScreenCaptureKit - overlay windows will be automatically excluded");
                 
                 // Create configuration for ScreenCaptureKit
@@ -188,16 +191,25 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
                 if ([ScreenCaptureKitRecorder startRecordingWithConfiguration:sckConfig 
                                                                      delegate:g_delegate 
                                                                         error:&sckError]) {
+                    NSLog(@"🎬 RECORDING METHOD: ScreenCaptureKit");
                     NSLog(@"✅ ScreenCaptureKit recording started with window exclusion");
                     g_isRecording = true;
                     return Napi::Boolean::New(env, true);
                 } else {
-                    NSLog(@"⚠️ ScreenCaptureKit failed (%@), falling back to AVFoundation", sckError.localizedDescription);
+                    NSLog(@"❌ ScreenCaptureKit failed to start");
+                    NSLog(@"❌ Error: %@", sckError ? sckError.localizedDescription : @"Unknown error");
+                    NSLog(@"⚠️ Falling back to AVFoundation");
                 }
+            } else {
+                NSLog(@"❌ ScreenCaptureKit availability check failed");
+                NSLog(@"⚠️ Falling back to AVFoundation");
             }
+        } else {
+            NSLog(@"❌ macOS version too old for ScreenCaptureKit (< 12.3)");
         }
         
         // Fallback: Use AVFoundation (older macOS or ScreenCaptureKit failure)
+        NSLog(@"🎬 RECORDING METHOD: AVFoundation");
         NSLog(@"📼 Falling back to AVFoundation - overlay windows may appear in recording");
         
         // Create capture session
@@ -356,6 +368,7 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
         NSURL *outputURL = [NSURL fileURLWithPath:[NSString stringWithUTF8String:outputPath.c_str()]];
         [g_movieFileOutput startRecordingToOutputFileURL:outputURL recordingDelegate:g_delegate];
         
+        NSLog(@"✅ AVFoundation recording started");
         g_isRecording = true;
         return Napi::Boolean::New(env, true);
         

package/src/screen_capture_kit.mm

@@ -19,8 +19,30 @@ static BOOL g_isRecording = NO;
 
 + (BOOL)isScreenCaptureKitAvailable {
     if (@available(macOS 12.3, *)) {
-        return YES;
+        NSLog(@"🔍 ScreenCaptureKit availability check - macOS 12.3+ confirmed");
+        
+        // Try to access ScreenCaptureKit classes to verify they're actually available
+        @try {
+            Class scStreamClass = NSClassFromString(@"SCStream");
+            Class scContentFilterClass = NSClassFromString(@"SCContentFilter");
+            Class scShareableContentClass = NSClassFromString(@"SCShareableContent");
+            
+            if (scStreamClass && scContentFilterClass && scShareableContentClass) {
+                NSLog(@"✅ ScreenCaptureKit classes are available");
+                return YES;
+            } else {
+                NSLog(@"❌ ScreenCaptureKit classes not found");
+                NSLog(@"   SCStream: %@", scStreamClass ? @"✅" : @"❌");
+                NSLog(@"   SCContentFilter: %@", scContentFilterClass ? @"✅" : @"❌");
+                NSLog(@"   SCShareableContent: %@", scShareableContentClass ? @"✅" : @"❌");
+                return NO;
+            }
+        } @catch (NSException *exception) {
+            NSLog(@"❌ Exception checking ScreenCaptureKit classes: %@", exception.reason);
+            return NO;
+        }
     }
+    NSLog(@"❌ macOS version < 12.3 - ScreenCaptureKit not available");
     return NO;
 }
 
@@ -74,11 +96,43 @@ static BOOL g_isRecording = NO;
                 // Also try to exclude Electron app if running (common overlay use case)
                 for (SCWindow *window in content.windows) {
                     NSString *appName = window.owningApplication.applicationName;
+                    NSString *windowTitle = window.title ? window.title : @"<No Title>";
+                    
+                    // Debug: Log all windows to see what we're dealing with (only for small subset)
+                    if ([appName containsString:@"Electron"] || [windowTitle containsString:@"camera"]) {
+                        NSLog(@"📋 Found potential exclude window: '%@' from app: '%@' (PID: %d, Level: %ld)", 
+                              windowTitle, appName, window.owningApplication.processID, (long)window.windowLayer);
+                    }
+                    
+                    // Comprehensive Electron window detection
+                    BOOL shouldExclude = NO;
+                    
+                    // Check app name patterns
                     if ([appName containsString:@"Electron"] || 
                         [appName isEqualToString:@"electron"] ||
-                        [window.title containsString:@"Electron"]) {
+                        [appName isEqualToString:@"Electron Helper"]) {
+                        shouldExclude = YES;
+                    }
+                    
+                    // Check window title patterns
+                    if ([windowTitle containsString:@"Electron"] ||
+                        [windowTitle containsString:@"camera"] ||
+                        [windowTitle containsString:@"Camera"] ||
+                        [windowTitle containsString:@"overlay"] ||
+                        [windowTitle containsString:@"Overlay"]) {
+                        shouldExclude = YES;
+                    }
+                    
+                    // Check window properties (transparent, always on top windows)
+                    if (window.windowLayer > 100) { // High window levels (like alwaysOnTop)
+                        shouldExclude = YES;
+                        NSLog(@"📋 High-level window detected: '%@' (Level: %ld)", windowTitle, (long)window.windowLayer);
+                    }
+                    
+                    if (shouldExclude) {
                         [excludedWindows addObject:window];
-                        NSLog(@"🚫 Excluding Electron window: %@ from %@", window.title, appName);
+                        NSLog(@"🚫 Excluding window: '%@' from %@ (PID: %d, Level: %ld)", 
+                              windowTitle, appName, window.owningApplication.processID, (long)window.windowLayer);
                     }
                 }