node-mac-recorder 2.1.3 → 2.4.0

package/binding.gyp

@@ -5,7 +5,6 @@
       "sources": [
         "src/mac_recorder.mm",
         "src/screen_capture.mm",
-        "src/screen_capture_kit.mm",
         "src/audio_capture.mm",
         "src/cursor_tracker.mm",
         "src/window_selector.mm"
@@ -22,25 +21,31 @@
         "GCC_ENABLE_CPP_EXCEPTIONS": "YES",
         "CLANG_CXX_LIBRARY": "libc++",
         "MACOSX_DEPLOYMENT_TARGET": "12.3",
+        "ARCHS": ["arm64"],
+        "VALID_ARCHS": ["arm64"],
         "OTHER_CFLAGS": [
-          "-ObjC++"
-        ]
+          "-ObjC++",
+          "-fmodules"
+        ],
+        "CLANG_ENABLE_OBJC_ARC": "YES"
       },
       "link_settings": {
         "libraries": [
+          "-framework ScreenCaptureKit",
+          "-framework AVFoundation",
+          "-framework CoreMedia",
+          "-framework CoreVideo",
           "-framework Foundation",
           "-framework AppKit",
-          "-framework ScreenCaptureKit",
           "-framework ApplicationServices",
           "-framework Carbon",
-          "-framework Accessibility",
-          "-framework CoreAudio",
-          "-framework AVFoundation",
-          "-framework CoreMedia",
-          "-framework CoreVideo"
+          "-framework Accessibility"
         ]
       },
-      "defines": [ "NAPI_DISABLE_CPP_EXCEPTIONS" ]
+      "defines": [ 
+        "NAPI_DISABLE_CPP_EXCEPTIONS",
+        "USE_SCREENCAPTUREKIT=1"
+      ]
     }
   ]
 } 

package/index.js

@@ -2,24 +2,19 @@ const { EventEmitter } = require("events");
 const path = require("path");
 const fs = require("fs");
 
-// Native modülü yükle (prebuilt > local build fallback)
+// Native modülü yükle
 let nativeBinding;
 try {
-	// Prebuilt
-	nativeBinding = require("node-gyp-build")(__dirname);
-} catch (e) {
+	nativeBinding = require("./build/Release/mac_recorder.node");
+} catch (error) {
 	try {
-		nativeBinding = require("./build/Release/mac_recorder.node");
-	} catch (error) {
-		try {
-			nativeBinding = require("./build/Debug/mac_recorder.node");
-		} catch (debugError) {
-			throw new Error(
-				'Native module not found. Please run "npm run build" to compile the native module.\n' +
-					"Original error: " +
-					(error?.message || e?.message)
-			);
-		}
+		nativeBinding = require("./build/Debug/mac_recorder.node");
+	} catch (debugError) {
+		throw new Error(
+			'Native module not found. Please run "npm run build" to compile the native module.\n' +
+				"Original error: " +
+				error.message
+		);
 	}
 }
 
@@ -50,12 +45,6 @@ class MacRecorder extends EventEmitter {
 			showClicks: false,
 			displayId: null, // Hangi ekranı kaydedeceği (null = ana ekran)
 			windowId: null, // Hangi pencereyi kaydedeceği (null = tam ekran)
-			// SC (gizli, opsiyonel) - mevcut kullanıcıları bozmaz
-			useScreenCaptureKit: false,
-			excludedAppBundleIds: [],
-			excludedPIDs: [],
-			excludedWindowIds: [],
-			autoExcludeSelf: !!(process.versions && process.versions.electron),
 		};
 
 		// Display cache için async initialization
@@ -129,14 +118,11 @@ class MacRecorder extends EventEmitter {
 			audioDeviceId: options.audioDeviceId || null, // null = default device
 			systemAudioDeviceId: options.systemAudioDeviceId || null, // null = auto-detect system audio device
 			captureArea: options.captureArea || null,
-			useScreenCaptureKit: options.useScreenCaptureKit || false,
-			excludedAppBundleIds: options.excludedAppBundleIds || [],
-			excludedPIDs: options.excludedPIDs || [],
-			excludedWindowIds: options.excludedWindowIds || [],
-			autoExcludeSelf:
-				typeof options.autoExcludeSelf === "boolean"
-					? options.autoExcludeSelf
-					: !!(process.versions && process.versions.electron),
+			// Exclusion options
+			excludeCurrentApp: options.excludeCurrentApp || false,
+			excludeWindowIds: Array.isArray(options.excludeWindowIds)
+				? options.excludeWindowIds
+				: [],
 		};
 	}
 
@@ -297,11 +283,9 @@ class MacRecorder extends EventEmitter {
 					windowId: this.options.windowId || null, // null = tam ekran
 					audioDeviceId: this.options.audioDeviceId || null, // null = default device
 					systemAudioDeviceId: this.options.systemAudioDeviceId || null, // null = auto-detect system audio device
-					useScreenCaptureKit: this.options.useScreenCaptureKit || false,
-					excludedAppBundleIds: this.options.excludedAppBundleIds || [],
-					excludedPIDs: this.options.excludedPIDs || [],
-					excludedWindowIds: this.options.excludedWindowIds || [],
-					autoExcludeSelf: this.options.autoExcludeSelf === true,
+					// Exclusion options passthrough
+					excludeCurrentApp: this.options.excludeCurrentApp || false,
+					excludeWindowIds: this.options.excludeWindowIds || [],
 				};
 
 				// Manuel captureArea varsa onu kullan
@@ -314,34 +298,10 @@ class MacRecorder extends EventEmitter {
 					};
 				}
 
-				// SC yolu: kullanıcıdan SC talebi varsa veya exclude listeleri doluysa ve SC mevcutsa otomatik kullan
-				let success;
-				try {
-					const wantsSC = !!(
-						this.options.useScreenCaptureKit ||
-						this.options.excludedAppBundleIds?.length ||
-						this.options.excludedPIDs?.length ||
-						this.options.excludedWindowIds?.length
-					);
-					const scAvailable =
-						typeof nativeBinding.isScreenCaptureKitAvailable === "function" &&
-						nativeBinding.isScreenCaptureKitAvailable();
-					if (wantsSC && scAvailable) {
-						const scOptions = {
-							...recordingOptions,
-							useScreenCaptureKit: true,
-						};
-						success = nativeBinding.startRecording(outputPath, scOptions);
-					} else {
-						success = nativeBinding.startRecording(
-							outputPath,
-							recordingOptions
-						);
-					}
-				} catch (e) {
-					// Fallback AVFoundation
-					success = nativeBinding.startRecording(outputPath, recordingOptions);
-				}
+				const success = nativeBinding.startRecording(
+					outputPath,
+					recordingOptions
+				);
 
 				if (success) {
 					this.isRecording = true;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "2.1.3",
+	"version": "2.4.0",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [
@@ -38,19 +38,14 @@
 		"build": "node-gyp build",
 		"rebuild": "node-gyp rebuild",
 		"clean": "node-gyp clean",
-		"prebuild:darwin:arm64": "prebuildify --napi --strip --platform darwin --arch arm64",
-		"prebuild:darwin:x64": "prebuildify --napi --strip --platform darwin --arch x64",
-		"prebuild": "npm run prebuild:darwin:arm64 && npm run prebuild:darwin:x64",
 		"test:window-selector": "node window-selector-test.js",
 		"example:window-selector": "node examples/window-selector-example.js"
 	},
 	"dependencies": {
-		"node-addon-api": "^7.0.0",
-		"node-gyp-build": "^4.6.0"
+		"node-addon-api": "^7.0.0"
 	},
 	"devDependencies": {
-		"node-gyp": "^10.0.0",
-		"prebuildify": "^5.0.0"
+		"node-gyp": "^10.0.0"
 	},
 	"gypfile": true
 }

package/src/audio_capture.mm

@@ -1,9 +1,11 @@
+#import <ScreenCaptureKit/ScreenCaptureKit.h>
 #import <AVFoundation/AVFoundation.h>
 #import <CoreAudio/CoreAudio.h>
 
 @interface AudioCapture : NSObject
 
 + (NSArray *)getAudioDevices;
++ (NSArray *)getSystemAudioDevices;
 + (BOOL)hasAudioPermission;
 + (void)requestAudioPermission:(void(^)(BOOL granted))completion;
 
@@ -14,25 +16,39 @@
 + (NSArray *)getAudioDevices {
     NSMutableArray *devices = [NSMutableArray array];
     
-    // Get all audio devices
-    NSArray *audioDevices = [AVCaptureDevice devicesWithMediaType:AVMediaTypeAudio];
+    // Get microphone devices using AVFoundation
+    AVCaptureDeviceDiscoverySession *discoverySession = [AVCaptureDeviceDiscoverySession 
+        discoverySessionWithDeviceTypes:@[AVCaptureDeviceTypeBuiltInMicrophone, AVCaptureDeviceTypeExternalUnknown]
+        mediaType:AVMediaTypeAudio
+        position:AVCaptureDevicePositionUnspecified];
+    NSArray *audioDevices = discoverySession.devices;
     
     for (AVCaptureDevice *device in audioDevices) {
         NSDictionary *deviceInfo = @{
             @"id": device.uniqueID,
             @"name": device.localizedName,
             @"manufacturer": device.manufacturer ?: @"Unknown",
+            @"type": @"microphone",
             @"isDefault": @([device isEqual:[AVCaptureDevice defaultDeviceWithMediaType:AVMediaTypeAudio]])
         };
         
         [devices addObject:deviceInfo];
     }
     
-    // Also get system audio devices using Core Audio
+    // Add system audio devices using Core Audio API
+    NSArray *systemDevices = [self getSystemAudioDevices];
+    [devices addObjectsFromArray:systemDevices];
+    
+    return [devices copy];
+}
+
++ (NSArray *)getSystemAudioDevices {
+    NSMutableArray *devices = [NSMutableArray array];
+    
     AudioObjectPropertyAddress propertyAddress = {
         kAudioHardwarePropertyDevices,
         kAudioObjectPropertyScopeGlobal,
-        kAudioObjectPropertyElementMaster
+        kAudioObjectPropertyElementMain  // Changed from kAudioObjectPropertyElementMaster (deprecated)
     };
     
     UInt32 dataSize = 0;
@@ -49,37 +65,41 @@
                 AudioDeviceID deviceID = audioDeviceIDs[i];
                 
                 // Get device name
-                propertyAddress.mSelector = kAudioDevicePropertyDeviceNameCFString;
-                propertyAddress.mScope = kAudioObjectPropertyScopeGlobal;
-                
                 CFStringRef deviceName = NULL;
-                dataSize = sizeof(deviceName);
+                UInt32 size = sizeof(deviceName);
+                AudioObjectPropertyAddress nameAddress = {
+                    kAudioDevicePropertyDeviceNameCFString,
+                    kAudioDevicePropertyScopeOutput,  // Focus on output devices for system audio
+                    kAudioObjectPropertyElementMain
+                };
                 
-                status = AudioObjectGetPropertyData(deviceID, &propertyAddress, 0, NULL, &dataSize, &deviceName);
+                status = AudioObjectGetPropertyData(deviceID, &nameAddress, 0, NULL, &size, &deviceName);
                 
                 if (status == kAudioHardwareNoError && deviceName) {
-                    // Check if it's an input device
-                    propertyAddress.mSelector = kAudioDevicePropertyStreamConfiguration;
-                    propertyAddress.mScope = kAudioDevicePropertyScopeInput;
+                    // Check if this is an output device
+                    AudioObjectPropertyAddress streamAddress = {
+                        kAudioDevicePropertyStreams,
+                        kAudioDevicePropertyScopeOutput,
+                        kAudioObjectPropertyElementMain
+                    };
                     
-                    AudioObjectGetPropertyDataSize(deviceID, &propertyAddress, 0, NULL, &dataSize);
+                    UInt32 streamSize = 0;
+                    status = AudioObjectGetPropertyDataSize(deviceID, &streamAddress, 0, NULL, &streamSize);
                     
-                    if (dataSize > 0) {
-                        AudioBufferList *bufferList = (AudioBufferList *)malloc(dataSize);
-                        AudioObjectGetPropertyData(deviceID, &propertyAddress, 0, NULL, &dataSize, bufferList);
+                    if (status == kAudioHardwareNoError && streamSize > 0) {
+                        // This is an output device - can be used for system audio capture
+                        const char *name = CFStringGetCStringPtr(deviceName, kCFStringEncodingUTF8);
+                        NSString *deviceNameStr = name ? [NSString stringWithUTF8String:name] : @"Unknown Device";
                         
-                        if (bufferList->mNumberBuffers > 0) {
-                            NSDictionary *deviceInfo = @{
-                                @"id": @(deviceID),
-                                @"name": (__bridge NSString *)deviceName,
-                                @"type": @"System Audio Input",
-                                @"isSystemDevice": @YES
-                            };
-                            
-                            [devices addObject:deviceInfo];
-                        }
+                        NSDictionary *deviceInfo = @{
+                            @"id": [NSString stringWithFormat:@"%u", deviceID],
+                            @"name": deviceNameStr,
+                            @"manufacturer": @"System",
+                            @"type": @"system_audio",
+                            @"isDefault": @(NO)  // We'll determine default separately if needed
+                        };
                         
-                        free(bufferList);
+                        [devices addObject:deviceInfo];
                     }
                     
                     CFRelease(deviceName);
@@ -94,23 +114,59 @@
 }
 
 + (BOOL)hasAudioPermission {
-    if (@available(macOS 10.14, *)) {
-        AVAuthorizationStatus status = [AVCaptureDevice authorizationStatusForMediaType:AVMediaTypeAudio];
-        return status == AVAuthorizationStatusAuthorized;
-    }
-    return YES; // Older versions don't require explicit permission
+    // Check microphone permission using AVFoundation
+    AVAuthorizationStatus authStatus = [AVCaptureDevice authorizationStatusForMediaType:AVMediaTypeAudio];
+    return authStatus == AVAuthorizationStatusAuthorized;
 }
 
 + (void)requestAudioPermission:(void(^)(BOOL granted))completion {
-    if (@available(macOS 10.14, *)) {
-        [AVCaptureDevice requestAccessForMediaType:AVMediaTypeAudio completionHandler:^(BOOL granted) {
-            dispatch_async(dispatch_get_main_queue(), ^{
+    [AVCaptureDevice requestAccessForMediaType:AVMediaTypeAudio completionHandler:^(BOOL granted) {
+        dispatch_async(dispatch_get_main_queue(), ^{
+            if (completion) {
                 completion(granted);
-            });
-        }];
-    } else {
-        completion(YES);
+            }
+        });
+    }];
+}
+
+@end
+
+// ScreenCaptureKit Audio Configuration Helper
+API_AVAILABLE(macos(12.3))
+@interface SCKAudioConfiguration : NSObject
+
++ (BOOL)configureAudioForStream:(SCStreamConfiguration *)config 
+                 includeMicrophone:(BOOL)includeMicrophone
+               includeSystemAudio:(BOOL)includeSystemAudio
+                  microphoneDevice:(NSString *)micDeviceID
+                systemAudioDevice:(NSString *)sysDeviceID;
+
+@end
+
+@implementation SCKAudioConfiguration
+
++ (BOOL)configureAudioForStream:(SCStreamConfiguration *)config 
+                 includeMicrophone:(BOOL)includeMicrophone
+               includeSystemAudio:(BOOL)includeSystemAudio
+                  microphoneDevice:(NSString *)micDeviceID
+                systemAudioDevice:(NSString *)sysDeviceID {
+    
+    // Configure system audio capture (requires macOS 13.0+)
+    if (@available(macOS 13.0, *)) {
+        config.capturesAudio = includeSystemAudio;
+        config.excludesCurrentProcessAudio = YES;
+        
+        if (includeSystemAudio) {
+            // ScreenCaptureKit will capture system audio from the selected content
+            // Quality settings
+            config.channelCount = 2;  // Stereo
+            config.sampleRate = 48000; // 48kHz
+        } else {
+            config.capturesAudio = NO;
+        }
     }
+    
+    return YES;
 }
 
-@end 
+@end

package/src/cursor_tracker.mm

@@ -168,7 +168,7 @@ void writeToFile(NSDictionary *cursorData) {
                                                                options:0
                                                                  error:&error];
             if (jsonData && !error) {
-                NSString *jsonString = [[[NSString alloc] initWithData:jsonData encoding:NSUTF8StringEncoding] autorelease];
+                NSString *jsonString = [[NSString alloc] initWithData:jsonData encoding:NSUTF8StringEncoding];
                 
                 if (g_isFirstWrite) {
                     // İlk yazma - array başlat
@@ -292,7 +292,6 @@ void cleanupCursorTracking() {
     }
     
     if (g_timerTarget) {
-        [g_timerTarget autorelease];
         g_timerTarget = nil;
     }
     
@@ -352,12 +351,12 @@ Napi::Value StartCursorTracking(const Napi::CallbackInfo& info) {
     @try {
         // Dosyayı oluştur ve aç
         g_outputPath = [NSString stringWithUTF8String:outputPath.c_str()];
-        g_fileHandle = [[NSFileHandle fileHandleForWritingAtPath:g_outputPath] retain];
+        g_fileHandle = [NSFileHandle fileHandleForWritingAtPath:g_outputPath];
         
         if (!g_fileHandle) {
             // Dosya yoksa oluştur
             [[NSFileManager defaultManager] createFileAtPath:g_outputPath contents:nil attributes:nil];
-            g_fileHandle = [[NSFileHandle fileHandleForWritingAtPath:g_outputPath] retain];
+            g_fileHandle = [NSFileHandle fileHandleForWritingAtPath:g_outputPath];
         }
         
         if (!g_fileHandle) {