node-mac-recorder 1.2.9 → 1.2.10

package/index.js

@@ -163,7 +163,7 @@ class MacRecorder extends EventEmitter {
 							targetWindow.y >= display.y &&
 							targetWindow.y < display.y + displayHeight
 						) {
-							targetDisplayId = i;
+							targetDisplayId = display.id; // Use actual display ID, not array index
 							// Koordinatları display'e göre normalize et
 							adjustedX = targetWindow.x - display.x;
 							adjustedY = targetWindow.y - display.y;
@@ -175,7 +175,7 @@ class MacRecorder extends EventEmitter {
 					if (targetDisplayId === null) {
 						const mainDisplay = displays.find((d) => d.x === 0 && d.y === 0);
 						if (mainDisplay) {
-							targetDisplayId = displays.indexOf(mainDisplay);
+							targetDisplayId = mainDisplay.id; // Use actual display ID, not array index
 							adjustedX = Math.max(
 								0,
 								Math.min(
@@ -200,7 +200,7 @@ class MacRecorder extends EventEmitter {
 						this.options.displayId = targetDisplayId;
 
 						// Recording için display bilgisini sakla (cursor capture için)
-						const targetDisplay = displays[targetDisplayId];
+						const targetDisplay = displays.find(d => d.id === targetDisplayId);
 						this.recordingDisplayInfo = {
 							displayId: targetDisplayId,
 							x: targetDisplay.x,
@@ -233,8 +233,8 @@ class MacRecorder extends EventEmitter {
 		if (this.options.displayId !== null && !this.recordingDisplayInfo) {
 			try {
 				const displays = await this.getDisplays();
-				if (this.options.displayId < displays.length) {
-					const targetDisplay = displays[this.options.displayId];
+				const targetDisplay = displays.find(d => d.id === this.options.displayId);
+				if (targetDisplay) {
 					this.recordingDisplayInfo = {
 						displayId: this.options.displayId,
 						x: targetDisplay.x,

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "node-mac-recorder",
-	"version": "1.2.9",
+	"version": "1.2.10",
 	"description": "Native macOS screen recording package for Node.js applications",
 	"main": "index.js",
 	"keywords": [

package/src/mac_recorder.mm

@@ -113,16 +113,30 @@ Napi::Value StartRecording(const Napi::CallbackInfo& info) {
         if (options.Has("displayId") && !options.Get("displayId").IsNull()) {
             double displayIdNum = options.Get("displayId").As<Napi::Number>().DoubleValue();
             
-            // Get all displays and use the specified one
+            // Use the display ID directly (not as an index)
+            // The JavaScript layer passes the actual CGDirectDisplayID
+            displayID = (CGDirectDisplayID)displayIdNum;
+            
+            // Verify that this display ID is valid
             uint32_t displayCount;
             CGGetActiveDisplayList(0, NULL, &displayCount);
             if (displayCount > 0) {
                 CGDirectDisplayID *displays = (CGDirectDisplayID*)malloc(displayCount * sizeof(CGDirectDisplayID));
                 CGGetActiveDisplayList(displayCount, displays, &displayCount);
                 
-                if (displayIdNum >= 0 && displayIdNum < displayCount) {
-                    displayID = displays[(int)displayIdNum];
+                bool validDisplay = false;
+                for (uint32_t i = 0; i < displayCount; i++) {
+                    if (displays[i] == displayID) {
+                        validDisplay = true;
+                        break;
+                    }
+                }
+                
+                if (!validDisplay) {
+                    // Fallback to main display if invalid ID provided
+                    displayID = CGMainDisplayID();
                 }
+                
                 free(displays);
             }
         }