node-linux-arm64 24.11.0 → 25.1.0

package/README.md

@@ -323,8 +323,6 @@ For information about the governance of the Node.js project, see
   **Erick Wendel** <<erick.workspace@gmail.com>> (he/him)
 * [Ethan-Arrowood](https://github.com/Ethan-Arrowood) -
   **Ethan Arrowood** <<ethan@arrowood.dev>> (he/him)
-* [F3n67u](https://github.com/F3n67u) -
-  **Feng Yu** <<F3n67u@outlook.com>> (he/him)
 * [fhinkel](https://github.com/fhinkel) -
   **Franziska Hinkelmann** <<franziska.hinkelmann@gmail.com>> (she/her)
 * [Flarna](https://github.com/Flarna) -
@@ -527,6 +525,8 @@ For information about the governance of the Node.js project, see
   **Eugene Ostroukhov** <<eostroukhov@google.com>>
 * [evanlucas](https://github.com/evanlucas) -
   **Evan Lucas** <<evanlucas@me.com>> (he/him)
+* [F3n67u](https://github.com/F3n67u) -
+  **Feng Yu** <<F3n67u@outlook.com>> (he/him)
 * [firedfox](https://github.com/firedfox) -
   **Daniel Wang** <<wangyang0123@gmail.com>>
 * [Fishrock123](https://github.com/Fishrock123) -
@@ -751,8 +751,6 @@ maintaining the Node.js project.
   **Oliver Medhurst** <<honk@goose.icu>> (they/them)
 * [daeyeon](https://github.com/daeyeon) -
   **Daeyeon Jeong** <<daeyeon.dev@gmail.com>> (he/him)
-* [F3n67u](https://github.com/F3n67u) -
-  **Feng Yu** <<F3n67u@outlook.com>> (he/him)
 * [gireeshpunathil](https://github.com/gireeshpunathil) -
   **Gireesh Punathil** <<gpunathi@in.ibm.com>> (he/him)
 * [gurgunday](https://github.com/gurgunday) -

package/include/node/common.gypi

@@ -38,7 +38,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.28',
+    'v8_embedder_string': '-node.11',
 
     ##### V8 defaults for Node.js #####
 
@@ -78,14 +78,11 @@
     'v8_win64_unwinding_info': 1,
 
     # Variables controlling external defines exposed in public headers.
-    'v8_enable_conservative_stack_scanning%': 0,
-    'v8_enable_direct_local%': 0,
     'v8_enable_map_packing%': 0,
     'v8_enable_pointer_compression_shared_cage%': 0,
     'v8_enable_external_code_space%': 0,
     'v8_enable_sandbox%': 0,
     'v8_enable_v8_checks%': 0,
-    'v8_enable_zone_compression%': 0,
     'v8_use_perfetto': 0,
     'tsan%': 0,
 
@@ -446,18 +443,15 @@
       ['v8_enable_pointer_compression == 1', {
         'defines': ['V8_COMPRESS_POINTERS'],
       }],
+      ['v8_enable_pointer_compression == 1 and v8_enable_pointer_compression_shared_cage != 1', {
+        'defines': ['V8_COMPRESS_POINTERS_IN_MULTIPLE_CAGES'],
+      }],
       ['v8_enable_pointer_compression_shared_cage == 1', {
         'defines': ['V8_COMPRESS_POINTERS_IN_SHARED_CAGE'],
       }],
-      ['v8_enable_pointer_compression == 1 and v8_enable_pointer_compression_shared_cage != 1', {
-        'defines': ['V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE'],
-      }],
       ['v8_enable_pointer_compression == 1 or v8_enable_31bit_smis_on_64bit_arch == 1', {
         'defines': ['V8_31BIT_SMIS_ON_64BIT_ARCH'],
       }],
-      ['v8_enable_zone_compression == 1', {
-        'defines': ['V8_COMPRESS_ZONES',],
-      }],
       ['v8_enable_sandbox == 1', {
         'defines': ['V8_ENABLE_SANDBOX',],
       }],
@@ -479,12 +473,6 @@
       ['tsan == 1', {
         'defines': ['V8_IS_TSAN',],
       }],
-      ['v8_enable_conservative_stack_scanning == 1', {
-        'defines': ['V8_ENABLE_CONSERVATIVE_STACK_SCANNING',],
-      }],
-      ['v8_enable_direct_local == 1', {
-        'defines': ['V8_ENABLE_DIRECT_LOCAL',],
-      }],
       ['OS == "win"', {
         'defines': [
           'WIN32',

package/include/node/config.gypi

@@ -8,7 +8,7 @@
                        'libraries': []},
   'variables': { 'arm_fpu': 'neon',
                  'asan': 0,
-                 'clang': 0,
+                 'clang': 1,
                  'control_flow_guard': 'false',
                  'coverage': 'false',
                  'dcheck_always_on': 0,
@@ -19,7 +19,6 @@
                  'enable_pgo_use': 'false',
                  'error_on_warn': 'false',
                  'force_dynamic_crt': 0,
-                 'gas_version': '2.38',
                  'host_arch': 'arm64',
                  'icu_data_in': '../../deps/icu-tmp/icudt77l.dat',
                  'icu_endianness': 'l',
@@ -28,7 +27,7 @@
                  'icu_small': 'false',
                  'icu_ver_major': '77',
                  'libdir': 'lib',
-                 'llvm_version': '0.0',
+                 'llvm_version': '19.1',
                  'napi_build_version': '10',
                  'node_builtin_shareable_builtins': [ 'deps/cjs-module-lexer/lexer.js',
                                                       'deps/cjs-module-lexer/dist/lexer.js',
@@ -36,6 +35,7 @@
                                                       'deps/amaro/dist/index.js'],
                  'node_byteorder': 'little',
                  'node_cctest_sources': [ 'src/node_snapshot_stub.cc',
+                                          'test/cctest/inspector/test_network_requests_buffer.cc',
                                           'test/cctest/inspector/test_node_protocol.cc',
                                           'test/cctest/node_test_fixture.cc',
                                           'test/cctest/test_aliased_buffer.cc',
@@ -60,6 +60,7 @@
                                           'test/cctest/test_platform.cc',
                                           'test/cctest/test_quic_cid.cc',
                                           'test/cctest/test_quic_error.cc',
+                                          'test/cctest/test_quic_preferredaddress.cc',
                                           'test/cctest/test_quic_tokens.cc',
                                           'test/cctest/test_report.cc',
                                           'test/cctest/test_sockaddr.cc',
@@ -72,7 +73,7 @@
                  'node_enable_v8_vtunejit': 'false',
                  'node_enable_v8windbg': 'false',
                  'node_fipsinstall': 'false',
-                 'node_install_corepack': 'true',
+                 'node_install_corepack': 'false',
                  'node_install_npm': 'true',
                  'node_library_files': [ 'lib/_http_agent.js',
                                          'lib/_http_client.js',
@@ -113,7 +114,6 @@
                                          'lib/internal/abort_controller.js',
                                          'lib/internal/assert.js',
                                          'lib/internal/assert/assertion_error.js',
-                                         'lib/internal/assert/calltracker.js',
                                          'lib/internal/assert/myers_diff.js',
                                          'lib/internal/assert/utils.js',
                                          'lib/internal/async_context_frame.js',
@@ -294,6 +294,7 @@
                                          'lib/internal/readline/utils.js',
                                          'lib/internal/repl.js',
                                          'lib/internal/repl/await.js',
+                                         'lib/internal/repl/completion.js',
                                          'lib/internal/repl/history.js',
                                          'lib/internal/repl/utils.js',
                                          'lib/internal/socket_list.js',
@@ -344,7 +345,9 @@
                                          'lib/internal/test_runner/tests_stream.js',
                                          'lib/internal/test_runner/utils.js',
                                          'lib/internal/timers.js',
+                                         'lib/internal/tls/common.js',
                                          'lib/internal/tls/secure-context.js',
+                                         'lib/internal/tls/wrap.js',
                                          'lib/internal/trace_events_async_hooks.js',
                                          'lib/internal/tty.js',
                                          'lib/internal/url.js',
@@ -421,10 +424,9 @@
                                          'lib/wasi.js',
                                          'lib/worker_threads.js',
                                          'lib/zlib.js'],
-                 'node_module_version': 137,
+                 'node_module_version': 141,
                  'node_no_browser_globals': 'false',
                  'node_prefix': '/',
-                 'node_quic': 'false',
                  'node_release_urlbase': 'https://nodejs.org/download/release/',
                  'node_section_ordering_info': '',
                  'node_shared': 'false',
@@ -456,9 +458,9 @@
                  'node_without_node_options': 'false',
                  'node_write_snapshot_as_array_literals': 'false',
                  'openssl_is_fips': 'false',
-                 'openssl_quic': 'false',
+                 'openssl_version': 810549327,
                  'ossfuzz': 'false',
-                 'shlib_suffix': 'so.137',
+                 'shlib_suffix': 'so.141',
                  'single_executable_application': 'true',
                  'suppress_all_error_on_warn': 'false',
                  'target_arch': 'arm64',

package/include/node/cppgc/allocation.h

@@ -71,7 +71,7 @@ class MakeGarbageCollectedTraitInternal {
   template <typename GCInfoType, typename CustomSpace, size_t alignment>
   struct AllocationDispatcher final {
     static void* Invoke(AllocationHandle& handle, size_t size) {
-      static_assert(std::is_base_of<CustomSpaceBase, CustomSpace>::value,
+      static_assert(std::is_base_of_v<CustomSpaceBase, CustomSpace>,
                     "Custom space must inherit from CustomSpaceBase.");
       static_assert(
           !CustomSpace::kSupportsCompaction,
@@ -111,7 +111,7 @@ class MakeGarbageCollectedTraitInternal {
                               api_constants::kDefaultAlignment>
       final {
     static void* Invoke(AllocationHandle& handle, size_t size) {
-      static_assert(std::is_base_of<CustomSpaceBase, CustomSpace>::value,
+      static_assert(std::is_base_of_v<CustomSpaceBase, CustomSpace>,
                     "Custom space must inherit from CustomSpaceBase.");
       return MakeGarbageCollectedTraitInternal::Allocate(
           handle, size, internal::GCInfoTrait<GCInfoType>::Index(),
@@ -164,7 +164,7 @@ class MakeGarbageCollectedTraitBase
    */
   V8_INLINE static void* Allocate(AllocationHandle& handle, size_t size) {
     static_assert(
-        std::is_base_of<typename T::ParentMostGarbageCollectedType, T>::value,
+        std::is_base_of_v<typename T::ParentMostGarbageCollectedType, T>,
         "U of GarbageCollected<U> must be a base of T. Check "
         "GarbageCollected<T> base class inheritance.");
     static constexpr size_t kWantedAlignment =

package/include/node/cppgc/cross-thread-persistent.h

@@ -102,20 +102,19 @@ class BasicCrossThreadPersistent final : public CrossThreadPersistentBase,
     // node.
   }
 
-  BasicCrossThreadPersistent(
-      const SourceLocation& loc = SourceLocation::Current())
+  BasicCrossThreadPersistent(SourceLocation loc = SourceLocation::Current())
       : LocationPolicy(loc) {}
 
-  BasicCrossThreadPersistent(
-      std::nullptr_t, const SourceLocation& loc = SourceLocation::Current())
+  BasicCrossThreadPersistent(std::nullptr_t,
+                             SourceLocation loc = SourceLocation::Current())
       : LocationPolicy(loc) {}
 
-  BasicCrossThreadPersistent(
-      SentinelPointer s, const SourceLocation& loc = SourceLocation::Current())
+  BasicCrossThreadPersistent(SentinelPointer s,
+                             SourceLocation loc = SourceLocation::Current())
       : CrossThreadPersistentBase(s), LocationPolicy(loc) {}
 
-  BasicCrossThreadPersistent(
-      T* raw, const SourceLocation& loc = SourceLocation::Current())
+  BasicCrossThreadPersistent(T* raw,
+                             SourceLocation loc = SourceLocation::Current())
       : CrossThreadPersistentBase(raw), LocationPolicy(loc) {
     if (!IsValid(raw)) return;
     PersistentRegionLock guard;
@@ -132,9 +131,8 @@ class BasicCrossThreadPersistent final : public CrossThreadPersistentBase,
     friend class BasicCrossThreadPersistent;
   };
 
-  BasicCrossThreadPersistent(
-      UnsafeCtorTag, T* raw,
-      const SourceLocation& loc = SourceLocation::Current())
+  BasicCrossThreadPersistent(UnsafeCtorTag, T* raw,
+                             SourceLocation loc = SourceLocation::Current())
       : CrossThreadPersistentBase(raw), LocationPolicy(loc) {
     if (!IsValid(raw)) return;
     CrossThreadPersistentRegion& region = this->GetPersistentRegion(raw);
@@ -142,24 +140,23 @@ class BasicCrossThreadPersistent final : public CrossThreadPersistentBase,
     this->CheckPointer(raw);
   }
 
-  BasicCrossThreadPersistent(
-      T& raw, const SourceLocation& loc = SourceLocation::Current())
+  BasicCrossThreadPersistent(T& raw,
+                             SourceLocation loc = SourceLocation::Current())
       : BasicCrossThreadPersistent(&raw, loc) {}
 
   template <typename U, typename MemberBarrierPolicy,
             typename MemberWeaknessTag, typename MemberCheckingPolicy,
             typename MemberStorageType,
-            typename = std::enable_if_t<std::is_base_of<T, U>::value>>
+            typename = std::enable_if_t<std::is_base_of_v<T, U>>>
   BasicCrossThreadPersistent(
       internal::BasicMember<U, MemberBarrierPolicy, MemberWeaknessTag,
                             MemberCheckingPolicy, MemberStorageType>
           member,
-      const SourceLocation& loc = SourceLocation::Current())
+      SourceLocation loc = SourceLocation::Current())
       : BasicCrossThreadPersistent(member.Get(), loc) {}
 
-  BasicCrossThreadPersistent(
-      const BasicCrossThreadPersistent& other,
-      const SourceLocation& loc = SourceLocation::Current())
+  BasicCrossThreadPersistent(const BasicCrossThreadPersistent& other,
+                             SourceLocation loc = SourceLocation::Current())
       : BasicCrossThreadPersistent(loc) {
     // Invoke operator=.
     *this = other;
@@ -168,19 +165,18 @@ class BasicCrossThreadPersistent final : public CrossThreadPersistentBase,
   // Heterogeneous ctor.
   template <typename U, typename OtherWeaknessPolicy,
             typename OtherLocationPolicy, typename OtherCheckingPolicy,
-            typename = std::enable_if_t<std::is_base_of<T, U>::value>>
-  BasicCrossThreadPersistent(
-      const BasicCrossThreadPersistent<U, OtherWeaknessPolicy,
-                                       OtherLocationPolicy,
-                                       OtherCheckingPolicy>& other,
-      const SourceLocation& loc = SourceLocation::Current())
+            typename = std::enable_if_t<std::is_base_of_v<T, U>>>
+  BasicCrossThreadPersistent(const BasicCrossThreadPersistent<
+                                 U, OtherWeaknessPolicy, OtherLocationPolicy,
+                                 OtherCheckingPolicy>& other,
+                             SourceLocation loc = SourceLocation::Current())
       : BasicCrossThreadPersistent(loc) {
     *this = other;
   }
 
   BasicCrossThreadPersistent(
       BasicCrossThreadPersistent&& other,
-      const SourceLocation& loc = SourceLocation::Current()) noexcept {
+      SourceLocation loc = SourceLocation::Current()) noexcept {
     // Invoke operator=.
     *this = std::move(other);
   }
@@ -194,7 +190,7 @@ class BasicCrossThreadPersistent final : public CrossThreadPersistentBase,
 
   template <typename U, typename OtherWeaknessPolicy,
             typename OtherLocationPolicy, typename OtherCheckingPolicy,
-            typename = std::enable_if_t<std::is_base_of<T, U>::value>>
+            typename = std::enable_if_t<std::is_base_of_v<T, U>>>
   BasicCrossThreadPersistent& operator=(
       const BasicCrossThreadPersistent<U, OtherWeaknessPolicy,
                                        OtherLocationPolicy,
@@ -232,7 +228,7 @@ class BasicCrossThreadPersistent final : public CrossThreadPersistentBase,
   template <typename U, typename MemberBarrierPolicy,
             typename MemberWeaknessTag, typename MemberCheckingPolicy,
             typename MemberStorageType,
-            typename = std::enable_if_t<std::is_base_of<T, U>::value>>
+            typename = std::enable_if_t<std::is_base_of_v<T, U>>>
   BasicCrossThreadPersistent& operator=(
       internal::BasicMember<U, MemberBarrierPolicy, MemberWeaknessTag,
                             MemberCheckingPolicy, MemberStorageType>
@@ -338,8 +334,8 @@ class BasicCrossThreadPersistent final : public CrossThreadPersistentBase,
   }
 
   template <typename U = T,
-            typename = typename std::enable_if<!BasicCrossThreadPersistent<
-                U, WeaknessPolicy>::IsStrongPersistent::value>::type>
+            typename = std::enable_if_t<!BasicCrossThreadPersistent<
+                U, WeaknessPolicy>::IsStrongPersistent::value>>
   BasicCrossThreadPersistent<U, internal::StrongCrossThreadPersistentPolicy>
   Lock() const {
     return BasicCrossThreadPersistent<

package/include/node/cppgc/internal/finalizer-trait.h

@@ -70,7 +70,7 @@ struct FinalizerTrait {
   // - a destructor.
   static constexpr bool kNonTrivialFinalizer =
       internal::HasFinalizeGarbageCollectedObject<T>::value ||
-      !std::is_trivially_destructible<typename std::remove_cv<T>::type>::value;
+      !std::is_trivially_destructible_v<std::remove_cv_t<T>>;
 
   static void Finalize(void* obj) {
     internal::FinalizerTraitImpl<T, kNonTrivialFinalizer>::Finalize(obj);

package/include/node/cppgc/internal/gc-info.h

@@ -108,10 +108,10 @@ struct GCInfoTrait final {
 template <typename T, typename ParentMostGarbageCollectedType>
 struct GCInfoFolding final {
   static constexpr bool kHasVirtualDestructorAtBase =
-      std::has_virtual_destructor<ParentMostGarbageCollectedType>::value;
+      std::has_virtual_destructor_v<ParentMostGarbageCollectedType>;
   static constexpr bool kBothTypesAreTriviallyDestructible =
-      std::is_trivially_destructible<ParentMostGarbageCollectedType>::value &&
-      std::is_trivially_destructible<T>::value;
+      std::is_trivially_destructible_v<ParentMostGarbageCollectedType> &&
+      std::is_trivially_destructible_v<T>;
   static constexpr bool kHasCustomFinalizerDispatchAtBase =
       internal::HasFinalizeGarbageCollectedObject<
           ParentMostGarbageCollectedType>::value;

package/include/node/cppgc/internal/logging.h

@@ -12,9 +12,9 @@ namespace cppgc {
 namespace internal {
 
 void V8_EXPORT DCheckImpl(const char*,
-                          const SourceLocation& = SourceLocation::Current());
+                          SourceLocation = SourceLocation::Current());
 [[noreturn]] void V8_EXPORT
-FatalImpl(const char*, const SourceLocation& = SourceLocation::Current());
+FatalImpl(const char*, SourceLocation = SourceLocation::Current());
 
 // Used to ignore -Wunused-variable.
 template <typename>

package/include/node/cppgc/internal/name-trait.h

@@ -80,7 +80,7 @@ class NameTrait final : public NameTraitBase {
 #elif CPPGC_SUPPORTS_OBJECT_NAMES
     return true;
 #else   // !CPPGC_SUPPORTS_OBJECT_NAMES
-    return std::is_base_of<NameProvider, T>::value;
+    return std::is_base_of_v<NameProvider, T>;
 #endif  // !CPPGC_SUPPORTS_OBJECT_NAMES
   }
 

package/include/node/cppgc/internal/pointer-policies.h

@@ -203,11 +203,11 @@ using DefaultCrossThreadPersistentCheckingPolicy = DisabledCheckingPolicy;
 
 class KeepLocationPolicy {
  public:
-  constexpr const SourceLocation& Location() const { return location_; }
+  constexpr SourceLocation Location() const { return location_; }
 
  protected:
   constexpr KeepLocationPolicy() = default;
-  constexpr explicit KeepLocationPolicy(const SourceLocation& location)
+  constexpr explicit KeepLocationPolicy(SourceLocation location)
       : location_(location) {}
 
   // KeepLocationPolicy must not copy underlying source locations.
@@ -228,7 +228,7 @@ class IgnoreLocationPolicy {
 
  protected:
   constexpr IgnoreLocationPolicy() = default;
-  constexpr explicit IgnoreLocationPolicy(const SourceLocation&) {}
+  constexpr explicit IgnoreLocationPolicy(SourceLocation) {}
 };
 
 #if CPPGC_SUPPORTS_OBJECT_NAMES

package/include/node/cppgc/member.h

@@ -20,6 +20,8 @@ namespace cppgc {
 
 namespace subtle {
 class HeapConsistency;
+template <typename, typename, typename>
+class TaggedUncompressedMember;
 }  // namespace subtle
 
 class Visitor;
@@ -163,7 +165,7 @@ class V8_TRIVIAL_ABI BasicMember final : private MemberBase<StorageType>,
   template <typename U, typename PersistentWeaknessPolicy,
             typename PersistentLocationPolicy,
             typename PersistentCheckingPolicy,
-            typename = std::enable_if_t<std::is_base_of<T, U>::value>>
+            typename = std::enable_if_t<std::is_base_of_v<T, U>>>
   V8_INLINE BasicMember(const BasicPersistent<U, PersistentWeaknessPolicy,
                                               PersistentLocationPolicy,
                                               PersistentCheckingPolicy>& p)
@@ -219,7 +221,7 @@ class V8_TRIVIAL_ABI BasicMember final : private MemberBase<StorageType>,
   template <typename U, typename PersistentWeaknessPolicy,
             typename PersistentLocationPolicy,
             typename PersistentCheckingPolicy,
-            typename = std::enable_if_t<std::is_base_of<T, U>::value>>
+            typename = std::enable_if_t<std::is_base_of_v<T, U>>>
   V8_INLINE BasicMember& operator=(
       const BasicPersistent<U, PersistentWeaknessPolicy,
                             PersistentLocationPolicy, PersistentCheckingPolicy>&
@@ -296,8 +298,10 @@ class V8_TRIVIAL_ABI BasicMember final : private MemberBase<StorageType>,
     return *this;
   }
 
-  V8_INLINE const T* GetRawAtomic() const {
-    return static_cast<const T*>(Base::GetRawAtomic());
+  V8_INLINE const void* GetRawAtomic() const { return Base::GetRawAtomic(); }
+
+  V8_INLINE const T* GetAtomic() const {
+    return static_cast<const T*>(GetRawAtomic());
   }
 
   V8_INLINE void InitializingWriteBarrier(T* value) const {
@@ -328,6 +332,8 @@ class V8_TRIVIAL_ABI BasicMember final : private MemberBase<StorageType>,
   V8_INLINE T* GetFromGC() const { return Get(); }
 
   friend class cppgc::subtle::HeapConsistency;
+  template <typename, typename, typename>
+  friend class cppgc::subtle::TaggedUncompressedMember;
   friend class cppgc::Visitor;
   template <typename U>
   friend struct cppgc::TraceTrait;

package/include/node/cppgc/persistent.h

@@ -58,20 +58,20 @@ class BasicPersistent final : public PersistentBase,
 
   // Null-state/sentinel constructors.
   BasicPersistent(  // NOLINT
-      const SourceLocation& loc = SourceLocation::Current())
+      SourceLocation loc = SourceLocation::Current())
       : LocationPolicy(loc) {}
 
   BasicPersistent(std::nullptr_t,  // NOLINT
-                  const SourceLocation& loc = SourceLocation::Current())
+                  SourceLocation loc = SourceLocation::Current())
       : LocationPolicy(loc) {}
 
   BasicPersistent(  // NOLINT
-      SentinelPointer s, const SourceLocation& loc = SourceLocation::Current())
+      SentinelPointer s, SourceLocation loc = SourceLocation::Current())
       : PersistentBase(s), LocationPolicy(loc) {}
 
   // Raw value constructors.
   BasicPersistent(T* raw,  // NOLINT
-                  const SourceLocation& loc = SourceLocation::Current())
+                  SourceLocation loc = SourceLocation::Current())
       : PersistentBase(raw), LocationPolicy(loc) {
     if (!IsValid()) return;
     SetNode(WeaknessPolicy::GetPersistentRegion(GetValue())
@@ -80,30 +80,29 @@ class BasicPersistent final : public PersistentBase,
   }
 
   BasicPersistent(T& raw,  // NOLINT
-                  const SourceLocation& loc = SourceLocation::Current())
+                  SourceLocation loc = SourceLocation::Current())
       : BasicPersistent(&raw, loc) {}
 
   // Copy ctor.
   BasicPersistent(const BasicPersistent& other,
-                  const SourceLocation& loc = SourceLocation::Current())
+                  SourceLocation loc = SourceLocation::Current())
       : BasicPersistent(other.Get(), loc) {}
 
   // Heterogeneous ctor.
   template <typename U, typename OtherWeaknessPolicy,
             typename OtherLocationPolicy, typename OtherCheckingPolicy,
-            typename = std::enable_if_t<std::is_base_of<T, U>::value>>
+            typename = std::enable_if_t<std::is_base_of_v<T, U>>>
   // NOLINTNEXTLINE
   BasicPersistent(
       const BasicPersistent<U, OtherWeaknessPolicy, OtherLocationPolicy,
                             OtherCheckingPolicy>& other,
-      const SourceLocation& loc = SourceLocation::Current())
+      SourceLocation loc = SourceLocation::Current())
       : BasicPersistent(other.Get(), loc) {}
 
   // Move ctor. The heterogeneous move ctor is not supported since e.g.
   // persistent can't reuse persistent node from weak persistent.
-  BasicPersistent(
-      BasicPersistent&& other,
-      const SourceLocation& loc = SourceLocation::Current()) noexcept
+  BasicPersistent(BasicPersistent&& other,
+                  SourceLocation loc = SourceLocation::Current()) noexcept
       : PersistentBase(std::move(other)), LocationPolicy(std::move(other)) {
     if (!IsValid()) return;
     GetNode()->UpdateOwner(this);
@@ -116,12 +115,12 @@ class BasicPersistent final : public PersistentBase,
   template <typename U, typename MemberBarrierPolicy,
             typename MemberWeaknessTag, typename MemberCheckingPolicy,
             typename MemberStorageType,
-            typename = std::enable_if_t<std::is_base_of<T, U>::value>>
+            typename = std::enable_if_t<std::is_base_of_v<T, U>>>
   // NOLINTNEXTLINE
   BasicPersistent(const internal::BasicMember<
                       U, MemberBarrierPolicy, MemberWeaknessTag,
                       MemberCheckingPolicy, MemberStorageType>& member,
-                  const SourceLocation& loc = SourceLocation::Current())
+                  SourceLocation loc = SourceLocation::Current())
       : BasicPersistent(member.Get(), loc) {}
 
   ~BasicPersistent() { Clear(); }
@@ -133,7 +132,7 @@ class BasicPersistent final : public PersistentBase,
 
   template <typename U, typename OtherWeaknessPolicy,
             typename OtherLocationPolicy, typename OtherCheckingPolicy,
-            typename = std::enable_if_t<std::is_base_of<T, U>::value>>
+            typename = std::enable_if_t<std::is_base_of_v<T, U>>>
   BasicPersistent& operator=(
       const BasicPersistent<U, OtherWeaknessPolicy, OtherLocationPolicy,
                             OtherCheckingPolicy>& other) {
@@ -158,7 +157,7 @@ class BasicPersistent final : public PersistentBase,
   template <typename U, typename MemberBarrierPolicy,
             typename MemberWeaknessTag, typename MemberCheckingPolicy,
             typename MemberStorageType,
-            typename = std::enable_if_t<std::is_base_of<T, U>::value>>
+            typename = std::enable_if_t<std::is_base_of_v<T, U>>>
   BasicPersistent& operator=(
       const internal::BasicMember<U, MemberBarrierPolicy, MemberWeaknessTag,
                                   MemberCheckingPolicy, MemberStorageType>&

package/include/node/cppgc/platform.h

@@ -165,7 +165,7 @@ V8_EXPORT void ShutdownProcess();
 namespace internal {
 
 V8_EXPORT void Fatal(const std::string& reason = std::string(),
-                     const SourceLocation& = SourceLocation::Current());
+                     SourceLocation = SourceLocation::Current());
 
 }  // namespace internal
 

package/include/node/cppgc/trace-trait.h

@@ -23,8 +23,7 @@ using TraceRootCallback = void (*)(RootVisitor&, const void* object);
 // Implementation of the default TraceTrait handling GarbageCollected and
 // GarbageCollectedMixin.
 template <typename T,
-          bool =
-              IsGarbageCollectedMixinTypeV<typename std::remove_const<T>::type>>
+          bool = IsGarbageCollectedMixinTypeV<std::remove_const_t<T>>>
 struct TraceTraitImpl;
 
 }  // namespace internal