node-fastify 5.8.3

package/test/500s.test.js

@@ -0,0 +1,422 @@
+'use strict'
+
+const { test } = require('node:test')
+const Fastify = require('..')
+const symbols = require('../lib/symbols.js')
+const { FastifyError } = require('@fastify/error')
+
+test('default 500', (t, done) => {
+  t.plan(4)
+
+  const fastify = Fastify()
+  t.after(() => fastify.close())
+
+  fastify.get('/', function (req, reply) {
+    reply.send(new Error('kaboom'))
+  })
+
+  fastify.inject({
+    method: 'GET',
+    url: '/'
+  }, (err, res) => {
+    t.assert.ifError(err)
+    t.assert.strictEqual(res.statusCode, 500)
+    t.assert.strictEqual(res.headers['content-type'], 'application/json; charset=utf-8')
+    t.assert.deepStrictEqual(JSON.parse(res.payload), {
+      error: 'Internal Server Error',
+      message: 'kaboom',
+      statusCode: 500
+    })
+    done()
+  })
+})
+
+test('default 500 with non-error string', (t, done) => {
+  t.plan(4)
+
+  const fastify = Fastify()
+  t.after(() => fastify.close())
+
+  fastify.get('/', function (req, reply) {
+    throw 'kaboom' // eslint-disable-line no-throw-literal
+  })
+
+  fastify.inject({
+    method: 'GET',
+    url: '/'
+  }, (err, res) => {
+    t.assert.ifError(err)
+    t.assert.strictEqual(res.statusCode, 500)
+    t.assert.strictEqual(res.headers['content-type'], 'text/plain; charset=utf-8')
+    t.assert.deepStrictEqual(res.payload, 'kaboom')
+    done()
+  })
+})
+
+test('default 500 with non-error symbol', (t, done) => {
+  t.plan(4)
+
+  const fastify = Fastify()
+  t.after(() => fastify.close())
+
+  fastify.get('/', function (req, reply) {
+    throw Symbol('error')
+  })
+
+  fastify.inject({
+    method: 'GET',
+    url: '/'
+  }, (err, res) => {
+    t.assert.ifError(err)
+    t.assert.strictEqual(res.statusCode, 500)
+    t.assert.strictEqual(res.headers['content-type'], 'application/json; charset=utf-8')
+    t.assert.deepStrictEqual(res.payload, '')
+    done()
+  })
+})
+
+test('default 500 with non-error false', (t, done) => {
+  t.plan(4)
+
+  const fastify = Fastify()
+  t.after(() => fastify.close())
+
+  fastify.get('/', function (req, reply) {
+    throw false // eslint-disable-line no-throw-literal
+  })
+
+  fastify.inject({
+    method: 'GET',
+    url: '/'
+  }, (err, res) => {
+    t.assert.ifError(err)
+    t.assert.strictEqual(res.statusCode, 500)
+    t.assert.strictEqual(res.headers['content-type'], 'application/json; charset=utf-8')
+    t.assert.deepStrictEqual(res.payload, 'false')
+    done()
+  })
+})
+
+test('default 500 with non-error null', (t, done) => {
+  t.plan(4)
+
+  const fastify = Fastify()
+  t.after(() => fastify.close())
+
+  fastify.get('/', function (req, reply) {
+    throw null // eslint-disable-line no-throw-literal
+  })
+
+  fastify.inject({
+    method: 'GET',
+    url: '/'
+  }, (err, res) => {
+    t.assert.ifError(err)
+    t.assert.strictEqual(res.statusCode, 500)
+    t.assert.strictEqual(res.headers['content-type'], 'application/json; charset=utf-8')
+    t.assert.deepStrictEqual(res.payload, 'null')
+    done()
+  })
+})
+
+test('custom 500', (t, done) => {
+  t.plan(6)
+
+  const fastify = Fastify()
+  t.after(() => fastify.close())
+
+  fastify.get('/', function (req, reply) {
+    reply.send(new Error('kaboom'))
+  })
+
+  fastify.setErrorHandler(function (err, request, reply) {
+    t.assert.ok(typeof request === 'object')
+    t.assert.ok(request instanceof fastify[symbols.kRequest].parent)
+    reply
+      .code(500)
+      .type('text/plain')
+      .send('an error happened: ' + err.message)
+  })
+
+  fastify.inject({
+    method: 'GET',
+    url: '/'
+  }, (err, res) => {
+    t.assert.ifError(err)
+    t.assert.strictEqual(res.statusCode, 500)
+    t.assert.strictEqual(res.headers['content-type'], 'text/plain')
+    t.assert.deepStrictEqual(res.payload.toString(), 'an error happened: kaboom')
+    done()
+  })
+})
+
+test('encapsulated 500', async t => {
+  t.plan(8)
+
+  const fastify = Fastify()
+  t.after(() => fastify.close())
+
+  fastify.get('/', function (req, reply) {
+    reply.send(new Error('kaboom'))
+  })
+
+  fastify.register(function (f, opts, done) {
+    f.get('/', function (req, reply) {
+      reply.send(new Error('kaboom'))
+    })
+
+    f.setErrorHandler(function (err, request, reply) {
+      t.assert.ok(typeof request === 'object')
+      t.assert.ok(request instanceof fastify[symbols.kRequest].parent)
+      reply
+        .code(500)
+        .type('text/plain')
+        .send('an error happened: ' + err.message)
+    })
+
+    done()
+  }, { prefix: 'test' })
+
+  {
+    const response = await fastify.inject({
+      method: 'GET',
+      url: '/test'
+    })
+
+    t.assert.strictEqual(response.statusCode, 500)
+    t.assert.strictEqual(response.headers['content-type'], 'text/plain')
+    t.assert.deepStrictEqual(response.payload.toString(), 'an error happened: kaboom')
+  }
+
+  {
+    const response = await fastify.inject({
+      method: 'GET',
+      url: '/'
+    })
+
+    t.assert.strictEqual(response.statusCode, 500)
+    t.assert.strictEqual(response.headers['content-type'], 'application/json; charset=utf-8')
+    t.assert.deepStrictEqual(JSON.parse(response.payload), {
+      error: 'Internal Server Error',
+      message: 'kaboom',
+      statusCode: 500
+    })
+  }
+})
+
+test('custom 500 with hooks', (t, done) => {
+  t.plan(7)
+
+  const fastify = Fastify()
+  t.after(() => fastify.close())
+
+  fastify.get('/', function (req, reply) {
+    reply.send(new Error('kaboom'))
+  })
+
+  fastify.setErrorHandler(function (err, request, reply) {
+    reply
+      .code(500)
+      .type('text/plain')
+      .send('an error happened: ' + err.message)
+  })
+
+  fastify.addHook('onSend', (req, res, payload, done) => {
+    t.assert.ok('called', 'onSend')
+    done()
+  })
+  fastify.addHook('onRequest', (req, res, done) => {
+    t.assert.ok('called', 'onRequest')
+    done()
+  })
+  fastify.addHook('onResponse', (request, reply, done) => {
+    t.assert.ok('called', 'onResponse')
+    done()
+  })
+
+  fastify.inject({
+    method: 'GET',
+    url: '/'
+  }, (err, res) => {
+    t.assert.ifError(err)
+    t.assert.strictEqual(res.statusCode, 500)
+    t.assert.strictEqual(res.headers['content-type'], 'text/plain')
+    t.assert.deepStrictEqual(res.payload.toString(), 'an error happened: kaboom')
+    done()
+  })
+})
+
+test('cannot set errorHandler after binding', (t, done) => {
+  t.plan(2)
+
+  const fastify = Fastify()
+  t.after(() => fastify.close())
+
+  fastify.listen({ port: 0 }, err => {
+    t.assert.ifError(err)
+
+    try {
+      fastify.setErrorHandler(() => { })
+      t.assert.fail()
+    } catch (e) {
+      t.assert.ok(true)
+    } finally {
+      done()
+    }
+  })
+})
+
+test('cannot set childLoggerFactory after binding', (t, done) => {
+  t.plan(2)
+
+  const fastify = Fastify()
+  t.after(() => fastify.close())
+
+  fastify.listen({ port: 0 }, err => {
+    t.assert.ifError(err)
+
+    try {
+      fastify.setChildLoggerFactory(() => { })
+      t.assert.fail()
+    } catch (e) {
+      t.assert.ok(true)
+    } finally {
+      done()
+    }
+  })
+})
+
+test('catch synchronous errors', (t, done) => {
+  t.plan(3)
+
+  const fastify = Fastify()
+  t.after(() => fastify.close())
+
+  fastify.setErrorHandler((_, req, reply) => {
+    throw new Error('kaboom2')
+  })
+
+  fastify.post('/', function (req, reply) {
+    reply.send(new Error('kaboom'))
+  })
+
+  fastify.inject({
+    method: 'POST',
+    url: '/',
+    headers: {
+      'Content-Type': 'application/json'
+    },
+    payload: JSON.stringify({ hello: 'world' }).substring(0, 5)
+  }, (err, res) => {
+    t.assert.ifError(err)
+    t.assert.strictEqual(res.statusCode, 500)
+    t.assert.deepStrictEqual(res.json(), {
+      error: 'Internal Server Error',
+      message: 'kaboom2',
+      statusCode: 500
+    })
+    done()
+  })
+})
+
+test('custom 500 with non-error and custom errorHandler', (t, done) => {
+  t.plan(6)
+
+  const fastify = Fastify()
+  t.after(() => fastify.close())
+
+  fastify.get('/', function (req, reply) {
+    throw 'kaboom' // eslint-disable-line no-throw-literal
+  })
+
+  fastify.setErrorHandler(function (err, request, reply) {
+    t.assert.ok(typeof request === 'object')
+    t.assert.ok(request instanceof fastify[symbols.kRequest].parent)
+    reply
+      .code(500)
+      .type('text/plain')
+      .send('an error happened: ' + err.message)
+  })
+
+  fastify.inject({
+    method: 'GET',
+    url: '/'
+  }, (err, res) => {
+    t.assert.ifError(err)
+    t.assert.strictEqual(res.statusCode, 500)
+    t.assert.strictEqual(res.headers['content-type'], 'text/plain')
+    t.assert.deepStrictEqual(res.payload, 'an error happened: undefined')
+    done()
+  })
+})
+
+test('custom 500 with FastifyError detection', (t, done) => {
+  t.plan(18)
+
+  const fastify = Fastify()
+  t.after(() => fastify.close())
+
+  fastify.get('/string', function (req, reply) {
+    throw 'kaboom' // eslint-disable-line no-throw-literal
+  })
+
+  fastify.get('/native-error', function (req, reply) {
+    throw new Error('kaboom')
+  })
+
+  fastify.get('/fastify-error', function (req, reply) {
+    throw new FastifyError('kaboom')
+  })
+
+  fastify.setErrorHandler(function (err, request, reply) {
+    t.assert.ok(typeof request === 'object')
+    t.assert.ok(request instanceof fastify[symbols.kRequest].parent)
+    if (err instanceof FastifyError) {
+      reply
+        .code(500)
+        .type('text/plain')
+        .send('FastifyError thrown')
+    } else if (err instanceof Error) {
+      reply
+        .code(500)
+        .type('text/plain')
+        .send('Error thrown')
+    } else {
+      reply
+        .code(500)
+        .type('text/plain')
+        .send('Primitive thrown')
+    }
+  })
+
+  fastify.inject({
+    method: 'GET',
+    url: '/string'
+  }, (err, res) => {
+    t.assert.ifError(err)
+    t.assert.strictEqual(res.statusCode, 500)
+    t.assert.strictEqual(res.headers['content-type'], 'text/plain')
+    t.assert.deepStrictEqual(res.payload, 'Primitive thrown')
+
+    fastify.inject({
+      method: 'GET',
+      url: '/native-error'
+    }, (err, res) => {
+      t.assert.ifError(err)
+      t.assert.strictEqual(res.statusCode, 500)
+      t.assert.strictEqual(res.headers['content-type'], 'text/plain')
+      t.assert.deepStrictEqual(res.payload, 'Error thrown')
+
+      fastify.inject({
+        method: 'GET',
+        url: '/fastify-error'
+      }, (err, res) => {
+        t.assert.ifError(err)
+        t.assert.strictEqual(res.statusCode, 500)
+        t.assert.strictEqual(res.headers['content-type'], 'text/plain')
+        t.assert.deepStrictEqual(res.payload, 'FastifyError thrown')
+        done()
+      })
+    })
+  })
+})

package/test/allow-unsafe-regex.test.js

@@ -0,0 +1,92 @@
+'use strict'
+
+const { test } = require('node:test')
+const Fastify = require('..')
+
+test('allow unsafe regex', async t => {
+  t.plan(2)
+
+  const fastify = Fastify({
+    allowUnsafeRegex: false
+  })
+  t.after(() => fastify.close())
+
+  fastify.get('/:foo(^[0-9]*$)', (req, reply) => {
+    reply.send({ foo: req.params.foo })
+  })
+
+  await fastify.listen({ port: 0 })
+
+  const result = await fetch(`http://localhost:${fastify.server.address().port}/1234`)
+  t.assert.strictEqual(result.status, 200)
+  t.assert.deepStrictEqual(await result.json(), { foo: '1234' })
+})
+
+test('allow unsafe regex not match', async t => {
+  t.plan(1)
+
+  const fastify = Fastify({
+    allowUnsafeRegex: false
+  })
+  t.after(() => fastify.close())
+
+  fastify.get('/:foo(^[0-9]*$)', (req, reply) => {
+    reply.send({ foo: req.params.foo })
+  })
+
+  await fastify.listen({ port: 0 })
+
+  const result = await fetch(`http://localhost:${fastify.server.address().port}/a1234`)
+  t.assert.strictEqual(result.status, 404)
+})
+
+test('allow unsafe regex not safe', (t, done) => {
+  t.plan(1)
+
+  const fastify = Fastify({
+    allowUnsafeRegex: false
+  })
+  t.after(() => fastify.close())
+
+  t.assert.throws(() => {
+    fastify.get('/:foo(^([0-9]+){4}$)', (req, reply) => {
+      reply.send({ foo: req.params.foo })
+    })
+  })
+  done()
+})
+
+test('allow unsafe regex not safe by default', (t, done) => {
+  t.plan(1)
+
+  const fastify = Fastify()
+  t.after(() => fastify.close())
+
+  t.assert.throws(() => {
+    fastify.get('/:foo(^([0-9]+){4}$)', (req, reply) => {
+      reply.send({ foo: req.params.foo })
+    })
+  })
+  done()
+})
+
+test('allow unsafe regex allow unsafe', async t => {
+  t.plan(3)
+
+  const fastify = Fastify({
+    allowUnsafeRegex: true
+  })
+  t.after(() => fastify.close())
+
+  t.assert.doesNotThrow(() => {
+    fastify.get('/:foo(^([0-9]+){4}$)', (req, reply) => {
+      reply.send({ foo: req.params.foo })
+    })
+  })
+
+  await fastify.listen({ port: 0 })
+
+  const result = await fetch(`http://localhost:${fastify.server.address().port}/1234`)
+  t.assert.strictEqual(result.status, 200)
+  t.assert.deepStrictEqual(await result.json(), { foo: '1234' })
+})

package/test/als.test.js

@@ -0,0 +1,65 @@
+'use strict'
+
+const { AsyncLocalStorage } = require('node:async_hooks')
+const { test } = require('node:test')
+const Fastify = require('..')
+
+test('Async Local Storage test', async (t) => {
+  t.plan(12)
+  if (!AsyncLocalStorage) {
+    t.skip('AsyncLocalStorage not available, skipping test')
+    process.exit(0)
+  }
+
+  const storage = new AsyncLocalStorage()
+  const app = Fastify({ logger: false })
+
+  t.after(() => app.close())
+
+  let counter = 0
+  app.addHook('onRequest', (req, reply, next) => {
+    const id = counter++
+    storage.run({ id }, next)
+  })
+
+  app.get('/', function (request, reply) {
+    t.assert.ok(storage.getStore())
+    const id = storage.getStore().id
+    reply.send({ id })
+  })
+
+  app.post('/', function (request, reply) {
+    t.assert.ok(storage.getStore())
+    const id = storage.getStore().id
+    reply.send({ id })
+  })
+
+  const fastifyServer = await app.listen({ port: 0 })
+
+  // First POST request
+  const result1 = await fetch(fastifyServer, {
+    method: 'POST',
+    headers: { 'Content-Type': 'application/json' },
+    body: JSON.stringify({ hello: 'world' })
+  })
+  t.assert.ok(result1.ok)
+  t.assert.strictEqual(result1.status, 200)
+  t.assert.deepStrictEqual(await result1.json(), { id: 0 })
+
+  const result2 = await fetch(fastifyServer, {
+    method: 'POST',
+    headers: { 'Content-Type': 'application/json' },
+    body: JSON.stringify({ hello: 'world' })
+  })
+  t.assert.ok(result2.ok)
+  t.assert.strictEqual(result2.status, 200)
+  t.assert.deepStrictEqual(await result2.json(), { id: 1 })
+
+  // GET request
+  const result3 = await fetch(fastifyServer, {
+    method: 'GET'
+  })
+  t.assert.ok(result3.ok)
+  t.assert.strictEqual(result3.status, 200)
+  t.assert.deepStrictEqual(await result3.json(), { id: 2 })
+})