node-datachannel 0.3.2 → 0.3.5

package/.github/workflows/build-linux-arm64-test.yml

@@ -0,0 +1,39 @@
+name: Build - Linux-Arm64
+
+on:
+  workflow_dispatch:
+  push:
+    tags:
+      - v*
+
+env:
+  ACTIONS_ALLOW_UNSECURE_COMMANDS: true
+
+jobs:
+  build-linux-arm64:
+    runs-on: ubuntu-20.04
+
+    strategy:
+      matrix:
+        node-version: [12.x, 13.x, 14.x, 15.x, 16.x, 17.x]
+    steps:
+      - uses: actions/checkout@v2
+      - name: Prepare Cross Compile
+        run: |
+          sudo apt update
+          sudo apt install -y g++-aarch64-linux-gnu gcc-aarch64-linux-gnu
+          mkdir sysroot && cd sysroot
+          wget https://commondatastorage.googleapis.com/chrome-linux-sysroot/toolchain/953c2471bc7e71a788309f6c2d2003e8b703305d/debian_sid_arm64_sysroot.tar.xz        
+          tar xf debian_sid_arm64_sysroot.tar.xz
+          echo "ARM64_SYSROOT=$(pwd)" >> $GITHUB_ENV
+          ls -l
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ matrix.node-version }}
+      - name: Build & Upload
+        run: |
+          npm install --ignore-scripts
+          node_modules/.bin/prebuild --backend cmake-js --arch arm64 --upload -u ${{ secrets.GITHUB_TOKEN }} -- --CDCMAKE_TOOLCHAIN_FILE:FILEPATH=./cmake/toolchain/arm64.cmake
+        env:
+          CI: true

package/.github/workflows/build-linux.yml

@@ -2,7 +2,7 @@ name: Build - Linux
 
 on:
   workflow_dispatch:
-  create:
+  push:
     tags:
       - v*
 
@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-20.04
     strategy:
       matrix:
-        node-version: [10.x, 11.x, 12.x, 13.x, 14.x, 15.x, 16.x, 17.x]
+        node-version: [10.x, 11.x, 12.x, 13.x, 14.x, 15.x, 16.x, 17.x, 18.x]
 
     steps:
       - uses: actions/checkout@v2
@@ -40,7 +40,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [10.x, 11.x, 12.x, 13.x, 14.x, 15.x, 16.x, 17.x]
+        node-version: [10.x, 11.x, 12.x, 13.x, 14.x, 15.x, 16.x, 17.x, 18.x]
     steps:
       - uses: actions/checkout@v2
       - name: Prepare Cross Compile
@@ -68,7 +68,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [10.x, 11.x, 12.x, 13.x, 14.x, 15.x, 16.x, 17.x]
+        node-version: [10.x, 11.x, 12.x, 13.x, 14.x, 15.x, 16.x, 17.x, 18.x]
     steps:
       - uses: actions/checkout@v2
       - name: Prepare Cross Compile

package/.github/workflows/build-mac-m1.yml

@@ -0,0 +1,41 @@
+name: Build - Mac M1
+
+on:
+  workflow_dispatch:
+  push:
+    tags:
+      - v*
+
+env:
+  ACTIONS_ALLOW_UNSECURE_COMMANDS: true
+
+jobs:
+  build-macos:
+    runs-on: macos-11
+    strategy:
+      matrix:
+        node-version: [ 16.x]
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Install OpenSSL
+        run: HOMEBREW_NO_INSTALL_CLEANUP=1 brew reinstall openssl@1.1
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ matrix.node-version }}
+          architecture: x64
+      - name: Build
+        run: npm install --build-from-source
+        env:
+          CI: true
+          OPENSSL_ROOT_DIR: /usr/local/opt/openssl
+          OPENSSL_LIBRARIES: /usr/local/opt/openssl/lib
+      - name: Test
+        run: npm run test
+        env:
+          CI: true
+      - name: Upload
+        run: node_modules/.bin/prebuild --upload -u ${{ secrets.GITHUB_TOKEN }}
+        env:
+          CI: true

package/.github/workflows/build-mac.yml

@@ -2,7 +2,7 @@ name: Build - Mac
 
 on:
   workflow_dispatch:
-  create:
+  push:
     tags:
       - v*
 
@@ -14,7 +14,7 @@ jobs:
     runs-on: macos-latest
     strategy:
       matrix:
-        node-version: [10.x, 11.x, 12.x, 13.x, 14.x, 15.x, 16.x, 17.x]
+        node-version: [10.x, 11.x, 12.x, 13.x, 14.x, 15.x, 16.x, 17.x, 18.x]
 
     steps:
       - uses: actions/checkout@v2

package/.github/workflows/build-win.yml

@@ -2,7 +2,7 @@ name: Build - Win
 
 on:
   workflow_dispatch:
-  create:
+  push:
     tags:
       - v*
 
@@ -14,7 +14,7 @@ jobs:
     runs-on: windows-2019
     strategy:
       matrix:
-        node-version: [10.x, 11.x, 12.x, 13.x, 14.x, 15.x, 16.x, 17.x]
+        node-version: [10.x, 11.x, 12.x, 13.x, 14.x, 15.x, 16.x, 17.x, 18.x]
 
     steps:
       - uses: actions/checkout@v2
@@ -42,7 +42,7 @@ jobs:
     runs-on: windows-2019
     strategy:
       matrix:
-        node_version: [10.x, 11.x, 12.x, 13.x, 14.x, 15.x, 16.x, 17.x]
+        node_version: [10.x, 11.x, 12.x, 13.x, 14.x, 15.x, 16.x, 17.x, 18.x]
         node_arch:
           - x86
     steps:

package/.github/workflows/lint.yml

@@ -1,10 +1,7 @@
 name: Lint
 
 on:
-  push:
-    branches: [ main ]
   pull_request:
-    branches: [ main ]
   workflow_dispatch:
 
 jobs:

package/API.md

@@ -0,0 +1,214 @@
+# API
+
+##  PeerConnection Class
+
+**Constructor**
+
+let pc = new PeerConnection(peerName[,options])
+- peerName `<string>` Peer name to use for logs etc..
+- options `<Object>` WebRTC Config Options
+```
+export interface RtcConfig {
+    iceServers: (string | IceServer)[];
+    proxyServer?: ProxyServer;
+    enableIceTcp?: boolean;
+    enableIceUdpMux?: boolean;
+    portRangeBegin?: number;
+    portRangeEnd?: number;
+    maxMessageSize?: number;
+    mtu?: number;
+    iceTransportPolicy?: TransportPolicy;
+}
+
+export const enum RelayType {
+    TurnUdp = 'TurnUdp',
+    TurnTcp = 'TurnTcp',
+    TurnTls = 'TurnTls'
+}
+
+export interface IceServer {
+    hostname: string;
+    port: number;
+    username?: string;
+    password?: string;
+    relayType?: RelayType;
+}
+
+export type TransportPolicy = 'all' | 'relay';
+
+"iceServers" option is an array of stun/turn server urls
+Examples;
+STUN Server Example          : stun:stun.l.google.com:19302
+TURN Server Example          : turn:USERNAME:PASSWORD@TURN_IP_OR_ADDRESS:PORT
+TURN Server Example (TCP)    : turn:USERNAME:PASSWORD@TURN_IP_OR_ADDRESS:PORT?transport=tcp
+TURN Server Example (TLS)    : turns:USERNAME:PASSWORD@TURN_IP_OR_ADDRESS:PORT
+
+```
+
+**close: () => void**
+
+Close Peer Connection
+
+**setRemoteDescription: (sdp: string, type: DescriptionType) => void**
+
+Set Remote Description
+```
+export const enum DescriptionType {
+    Unspec = 'Unspec',
+    Offer = 'Offer',
+    Answer = 'Answer'
+}
+```
+
+**addRemoteCandidate: (candidate: string, mid: string) => void**
+
+Add remote candidate info
+
+**createDataChannel: (label: string, config?: DataChannelInitConfig) => DataChannel**
+
+Create new data-channel
+* label `<string>` Data channel name
+* config `<Object>` Data channel options
+```
+export interface DataChannelInitConfig {
+    protocol?: string;
+    negotiated?: boolean;
+    id?: number;
+    ordered?: boolean;
+    maxPacketLifeTime?: number;
+    maxRetransmits?: number;
+
+    // Deprecated, use ordered, maxPacketLifeTime, and maxRetransmits
+    reliability?: {
+        type?: ReliabilityType;
+        unordered?: boolean;
+        rexmit?: number;
+    }
+}
+
+export const enum ReliabilityType {
+    Reliable = 0, Rexmit = 1, Timed = 2
+}
+```
+**state: () => string**
+
+Get current state
+
+**signalingState: () => string**
+
+Get current signaling state
+
+**gatheringState: () => string**
+
+Get current gathering state
+
+**onLocalDescription: (cb: (sdp: string, type: DescriptionType) => void) => void**
+
+Local Description Callback
+```
+export const enum DescriptionType {
+    Unspec = 'Unspec',
+    Offer = 'Offer',
+    Answer = 'Answer'
+}
+```
+
+**onLocalCandidate: (cb: (candidate: string, mid: string) => void) => void**
+
+Local Candidate Callback
+
+**onStateChange: (cb: (state: string) => void) => void**
+
+State Change Callback
+
+**onSignalingStateChange: (state: (sdp: string) => void) => void**
+
+Signaling State Change Callback
+
+**onGatheringStateChange: (state: (sdp: string) => void) => void**
+
+Gathering State Change Callback
+
+**onDataChannel: (cb: (dc: DataChannel) => void) => void**
+
+New Data Channel Callback
+
+**bytesSent: () => number**
+
+Get bytes sent stat
+
+**bytesReceived: () => number**
+
+Get bytes received stat
+
+**rtt: () => number**
+
+Get rtt stat
+
+**getSelectedCandidatePair: () => { local: SelectedCandidateInfo, remote: SelectedCandidateInfo }**
+
+Get info about selected candidate pair
+```
+export interface SelectedCandidateInfo {
+    address: string;
+    port: number;
+    type: string;
+    transportType: string;
+}
+```
+
+##  DataChannel Class
+
+> You can create a new Datachannel instance by calling `PeerConnection.createDataChannel` function.
+
+**close: () => void**
+
+Close data channel
+
+**getLabel: () => string**
+
+Get label of data-channel
+
+**sendMessage: (msg: string) => boolean**
+
+Send Message as string
+
+**sendMessageBinary: (buffer: Buffer) => boolean**
+
+Send Message as binary
+
+**isOpen: () => boolean**
+
+Query data-channel
+
+**bufferedAmount: () => number**
+
+Get current buffered amount level
+
+**maxMessageSize: () => number**
+
+Get max message size of the data-channel, that could be sent
+
+**setBufferedAmountLowThreshold: (newSize: number) => void**
+
+Set buffer level of the `onBufferedAmountLow` callback
+
+**onOpen: (cb: () => void) => void**
+
+Open callback
+
+**onClosed: (cb: () => void) => void**
+
+Closed callback
+
+**onError: (cb: (err: string) => void) => void**
+
+Error callback
+
+**onBufferedAmountLow: (cb: () => void) => void**
+
+Buffer level low callback
+
+**onMessage: (cb: (msg: string | Buffer) => void) => void**
+
+New Message callback

package/BULDING.md

@@ -0,0 +1,19 @@
+# Build
+
+## Requirements
+* cmake >= V3.14
+* [libdatachannel dependencies](https://github.com/paullouisageneau/libdatachannel/blob/master/README.md#dependencies)
+
+## Building from source
+
+```sh
+> git clone https://github.com/murat-dogan/node-datachannel.git
+> cd node-datachannel
+> npm i
+```
+
+Other Options
+```sh
+> npm run install -- -DUSE_GNUTLS=1  # Use GnuTLS instead of OpenSSL (Default False)
+> npm run install -- -DUSE_NICE=1    # Use libnice instead of libjuice (Default False)
+```

package/CMakeLists.txt

@@ -1,6 +1,6 @@
 cmake_minimum_required(VERSION 3.15)
 cmake_policy(SET CMP0091 NEW)
-project(node_datachannel VERSION 0.3.2)
+project(node_datachannel VERSION 0.3.5)
 
 # Workaround for https://github.com/murat-dogan/node-datachannel/issues/65
 if( NODE_RUNTIMEVERSION VERSION_GREATER_EQUAL "17.0.0")
@@ -33,7 +33,7 @@ include(FetchContent)
 FetchContent_Declare(
     libdatachannel
     GIT_REPOSITORY https://github.com/paullouisageneau/libdatachannel.git
-    GIT_TAG "v0.17.3"
+    GIT_TAG "v0.17.9"
 )
 
 option(NO_MEDIA "Disable media transport support in libdatachannel" OFF)
@@ -81,7 +81,8 @@ set(LINK_LIBRARIES
 )
 
 if(APPLE)
-  ###
+    SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -arch x86_64 -arch arm64 ")
+    SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_LINK_FLAGS} -arch x86_64 -arch arm64 ")
 elseif(UNIX)
     list(APPEND LINK_LIBRARIES -static-libgcc -static-libstdc++)
 endif()

package/README.md

@@ -6,17 +6,36 @@
 - Lightweight
   - No need to deal with WebRTC stack!
   - Small binary sizes
-- Has Prebuilt binaries (Linux,Windows,ARM)
 - Type infos for Typescript
 
-> "libdatachannel is a standalone implementation of WebRTC Data Channels, WebRTC Media Transport, and WebSockets in C++17 with C bindings for POSIX platforms (including GNU/Linux, Android, and Apple macOS) and Microsoft Windows. It enables direct connectivity between native applications and web browsers without the pain of importing the entire WebRTC stack. "
-
-
 This project is NodeJS bindings for [libdatachannel](https://github.com/paullouisageneau/libdatachannel) library.
 
 Please check [libdatachannel](https://github.com/paullouisageneau/libdatachannel) for Compatibility & WebRTC details.
 
+## Install
+
+```sh
+npm install node-datachannel
+```
+
+## Supported Platforms
+
+|          | Linux-x64 | Linux-armv7 | Linux-arm64(1)   | Windows-x86 | Windows-x64 | Mac |
+|----------|:---------:|:-----------:|:----------------:|:-----------:|:-----------:|:---:|
+| Node V10 |     +     |      +      |      +           |      +      |      +      |  +  |
+| Node V11 |     +     |      +      |      +           |      +      |      +      |  +  |
+| Node V12 |     +     |      +      |      +           |      +      |      +      |  +  |
+| Node V13 |     +     |      +      |      +           |      +      |      +      |  +  |
+| Node V14 |     +     |      +      |      +           |      +      |      +      |  +  |
+| Node V15 |     +     |      +      |      +           |      +      |      +      |  +  |
+| Node V16 |     +     |      +      |      +           |      +      |      +      |  +  |
+| Node V17 |     +     |      +      |      +           |      +      |      +      |  +  |
+
+1) Please note that; For arm64 platform we need OpenSSL to be installed locally.
+
+
 ## Example Usage
+
 ```js
 const nodeDataChannel = require('node-datachannel');
 
@@ -77,264 +96,26 @@ setTimeout(() => {
 }, 10 * 1000);
 ```
 
-> Please check examples/media folder for media usage example
-
-## Install
-
-Prebuilt binaries are available (Node Version >= 10);
-* Windows (x86, x64)
-* Linux (x64, armv7, arm64)
-* Mac
-
+## Test
 ```sh
-> npm install node-datachannel --save
-```
-
-## API
-
-###  PeerConnection Class
-
-**Constructor**
-
-let pc = new PeerConnection(peerName[,options])
-- peerName `<string>` Peer name to use for logs etc..
-- options `<Object>` WebRTC Config Options
-```
-export interface RtcConfig {
-    iceServers: (string | IceServer)[];
-    proxyServer?: ProxyServer;
-    enableIceTcp?: boolean;
-    portRangeBegin?: number;
-    portRangeEnd?: number;
-    maxMessageSize?: number;
-    iceTransportPolicy?: TransportPolicy;
-}
-
-export const enum RelayType {
-    TurnUdp = 'TurnUdp',
-    TurnTcp = 'TurnTcp',
-    TurnTls = 'TurnTls'
-}
-
-export interface IceServer {
-    hostname: string;
-    port: number;
-    username?: string;
-    password?: string;
-    relayType?: RelayType;
-}
-
-export type TransportPolicy = 'all' | 'relay';
-
-"iceServers" option is an array of stun/turn server urls
-Examples;
-STUN Server Example          : stun:stun.l.google.com:19302
-TURN Server Example          : turn:USERNAME:PASSWORD@TURN_IP_OR_ADDRESS:PORT
-TURN Server Example (TCP)    : turn:USERNAME:PASSWORD@TURN_IP_OR_ADDRESS:PORT?transport=tcp
-TURN Server Example (TLS)    : turns:USERNAME:PASSWORD@TURN_IP_OR_ADDRESS:PORT
-
-```
-
-**close: () => void**
-
-Close Peer Connection
-
-**setRemoteDescription: (sdp: string, type: DescriptionType) => void**
-
-Set Remote Description
-```
-export const enum DescriptionType {
-    Unspec = 'Unspec',
-    Offer = 'Offer',
-    Answer = 'Answer'
-}
-```
-
-**addRemoteCandidate: (candidate: string, mid: string) => void**
-
-Add remote candidate info
-
-**createDataChannel: (label: string, config?: DataChannelInitConfig) => DataChannel**
-
-Create new data-channel
-* label `<string>` Data channel name
-* config `<Object>` Data channel options
-```
-export interface DataChannelInitConfig {
-    protocol?: string;
-    negotiated?: boolean;
-    id?: number;
-    ordered?: boolean;
-    maxPacketLifeTime?: number;
-    maxRetransmits?: number;
-
-    // Deprecated, use ordered, maxPacketLifeTime, and maxRetransmits
-    reliability?: {
-        type?: ReliabilityType;
-        unordered?: boolean;
-        rexmit?: number;
-    }
-}
-
-export const enum ReliabilityType {
-    Reliable = 0, Rexmit = 1, Timed = 2
-}
-```
-**state: () => string**
-
-Get current state
-
-**signalingState: () => string**
-
-Get current signaling state
-
-**gatheringState: () => string**
-
-Get current gathering state
-
-**onLocalDescription: (cb: (sdp: string, type: DescriptionType) => void) => void**
-
-Local Description Callback
-```
-export const enum DescriptionType {
-    Unspec = 'Unspec',
-    Offer = 'Offer',
-    Answer = 'Answer'
-}
-```
-
-**onLocalCandidate: (cb: (candidate: string, mid: string) => void) => void**
-
-Local Candidate Callback
-
-**onStateChange: (cb: (state: string) => void) => void**
-
-State Change Callback
-
-**onSignalingStateChange: (state: (sdp: string) => void) => void**
-
-Signaling State Change Callback
-
-**onGatheringStateChange: (state: (sdp: string) => void) => void**
-
-Gathering State Change Callback
-
-**onDataChannel: (cb: (dc: DataChannel) => void) => void**
-
-New Data Channel Callback
-
-**bytesSent: () => number**
-
-Get bytes sent stat
-
-**bytesReceived: () => number**
-
-Get bytes received stat
-
-**rtt: () => number**
-
-Get rtt stat
-
-**getSelectedCandidatePair: () => { local: SelectedCandidateInfo, remote: SelectedCandidateInfo }**
-
-Get info about selected candidate pair
+npm run test                  # Unit tests
+node test/connectivity.js     # Connectivity
 ```
-export interface SelectedCandidateInfo {
-    address: string;
-    port: number;
-    type: string;
-    transportType: string;
-}
-```
-
-###  DataChannel Class
-
-> You can create a new Datachannel instance by calling `PeerConnection.createDataChannel` function.
-
-**close: () => void**
-
-Close data channel
-
-**getLabel: () => string**
-
-Get label of data-channel
-
-**sendMessage: (msg: string) => boolean**
-
-Send Message as string
-
-**sendMessageBinary: (buffer: Buffer) => boolean**
-
-Send Message as binary
-
-**isOpen: () => boolean**
 
-Query data-channel
-
-**bufferedAmount: () => number**
-
-Get current buffered amount level
-
-**maxMessageSize: () => number**
-
-Get max message size of the data-channel, that could be sent
-
-**setBufferedAmountLowThreshold: (newSize: number) => void**
-
-Set buffer level of the `onBufferedAmountLow` callback
-
-**onOpen: (cb: () => void) => void**
-
-Open callback
-
-**onClosed: (cb: () => void) => void**
-
-Closed callback
-
-**onError: (cb: (err: string) => void) => void**
-
-Error callback
-
-**onBufferedAmountLow: (cb: () => void) => void**
-
-Buffer level low callback
-
-**onMessage: (cb: (msg: string | Buffer) => void) => void**
-
-New Message callback
 
 ## Build
 
-### Requirements
-* cmake >= V3.14
-* [libdatachannel dependencies](https://github.com/paullouisageneau/libdatachannel/blob/master/README.md#dependencies)
-
-### Building from source
-
-```sh
-> git clone https://github.com/murat-dogan/node-datachannel.git
-> cd node-datachannel
-> npm i
-```
+Please check [here](/BULDING.md)
 
-Other Options
-```sh
-> npm run install -- -DUSE_GNUTLS=1  # Use GnuTLS instead of OpenSSL (Default False)
-> npm run install -- -DUSE_NICE=1    # Use libnice instead of libjuice (Default False)
-```
+## Examples
 
-### Test
-```sh
-> npm run test                  # Unit tests
-> node test/connectivity.js     # Connectivity
-```
+Please check [examples](/examples/) folder
 
-### More Examples
+## API Docs
 
-Check `examples` folder
+Please check [docs](/API.md) page
 
 ## Thanks
 
-
 Thanks to [Streamr](https://streamr.network/) for supporting this project by being a Sponsor!
 

package/lib/index.d.ts

@@ -50,18 +50,22 @@ export interface RtcConfig {
     iceServers: (string | IceServer)[];
     proxyServer?: ProxyServer;
     enableIceTcp?: boolean;
+    enableIceUdpMux?: boolean;
+    disableAutoNegotiation?: boolean;
     portRangeBegin?: number;
     portRangeEnd?: number;
     maxMessageSize?: number;
+    mtu?: number;
     iceTransportPolicy?: TransportPolicy;
 }
 
+// Lowercase to match the description type string from libdatachannel
 export const enum DescriptionType {
-    Unspec = 'Unspec',
-    Offer = 'Offer',
-    Answer = 'Answer',
-    Pranswer = 'Pranswer',
-    Rollback = 'Rollback',
+    Unspec = 'unspec',
+    Offer = 'offer',
+    Answer = 'answer',
+    Pranswer = 'pranswer',
+    Rollback = 'rollback',
 }
 
 export const enum ReliabilityType {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-datachannel",
-  "version": "0.3.2",
+  "version": "0.3.5",
   "description": "libdatachannel node bindings",
   "main": "lib/index.js",
   "typings": "lib/index.d.ts",

package/src/peer-connection-wrapper.cpp

@@ -4,6 +4,7 @@
 #include "media-video-wrapper.h"
 #include "media-audio-wrapper.h"
 
+#include <cctype>
 #include <sstream>
 
 Napi::FunctionReference PeerConnectionWrapper::constructor;
@@ -182,7 +183,11 @@ PeerConnectionWrapper::PeerConnectionWrapper(const Napi::CallbackInfo &info) : N
 
     // Max Message Size
     if (config.Get("maxMessageSize").IsNumber())
-        rtcConfig.maxMessageSize = config.Get("maxMessageSize").As<Napi::Number>().Uint32Value();
+        rtcConfig.maxMessageSize = config.Get("maxMessageSize").As<Napi::Number>().Int32Value();
+
+    // MTU
+    if (config.Get("mtu").IsNumber())
+        rtcConfig.mtu = config.Get("mtu").As<Napi::Number>().Int32Value();
 
     // ICE transport policy
     if (!config.Get("iceTransportPolicy").IsUndefined())
@@ -277,13 +282,17 @@ void PeerConnectionWrapper::setLocalDescription(const Napi::CallbackInfo &info)
         }
         std::string typeStr = info[0].As<Napi::String>().ToString();
 
-        if (typeStr == "Answer")
+        // Accept uppercase first letter for backward compatibility
+        if(typeStr.size() > 0)
+            typeStr[0] = std::tolower(typeStr[0]);
+
+        if (typeStr == "answer")
             type = rtc::Description::Type::Answer;
-        if (typeStr == "Offer")
+        else if (typeStr == "offer")
             type = rtc::Description::Type::Offer;
-        if (typeStr == "Pranswer")
+        else if (typeStr == "pranswer")
             type = rtc::Description::Type::Pranswer;
-        if (typeStr == "Rollback")
+        else if (typeStr == "rollback")
             type = rtc::Description::Type::Rollback;
     }