node-autotask 0.17.0 → 0.19.0

package/dist/{chunk-HC6YWPIY.js → chunk-LB2X4X4B.js}

@@ -1,6 +1,6 @@
 import {
   CAPABILITIES
-} from "./chunk-6SP6GJJR.js";
+} from "./chunk-NDK7WYWA.js";
 
 // src/auth.ts
 var AUTH_HEADERS = {
@@ -377,7 +377,8 @@ function parseVendorErrors(body) {
 var DETERMINISTIC_VENDOR_500_PHRASES = [
   /exceeds maximum length/i,
   /Missing Required Field/i,
-  /Value does not exist for the required field/i
+  /Value does not exist for the required field/i,
+  /Unable to find .+ in the .+ Entity\./i
 ];
 function isDeterministicVendor500(entries) {
   if (entries === void 0) return false;
@@ -1535,6 +1536,7 @@ var DEFAULT_TIMEOUT_MS = 3e4;
 var DEFAULT_MAX_RETRIES = 3;
 var DEFAULT_MAINTENANCE_MAX_WAIT_MS = 36e5;
 var DEFAULT_MAINTENANCE_POLL_MS = 3e4;
+var MAINTENANCE_WINDOW_MAX_MS = 4 * 36e5;
 var DEFAULT_MAX_CONCURRENT = 10;
 var DEFAULT_MAX_RESPONSE_BYTES = 64 * 1024 * 1024;
 var DEFAULT_MAX_SCAN_RECORDS = 500;
@@ -14689,12 +14691,26 @@ function normalizeZoneBase(raw) {
   if (url.protocol !== "http:" && url.protocol !== "https:") return void 0;
   return `${url.origin}${url.pathname.replace(/\/+$/, "")}`;
 }
-function buildQueryRequest(baseUrl, resourcePath, params) {
-  const queryPath = `${resourcePath}/query`;
+function buildQueryBody(params) {
   const conditions = normalizedConditions(params.filter);
   const filter = conditions === void 0 ? void 0 : buildFilter(conditions);
-  const includeFields = params.includeFields === void 0 ? void 0 : params.includeFields.includes("id") ? params.includeFields : [...params.includeFields, "id"];
+  const includeFields = effectiveIncludeFields(params);
+  const body = {};
+  if (params.maxRecords !== void 0) body.MaxRecords = params.maxRecords;
+  if (includeFields !== void 0) body.IncludeFields = includeFields;
+  body.filter = filter === void 0 ? [] : filter.filter;
+  return body;
+}
+function effectiveIncludeFields(params) {
+  if (params.includeFields === void 0) return void 0;
+  return params.includeFields.includes("id") ? params.includeFields : [...params.includeFields, "id"];
+}
+function buildQueryRequest(baseUrl, resourcePath, params) {
+  const queryPath = `${resourcePath}/query`;
   if (params.via === "get") {
+    const conditions = normalizedConditions(params.filter);
+    const filter = conditions === void 0 ? void 0 : buildFilter(conditions);
+    const includeFields = effectiveIncludeFields(params);
     const search = {};
     if (filter !== void 0) search.filter = filter.filter;
     if (params.maxRecords !== void 0) search.maxRecords = params.maxRecords;
@@ -14712,11 +14728,7 @@ function buildQueryRequest(baseUrl, resourcePath, params) {
     }
     return req;
   }
-  const body = {};
-  if (params.maxRecords !== void 0) body.MaxRecords = params.maxRecords;
-  if (includeFields !== void 0) body.IncludeFields = includeFields;
-  body.filter = filter === void 0 ? [] : filter.filter;
-  return { method: "POST", path: queryPath, body, idempotent: true };
+  return { method: "POST", path: queryPath, body: buildQueryBody(params), idempotent: true };
 }
 var ambientSignal = new AsyncLocalStorage();
 function runWithSignal(signal, fn) {
@@ -14768,9 +14780,21 @@ function backoffDelay(attempt) {
   const exp = Math.min(BACKOFF_CAP_MS, BACKOFF_BASE_MS * 2 ** attempt);
   return Math.floor(exp / 2 + Math.random() * (exp / 2));
 }
-function isMaintenancePage(err) {
-  const snippet = typeof err.details?.bodySnippet === "string" ? err.details.bodySnippet : "";
-  return /maintenance|temporarily unavailable|service unavailable|outage|downtime|down for/i.test(snippet);
+var MAINTENANCE_PROBE_BYTES = 256;
+function maintenanceProbe(text) {
+  return Buffer.from(text, "utf8").subarray(0, MAINTENANCE_PROBE_BYTES).toString("utf8");
+}
+function looksLikeMaintenanceText(text) {
+  return /maintenance|temporarily unavailable|service unavailable|outage|downtime|down for/i.test(
+    maintenanceProbe(text)
+  );
+}
+function isHtmlLike(contentType, body) {
+  if (contentType !== null && /text\/html|application\/xhtml/i.test(contentType)) return true;
+  return body.trimStart().startsWith("<");
+}
+function maintenanceExhaustedAction(maxWaitMs, waits) {
+  return `The zone stayed in a maintenance window for ${Math.round(maxWaitMs / 6e4)} min \u2014 the SDK waited and retried ${waits} time(s) and gave up. Re-run after the window (the observed median is about 2 h; the ceiling is 4 h \u2014 MAINTENANCE_WINDOW_MAX_MS), or raise maintenanceMaxWaitMs.`;
 }
 function parseRetryAfter(value) {
   if (value === null || value.length === 0) return void 0;
@@ -15206,6 +15230,7 @@ var HttpClient = class {
     const maintenancePollMs = opts.maintenancePollMs ?? this.maintenancePollMs;
     let firstMaintenanceAt;
     let maintenanceWaits = 0;
+    let maintenanceBudgetSpent = false;
     const started = Date.now();
     let deadlineAt = started + timeoutMs;
     const callerSignal = opts.signal ?? ambientSignal.getStore();
@@ -15426,12 +15451,13 @@ var HttpClient = class {
               httpStatus: status,
               suggestedAction: "The zone returned a non-JSON 2xx body; verify baseUrl points at the REST API."
             });
-            if (err2.code === "UNEXPECTED_CONTENT_TYPE" && maintenanceMaxWaitMs > 0 && isMaintenancePage(err2)) {
+            if (err2.code === "UNEXPECTED_CONTENT_TYPE" && maintenanceMaxWaitMs > 0 && looksLikeMaintenanceText(text)) {
               const now = Date.now();
               firstMaintenanceAt ??= now;
               const remaining = maintenanceMaxWaitMs - (now - firstMaintenanceAt);
               if (remaining > 0) {
                 const wait = Math.min(maintenancePollMs, remaining);
+                if (wait >= remaining) maintenanceBudgetSpent = true;
                 maintenanceWaits += 1;
                 this.logger.warn?.(
                   `[autotask] maintenance window on ${method} ${opts.path}; waiting ${Math.round(wait / 1e3)}s (retry ${maintenanceWaits}, up to ${Math.round(maintenanceMaxWaitMs / 6e4)} min)`,
@@ -15442,6 +15468,7 @@ var HttpClient = class {
                 await pause(wait);
                 continue;
               }
+              maintenanceBudgetSpent = true;
             }
             if (err2.code === "UNEXPECTED_CONTENT_TYPE" && retriable5xx && attempt < maxRetries) {
               const retryAfter = parseRetryAfter(res.headers.get("Retry-After"));
@@ -15456,17 +15483,27 @@ var HttpClient = class {
                 continue;
               }
             }
-            if (maintenanceWaits > 0 && err2.code === "UNEXPECTED_CONTENT_TYPE") {
+            const pageSnippet = typeof err2.details?.bodySnippet === "string" ? err2.details.bodySnippet : "";
+            if (maintenanceWaits > 0) {
               err2.details = {
                 ...err2.details ?? {},
                 maintenance: {
                   waits: maintenanceWaits,
                   waitedMs: Date.now() - (firstMaintenanceAt ?? Date.now()),
                   maxWaitMs: maintenanceMaxWaitMs,
-                  exhausted: true
+                  exhausted: maintenanceBudgetSpent
                 }
               };
-              err2.suggestedAction = `The zone stayed in a maintenance window for ${Math.round(maintenanceMaxWaitMs / 6e4)} min \u2014 the SDK waited and retried ${maintenanceWaits} time(s) and gave up. Re-run after the window (typically under 30 min), or raise maintenanceMaxWaitMs.`;
+              if (maintenanceBudgetSpent) {
+                err2.suggestedAction = maintenanceExhaustedAction(maintenanceMaxWaitMs, maintenanceWaits);
+              }
+            }
+            if (err2.code === "UNEXPECTED_CONTENT_TYPE" && !looksLikeMaintenanceText(text) && isHtmlLike(res.headers.get("Content-Type"), text)) {
+              err2.details = { ...err2.details ?? {}, maintenancePatternMiss: true };
+              this.logger.debug?.(
+                `[autotask] non-JSON body did not match the maintenance vocabulary on ${method} ${opts.path}: ${pageSnippet}`,
+                correlationId
+              );
             }
             attachEmptyReasonDetails(err2);
             throw err2;
@@ -15478,12 +15515,37 @@ var HttpClient = class {
           break;
         }
         let body;
+        let nonJsonBody;
         if (text.length > 0) {
           try {
             body = JSON.parse(text);
           } catch {
             body = text;
+            nonJsonBody = text;
+          }
+        }
+        const nonJsonSnippet = nonJsonBody === void 0 ? void 0 : bodySnippet(nonJsonBody, this.redactPersonalData);
+        const nonJsonIsMaintenance = nonJsonBody !== void 0 && looksLikeMaintenanceText(nonJsonBody);
+        const nonJsonIsHtmlCandidate = nonJsonBody !== void 0 && isHtmlLike(res.headers.get("Content-Type"), nonJsonBody);
+        const nonJsonMaintenanceMayWait = nonJsonIsMaintenance && retriable5xx;
+        if (nonJsonBody !== void 0 && maintenanceMaxWaitMs > 0 && nonJsonMaintenanceMayWait) {
+          const now = Date.now();
+          firstMaintenanceAt ??= now;
+          const remaining = maintenanceMaxWaitMs - (now - firstMaintenanceAt);
+          if (remaining > 0) {
+            const wait = Math.min(maintenancePollMs, remaining);
+            if (wait >= remaining) maintenanceBudgetSpent = true;
+            maintenanceWaits += 1;
+            this.logger.warn?.(
+              `[autotask] maintenance window on ${method} ${opts.path} (HTTP ${status}); waiting ${Math.round(wait / 1e3)}s (retry ${maintenanceWaits}, up to ${Math.round(maintenanceMaxWaitMs / 6e4)} min)`,
+              correlationId
+            );
+            deadlineAt = Date.now() + wait + timeoutMs;
+            armDeadline(deadlineAt - Date.now());
+            await pause(wait);
+            continue;
           }
+          maintenanceBudgetSpent = true;
         }
         const deterministic500 = status >= 500 && isDeterministicVendor500(parseVendorErrors(body));
         const retryableStatus = status === 429 || status >= 500;
@@ -15526,6 +15588,32 @@ var HttpClient = class {
           credentialShapeExpectation(headers, this.auth)
         );
         err.correlationId = correlationId;
+        if (maintenanceWaits > 0) {
+          err.details = {
+            ...err.details ?? {},
+            maintenance: {
+              waits: maintenanceWaits,
+              waitedMs: Date.now() - (firstMaintenanceAt ?? Date.now()),
+              maxWaitMs: maintenanceMaxWaitMs,
+              exhausted: maintenanceBudgetSpent
+            }
+          };
+          if (maintenanceBudgetSpent) {
+            err.suggestedAction = maintenanceExhaustedAction(maintenanceMaxWaitMs, maintenanceWaits);
+          }
+        }
+        if (nonJsonBody !== void 0) {
+          if (nonJsonIsMaintenance && !retriable5xx) {
+            err.details = { ...err.details ?? {}, maintenanceDetected: true };
+            err.suggestedAction = `A maintenance-shaped page answered ${method} ${opts.path} (HTTP ${status}); it was NOT waited out or re-sent \u2014 a non-2xx edge page can arrive after the request was forwarded, so verify the record before re-issuing (only a GET or an explicitly idempotent-flagged call waits this window out).`;
+          } else if (!nonJsonIsMaintenance && nonJsonIsHtmlCandidate) {
+            err.details = { ...err.details ?? {}, maintenancePatternMiss: true };
+            this.logger.debug?.(
+              `[autotask] non-JSON body did not match the maintenance vocabulary on ${method} ${opts.path}: ${nonJsonSnippet}`,
+              correlationId
+            );
+          }
+        }
         if (status === 401 && zoneRetry !== void 0) {
           err.details = {
             ...err.details ?? {},
@@ -15982,6 +16070,7 @@ function applyFieldsFilter(projected, filter, row) {
   if (filter !== void 0) {
     const present = new Set(projected.map((f) => f.name));
     row.unmatchedFields = filter.filter((n) => !present.has(n));
+    row.projected = true;
   }
   row.fields = kept;
   row.required = kept.filter((f) => f.isRequired).map((f) => f.name);
@@ -17042,7 +17131,7 @@ var BaseResource = class {
   // ------------------------------------------------------------------
   // Query walk (wired to the G3 walker; cursor-follow per the pinned wire)
   // ------------------------------------------------------------------
-  /** One page fetch: page 1 POSTs the QueryModel body; later pages POST the filter to the absolute cursor. */
+  /** One page fetch: page 1 POSTs the QueryModel body; later pages POST the same body (`buildQueryBody`) to the absolute cursor (issue #118). */
   async fetchPage(params, page, pageSize, state) {
     const operation = `${this.config.key}.query`;
     if (page === 1) {
@@ -17058,8 +17147,7 @@ var BaseResource = class {
         operation
       });
     }
-    const conditions = normalizedConditions(params.filter);
-    const body = { filter: conditions === void 0 ? [] : buildFilter(conditions).filter };
+    const body = buildQueryBody({ ...params, maxRecords: pageSize });
     const res = await this.http.request({
       method: "POST",
       path: cursorToPath(this.http.baseUrl, cursor),
@@ -17112,10 +17200,12 @@ var BaseResource = class {
    * complete-enough result. The client never owns the walk:
    * - `limit` = total records (default 500, hard max 2500 — above it throws
    *   AutotaskConfigError; it is NOT a page size). The page-1 request uses
-   *   the internal page size min(500, limit); follow-up pages POST the
-   *   preserved filter to the absolute cursor verbatim (the pinned wire:
-   *   MaxRecords/IncludeFields are baked into the cursor — never changed
-   *   mid-walk), so the walk reuses `fetchPage` (the shared cursor machinery)
+   *   the internal page size min(500, limit) (the `latest` mechanism sizes
+   *   its walk from the matching count); every follow-up page POSTs the
+   *   SAME QueryModel body (`buildQueryBody`: MaxRecords, IncludeFields and
+   *   the preserved filter) to the absolute cursor (issue #118 — the vendor
+   *   honours IncludeFields there and ignores MaxRecords, serving its own
+   *   page size), so the walk reuses `fetchPage` (the shared cursor machinery)
    *   with a per-walk closure state (walks never share state).
    * - The 1000-page guard still applies as a SOFT stop: a walk that would
    *   fetch a 1001st page stops with `hasMore: true` (never a throw — this
@@ -18689,6 +18779,7 @@ export {
   DEFAULT_MAX_RETRIES,
   DEFAULT_MAINTENANCE_MAX_WAIT_MS,
   DEFAULT_MAINTENANCE_POLL_MS,
+  MAINTENANCE_WINDOW_MAX_MS,
   DEFAULT_MAX_CONCURRENT,
   DEFAULT_MAX_RESPONSE_BYTES,
   DEFAULT_MAX_SCAN_RECORDS,
@@ -18734,6 +18825,7 @@ export {
   IDEMPOTENT_METHODS,
   buildUrl,
   cursorToPath,
+  buildQueryBody,
   buildQueryRequest,
   runWithSignal,
   HttpClient,