node-aix-ppc64 22.9.0 → 23.0.0

package/README.md

@@ -81,8 +81,10 @@ directory contains the latest Hydrogen (Node.js 18) release.
 
 <https://nodejs.org/download/nightly/>
 
-Each directory name and filename contains a date (in UTC) and the commit
-SHA at the HEAD of the release.
+Each directory and filename includes the version (e.g., `v22.0.0`),
+followed by the UTC date (e.g., `20240424` for April 24, 2024),
+and the short commit SHA of the HEAD of the release (e.g., `ddd0a9e494`).
+For instance, a full directory name might look like `v22.0.0-nightly20240424ddd0a9e494`.
 
 #### API documentation
 
@@ -282,6 +284,8 @@ For information about the governance of the Node.js project, see
 
 ### Collaborators
 
+* [abmusse](https://github.com/abmusse) -
+  **Abdirahim Musse** <<abdirahim.musse@ibm.com>>
 * [addaleax](https://github.com/addaleax) -
   **Anna Henningsen** <<anna@addaleax.net>> (she/her)
 * [aduh95](https://github.com/aduh95) -
@@ -358,8 +362,6 @@ For information about the governance of the Node.js project, see
   **James M Snell** <<jasnell@gmail.com>> (he/him)
 * [jkrems](https://github.com/jkrems) -
   **Jan Krems** <<jan.krems@gmail.com>> (he/him)
-* [joesepi](https://github.com/joesepi) -
-  **Joe Sepi** <<sepi@joesepi.com>> (he/him)
 * [joyeecheung](https://github.com/joyeecheung) -
   **Joyee Cheung** <<joyeec9h3@gmail.com>> (she/her)
 * [juanarbol](https://github.com/juanarbol) -
@@ -408,6 +410,8 @@ For information about the governance of the Node.js project, see
   **Filip Skokan** <<panva.ip@gmail.com>> (he/him)
 * [pimterry](https://github.com/pimterry) -
   **Tim Perry** <<pimterry@gmail.com>> (he/him)
+* [pmarchini](https://github.com/pmarchini)
+  **Pietro Marchini** <<pietro.marchini94@gmail.com>> (he/him)
 * [Qard](https://github.com/Qard) -
   **Stephen Belanger** <<admin@stephenbelanger.com>> (he/him)
 * [RafaelGSS](https://github.com/RafaelGSS) -
@@ -562,6 +566,8 @@ For information about the governance of the Node.js project, see
   **Yuval Brik** <<yuval@brik.org.il>>
 * [joaocgreis](https://github.com/joaocgreis) -
   **João Reis** <<reis@janeasystems.com>>
+* [joesepi](https://github.com/joesepi) -
+  **Joe Sepi** <<sepi@joesepi.com>> (he/him)
 * [joshgav](https://github.com/joshgav) -
   **Josh Gavant** <<josh.gavant@outlook.com>>
 * [julianduque](https://github.com/julianduque) -
@@ -762,6 +768,8 @@ responding to new issues.
 
 Primary GPG keys for Node.js Releasers (some Releasers sign with subkeys):
 
+* **Antoine du Hamel** <<duhamelantoine1995@gmail.com>>
+  `C0D6248439F1D5604AAFFB4021D900FFDB233756`
 * **Beth Griggs** <<bethanyngriggs@gmail.com>>
   `4ED778F539E3634C779C87C6D7062848A1AB005C`
 * **Bryan English** <<bryan@bryanenglish.com>>
@@ -787,6 +795,7 @@ To import the full set of trusted release keys (including subkeys possibly used
 to sign releases):
 
 ```bash
+gpg --keyserver hkps://keys.openpgp.org --recv-keys C0D6248439F1D5604AAFFB4021D900FFDB233756 # Antoine du Hamel
 gpg --keyserver hkps://keys.openpgp.org --recv-keys 4ED778F539E3634C779C87C6D7062848A1AB005C # Beth Griggs
 gpg --keyserver hkps://keys.openpgp.org --recv-keys 141F07595B7B3FFE74309A937405533BE57C7D57 # Bryan English
 gpg --keyserver hkps://keys.openpgp.org --recv-keys 74F12602B6F1C4E913FAA37AD3A89613643B6201 # Danielle Adams

package/include/node/common.gypi

@@ -36,7 +36,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.19',
+    'v8_embedder_string': '-node.10',
 
     ##### V8 defaults for Node.js #####
 
@@ -493,7 +493,7 @@
           '-fno-rtti',
           '-fno-exceptions',
           '-fno-strict-aliasing',
-          '-std=gnu++17',
+          '-std=gnu++20',
         ],
         'defines': [ '__STDC_FORMAT_MACROS' ],
         'ldflags': [ '-rdynamic' ],
@@ -663,7 +663,7 @@
           ['clang==1', {
             'xcode_settings': {
               'GCC_VERSION': 'com.apple.compilers.llvm.clang.1_0',
-              'CLANG_CXX_LANGUAGE_STANDARD': 'gnu++17',  # -std=gnu++17
+              'CLANG_CXX_LANGUAGE_STANDARD': 'gnu++20',  # -std=gnu++20
               'CLANG_CXX_LIBRARY': 'libc++',
             },
           }],

package/include/node/config.gypi

@@ -165,7 +165,6 @@
                                          'lib/internal/http2/compat.js',
                                          'lib/internal/http2/core.js',
                                          'lib/internal/http2/util.js',
-                                         'lib/internal/idna.js',
                                          'lib/internal/inspector_async_hook.js',
                                          'lib/internal/inspector_network_tracking.js',
                                          'lib/internal/js_stream_socket.js',
@@ -235,6 +234,7 @@
                                          'lib/internal/process/worker_thread_only.js',
                                          'lib/internal/promise_hooks.js',
                                          'lib/internal/querystring.js',
+                                         'lib/internal/quic/quic.js',
                                          'lib/internal/readline/callbacks.js',
                                          'lib/internal/readline/emitKeypressEvents.js',
                                          'lib/internal/readline/interface.js',
@@ -363,7 +363,7 @@
                                          'lib/wasi.js',
                                          'lib/worker_threads.js',
                                          'lib/zlib.js'],
-                 'node_module_version': 127,
+                 'node_module_version': 131,
                  'node_no_browser_globals': 'false',
                  'node_prefix': '/',
                  'node_release_urlbase': 'https://nodejs.org/download/release/',
@@ -396,7 +396,7 @@
                  'openssl_is_fips': 'false',
                  'openssl_quic': 'true',
                  'ossfuzz': 'false',
-                 'shlib_suffix': '127.a',
+                 'shlib_suffix': '131.a',
                  'single_executable_application': 'true',
                  'target_arch': 'ppc64',
                  'ubsan': 0,

package/include/node/cppgc/allocation.h

@@ -47,7 +47,7 @@ namespace internal {
 // Similar to C++17 std::align_val_t;
 enum class AlignVal : size_t {};
 
-class V8_EXPORT MakeGarbageCollectedTraitInternal {
+class MakeGarbageCollectedTraitInternal {
  protected:
   static inline void MarkObjectAsFullyConstructed(const void* payload) {
     // See api_constants for an explanation of the constants.
@@ -121,16 +121,15 @@ class V8_EXPORT MakeGarbageCollectedTraitInternal {
   };
 
  private:
-  static void* CPPGC_DEFAULT_ALIGNED Allocate(cppgc::AllocationHandle&, size_t,
-                                              GCInfoIndex);
-  static void* CPPGC_DOUBLE_WORD_ALIGNED Allocate(cppgc::AllocationHandle&,
-                                                  size_t, AlignVal,
-                                                  GCInfoIndex);
-  static void* CPPGC_DEFAULT_ALIGNED Allocate(cppgc::AllocationHandle&, size_t,
-                                              GCInfoIndex, CustomSpaceIndex);
-  static void* CPPGC_DOUBLE_WORD_ALIGNED Allocate(cppgc::AllocationHandle&,
-                                                  size_t, AlignVal, GCInfoIndex,
-                                                  CustomSpaceIndex);
+  V8_EXPORT static void* CPPGC_DEFAULT_ALIGNED
+  Allocate(cppgc::AllocationHandle&, size_t, GCInfoIndex);
+  V8_EXPORT static void* CPPGC_DOUBLE_WORD_ALIGNED
+  Allocate(cppgc::AllocationHandle&, size_t, AlignVal, GCInfoIndex);
+  V8_EXPORT static void* CPPGC_DEFAULT_ALIGNED
+  Allocate(cppgc::AllocationHandle&, size_t, GCInfoIndex, CustomSpaceIndex);
+  V8_EXPORT static void* CPPGC_DOUBLE_WORD_ALIGNED
+  Allocate(cppgc::AllocationHandle&, size_t, AlignVal, GCInfoIndex,
+           CustomSpaceIndex);
 
   friend class HeapObjectHeader;
 };

package/include/node/cppgc/garbage-collected.h

@@ -94,6 +94,14 @@ class GarbageCollectedMixin {
  public:
   using IsGarbageCollectedMixinTypeMarker = void;
 
+  // Must use MakeGarbageCollected.
+  void* operator new(size_t) = delete;
+  void* operator new[](size_t) = delete;
+  // The garbage collector is taking care of reclaiming the object.
+  // Not override the non-array varaint of `delete` to not conflict with the
+  // operator in GarbageCollected above.
+  void operator delete[](void*) = delete;
+
   /**
    * This Trace method must be overriden by objects inheriting from
    * GarbageCollectedMixin.

package/include/node/cppgc/heap-statistics.h

@@ -102,6 +102,8 @@ struct HeapStatistics final {
   size_t resident_size_bytes = 0;
   /** Amount of memory actually used on the heap. */
   size_t used_size_bytes = 0;
+  /** Memory retained in the page pool, not used directly by the heap. */
+  size_t pooled_memory_size_bytes = 0;
   /** Detail level of this HeapStatistics. */
   DetailLevel detail_level;
 

package/include/node/cppgc/internal/api-constants.h

@@ -30,10 +30,15 @@ static constexpr size_t kFullyConstructedBitFieldOffsetFromPayload =
 // Mask for in-construction bit.
 static constexpr uint16_t kFullyConstructedBitMask = uint16_t{1};
 
-static constexpr size_t kPageSize = size_t{1} << 17;
+static constexpr size_t kPageSizeBits = 17;
+static constexpr size_t kPageSize = size_t{1} << kPageSizeBits;
 
 #if defined(V8_HOST_ARCH_ARM64) && defined(V8_OS_DARWIN)
 constexpr size_t kGuardPageSize = 0;
+#elif defined(V8_HOST_ARCH_PPC64)
+constexpr size_t kGuardPageSize = 0;
+#elif defined(V8_HOST_ARCH_LOONG64) || defined(V8_HOST_ARCH_MIPS64)
+constexpr size_t kGuardPageSize = 0;
 #else
 constexpr size_t kGuardPageSize = 4096;
 #endif

package/include/node/cppgc/internal/compiler-specific.h

@@ -5,6 +5,8 @@
 #ifndef INCLUDE_CPPGC_INTERNAL_COMPILER_SPECIFIC_H_
 #define INCLUDE_CPPGC_INTERNAL_COMPILER_SPECIFIC_H_
 
+#include "v8config.h"  // NOLINT(build/include_directory)
+
 namespace cppgc {
 
 #if defined(__has_attribute)
@@ -21,7 +23,13 @@ namespace cppgc {
 
 // [[no_unique_address]] comes in C++20 but supported in clang with -std >=
 // c++11.
-#if CPPGC_HAS_CPP_ATTRIBUTE(no_unique_address)
+#if defined(V8_CC_MSVC) && CPPGC_HAS_CPP_ATTRIBUTE(msvc::no_unique_address)
+// Unfortunately MSVC ignores [[no_unique_address]] (see
+// https://devblogs.microsoft.com/cppblog/msvc-cpp20-and-the-std-cpp20-switch/#msvc-extensions-and-abi),
+// and clang-cl matches it for ABI compatibility reasons. We need to prefer
+// [[msvc::no_unique_address]] when available if we actually want any effect.
+#define CPPGC_NO_UNIQUE_ADDRESS [[msvc::no_unique_address]]
+#elif CPPGC_HAS_CPP_ATTRIBUTE(no_unique_address)
 #define CPPGC_NO_UNIQUE_ADDRESS [[no_unique_address]]
 #else
 #define CPPGC_NO_UNIQUE_ADDRESS

package/include/node/cppgc/internal/gc-info.h

@@ -94,12 +94,11 @@ struct GCInfoTrait final {
     return index;
   }
 
-  static constexpr bool CheckCallbacksAreDefined() {
+  static constexpr void CheckCallbacksAreDefined() {
     // No USE() macro available.
     (void)static_cast<TraceCallback>(TraceTrait<T>::Trace);
     (void)static_cast<FinalizationCallback>(FinalizerTrait<T>::kCallback);
     (void)static_cast<NameCallback>(NameTrait<T>::GetName);
-    return true;
   }
 };
 
@@ -127,19 +126,22 @@ struct GCInfoFolding final {
   // configuration. Only a single GCInfo (for `ResultType` below) will actually
   // be instantiated but existence (and well-formedness) of all callbacks is
   // checked.
-  static constexpr bool kCheckTypeGuardAlwaysTrue =
-      GCInfoTrait<T>::CheckCallbacksAreDefined() &&
+  static constexpr bool WantToFold() {
+    if constexpr ((kHasVirtualDestructorAtBase ||
+                   kBothTypesAreTriviallyDestructible ||
+                   kHasCustomFinalizerDispatchAtBase) &&
+                  !kWantsDetailedObjectNames) {
+      GCInfoTrait<T>::CheckCallbacksAreDefined();
       GCInfoTrait<ParentMostGarbageCollectedType>::CheckCallbacksAreDefined();
+      return true;
+    }
+    return false;
+  }
 
   // Folding would regress name resolution when deriving names from C++
   // class names as it would just folds a name to the base class name.
   using ResultType =
-      std::conditional_t<kCheckTypeGuardAlwaysTrue &&
-                             (kHasVirtualDestructorAtBase ||
-                              kBothTypesAreTriviallyDestructible ||
-                              kHasCustomFinalizerDispatchAtBase) &&
-                             !kWantsDetailedObjectNames,
-                         ParentMostGarbageCollectedType, T>;
+      std::conditional_t<WantToFold(), ParentMostGarbageCollectedType, T>;
 };
 
 }  // namespace internal

package/include/node/cppgc/internal/member-storage.h

@@ -158,6 +158,12 @@ class V8_TRIVIAL_ABI CompressedPointer final {
   static V8_INLINE void* Decompress(IntegralType ptr) {
     CPPGC_DCHECK(CageBaseGlobal::IsSet());
     const uintptr_t base = CageBaseGlobal::Get();
+    return Decompress(ptr, base);
+  }
+
+  static V8_INLINE void* Decompress(IntegralType ptr, uintptr_t base) {
+    CPPGC_DCHECK(CageBaseGlobal::IsSet());
+    CPPGC_DCHECK(base == CageBaseGlobal::Get());
     // Treat compressed pointer as signed and cast it to uint64_t, which will
     // sign-extend it.
 #if defined(CPPGC_2GB_CAGE)

package/include/node/cppgc/internal/name-trait.h

@@ -121,7 +121,11 @@ class NameTrait final : public NameTraitBase {
 #undef PRETTY_FUNCTION_VALUE
 
 #else   // !CPPGC_SUPPORTS_OBJECT_NAMES
-    return {NameProvider::kHiddenName, true};
+    // We wanted to use a class name but were unable to provide one due to
+    // compiler limitations or build configuration. As such, return the hidden
+    // name with name_was_hidden=false, which will cause this object to be
+    // visible in the snapshot.
+    return {NameProvider::kHiddenName, false};
 #endif  // !CPPGC_SUPPORTS_OBJECT_NAMES
   }
 };

package/include/node/cppgc/name-provider.h

@@ -55,6 +55,13 @@ class V8_EXPORT NameProvider {
    * Specifies a name for the garbage-collected object. Such names will never
    * be hidden, as they are explicitly specified by the user of this API.
    *
+   * V8 may call this function while generating a heap snapshot or at other
+   * times. If V8 is currently generating a heap snapshot (according to
+   * HeapProfiler::IsTakingSnapshot), then the returned string must stay alive
+   * until the snapshot generation has completed. Otherwise, the returned string
+   * must stay alive forever. If you need a place to store a temporary string
+   * during snapshot generation, use HeapProfiler::CopyNameForHeapSnapshot.
+   *
    * @returns a human readable name for the object.
    */
   virtual const char* GetHumanReadableName() const = 0;