nodal-agents 0.7.0 → 0.7.2

package/migrations/0054_audit2_db_integrity.sql

@@ -0,0 +1,52 @@
+-- Dedup pass (audit#2 follow-up): these six tables never had the UNIQUE
+-- constraints below, and their pre-fix write paths were check-then-insert
+-- (raceable) — so an upgraded install may already carry duplicate rows. A bare
+-- ADD CONSTRAINT / CREATE UNIQUE INDEX validates existing rows and aborts the
+-- whole migration (Postgres 23505) if any duplicate exists, bricking `up` with
+-- no recovery. Follow migration 0007's precedent: collapse each duplicate group
+-- to a single survivor BEFORE adding the constraint. Survivor = most recently
+-- updated/created row (id as final, always-unique tiebreaker); COALESCE guards
+-- NULL timestamps; IS NOT DISTINCT FROM matches the NULLS NOT DISTINCT semantics
+-- of the entity_id keys. On a clean install (no duplicates) every DELETE is a
+-- no-op.
+DELETE FROM "approval_rules" a USING "approval_rules" b
+WHERE a."id" <> b."id"
+  AND a."entity_id" IS NOT DISTINCT FROM b."entity_id"
+  AND a."agent_id" IS NOT DISTINCT FROM b."agent_id"
+  AND a."tool_name" = b."tool_name"
+  AND (COALESCE(a."updated_at", 'epoch'::timestamptz) < COALESCE(b."updated_at", 'epoch'::timestamptz)
+       OR (COALESCE(a."updated_at", 'epoch'::timestamptz) = COALESCE(b."updated_at", 'epoch'::timestamptz) AND a."id" < b."id"));--> statement-breakpoint
+DELETE FROM "agent_skill_assignments" a USING "agent_skill_assignments" b
+WHERE a."agent_id" = b."agent_id"
+  AND a."skill_id" = b."skill_id"
+  AND a."id" < b."id";--> statement-breakpoint
+DELETE FROM "agent_assignments" a USING "agent_assignments" b
+WHERE a."orchestrator_id" = b."orchestrator_id"
+  AND a."sub_agent_id" = b."sub_agent_id"
+  AND (COALESCE(a."created_at", 'epoch'::timestamptz) < COALESCE(b."created_at", 'epoch'::timestamptz)
+       OR (COALESCE(a."created_at", 'epoch'::timestamptz) = COALESCE(b."created_at", 'epoch'::timestamptz) AND a."id" < b."id"));--> statement-breakpoint
+DELETE FROM "agent_plugins" a USING "agent_plugins" b
+WHERE a."id" <> b."id"
+  AND a."entity_id" IS NOT DISTINCT FROM b."entity_id"
+  AND a."slug" = b."slug"
+  AND (COALESCE(a."updated_at", 'epoch'::timestamptz) < COALESCE(b."updated_at", 'epoch'::timestamptz)
+       OR (COALESCE(a."updated_at", 'epoch'::timestamptz) = COALESCE(b."updated_at", 'epoch'::timestamptz) AND a."id" < b."id"));--> statement-breakpoint
+DELETE FROM "mcp_connections" a USING "mcp_connections" b
+WHERE a."entity_id" = b."entity_id"
+  AND a."slug" = b."slug"
+  AND (COALESCE(a."updated_at", 'epoch'::timestamptz) < COALESCE(b."updated_at", 'epoch'::timestamptz)
+       OR (COALESCE(a."updated_at", 'epoch'::timestamptz) = COALESCE(b."updated_at", 'epoch'::timestamptz) AND a."id" < b."id"));--> statement-breakpoint
+DELETE FROM "entity_members" a USING "entity_members" b
+WHERE a."entity_id" = b."entity_id"
+  AND a."user_id" = b."user_id"
+  AND (COALESCE(a."created_at", 'epoch'::timestamptz) < COALESCE(b."created_at", 'epoch'::timestamptz)
+       OR (COALESCE(a."created_at", 'epoch'::timestamptz) = COALESCE(b."created_at", 'epoch'::timestamptz) AND a."id" < b."id"));--> statement-breakpoint
+ALTER TABLE "approval_rules" ADD CONSTRAINT "approval_rules_entity_agent_tool_unique" UNIQUE NULLS NOT DISTINCT("entity_id","agent_id","tool_name");--> statement-breakpoint
+ALTER TABLE "agent_skill_assignments" ADD CONSTRAINT "agent_skill_assignments_agent_skill_unique" UNIQUE("agent_id","skill_id");--> statement-breakpoint
+ALTER TABLE "agent_assignments" ADD CONSTRAINT "agent_assignments_orchestrator_sub_agent_unique" UNIQUE("orchestrator_id","sub_agent_id");--> statement-breakpoint
+CREATE INDEX "idx_agent_tasks_root_job_id" ON "agent_tasks" USING btree ("root_job_id");--> statement-breakpoint
+CREATE INDEX "idx_agent_jobs_completed_at_null" ON "agent_jobs" USING btree ("completed_at") WHERE "completed_at" IS NULL;--> statement-breakpoint
+DROP INDEX "idx_jobs_parent";--> statement-breakpoint
+ALTER TABLE "agent_plugins" ADD CONSTRAINT "agent_plugins_entity_slug_unique" UNIQUE NULLS NOT DISTINCT("entity_id","slug");--> statement-breakpoint
+CREATE UNIQUE INDEX "mcp_connections_entity_slug_unique" ON "mcp_connections" USING btree ("entity_id","slug");--> statement-breakpoint
+CREATE UNIQUE INDEX "entity_members_entity_user_unique" ON "entity_members" USING btree ("entity_id","user_id");

package/migrations/0055_entity_settings.sql

@@ -0,0 +1,22 @@
+CREATE TABLE "entity_settings" (
+	"entity_id" uuid NOT NULL,
+	"key" text NOT NULL,
+	"value" text DEFAULT '' NOT NULL,
+	"updated_at" timestamp with time zone DEFAULT now() NOT NULL,
+	CONSTRAINT "entity_settings_entity_id_key_pk" PRIMARY KEY("entity_id","key")
+);
+--> statement-breakpoint
+ALTER TABLE "entity_settings" ADD CONSTRAINT "entity_settings_entity_id_entities_id_fk" FOREIGN KEY ("entity_id") REFERENCES "entities"("id") ON DELETE cascade ON UPDATE no action;
+--> statement-breakpoint
+-- M-2 (audit #2): install_notes used to be one machine-global row injected
+-- into EVERY entity's agents — the opposite of isolation. Backfill preserves
+-- current behaviour for existing installs (the note was already visible
+-- everywhere) by copying it to every existing entity as its own row; going
+-- forward each entity's notes are independent and owner-gated per entity
+-- (see setInstallNotesAction in apps/web).
+INSERT INTO "entity_settings" ("entity_id", "key", "value")
+SELECT "entities"."id", 'install_notes', "app_settings"."value"
+FROM "entities", "app_settings"
+WHERE "app_settings"."key" = 'install_notes' AND "app_settings"."value" <> '';
+--> statement-breakpoint
+DELETE FROM "app_settings" WHERE "key" = 'install_notes';

package/migrations/0056_agents_skills_entity_scoped_unique.sql

@@ -0,0 +1,23 @@
+-- F-6 (audit #2): agents.slug and agent_skills.slug/name were UNIQUE
+-- GLOBALLY across the whole install. Consequences: (a) a 2nd entity/
+-- workspace installing the same community skill (e.g. slug 'comfyui') or
+-- creating an agent/skill that happens to share a slug or name with another
+-- entity's crashed the insert outright; (b) in multi-user mode, slug/name
+-- collisions let one entity enumerate or squat another's identifiers.
+--
+-- Fix: drop the global unique constraints and replace them with composite
+-- (entity_id, slug) / (entity_id, name) uniques, NULLS NOT DISTINCT (same
+-- pattern as 0000's agent_plugins_entity_slug_unique / approval_rules —
+-- entity_id is nullable in both tables, and a plain UNIQUE treats every NULL
+-- as distinct, which would let multiple (NULL, 'x') rows back in).
+--
+-- Safe to apply: the OLD global unique constraints made it structurally
+-- impossible for two existing rows to already share a (entity_id, slug) or
+-- (entity_id, name) pair, so the new composite constraints cannot fail on
+-- current data.
+ALTER TABLE "agents" DROP CONSTRAINT "agents_slug_unique";--> statement-breakpoint
+ALTER TABLE "agent_skills" DROP CONSTRAINT "agent_skills_slug_unique";--> statement-breakpoint
+ALTER TABLE "agent_skills" DROP CONSTRAINT "agent_skills_name_unique";--> statement-breakpoint
+ALTER TABLE "agents" ADD CONSTRAINT "agents_entity_slug_unique" UNIQUE NULLS NOT DISTINCT("entity_id","slug");--> statement-breakpoint
+ALTER TABLE "agent_skills" ADD CONSTRAINT "agent_skills_entity_slug_unique" UNIQUE NULLS NOT DISTINCT("entity_id","slug");--> statement-breakpoint
+ALTER TABLE "agent_skills" ADD CONSTRAINT "agent_skills_entity_name_unique" UNIQUE NULLS NOT DISTINCT("entity_id","name");

package/migrations/0057_telegram_allowed_chats.sql

@@ -0,0 +1,34 @@
+CREATE TABLE "telegram_allowed_chats" (
+	"id" uuid PRIMARY KEY DEFAULT gen_random_uuid() NOT NULL,
+	"entity_id" uuid,
+	"agent_id" uuid NOT NULL,
+	"chat_id" text NOT NULL,
+	"role" text DEFAULT 'member' NOT NULL,
+	"status" text DEFAULT 'pending' NOT NULL,
+	"requester_name" text,
+	"created_at" timestamp with time zone DEFAULT now(),
+	"updated_at" timestamp with time zone DEFAULT now(),
+	CONSTRAINT "telegram_allowed_chats_agent_chat_unique" UNIQUE("agent_id","chat_id"),
+	CONSTRAINT "telegram_allowed_chats_role_check" CHECK ("telegram_allowed_chats"."role" IN ('owner','member')),
+	CONSTRAINT "telegram_allowed_chats_status_check" CHECK ("telegram_allowed_chats"."status" IN ('active','pending'))
+);
+--> statement-breakpoint
+ALTER TABLE "telegram_allowed_chats" ADD CONSTRAINT "telegram_allowed_chats_entity_id_entities_id_fk" FOREIGN KEY ("entity_id") REFERENCES "entities"("id") ON DELETE cascade ON UPDATE no action;
+--> statement-breakpoint
+ALTER TABLE "telegram_allowed_chats" ADD CONSTRAINT "telegram_allowed_chats_agent_id_agents_id_fk" FOREIGN KEY ("agent_id") REFERENCES "agents"("id") ON DELETE cascade ON UPDATE no action;
+--> statement-breakpoint
+CREATE INDEX "idx_telegram_allowed_chats_agent" ON "telegram_allowed_chats" ("agent_id");
+--> statement-breakpoint
+CREATE INDEX "idx_telegram_allowed_chats_entity" ON "telegram_allowed_chats" ("entity_id");
+--> statement-breakpoint
+-- H-1: seed the OWNER for every bot that already has a known chat, so existing
+-- installs are not locked out AND a stranger can't claim ownership of a bot the
+-- real user was already using. The last chat that talked to each configured bot
+-- becomes its active owner. New bots (no prior chat) claim their owner on the
+-- first DM instead. NULLS-safe and idempotent (unique(agent_id,chat_id)).
+INSERT INTO "telegram_allowed_chats" ("entity_id", "agent_id", "chat_id", "role", "status")
+SELECT "entity_id", "id", "last_seen_chat_id_telegram", 'owner', 'active'
+FROM "agents"
+WHERE "last_seen_chat_id_telegram" IS NOT NULL
+  AND "telegram_bot_token" IS NOT NULL
+ON CONFLICT ("agent_id","chat_id") DO NOTHING;

package/migrations/meta/_journal.json

@@ -372,6 +372,34 @@
       "when": 1783300000000,
       "tag": "0053_memory_importance_locked",
       "breakpoints": true
+    },
+    {
+      "idx": 54,
+      "version": "7",
+      "when": 1783400000000,
+      "tag": "0054_audit2_db_integrity",
+      "breakpoints": true
+    },
+    {
+      "idx": 55,
+      "version": "7",
+      "when": 1783500000000,
+      "tag": "0055_entity_settings",
+      "breakpoints": true
+    },
+    {
+      "idx": 56,
+      "version": "7",
+      "when": 1783600000000,
+      "tag": "0056_agents_skills_entity_scoped_unique",
+      "breakpoints": true
+    },
+    {
+      "idx": 57,
+      "version": "7",
+      "when": 1783700000000,
+      "tag": "0057_telegram_allowed_chats",
+      "breakpoints": true
     }
   ]
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodal-agents",
-  "version": "0.7.0",
+  "version": "0.7.2",
   "description": "Local-first AI agent platform with a web dashboard — install in one command.",
   "license": "MIT",
   "repository": {