nodal-agents 0.3.7 → 0.3.9

package/README.md

@@ -25,7 +25,7 @@ no cloud roundtrip.** Runs on any machine with Node 22+ — Mac, PC, Linux.
 | 🗂️  **Workspaces** | Multiple isolated workspaces on one install (personal vs work) — each with its own agents, skills, connectors, jobs and memory. Switch from the sidebar. |
 | 🤖  **Self-extending (ROOT agent)** | Designate an orchestrator as ROOT and let it create skills/agents and assign them on your behalf — gated by per-grant toggles and an autonomy level (propose-confirm → fully-autonomous). |
 | 📄  **Office files** | Read + edit Excel in place, create Word & PowerPoint, inside the agent's workspace — gated behind the office-editing skill. |
-| 📡  **MCP support** | Connect MCP servers over Streamable HTTP *and* stdio (local subprocess) — per-job tool discovery, tool whitelisting, multi-instance. |
+| 📡  **MCP support** | Connect MCP servers over Streamable HTTP *and* stdio (local subprocess) — a growing catalogue (Stripe, n8n, Supabase, Airtable, Notion…) plus add *and edit* your own custom servers from the UI. Per-job tool discovery, tool whitelisting, multi-instance. |
 | 💬 &nbsp;**Telegram out of the box** | Long-polling, multi-agent routing (`/ask <slug>`), group-chat filters, conversation continuity, delegation gracefulness on Telegram. |
 | ⚙️ &nbsp;**Real engineering** | TypeScript strict, dependency-cruiser-enforced architecture, full unit + integration suite, Playwright e2e, idempotent migrations, encryption at rest for keys. |
 
@@ -134,7 +134,7 @@ Delegations create child jobs that resume the parent on completion.
 | `/agents` | Create, edit, assign skills + connectors + MCP servers to agents. |
 | `/jobs` | Live job stream — task, agent, status, full transcript, tool I/O. |
 | `/connectors` | Active connector instances + Marketplace (multi-instance, OAuth or API-key). |
-| `/mcp` | Active MCP servers + Marketplace (HTTP transport). |
+| `/mcp` | Active MCP servers + Marketplace — HTTP & stdio, a growing catalogue, plus add/edit your own custom servers. |
 | `/memories` | Persistent facts per entity — search, edit, archive. |
 | `/skills` | Assigned / Custom / Built-in Library tabs — reusable instructions appended to an agent's prompt; create your own or customise built-ins. |
 | `/logs` | Tool-call audit — input/output JSON per call, filterable by tool name. |
@@ -204,7 +204,7 @@ pnpm deps:check   # runs locally and in CI before every release
 
 ## Status
 
-**Current release:** `0.3.7` on npm `latest`. Used daily by the
+**Current release:** `0.3.9` on npm `latest`. Used daily by the
 maintainer, stable enough for personal production. Pre-1.0 — breaking
 changes are still possible between minors.
 
@@ -218,13 +218,15 @@ changes are still possible between minors.
   caps
 - Multi-instance connectors with OAuth (Gmail, Drive, Sheets, Docs, Notion,
   Airtable) and API-key (Notion, Airtable, Apify, Firecrawl, Tavily)
-- MCP catalog — Streamable HTTP *and* stdio (local subprocess) servers, API-key auth
+- MCP catalog — Streamable HTTP *and* stdio (local subprocess) servers, API-key auth; a growing catalogue (Stripe, n8n, Supabase, Airtable, Notion…) with a "test pending" badge on entries not yet verified live, plus add *and edit* your own custom HTTP/stdio servers from the dashboard
 - Top-level workspaces — multiple isolated entities (agents/skills/connectors/jobs/memory per workspace), switch in the sidebar
 - ROOT agent — designate an orchestrator that can create skills/agents and assign them, gated by per-grant toggles + an autonomy/approval level
 - Office file editing — Excel in-place edit, Word/PowerPoint create, in the agent workspace (office-editing skill)
 - Multiple filesystem folders per agent (sandboxed `file_*` tools)
 - Telegram delivery (long-poll, group filters, multi-agent routing,
-  delegation gracefulness)
+  delegation gracefulness) — exactly-once delivery contract: anti-spam guard
+  against runaway message loops + a guard that re-prompts (then fails loud)
+  rather than completing a job without ever replying
 - Approval gates for risky tools (execute-the-approved-action on resume)
 - Cron scheduling
 - `nodal-agents update` — one-command upgrade + boot version notice

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodal-agents",
-  "version": "0.3.7",
+  "version": "0.3.9",
   "description": "Local-first AI agent platform with a web dashboard — install in one command.",
   "license": "MIT",
   "repository": {

package/runner.js

@@ -13282,6 +13282,12 @@ Wrong (4 LLM round-trips for the same outcome):
   response 3: [{ telegram_send_message: part3 }]
   response 4: [{ return_result: ... }]
 
+**Stop when you're done**: once you have sent your reply, call \`return_result\`
+to end your turn. Do NOT keep sending standalone acknowledgements, follow-ups, or
+emoji-only messages turn after turn \u2014 the user did not ask for them and the
+platform will cut you off for spamming if you send on several turns in a row
+without finishing.
+
 Fail conditions:
 - If no chatId is provided and the current job has no origin chat, the tool throws
   \`telegram_no_recipient\`. This is intentional \u2014 do not guess a chat ID.
@@ -25721,7 +25727,12 @@ function mcpToolToToolDefinition(client, mcpTool, slug) {
         const detail = extractText(result.content);
         throw new Error(`MCP tool ${originalName} failed: ${detail || "unknown error"}`);
       }
-      return result.content;
+      if (result.structuredContent != null) return result.structuredContent;
+      const content = result.content ?? [];
+      if (Array.isArray(content) && content.length > 0 && content.every((c) => c.type === "text")) {
+        return extractText(content);
+      }
+      return content;
     }
   };
 }
@@ -25792,8 +25803,9 @@ var DEFAULT_LIMITS = {
   maxChains: 15,
   maxToolCallsPerTurn: 50,
   maxDelegationDepth: 3,
-  maxTurns: 50
+  maxTurns: 50,
   // matches Hermes Agent's per-subagent iteration budget; cumulative cap across resumes
+  maxConsecutiveDeliveryTurns: 3
 };
 var ChainCounters = class _ChainCounters {
   constructor(limits = DEFAULT_LIMITS) {
@@ -26803,6 +26815,8 @@ function totalChars(blocks) {
 
 // src/job/execute.ts
 var MAX_TOOL_RESULT_CHARS = 5e4;
+var DELIVERY_TOOL_NAMES = /* @__PURE__ */ new Set(["telegram_send_message"]);
+var TOOL_ONLY_DELIVERY_CHANNELS = /* @__PURE__ */ new Set(["telegram"]);
 function truncateForContext(value) {
   if (value.length <= MAX_TOOL_RESULT_CHARS) return value;
   const dropped = value.length - MAX_TOOL_RESULT_CHARS;
@@ -27204,6 +27218,12 @@ async function executeJob(jobId, deps, _runnerEnv) {
   }
   const MAX_EMPTY_TURN_RETRIES = 2;
   let emptyTurnRetries = 0;
+  let consecutiveDeliveryOnlyTurns = 0;
+  const requiresToolDelivery = TOOL_ONLY_DELIVERY_CHANNELS.has(job.channel ?? "");
+  const MAX_TELEGRAM_REDELIVERY_NUDGES = 2;
+  let telegramRedeliveryNudges = 0;
+  let telegramDelivered = false;
+  const deliveryNudge = "[syst\xE8me] Tu es sur Telegram. Tu n'as pas encore livr\xE9 ta r\xE9ponse \xE0 l'utilisateur. Appelle `telegram_send_message` avec ta r\xE9ponse, PUIS `return_result`. Ne r\xE9ponds pas en texte simple \u2014 sur Telegram, seul un message envoy\xE9 via `telegram_send_message` est visible par l'utilisateur.";
   try {
     while (true) {
       turn += 1;
@@ -27243,6 +27263,13 @@ async function executeJob(jobId, deps, _runnerEnv) {
         textLen: (response.text ?? "").length,
         usage: { in: promptT, out: completionT }
       });
+      const isDeliveryOnlyTurn = rawToolCalls.length > 0 && rawToolCalls.every((tc) => DELIVERY_TOOL_NAMES.has(tc.toolName));
+      consecutiveDeliveryOnlyTurns = isDeliveryOnlyTurn ? consecutiveDeliveryOnlyTurns + 1 : 0;
+      if (consecutiveDeliveryOnlyTurns > DEFAULT_LIMITS.maxConsecutiveDeliveryTurns) {
+        trace("delivery_spam_guard", { turn, consecutiveDeliveryOnlyTurns });
+        await failJob(db, jobId, "delivery_spam_guard", runStats());
+        return { status: "failed", error: "delivery_spam_guard" };
+      }
       const assistantMsg = {
         role: "assistant",
         content: rawToolCalls.length > 0 ? rawToolCalls.map((tc) => ({
@@ -27258,6 +27285,21 @@ async function executeJob(jobId, deps, _runnerEnv) {
         trace("no_tool_calls_branch", { turn, hasText: Boolean(response.text) });
         const textContent = response.text ?? "";
         if (textContent) {
+          if (requiresToolDelivery && !telegramDelivered) {
+            if (telegramRedeliveryNudges < MAX_TELEGRAM_REDELIVERY_NUDGES) {
+              telegramRedeliveryNudges += 1;
+              trace("telegram_redelivery_nudge", {
+                turn,
+                attempt: telegramRedeliveryNudges,
+                via: "text_branch"
+              });
+              messages = [...messages, { role: "user", content: deliveryNudge }];
+              continue;
+            }
+            trace("telegram_not_delivered", { turn, via: "text_branch" });
+            await failJob(db, jobId, "telegram_not_delivered", runStats());
+            return { status: "failed", error: "telegram_not_delivered" };
+          }
           await completeJob(db, jobId, textContent, toolsUsed, runStats(), messages);
           return { status: "completed", result: textContent };
         }
@@ -27450,6 +27492,9 @@ async function executeJob(jobId, deps, _runnerEnv) {
           awaitingApproval = true;
           continue;
         }
+        if (toolResult.outcome === "success" && DELIVERY_TOOL_NAMES.has(call.name)) {
+          telegramDelivered = true;
+        }
         toolResultBlocks.push({
           type: "tool-result",
           toolCallId: call.id,
@@ -27490,6 +27535,31 @@ async function executeJob(jobId, deps, _runnerEnv) {
       }
       if (returnResultCall) {
         trace("return_result_branch", { turn });
+        const taskRows = await db.select({ id: agentTasks.id }).from(agentTasks).where(eq4(agentTasks.rootJobId, jobId));
+        if (requiresToolDelivery && !telegramDelivered && taskRows.length === 0) {
+          if (telegramRedeliveryNudges < MAX_TELEGRAM_REDELIVERY_NUDGES) {
+            telegramRedeliveryNudges += 1;
+            trace("telegram_redelivery_nudge", {
+              turn,
+              attempt: telegramRedeliveryNudges,
+              via: "return_result_branch"
+            });
+            toolResultBlocks.push({
+              type: "tool-result",
+              toolCallId: returnResultCall.toolCallId,
+              toolName: "return_result",
+              output: toResultOutput({
+                error: "deferred: tu n'as pas encore livr\xE9 ta r\xE9ponse via telegram_send_message \u2014 fais-le avant de terminer"
+              })
+            });
+            messages = [...messages, { role: "tool", content: toolResultBlocks }];
+            messages = [...messages, { role: "user", content: deliveryNudge }];
+            continue;
+          }
+          trace("telegram_not_delivered", { turn, via: "return_result_branch" });
+          await failJob(db, jobId, "telegram_not_delivered", runStats());
+          return { status: "failed", error: "telegram_not_delivered" };
+        }
         const finalResult = "";
         toolsUsed = [.../* @__PURE__ */ new Set([...toolsUsed, "return_result"])];
         toolResultBlocks.push({
@@ -27499,7 +27569,6 @@ async function executeJob(jobId, deps, _runnerEnv) {
           output: toResultOutput({ acknowledged: true })
         });
         messages = [...messages, { role: "tool", content: toolResultBlocks }];
-        const taskRows = await db.select({ id: agentTasks.id }).from(agentTasks).where(eq4(agentTasks.rootJobId, jobId));
         if (taskRows.length > 0) {
           trace("return_result_with_tasks", { taskCount: taskRows.length });
           await saveCheckpoint(db, jobId, {

package/web/.next/BUILD_ID

@@ -1 +1 @@
-0Ja3V81w-79oY4P3asE4L
+8MmUGL73Wv8U4wr-eDBt8

package/web/.next/app-path-routes-manifest.json

@@ -13,8 +13,8 @@
   "/(dashboard)/agents/[id]/edit/page": "/agents/[id]/edit",
   "/(dashboard)/agents/[id]/telegram/page": "/agents/[id]/telegram",
   "/(dashboard)/agents/page": "/agents",
-  "/(dashboard)/approvals/page": "/approvals",
   "/(dashboard)/automations/page": "/automations",
+  "/(dashboard)/approvals/page": "/approvals",
   "/(dashboard)/connectors/page": "/connectors",
   "/(dashboard)/credentials/page": "/credentials",
   "/(dashboard)/jobs/[id]/page": "/jobs/[id]",

package/web/.next/build-manifest.json

@@ -4,8 +4,8 @@
   ],
   "devFiles": [],
   "lowPriorityFiles": [
-    "static/0Ja3V81w-79oY4P3asE4L/_buildManifest.js",
-    "static/0Ja3V81w-79oY4P3asE4L/_ssgManifest.js"
+    "static/8MmUGL73Wv8U4wr-eDBt8/_buildManifest.js",
+    "static/8MmUGL73Wv8U4wr-eDBt8/_ssgManifest.js"
   ],
   "rootMainFiles": [
     "static/chunks/webpack-3741bf0a7636d65e.js",