no-mistakes 0.91.3 → 0.93.0

package/README.md

@@ -199,3 +199,10 @@ See the full documentation in [docs/](../../docs/README.md), the
 [CLI command index](../../docs/cli/README.md), and the
 [Node/N-API guide](../../docs/node-api.md). Agents can use the compact
 [packaged skill](../../skills/no-mistakes/SKILL.md).
+
+The async `effects()` report keeps one row per physical call occurrence. Multiple
+configured callable/category matches appear in optional `alternatives` using the
+exported `EffectCallAlternative` type; singleton rows omit it. Category filters
+project candidates before scalar selection and category counts. One occurrence
+counts once per matched category, so category totals can exceed row count. See
+[effect query details](../../docs/cli/effects.md).

package/analyze-project-types.d.ts

@@ -3,6 +3,7 @@ import type { CiTopologyOptions } from "./workflow-topology-types";
 import type { CiEnvOptions, CiImpactOptions, ImpactedChecksOptions } from "./ci-types";
 import type { FetchesOptions, FlowOptions } from "./flow-types";
 import type { ImportUsagesOptions } from "./import-usage-types";
+import type { JobsPoolWarning } from "./invocation-types";
 import type { MermaidValidationOptions } from "./mermaid-types";
 import type {
   DataPwOptions,
@@ -156,4 +157,10 @@ export interface AnalyzeProjectResult {
     type: AnalyzeProjectReportRequest["type"];
     result: unknown | EffectsReport | RscCallersReport;
   }>;
+  /**
+   * Set when this call's resolved `jobs` differs from the process-wide Rayon pool.
+   * Omitted when the pool was just created or the resolved count already matches.
+   * Other analysis JSON objects use the same optional field.
+   */
+  jobsPoolWarning?: JobsPoolWarning;
 }

package/forbidden-call-types.d.ts

@@ -0,0 +1,17 @@
+/** Bounded source literals; no source code is evaluated. */
+export type ForbiddenCallArgumentLiteral = string | number | boolean | null;
+export type ForbiddenCallUnknownArguments = "finding" | "ignore";
+export type ForbiddenCallArgumentPredicate = {
+  /** Zero-based argument index, from 0 through 31. */
+  position: number;
+  /** Optional single literal options-property name. */
+  property?: string;
+} & (
+  | { equals: ForbiddenCallArgumentLiteral; arrayIncludes?: never; arrayExcludes?: never }
+  | { arrayIncludes: ForbiddenCallArgumentLiteral; equals?: never; arrayExcludes?: never }
+  | { arrayExcludes: ForbiddenCallArgumentLiteral; equals?: never; arrayIncludes?: never }
+);
+export interface ForbiddenCallArgumentConditions {
+  /** Between one and sixteen conjunctive predicates. */
+  all: ForbiddenCallArgumentPredicate[];
+}

package/index-ci-infra.d.ts

@@ -1,3 +1,10 @@
+import type { TypeScriptModulesOptions, TypeScriptModulesReport } from "./typescript-module-types";
+import type {
+  PostgresCatalog,
+  PostgresCatalogOptions,
+  PostgresCompleteCatalog,
+  PostgresOrderingCatalog,
+} from "./postgres-catalog-types";
 // CI, impacted-checks, data-flow, infra, and Swift API declarations, split
 // out of `index.d.ts` to stay under the 200-line file limit.
 
@@ -31,6 +38,7 @@ import type {
   TestAuditReport,
   TestsAuditOptions,
   WithInvocationOptions,
+  WithInvocationResult,
   WorkflowTopology,
   WorkflowTopologyIndex,
 } from "./types";
@@ -38,33 +46,41 @@ import type {
 export function lockfileDiff(
   options: WithInvocationOptions<LockfileDiffOptions>,
 ): Promise<LockfileDiffEntry[]>;
-export function ciImpact(options: WithInvocationOptions<CiImpactOptions>): Promise<CiImpactReport>;
-export function ciEnv(options: WithInvocationOptions<CiEnvOptions>): Promise<CiEnvReport>;
+export function ciImpact(
+  options: WithInvocationOptions<CiImpactOptions>,
+): Promise<WithInvocationResult<CiImpactReport>>;
+export function ciEnv(
+  options: WithInvocationOptions<CiEnvOptions>,
+): Promise<WithInvocationResult<CiEnvReport>>;
 export function ciTopology(
   options?: WithInvocationOptions<CiTopologyOptions>,
-): Promise<WorkflowTopology>;
+): Promise<WithInvocationResult<WorkflowTopology>>;
 export function ciTopologyImpact(
   options: WithInvocationOptions<CiTopologyImpactOptions>,
-): Promise<CiTopologyImpactReport>;
+): Promise<WithInvocationResult<CiTopologyImpactReport>>;
 /** Builds a query index over a `ciTopology()` result. Pure JS — never crosses the N-API boundary. */
 export function createWorkflowTopologyIndex(topology: WorkflowTopology): WorkflowTopologyIndex;
 export function impactedChecks(
   options: WithInvocationOptions<ImpactedChecksOptions>,
-): Promise<ImpactedChecksReport>;
-export function dataPw(options: WithInvocationOptions<DataPwOptions>): Promise<DataPwReport>;
-export function effects(options: WithInvocationOptions<EffectsOptions>): Promise<EffectsReport>;
+): Promise<WithInvocationResult<ImpactedChecksReport>>;
+export function dataPw(
+  options: WithInvocationOptions<DataPwOptions>,
+): Promise<WithInvocationResult<DataPwReport>>;
+export function effects(
+  options: WithInvocationOptions<EffectsOptions>,
+): Promise<WithInvocationResult<EffectsReport>>;
 export function rscCallers(
   options: WithInvocationOptions<RscCallersOptions>,
-): Promise<RscCallersReport>;
+): Promise<WithInvocationResult<RscCallersReport>>;
 export function registryExtension(
   options: WithInvocationOptions<RegistryExtensionOptions>,
-): Promise<RegistryExtensionReport>;
+): Promise<WithInvocationResult<RegistryExtensionReport>>;
 export function infraResourceRefs(
   options: WithInvocationOptions<InfraOptions & { address: string }>,
 ): Promise<ResourceRefRow[]>;
 export function infraOutputs(
   options: WithInvocationOptions<InfraOptions & { moduleDir: string }>,
-): Promise<ModuleOutputsResult>;
+): Promise<WithInvocationResult<ModuleOutputsResult>>;
 export function infraTestFor(
   options: WithInvocationOptions<InfraOptions & { tfFile: string }>,
 ): Promise<TestForRow[]>;
@@ -78,4 +94,22 @@ export function version(): Promise<string>;
 
 export function testsAudit(
   options: WithInvocationOptions<TestsAuditOptions>,
-): Promise<TestAuditReport>;
+): Promise<WithInvocationResult<TestAuditReport>>;
+
+/**
+ * Observe committed PostgreSQL metadata in a read-only transaction and return the catalog that
+ * `schemaCatalogPath` reads. Requires psql. `coverage: "ordering"` returns only the ordering facts.
+ */
+export function generatePostgresCatalog(
+  options: WithInvocationOptions<PostgresCatalogOptions & { coverage: "ordering" }>,
+): Promise<WithInvocationResult<PostgresOrderingCatalog>>;
+export function generatePostgresCatalog(
+  options: WithInvocationOptions<PostgresCatalogOptions & { coverage?: "complete" }>,
+): Promise<WithInvocationResult<PostgresCompleteCatalog>>;
+export function generatePostgresCatalog(
+  options: WithInvocationOptions<PostgresCatalogOptions>,
+): Promise<WithInvocationResult<PostgresCatalog>>;
+
+export function analyzeTypeScriptModules(
+  options: WithInvocationOptions<TypeScriptModulesOptions>,
+): Promise<WithInvocationResult<TypeScriptModulesReport>>;

package/index.d.ts

@@ -1,21 +1,13 @@
 import type { TypeScriptModulesOptions, TypeScriptModulesReport } from "./typescript-module-types";
 export type * from "./typescript-module-types";
 /** Analyze selected TS/JS modules asynchronously with source-local binding semantics. */
-export function analyzeTypeScriptModules(
-  options: WithInvocationOptions<TypeScriptModulesOptions>,
-): Promise<TypeScriptModulesReport>;
+
 import type { PostgresSqlSource, PostgresSqlFacts } from "./postgres-source-types";
 export { extractExecutedPostgresSql } from "./executed-postgres-sql-types";
 export * from "./postgres-source-types";
 /** Parse SQL on the native async worker without repository I/O or a database. */
 export function parsePostgresSql(source: PostgresSqlSource): Promise<PostgresSqlFacts>;
 export function parsePostgresSql(sources: PostgresSqlSource[]): Promise<PostgresSqlFacts[]>;
-import type {
-  PostgresCatalog,
-  PostgresCatalogOptions,
-  PostgresCompleteCatalog,
-  PostgresOrderingCatalog,
-} from "./postgres-catalog-types";
 import type {
   CheckReport,
   AnalyzeProjectOptions,
@@ -74,6 +66,7 @@ import type {
   ImportClosureResult,
   WhyStep,
   WithInvocationOptions,
+  WithInvocationResult,
   WritePlanningImpactArtifactsOptions,
   PlanningImpactArtifacts,
 } from "./types";
@@ -83,71 +76,85 @@ export * from "./index-ci-infra";
 
 export function dependencies(
   options: WithInvocationOptions<TraversePathsOptions>,
-): Promise<ImportClosureResult>;
+): Promise<WithInvocationResult<ImportClosureResult>>;
 export function dependencies(
   options: WithInvocationOptions<TraverseGraphOptions>,
-): Promise<DependencyResult>;
+): Promise<WithInvocationResult<DependencyResult>>;
 export function dependents(
   options: WithInvocationOptions<TraverseOptions>,
-): Promise<DependencyResult>;
-export function related(options: WithInvocationOptions<TraverseOptions>): Promise<DependencyResult>;
+): Promise<WithInvocationResult<DependencyResult>>;
+export function related(
+  options: WithInvocationOptions<TraverseOptions>,
+): Promise<WithInvocationResult<DependencyResult>>;
 export function analyzeProject(
   options: WithInvocationOptions<AnalyzeProjectOptions>,
-): Promise<AnalyzeProjectResult>;
+): Promise<WithInvocationResult<AnalyzeProjectResult>>;
 export function writePlanningImpactArtifacts(
   options: WithInvocationOptions<WritePlanningImpactArtifactsOptions>,
-): Promise<PlanningImpactArtifacts>;
+): Promise<WithInvocationResult<PlanningImpactArtifacts>>;
 export function symbols(
   options: WithInvocationOptions<SymbolsSignatureImpactOptions>,
-): Promise<SignatureImpactResult>;
-export function symbols(options: WithInvocationOptions<SymbolsListOptions>): Promise<SymbolsResult>;
+): Promise<WithInvocationResult<SignatureImpactResult>>;
+export function symbols(
+  options: WithInvocationOptions<SymbolsListOptions>,
+): Promise<WithInvocationResult<SymbolsResult>>;
 export function symbols(
   options: WithInvocationOptions<SymbolsOptions>,
-): Promise<SymbolsResult | SignatureImpactResult>;
+): Promise<WithInvocationResult<SymbolsResult | SignatureImpactResult>>;
 export function importUsages(
   options?: WithInvocationOptions<ImportUsagesOptions>,
-): Promise<ImportUsagesResult>;
+): Promise<WithInvocationResult<ImportUsagesResult>>;
 export function importers(
   options: WithInvocationOptions<ImportersOptions>,
-): Promise<ImportersResult>;
+): Promise<WithInvocationResult<ImportersResult>>;
 export function exportsOf(
   options: WithInvocationOptions<ExportsOfOptions>,
-): Promise<ExportsOfResult>;
+): Promise<WithInvocationResult<ExportsOfResult>>;
 export function deadExports(
   options: WithInvocationOptions<DeadExportsOptions>,
-): Promise<DeadExportsResult>;
+): Promise<WithInvocationResult<DeadExportsResult>>;
 export function callSites(
   options: WithInvocationOptions<CallSitesOptions>,
-): Promise<CallSitesResult>;
+): Promise<WithInvocationResult<CallSitesResult>>;
 export function resolveCheck(
   options: WithInvocationOptions<ResolveCheckOptions>,
-): Promise<ResolveCheckResult>;
+): Promise<WithInvocationResult<ResolveCheckResult>>;
 export function resolveCheck(
   options: WithInvocationOptions<ResolveCheckFilesOptions>,
-): Promise<ResolveCheckBatchResult>;
-export function fetches(options?: WithInvocationOptions<FetchesOptions>): Promise<FetchReport>;
-export function flow(options: WithInvocationOptions<FlowOptions>): Promise<FlowReport>;
-export function check(options?: WithInvocationOptions<CheckOptions>): Promise<CheckReport>;
+): Promise<WithInvocationResult<ResolveCheckBatchResult>>;
+export function fetches(
+  options?: WithInvocationOptions<FetchesOptions>,
+): Promise<WithInvocationResult<FetchReport>>;
+export function flow(
+  options: WithInvocationOptions<FlowOptions>,
+): Promise<WithInvocationResult<FlowReport>>;
+export function check(
+  options?: WithInvocationOptions<CheckOptions>,
+): Promise<WithInvocationResult<CheckReport>>;
 export function resolveConfig(
   options?: WithInvocationOptions<ProjectOptions>,
-): Promise<ResolvedConfig>;
+): Promise<WithInvocationResult<ResolvedConfig>>;
 export function validateMermaidMarkdown(
   options: WithInvocationOptions<MermaidValidationOptions>,
-): Promise<MermaidValidationResult>;
-export function testsPlan(options: WithInvocationOptions<TestsPlanOptions>): Promise<TestPlan>;
-export function testsImpact(options: WithInvocationOptions<TestsImpactOptions>): Promise<TestPlan>;
+): Promise<WithInvocationResult<MermaidValidationResult>>;
+export function testsPlan(
+  options: WithInvocationOptions<TestsPlanOptions>,
+): Promise<WithInvocationResult<TestPlan>>;
+export function testsImpact(
+  options: WithInvocationOptions<TestsImpactOptions>,
+): Promise<WithInvocationResult<TestPlan>>;
 export function testsTargets(
   options: WithInvocationOptions<TestsTargetsOptions>,
-): Promise<TestsTargetsReport>;
+): Promise<WithInvocationResult<TestsTargetsReport>>;
 export function testsWhy(
   options: WithInvocationOptions<TestsWhyOptions>,
-): Promise<Record<string, WhyStep[]>>;
+): Promise<WithInvocationResult<Record<string, WhyStep[]>>>;
 export function testsComment(
   options: WithInvocationOptions<TestsPlanDocumentOptions>,
 ): Promise<string>;
 export function testsGraph(
   options: WithInvocationOptions<TestsPlanDocumentOptions>,
-): Promise<TestGraph>;
+): Promise<WithInvocationResult<TestGraph>>;
 export function testsGraphMermaid(
   options: WithInvocationOptions<TestsPlanDocumentOptions>,
 ): Promise<string>;
@@ -163,7 +170,9 @@ export function playwrightRelated(
 export function playwrightTests(
   options?: WithInvocationOptions<PlaywrightOptions>,
 ): Promise<unknown>;
-export function queues(options?: WithInvocationOptions<ProjectOptions>): Promise<QueueReport>;
+export function queues(
+  options?: WithInvocationOptions<ProjectOptions>,
+): Promise<WithInvocationResult<QueueReport>>;
 export function queueEdges(options?: WithInvocationOptions<ProjectOptions>): Promise<QueueEdge[]>;
 export function queueRelated(options: WithInvocationOptions<ProjectOptions>): Promise<QueueEdge[]>;
 export function queueCheck(
@@ -171,7 +180,7 @@ export function queueCheck(
 ): Promise<QueueCheckFinding[]>;
 export function serverRoutes(
   options?: WithInvocationOptions<ProjectOptions>,
-): Promise<ServerRoutesReport>;
+): Promise<WithInvocationResult<ServerRoutesReport>>;
 export function serverRouteList(
   options?: WithInvocationOptions<ProjectOptions>,
 ): Promise<unknown[]>;
@@ -183,7 +192,7 @@ export function serverRouteRelated(
 ): Promise<GraphEdge[]>;
 export function serverContracts(
   options?: WithInvocationOptions<ProjectOptions>,
-): Promise<ServerContractsReport>;
+): Promise<WithInvocationResult<ServerContractsReport>>;
 export function reactAnalyze(
   options?: WithInvocationOptions<ProjectOptions>,
 ): Promise<ReactComponentFacts[]>;
@@ -192,18 +201,4 @@ export function reactCheck(
 ): Promise<ReactViolation[]>;
 export function reactUsages(
   options: WithInvocationOptions<ProjectOptions & { target: string }>,
-): Promise<ReactUsagesReport>;
-
-/**
- * Observe committed PostgreSQL metadata in a read-only transaction and return the catalog that
- * `schemaCatalogPath` reads. Requires psql. `coverage: "ordering"` returns only the ordering facts.
- */
-export function generatePostgresCatalog(
-  options: WithInvocationOptions<PostgresCatalogOptions & { coverage: "ordering" }>,
-): Promise<PostgresOrderingCatalog>;
-export function generatePostgresCatalog(
-  options: WithInvocationOptions<PostgresCatalogOptions & { coverage?: "complete" }>,
-): Promise<PostgresCompleteCatalog>;
-export function generatePostgresCatalog(
-  options: WithInvocationOptions<PostgresCatalogOptions>,
-): Promise<PostgresCatalog>;
+): Promise<WithInvocationResult<ReactUsagesReport>>;

package/invocation-types.d.ts

@@ -11,12 +11,17 @@ export interface InvocationOptions {
   /**
    * Rayon worker count. A positive integer takes precedence over `RAYON_NUM_THREADS`.
    * Omit, `0`, or `null` uses `RAYON_NUM_THREADS`, falling back to CPU count when
-   * unset or invalid, matching CLI `--jobs 0`.
+   * unset, zero, or invalid, matching CLI `--jobs 0`.
    * The first analysis request with valid UTF-8 JSON and invocation controls that
    * acquires the invocation lock initializes the process-wide pool before
    * command-specific options are validated. A later command-validation failure
    * can therefore still select the pool; JSON/control or lock failures cannot.
    * Later calls cannot resize an already initialized pool.
+   * The call that installs the pool does not warn. A later call whose resolved
+   * count differs keeps that pool, does not fail, and includes `jobsPoolWarning`
+   * on the JSON object. Omit, `0`, or `null` does not warn when the resolved
+   * count matches the pool. Concurrent `analyzeProject()` calls and same-user CLI
+   * runs queue on the per-user invocation lock, and each queued run uses the full pool.
    */
   jobs?: number | null;
   /** `ci` sets unbounded command and lock timeouts. CLI `--profile ci` does the same. */
@@ -27,6 +32,27 @@ export interface InvocationOptions {
 
 export type WithInvocationOptions<T> = T & InvocationOptions;
 
+/** Metadata emitted only on analysis JSON objects, never arrays or scalar results. */
+export interface InvocationResultMetadata {
+  jobsPoolWarning?: JobsPoolWarning;
+}
+
+export type WithInvocationResult<T> = T extends readonly unknown[]
+  ? T
+  : T extends object
+    ? T & InvocationResultMetadata
+    : T;
+
+/** Present when a later call's resolved `jobs` cannot resize the process-wide Rayon pool. */
+export interface JobsPoolWarning {
+  code: "rayon-pool-size";
+  message: string;
+  /** Worker count resolved from this call's `jobs` and `RAYON_NUM_THREADS`. */
+  requestedJobs: number;
+  /** Worker count recorded for the process pool. */
+  effectiveJobs: number;
+}
+
 /** One live span; siblings may overlap and labels form the enclosing phase path. */
 export interface ActiveTimingSpan {
   id: number;

package/named-query-types.d.ts

@@ -47,6 +47,12 @@ export interface EffectsOptions {
   depth?: number;
 }
 
+/** One distinct configured match for a physical call occurrence. */
+export interface EffectCallAlternative {
+  callee: string;
+  category?: string;
+}
+
 export interface EffectCallSite {
   file: string;
   line: number;
@@ -54,12 +60,15 @@ export interface EffectCallSite {
   category?: string;
   caller?: string;
   depth: number;
+  /** Sorted distinct matches, omitted unless multiple matches remain after category projection. */
+  alternatives?: EffectCallAlternative[];
 }
 
 export interface EffectsReport {
   kind: string;
   entry: string;
   callSites: EffectCallSite[];
+  /** Physical occurrence count per matched category; sums can exceed callSites.length. */
   byCategory: Record<string, number>;
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "no-mistakes",
-  "version": "0.91.3",
+  "version": "0.93.0",
   "description": "Deterministic impact maps, test plans, Playwright coverage, and repository checks for coding agents",
   "license": "MIT",
   "repository": {
@@ -65,9 +65,9 @@
     }
   },
   "optionalDependencies": {
-    "no-mistakes-darwin-arm64": "0.91.3",
-    "no-mistakes-linux-arm64-gnu": "0.91.3",
-    "no-mistakes-linux-x64-gnu": "0.91.3",
-    "no-mistakes-win32-x64-msvc": "0.91.3"
+    "no-mistakes-darwin-arm64": "0.93.0",
+    "no-mistakes-linux-arm64-gnu": "0.93.0",
+    "no-mistakes-linux-x64-gnu": "0.93.0",
+    "no-mistakes-win32-x64-msvc": "0.93.0"
   }
 }

package/planning-impact-artifacts.js

@@ -88,7 +88,11 @@ async function writePlanningImpactArtifactsUnlocked(options, analyzeProject, ren
       (privateOutput) => writeSuccess(privateOutput, artifacts),
       renameNoReplace,
     );
-    return { outputDirectory: output.path, ...artifacts };
+    return {
+      outputDirectory: output.path,
+      ...artifacts,
+      ...(result.jobsPoolWarning ? { jobsPoolWarning: result.jobsPoolWarning } : {}),
+    };
   } catch (error) {
     if (mayWriteFailureArtifacts && !artifactErrors.isOutputRestorationFailure(error)) {
       try {

package/types.d.ts

@@ -17,3 +17,4 @@ export * from "./postgres-query-annotation-types";
 export * from "./postgres-catalog-types";
 export * from "./planning-impact-artifacts-types";
 export * from "./declared-payload-types";
+export type * from "./forbidden-call-types";