no-mistakes 0.58.0 → 0.59.0

package/README.md

@@ -48,6 +48,10 @@ const report = await analyzeProject({
 Use `analyzeProject()` when reports share a root and configuration. Dedicated
 functions remain convenient for a single query:
 
+`testsWhy` reports that receive `planJson` are materialized in a private
+temporary directory and cleaned up after success, native rejection, or
+preparation failure, including when they are batched through `analyzeProject()`.
+
 ````js
 const {
   dependencies,

package/index.js

@@ -7,7 +7,6 @@ const planning = require("./planning");
 const { writePlanningImpactArtifacts: writeArtifacts } = require("./planning-impact-artifacts");
 const { createPlanningArtifactLock } = require("./planning-impact-artifacts-lock");
 const { createWorkflowTopologyIndex } = require("./workflow-topology-index");
-const fs = require("node:fs");
 const path = require("node:path");
 
 async function callJson(fn, options) {
@@ -64,7 +63,6 @@ const jsonApis = createJsonApis({
   symbols: "symbolsJson",
 });
 
-const PLAN_INPUT_REPORTS = new Set(["testsComment", "testsGraph", "testsGraphMermaid"]);
 const CAMELIZE_REPORTS = new Set(["testsPlan", "testsImpact", "testsTargets", "testsGraph"]);
 const acquirePlanningArtifactLock = createPlanningArtifactLock(native);
 
@@ -73,18 +71,7 @@ async function analyzeProject(options = {}) {
   const generatedDirs = [];
   try {
     if (Array.isArray(request.reports)) {
-      request.reports = await Promise.all(
-        request.reports.map(async (report) => {
-          if (report.type === "testsWhy") {
-            const prepared = await planning.prepareWhyPlan(report);
-            if (prepared.generatedDir) generatedDirs.push(prepared.generatedDir);
-            return prepared.request;
-          }
-          return PLAN_INPUT_REPORTS.has(report.type)
-            ? await planning.decamelizePlanOptions(report)
-            : report;
-        }),
-      );
+      request.reports = await planning.prepareAnalyzeProjectReports(request.reports, generatedDirs);
     }
     const result = await jsonApis.analyzeProject(request);
     for (const report of result.reports || []) {
@@ -114,40 +101,8 @@ async function writePlanningImpactArtifacts(options) {
   );
 }
 
-const topologyMemo = new Map();
-
-async function ciTopology(options) {
-  const root = path.resolve((options && options.root) || process.cwd());
-  const configPath = path.resolve(root, (options && options.config) || ".no-mistakes.yml");
-  let mtime = 0;
-  try {
-    mtime = fs.statSync(configPath).mtimeMs;
-  } catch {
-    mtime = 0;
-  }
-  const workflows = JSON.stringify(
-    []
-      .concat((options && options.workflows) || [])
-      .map(String)
-      .sort(),
-  );
-  const identity = `${root}\0${configPath}\0`;
-  const key = `${identity}${mtime}\0${workflows}`;
-  const stale = [];
-  for (const memoKey of topologyMemo.keys()) {
-    if (!memoKey.startsWith(identity)) continue;
-    const memoMtime = memoKey.slice(identity.length).split("\0")[0];
-    if (memoMtime !== String(mtime)) stale.push(memoKey);
-  }
-  for (const memoKey of stale) topologyMemo.delete(memoKey);
-  const cached = topologyMemo.get(key);
-  if (cached) return cached.then((value) => structuredClone(value));
-  const pending = jsonApis.ciTopology({ ...options, root }).catch((error) => {
-    topologyMemo.delete(key);
-    throw error;
-  });
-  topologyMemo.set(key, pending);
-  return pending.then((value) => structuredClone(value));
+async function ciTopology(options = {}) {
+  return jsonApis.ciTopology({ ...options, root: path.resolve(options.root || process.cwd()) });
 }
 
 const version = () => native.version();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "no-mistakes",
-  "version": "0.58.0",
+  "version": "0.59.0",
   "description": "Deterministic impact maps, test plans, Playwright coverage, and repository checks for coding agents",
   "license": "MIT",
   "repository": {
@@ -45,10 +45,10 @@
     "access": "public"
   },
   "optionalDependencies": {
-    "no-mistakes-darwin-arm64": "0.58.0",
-    "no-mistakes-darwin-x64": "0.58.0",
-    "no-mistakes-linux-arm64-gnu": "0.58.0",
-    "no-mistakes-linux-x64-gnu": "0.58.0",
-    "no-mistakes-win32-x64-msvc": "0.58.0"
+    "no-mistakes-darwin-arm64": "0.59.0",
+    "no-mistakes-darwin-x64": "0.59.0",
+    "no-mistakes-linux-arm64-gnu": "0.59.0",
+    "no-mistakes-linux-x64-gnu": "0.59.0",
+    "no-mistakes-win32-x64-msvc": "0.59.0"
   }
 }

package/planning.js

@@ -7,6 +7,7 @@ const { resolveNativePackage } = require("./scripts/native-package");
 const native = require(
   process.env.NO_MISTAKES_TEST_NAPI_ADDON_PATH || resolveNativePackage().addonPath,
 );
+const PLAN_INPUT_REPORTS = new Set(["testsComment", "testsGraph", "testsGraphMermaid"]);
 
 async function callJson(fn, options) {
   const input = Buffer.from(JSON.stringify(options || {}));
@@ -94,7 +95,15 @@ async function prepareWhyPlan(options = {}) {
   }
   if (document == null) return { request: next };
   const generatedDir = await fs.mkdtemp(path.join(os.tmpdir(), "no-mistakes-why-"));
-  await fs.writeFile(path.join(generatedDir, "plan.json"), JSON.stringify(loadPlanJson(document)));
+  try {
+    await fs.writeFile(
+      path.join(generatedDir, "plan.json"),
+      JSON.stringify(loadPlanJson(document)),
+    );
+  } catch (error) {
+    await removeGeneratedDir(generatedDir);
+    throw error;
+  }
   next.plan = path.join(generatedDir, "plan.json");
   delete next.planJson;
   return { request: next, generatedDir };
@@ -109,6 +118,21 @@ async function removeGeneratedDir(generatedDir) {
   await fs.rm(generatedDir, { recursive: true, force: true }).catch(() => {});
 }
 
+async function prepareAnalyzeProjectReports(reports, generatedDirs) {
+  const preparations = reports.map(async (report) => {
+    if (report.type === "testsWhy") {
+      const prepared = await prepareWhyPlan(report);
+      if (prepared.generatedDir) generatedDirs.push(prepared.generatedDir);
+      return prepared.request;
+    }
+    return PLAN_INPUT_REPORTS.has(report.type) ? await decamelizePlanOptions(report) : report;
+  });
+  const settled = await Promise.allSettled(preparations);
+  const rejected = settled.find((result) => result.status === "rejected");
+  if (rejected) throw rejected.reason;
+  return settled.map((result) => result.value);
+}
+
 function camelizeWhy(value) {
   if (!value || typeof value !== "object" || Array.isArray(value)) {
     return camelizeValue(value);
@@ -176,6 +200,7 @@ module.exports = {
   camelizeWhy,
   decamelizePlanOptions,
   materializeWhyPlan,
+  prepareAnalyzeProjectReports,
   prepareWhyPlan,
   removeGeneratedDir,
   testsComment,