no-mistakes 0.41.0 → 0.43.0

package/analyze-project-types.d.ts

@@ -8,6 +8,7 @@ import type {
 } from "./named-query-types";
 import type { PlaywrightOptions, PlaywrightRelatedOptions } from "./report-types";
 import type {
+  CheckOptions,
   ProjectOptions,
   SymbolsListOptions,
   SymbolsSignatureImpactOptions,
@@ -25,7 +26,7 @@ type BatchedReactUsagesOptions = Pick<
   "root" | "tsconfig" | "config" | "targets" | "include"
 > &
   Required<Pick<ProjectOptions, "target">>;
-type BatchedCheckOptions = Pick<ProjectOptions, "root" | "tsconfig" | "config">;
+type BatchedCheckOptions = Pick<CheckOptions, "root" | "tsconfig" | "config" | "includeSuppressed">;
 
 export type AnalyzeProjectReportRequest =
   | ({ type: "dependencies" | "dependents" | "related"; id?: string } & BatchedTraverseOptions)

package/check-report-types.d.ts

@@ -0,0 +1,57 @@
+import type { QueueCheckFinding } from "./queue-report-types";
+import type { ReactViolation } from "./react-report-types";
+
+export interface CheckReport {
+  react: ReactViolation[];
+  queues: QueueCheckFinding[];
+  rules: RuleFinding[];
+  integration: IntegrationFinding[];
+  codebase: UniqueExportFinding[];
+  warnings: string[];
+  advisories: RuleFinding[];
+  /** Present when `includeSuppressed` is requested; empty when no directives matched. */
+  suppressed?: SuppressedFinding[];
+}
+
+export interface SuppressedFinding {
+  domain: "react" | "queues" | "rules" | "filesystem" | "integration" | "codebase" | "advisories";
+  rule: string;
+  file: string;
+  /** File containing the suppression directive. */
+  sourceFile: string;
+  line?: number;
+  reason: string;
+  directive: {
+    kind: "file" | "line" | "nextLine";
+    line: number;
+  };
+}
+
+export interface RuleFinding {
+  rule: string;
+  file: string;
+  line: number;
+  message: string;
+  import?: string;
+  target?: string;
+}
+
+export interface IntegrationFinding {
+  framework: string;
+  suite: string;
+  file: string;
+  line: number;
+  testName?: string;
+  describePath?: string[];
+  integration?: string;
+  message: string;
+}
+
+export interface UniqueExportFinding {
+  rule: string;
+  file: string;
+  line: number;
+  exportName: string;
+  exportKind: string;
+  message: string;
+}

package/ci-types.d.ts

@@ -115,11 +115,18 @@ export interface ImpactedChecksTiming {
   duration_ms: number;
 }
 
+export interface ImpactedChecksEmptyResult {
+  code: "no-changed-files" | "no-impacted-checks";
+  message: string;
+}
+
 export interface ImpactedChecksReport {
   changed_files: string[];
   checks: CheckCommand[];
   warnings: Array<{ type: string; message: string; file: string }>;
   fallback_triggered: boolean;
+  /** Present only when no changed files or impacted checks were found. */
+  empty_result?: ImpactedChecksEmptyResult;
   /** Present only when `timings: true` was requested. */
   timings?: ImpactedChecksTiming[];
 }

package/fetch-report-types.d.ts

@@ -0,0 +1,86 @@
+export type FetchSourceType =
+  | "page"
+  | "layout"
+  | "loading"
+  | "error"
+  | "template"
+  | "route"
+  | "module";
+
+export type CacheKind =
+  | "none"
+  | "fetch-cache"
+  | "fetch-next-revalidate"
+  | "fetch-next-tags"
+  | "react-cache"
+  | "cache"
+  | "unstable-cache";
+
+export interface FetchOccurrence {
+  path: string;
+  rawPath: string;
+  method: string;
+  file: string;
+  line: number;
+  side: "server" | "client";
+  rsc: boolean;
+  cached: boolean;
+  cacheKind: CacheKind;
+  cachedFunction?: string;
+  dynamic: boolean;
+  unsupported: boolean;
+  functionName?: string;
+  conditional: boolean;
+  inPromiseAll: boolean;
+  errorHandled: boolean;
+  sourceType: FetchSourceType;
+}
+
+export interface FetchRouteReport {
+  route: string;
+  file: string;
+  apiCalls: FetchOccurrence[];
+}
+
+export interface FetchSummary {
+  totalRoutes: number;
+  routesWithApiCalls: number;
+  totalApiCalls: number;
+  uniqueApiCalls: number;
+  duplicateApiCalls: number;
+  dynamicApiCalls: number;
+  cachedApiCalls: number;
+  clientApiCalls: number;
+  serverApiCalls: number;
+  rscApiCalls: number;
+  conditionalApiCalls: number;
+  parallelApiCalls: number;
+  errorHandledApiCalls: number;
+}
+
+export interface FetchReport {
+  summary: FetchSummary;
+  routes: FetchRouteReport[];
+  duplicates: DuplicateApiCall[];
+  unsupported: UnsupportedApiCall[];
+}
+
+export interface DuplicateApiCall {
+  key: string;
+  count: number;
+  occurrences: ApiCallOccurrence[];
+}
+
+export interface ApiCallOccurrence {
+  route: string;
+  file: string;
+  line: number;
+}
+
+export interface UnsupportedApiCall {
+  route: string;
+  file: string;
+  line: number;
+  reason: string;
+  rawPath: string;
+}

package/index.d.ts

@@ -4,11 +4,13 @@ import type {
   AnalyzeProjectResult,
   CallSitesOptions,
   CallSitesResult,
+  CheckOptions,
   DeadExportsOptions,
   DeadExportsResult,
   DependencyResult,
   ExportsOfOptions,
   ExportsOfResult,
+  FetchReport,
   FetchesOptions,
   FlowOptions,
   FlowReport,
@@ -19,11 +21,15 @@ import type {
   MermaidValidationOptions,
   MermaidValidationResult,
   ResolveCheckOptions,
+  ResolveCheckFilesOptions,
   ResolveCheckResult,
+  ResolveCheckBatchResult,
   GraphEdge,
   PlaywrightOptions,
   PlaywrightRelatedOptions,
   ProjectOptions,
+  QueueCheckFinding,
+  QueueEdge,
   QueueReport,
   ReactComponentFacts,
   ReactUsagesReport,
@@ -86,9 +92,12 @@ export function callSites(
 export function resolveCheck(
   options: WithInvocationOptions<ResolveCheckOptions>,
 ): Promise<ResolveCheckResult>;
-export function fetches(options?: WithInvocationOptions<FetchesOptions>): Promise<unknown>;
+export function resolveCheck(
+  options: WithInvocationOptions<ResolveCheckFilesOptions>,
+): Promise<ResolveCheckBatchResult>;
+export function fetches(options?: WithInvocationOptions<FetchesOptions>): Promise<FetchReport>;
 export function flow(options: WithInvocationOptions<FlowOptions>): Promise<FlowReport>;
-export function check(options?: WithInvocationOptions<ProjectOptions>): Promise<CheckReport>;
+export function check(options?: WithInvocationOptions<CheckOptions>): Promise<CheckReport>;
 export function validateMermaidMarkdown(
   options: WithInvocationOptions<MermaidValidationOptions>,
 ): Promise<MermaidValidationResult>;
@@ -122,9 +131,11 @@ export function playwrightTests(
   options?: WithInvocationOptions<PlaywrightOptions>,
 ): Promise<unknown>;
 export function queues(options?: WithInvocationOptions<ProjectOptions>): Promise<QueueReport>;
-export function queueEdges(options?: WithInvocationOptions<ProjectOptions>): Promise<GraphEdge[]>;
-export function queueRelated(options: WithInvocationOptions<ProjectOptions>): Promise<GraphEdge[]>;
-export function queueCheck(options?: WithInvocationOptions<ProjectOptions>): Promise<unknown[]>;
+export function queueEdges(options?: WithInvocationOptions<ProjectOptions>): Promise<QueueEdge[]>;
+export function queueRelated(options: WithInvocationOptions<ProjectOptions>): Promise<QueueEdge[]>;
+export function queueCheck(
+  options?: WithInvocationOptions<ProjectOptions>,
+): Promise<QueueCheckFinding[]>;
 export function serverRoutes(
   options?: WithInvocationOptions<ProjectOptions>,
 ): Promise<ServerRoutesReport>;

package/index.js

@@ -1,6 +1,8 @@
 "use strict";
 
-const native = require("./bin/no-mistakes.node");
+// CI real-addon tests point this at the freshly compiled cdylib without
+// overwriting the package's checked-in install placeholder.
+const native = require(process.env.NO_MISTAKES_TEST_NAPI_ADDON_PATH || "./bin/no-mistakes.node");
 const planning = require("./planning");
 const { createWorkflowTopologyIndex } = require("./workflow-topology-index");
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "no-mistakes",
-  "version": "0.41.0",
+  "version": "0.43.0",
   "description": "Static codebase analysis tools for TS/JS dependencies, dependents, and symbols",
   "license": "MIT",
   "repository": {

package/planning.js

@@ -1,6 +1,6 @@
 "use strict";
 
-const native = require("./bin/no-mistakes.node");
+const native = require(process.env.NO_MISTAKES_TEST_NAPI_ADDON_PATH || "./bin/no-mistakes.node");
 
 async function callJson(fn, options) {
   return JSON.parse(await fn(JSON.stringify(options || {})));

package/query-types.d.ts

@@ -96,13 +96,28 @@ export interface CallSitesResult {
   callSites: CallSite[];
 }
 
-export type ResolveCheckOptions = QueryFileOptions;
+/** Single-file form of `resolveCheck`; cannot be combined with `files`. */
+export type ResolveCheckOptions = QueryFileOptions & {
+  files?: never;
+};
+
+/** Batch form of `resolveCheck`; `files` always returns the batch schema. */
+export interface ResolveCheckFilesOptions {
+  /** A nonempty list of TS/JS files to check. */
+  files: [string, ...string[]];
+  /** Mutually exclusive with `files`. */
+  file?: never;
+  /** Project root. Defaults to the current working directory. */
+  root?: string;
+  /** Path to tsconfig.json for alias resolution. Searched upward if omitted. */
+  tsconfig?: string;
+}
 
 export type ImportResolutionStatus = "resolved" | "unresolved" | "external";
 
 export interface ResolveCheckImport {
   specifier: string;
-  kind: "static" | "type" | "dynamic" | "require";
+  kind: "static" | "type" | "dynamic" | "require" | "require-resolve";
   status: ImportResolutionStatus;
   /** Root-relative resolved target, when the import resolves locally. */
   resolved?: string;
@@ -114,3 +129,9 @@ export interface ResolveCheckResult {
   imports: ResolveCheckImport[];
   unresolved: string[];
 }
+
+export interface ResolveCheckBatchResult {
+  allResolve: boolean;
+  unresolvedFiles: string[];
+  results: ResolveCheckResult[];
+}

package/queue-report-types.d.ts

@@ -0,0 +1,62 @@
+export interface QueueReport {
+  producers: QueueProducer[];
+  workers: QueueWorker[];
+  jobs: QueueJobNode[];
+  edges: QueueEdge[];
+  diagnostics: QueueDiagnostic[];
+  check: QueueCheckFinding[];
+}
+
+export interface QueueJobNode {
+  queueFile: string;
+  queueName: string;
+  job: string;
+}
+
+export interface QueueProducer {
+  file: string;
+  line: number;
+  queueFile: string | null;
+  queueName: string | null;
+  job: string | null;
+  rawJob: string | null;
+  library: string | null;
+}
+
+export interface QueueWorker {
+  file: string;
+  line: number;
+  processorFile: string | null;
+  queueFile: string | null;
+  queueName: string | null;
+  jobs: string[];
+  wildcard: boolean;
+  library: string | null;
+}
+
+export type QueueEdgeKind = "queue-enqueue" | "queue-worker";
+
+export interface QueueEdge {
+  from: string;
+  to: string;
+  kind: QueueEdgeKind;
+}
+
+export type QueueDiagnosticSeverity = "warning" | "error";
+
+export interface QueueDiagnostic {
+  severity: QueueDiagnosticSeverity;
+  file: string;
+  line: number;
+  message: string;
+}
+
+export interface QueueCheckFinding {
+  kind: string;
+  file: string;
+  line: number;
+  queueFile: string | null;
+  queueName: string | null;
+  job: string | null;
+  message: string;
+}

package/react-report-types.d.ts

@@ -0,0 +1,62 @@
+export interface ReactComponentFacts {
+  name: string;
+  file: string;
+  environment: "server" | "client" | "shared" | "unknown";
+  hasState: boolean;
+  hasProps: boolean;
+  passesProps: boolean;
+  usesMemo: boolean;
+  usesContextProvider: boolean;
+  usesSuspense: boolean;
+  fetches: ReactFetchCall[];
+  dependencies: string[];
+  children: ReactComponentRef[];
+  inheritedFromChildren?: ReactAggregatedFacts;
+}
+
+export interface ReactFetchCall {
+  file: string;
+  exportedName: string | null;
+  shape: string | null;
+}
+
+export interface ReactComponentRef {
+  name: string;
+  file: string;
+}
+
+export interface ReactAggregatedFacts {
+  hasState: boolean;
+  hasProps: boolean;
+  passesProps: boolean;
+  usesMemo: boolean;
+  usesContextProvider: boolean;
+  usesSuspense: boolean;
+  hasFetch: boolean;
+}
+
+export interface ReactViolation {
+  component: string;
+  file: string;
+  rule: string;
+  detail: string | null;
+}
+
+export interface ReactCallsite {
+  file: string;
+  line: number;
+  component: string;
+  props: string[];
+  hasSpread: boolean;
+}
+
+export interface ReactUsagesReport {
+  target: { file: string; symbol?: string };
+  callsites: ReactCallsite[];
+  /** Story files importing the target. Omitted when `props`/`tests`-only `include`. */
+  stories?: string[];
+  /** Test files importing the target. */
+  tests?: string[];
+  /** Exported prop type/interface names declared in the target file. */
+  propTypes?: string[];
+}

package/report-types.d.ts

@@ -1,3 +1,8 @@
+export * from "./check-report-types";
+export * from "./fetch-report-types";
+export * from "./queue-report-types";
+export * from "./react-report-types";
+
 export interface PlaywrightOptions {
   /** Project root. Defaults to the current working directory. */
   root?: string;
@@ -22,25 +27,6 @@ export interface PlaywrightRelatedOptions extends PlaywrightOptions {
   files: string[];
 }
 
-export interface CheckReport {
-  react: ReactViolation[];
-  queues: unknown[];
-  rules: unknown[];
-  integration: unknown[];
-  codebase: unknown[];
-  warnings: string[];
-  advisories: unknown[];
-}
-
-export interface QueueReport {
-  producers: unknown[];
-  workers: unknown[];
-  jobs: unknown[];
-  edges: unknown[];
-  diagnostics: unknown[];
-  check: unknown[];
-}
-
 export interface GraphEdge {
   from: string;
   to: string;
@@ -118,112 +104,3 @@ export interface ServerRoutesReport {
   edges: unknown[];
   diagnostics: unknown[];
 }
-
-export type FetchSourceType =
-  | "page"
-  | "layout"
-  | "loading"
-  | "error"
-  | "template"
-  | "route"
-  | "module";
-
-export type CacheKind =
-  | "none"
-  | "fetch-cache"
-  | "fetch-next-revalidate"
-  | "fetch-next-tags"
-  | "react-cache"
-  | "cache"
-  | "unstable-cache";
-
-export interface FetchOccurrence {
-  path: string;
-  rawPath: string;
-  method: string;
-  file: string;
-  line: number;
-  side: "server" | "client";
-  rsc: boolean;
-  cached: boolean;
-  cacheKind: CacheKind;
-  cachedFunction?: string;
-  dynamic: boolean;
-  unsupported: boolean;
-  functionName?: string;
-  conditional: boolean;
-  inPromiseAll: boolean;
-  errorHandled: boolean;
-  sourceType: FetchSourceType;
-}
-
-export interface FetchRouteReport {
-  route: string;
-  file: string;
-  apiCalls: FetchOccurrence[];
-}
-
-export interface FetchSummary {
-  totalRoutes: number;
-  routesWithApiCalls: number;
-  totalApiCalls: number;
-  uniqueApiCalls: number;
-  duplicateApiCalls: number;
-  dynamicApiCalls: number;
-  cachedApiCalls: number;
-  clientApiCalls: number;
-  serverApiCalls: number;
-  rscApiCalls: number;
-  conditionalApiCalls: number;
-  parallelApiCalls: number;
-  errorHandledApiCalls: number;
-}
-
-export interface FetchReport {
-  summary: FetchSummary;
-  routes: FetchRouteReport[];
-  duplicates: unknown[];
-  unsupported: unknown[];
-}
-
-export interface ReactComponentFacts {
-  name: string;
-  file: string;
-  environment: "server" | "client" | "shared" | "unknown";
-  hasState: boolean;
-  hasProps: boolean;
-  passesProps: boolean;
-  usesMemo: boolean;
-  usesContextProvider: boolean;
-  usesSuspense: boolean;
-  fetches: unknown[];
-  dependencies: string[];
-  children: unknown[];
-  inheritedFromChildren?: unknown;
-}
-
-export interface ReactViolation {
-  component: string;
-  file: string;
-  rule: string;
-  detail?: string;
-}
-
-export interface ReactCallsite {
-  file: string;
-  line: number;
-  component: string;
-  props: string[];
-  hasSpread: boolean;
-}
-
-export interface ReactUsagesReport {
-  target: { file: string; symbol?: string };
-  callsites: ReactCallsite[];
-  /** Story files importing the target. Omitted when `props`/`tests`-only `include`. */
-  stories?: string[];
-  /** Test files importing the target. */
-  tests?: string[];
-  /** Exported prop type/interface names declared in the target file. */
-  propTypes?: string[];
-}

package/test-types.d.ts

@@ -1,7 +1,9 @@
 import type { SymbolEntrypoint } from "./traversal-types";
 
-export interface TestsPlanOptions {
-  framework?: "vitest" | "playwright" | "dotnet" | "swift";
+type TestPlanFramework = "vitest" | "playwright" | "dotnet" | "swift";
+
+interface TestsPlanOptionsBase {
+  framework?: TestPlanFramework;
   /** Project root. Defaults to the current working directory. */
   root?: string;
   /** Path to the no-mistakes config file (e.g. .no-mistakes.yml). Auto-discovered in root if omitted. */
@@ -26,6 +28,29 @@ export interface TestsPlanOptions {
   globalConfigFallback?: boolean;
 }
 
+/**
+ * Options for `testsPlan()`. Direct-owner plans intentionally bypass normal
+ * test-plan policy, so their incompatible options are rejected at compile time.
+ */
+export type TestsPlanOptions =
+  | (Omit<
+      TestsPlanOptionsBase,
+      "framework" | "limitPercent" | "limitFiles" | "globalConfigFallback"
+    > & {
+      /** Select changed framework-owned tests plus tests one reverse graph edge away. */
+      directTestOwner: true;
+      framework: TestPlanFramework;
+      /** Direct-owner selection is bounded to changed files; use testsImpact for explicit entrypoints. */
+      entrypoints?: never;
+      limitPercent?: never;
+      limitFiles?: never;
+      globalConfigFallback?: never;
+    })
+  | (TestsPlanOptionsBase & {
+      /** Set to true only with an explicit framework and without policy overrides. */
+      directTestOwner?: false;
+    });
+
 export interface TestsImpactOptions {
   /** Project root. Defaults to the current working directory. */
   root?: string;

package/traversal-types.d.ts

@@ -207,3 +207,8 @@ export interface ProjectOptions {
   /** `reactUsages` `--include` spec: comma-separated `stories,tests,props`. */
   include?: string;
 }
+
+export interface CheckOptions extends ProjectOptions {
+  /** Add deterministic accounting for findings hidden by no-mistakes directives. */
+  includeSuppressed?: boolean;
+}