no-mistakes 0.31.2 → 0.31.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "no-mistakes",
-  "version": "0.31.2",
+  "version": "0.31.4",
   "description": "Static codebase analysis tools for TS/JS dependencies, dependents, and symbols",
   "license": "MIT",
   "repository": {

package/scripts/install/installer.js

@@ -2,12 +2,13 @@
 
 const { createHash, randomBytes } = require("node:crypto");
 const { closeSync, createReadStream, existsSync, openSync, readSync } = require("node:fs");
-const { chmod, mkdir, rename, rm } = require("node:fs/promises");
+const { chmod, mkdir, rename, rm, writeFile } = require("node:fs/promises");
 const { join } = require("node:path");
 
 const { assetName, parseChecksum, releaseBaseUrl } = require("./assets");
 const { download, fetchText } = require("./download");
 const { platformTarget, supportedGlibc } = require("./platform");
+const { installedVersion, versionMarkerPath } = require("./version-marker");
 
 const PLACEHOLDER_TEXT = "Native binary placeholder.";
 const PLACEHOLDER_READ_BYTES = 256;
@@ -48,7 +49,12 @@ async function install(binName, repository, options = {}) {
     );
   }
 
-  if (options.checkExisting && destinationExists && !destinationIsPlaceholder) {
+  if (
+    options.checkExisting &&
+    destinationExists &&
+    !destinationIsPlaceholder &&
+    installedVersion(destination) === version
+  ) {
     return destination;
   }
 
@@ -84,6 +90,7 @@ async function install(binName, repository, options = {}) {
       await chmod(temp, 0o755);
     }
     await rename(temp, destination);
+    await writeFile(versionMarkerPath(destination), version);
     return destination;
   } catch (error) {
     await rm(temp, { force: true });
@@ -202,8 +209,10 @@ function unsupportedPlatformMessage(
 
 module.exports = {
   install,
+  installedVersion,
   isPlaceholder,
   sha256,
   unsupportedPlatformMessage,
   validateReleaseBaseUrl,
+  versionMarkerPath,
 };

package/scripts/install/version-marker.js

@@ -0,0 +1,30 @@
+"use strict";
+
+const { readFileSync } = require("node:fs");
+
+function versionMarkerPath(destination) {
+  return `${destination}.version`;
+}
+
+// The destination binary alone can't tell us which version it is (the CLI's
+// own --version requires spawning a process, and the N-API .node addon isn't
+// executable at all), so track the installed version in a small sidecar file
+// written right after a successful install. A missing or mismatched marker
+// means we can't prove the existing file matches the requested version, so
+// checkExisting must fall through to a real (re)download rather than trust
+// stale bytes left behind by an earlier install of a different version.
+function installedVersion(destination) {
+  try {
+    return readFileSync(versionMarkerPath(destination), "utf8").trim();
+  } catch (error) {
+    if (error.code === "ENOENT") {
+      return null;
+    }
+    throw error;
+  }
+}
+
+module.exports = {
+  installedVersion,
+  versionMarkerPath,
+};