no-mistakes 0.20.0 → 0.21.0

package/README.md

@@ -48,6 +48,12 @@ const {
     files: ["src/utils.mts"],
     include: "both",
   });
+  const signatureImpact = await symbols({
+    root: process.cwd(),
+    files: ["src/utils.mts"],
+    mode: "signature-impact",
+    symbol: "parseDate",
+  });
   const plan = await testsPlan({
     root: process.cwd(),
     framework: "vitest",

package/index.d.ts

@@ -15,8 +15,11 @@ import type {
   ReactUsagesReport,
   ReactViolation,
   ServerRoutesReport,
+  SignatureImpactResult,
+  SymbolsListOptions,
   SymbolsOptions,
   SymbolsResult,
+  SymbolsSignatureImpactOptions,
   TestGraph,
   TestPlan,
   TestsImpactOptions,
@@ -33,7 +36,9 @@ export function dependencies(options: TraverseOptions): Promise<DependencyResult
 export function dependents(options: TraverseOptions): Promise<DependencyResult>;
 export function related(options: TraverseOptions): Promise<DependencyResult>;
 export function analyzeProject(options: AnalyzeProjectOptions): Promise<AnalyzeProjectResult>;
-export function symbols(options: SymbolsOptions): Promise<SymbolsResult>;
+export function symbols(options: SymbolsSignatureImpactOptions): Promise<SignatureImpactResult>;
+export function symbols(options: SymbolsListOptions): Promise<SymbolsResult>;
+export function symbols(options: SymbolsOptions): Promise<SymbolsResult | SignatureImpactResult>;
 export function fetches(options?: FetchesOptions): Promise<unknown>;
 export function check(options?: ProjectOptions): Promise<CheckReport>;
 export function testsPlan(options: TestsPlanOptions): Promise<TestPlan>;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "no-mistakes",
-  "version": "0.20.0",
+  "version": "0.21.0",
   "description": "Static codebase analysis tools for TS/JS dependencies, dependents, and symbols",
   "license": "MIT",
   "repository": {

package/scripts/install/download.js

@@ -60,8 +60,26 @@ function request(
           reject(new Error(`Redirect missing Location header while downloading ${url}`));
           return;
         }
+
+        let redirectedUrl;
+        try {
+          redirectedUrl = new URL(response.headers.location, url);
+        } catch {
+          reject(
+            new Error(
+              `Invalid redirect Location header while downloading ${url}: ${response.headers.location}`,
+            ),
+          );
+          return;
+        }
+
+        if (redirectedUrl.protocol !== "http:" && redirectedUrl.protocol !== "https:") {
+          reject(new Error(`Unsupported redirect protocol: ${redirectedUrl.protocol}`));
+          return;
+        }
+
         request(
-          new URL(response.headers.location, url).toString(),
+          redirectedUrl.toString(),
           handleResponse,
           redirects + 1,
           clients,

package/scripts/install/installer.js

@@ -1,6 +1,6 @@
 "use strict";
 
-const { createHash } = require("node:crypto");
+const { createHash, randomBytes } = require("node:crypto");
 const { closeSync, createReadStream, existsSync, openSync, readSync } = require("node:fs");
 const { chmod, mkdir, rename, rm } = require("node:fs/promises");
 const { join } = require("node:path");
@@ -60,7 +60,7 @@ async function install(binName, repository, options = {}) {
   const validateReleaseDownloadUrl = (url) =>
     validateReleaseBaseUrl(url, repository, { enforcePath: false });
 
-  const temp = `${destination}.tmp-${process.pid}`;
+  const temp = `${destination}.tmp-${randomBytes(8).toString("hex")}`;
 
   await mkdir(vendorDir, { recursive: true });
 

package/traversal-types.d.ts

@@ -68,10 +68,23 @@ export interface SymbolsOptions {
   files: string[];
   root?: string;
   tsconfig?: string;
+  config?: string;
+  mode?: "list" | "signature-impact";
+  symbol?: string;
   kinds?: ExportKind[];
   include?: "exports" | "imports" | "both";
 }
 
+export type SymbolsListOptions = Omit<SymbolsOptions, "mode" | "symbol"> & {
+  mode?: "list";
+  symbol?: string;
+};
+
+export type SymbolsSignatureImpactOptions = SymbolsOptions & {
+  mode: "signature-impact";
+  symbol: string;
+};
+
 export interface SymbolExport {
   name: string;
   kind: string;
@@ -103,6 +116,42 @@ export interface SymbolsResult {
   files: SymbolFile[];
 }
 
+export interface SignatureImpactLocation {
+  file: string;
+  symbol: string;
+  line: number;
+  kind: string;
+}
+
+export interface SignatureImpactCaller {
+  file: string;
+  symbol?: string;
+  depth: number;
+  via: string[];
+}
+
+export interface SignatureImpactTest {
+  file: string;
+  depth: number;
+  via: string[];
+}
+
+export interface SignatureImpactWarning {
+  type: string;
+  message: string;
+}
+
+export interface SignatureImpactResult {
+  roots: string[];
+  symbol: string;
+  definition: SignatureImpactLocation;
+  exports: SignatureImpactLocation[];
+  productionCallers: SignatureImpactCaller[];
+  testCallers: SignatureImpactCaller[];
+  suggestedTests: SignatureImpactTest[];
+  warnings: SignatureImpactWarning[];
+}
+
 export interface ProjectOptions {
   root?: string;
   tsconfig?: string;
@@ -136,7 +185,7 @@ export type AnalyzeProjectReportRequest =
       TraverseOptions,
       "root" | "tsconfig"
     >)
-  | ({ type: "symbols"; id?: string } & SymbolsOptions)
+  | ({ type: "symbols"; id?: string } & (SymbolsListOptions | SymbolsSignatureImpactOptions))
   | ({ type: "queues" | "queueEdges" | "queueCheck"; id?: string } & BatchedProjectOptions)
   | ({ type: "queueRelated"; id?: string } & BatchedQueueRelatedOptions)
   | ({