nnw-theme 2.0.0 → 2.0.1

package/dist/browser.js

@@ -154,6 +154,8 @@ export function failures(state) {
         found.push(`broken images: ${pyReprList(state.brokenImages)}`);
     if (state.collapsedImages.length)
         found.push(`images drawn at zero size: ${pyReprList(state.collapsedImages)}`);
+    if (state.unloadedImages.length)
+        found.push(`images still loading: ${pyReprList(state.unloadedImages)}`);
     found.push(...(state.footnotes ?? []));
     if (state.blocked.length)
         found.push(`external requests: ${pyReprList(state.blocked)}`);
@@ -161,6 +163,21 @@ export function failures(state) {
         found.push(`page errors: ${pyReprList(state.pageErrors)}`);
     return found;
 }
+// Runs in the page before its screenshot. A loading="lazy" image outside the viewport
+// never starts loading in a full-page screenshot, so it would draw as blank space and
+// escape the image checks; NetNewsWire loads it as the reader scrolls, so load every
+// image now and wait (up to timeout ms) for each to finish or fail.
+async function loadImages(timeout) {
+    const images = [...document.images];
+    for (const image of images)
+        if (image.loading === "lazy")
+            image.loading = "eager";
+    const settled = images.map((image) => image.decode().catch(() => { }));
+    await Promise.race([
+        Promise.all(settled),
+        new Promise((resolve) => setTimeout(resolve, timeout)),
+    ]);
+}
 // Runs in the page after its screenshot.
 function pageState() {
     const article = document.querySelector(".articleBody");
@@ -194,6 +211,10 @@ function pageState() {
             return box.width < 1 || box.height < 1;
         })
             .map((image) => image.currentSrc || image.src),
+        // Still loading after loadImages: neither drawn nor covered by the checks above.
+        unloadedImages: [...document.images]
+            .filter((image) => !image.complete)
+            .map((image) => image.currentSrc || image.src),
     };
 }
 /**
@@ -260,6 +281,7 @@ async function checkPage(browser, origin, url, target, screenshot, footnotes) {
         const page = await context.newPage();
         page.on("pageerror", (error) => pageErrors.push(String(error)));
         await page.goto(url, { waitUntil: "networkidle" });
+        await page.evaluate(loadImages, 10_000);
         await page.screenshot({ path: screenshot, fullPage: true });
         const state = await page.evaluate(pageState);
         // Last: it clicks footnotes open, so it must not disturb the screenshot.

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "nnw-theme",
-	"version": "2.0.0",
+	"version": "2.0.1",
 	"description": "Create, preview, check, and publish a NetNewsWire theme.",
 	"license": "Apache-2.0",
 	"author": "Dave Marquard",