nlm-memory 0.5.18 → 0.5.20

package/dist/core/storage/pg-storage.js

@@ -0,0 +1,87 @@
+/**
+ * PgStorage — canonical Storage adapter for PostgreSQL + pgvector.
+ *
+ * Implements the Storage port (init/close/withTransaction). withTransaction
+ * uses the write-queue pattern: the sync callback queues SQL ops, then
+ * PgStorage flushes the queue inside a single BEGIN/COMMIT after the
+ * callback returns.
+ *
+ * pgPool() is a deprecated escape hatch for callers not yet ported to the
+ * Storage interface. Tracked for removal in #215a (PG branch).
+ */
+import { Pool } from "pg";
+import { readFileSync } from "node:fs";
+import { join } from "node:path";
+import { PgFactStore } from "./pg-fact-store.js";
+import { PgSessionStore } from "./pg-session-store.js";
+import { PgTxBoundFactStore, PgTxBoundSessionStore } from "./pg-tx-context.js";
+export class PgStorage {
+    facts;
+    sessions;
+    _pool;
+    _migrationsDir;
+    // Guards against re-entrant (synchronous) nesting only. Not concurrent-call-safe.
+    inTxn = false;
+    constructor(pool, migrationsDir) {
+        this._pool = pool;
+        this._migrationsDir = migrationsDir;
+        this.facts = new PgFactStore(pool);
+        this.sessions = new PgSessionStore(pool);
+    }
+    static create(opts) {
+        const pool = new Pool({ connectionString: opts.connectionString });
+        return new PgStorage(pool, opts.migrationsDir);
+    }
+    async init() {
+        const sql = readFileSync(join(this._migrationsDir, "001_initial.sql"), "utf8");
+        await this._pool.query(sql);
+    }
+    async close() {
+        await this._pool.end();
+    }
+    async withTransaction(fn) {
+        if (this.inTxn) {
+            throw new Error("PgStorage.withTransaction does not support nesting");
+        }
+        this.inTxn = true;
+        const queue = [];
+        const txFacts = new PgTxBoundFactStore(queue);
+        const txSessions = new PgTxBoundSessionStore(queue);
+        const ctx = { facts: txFacts, sessions: txSessions };
+        let result;
+        try {
+            result = fn(ctx);
+        }
+        catch (err) {
+            this.inTxn = false;
+            throw err;
+        }
+        this.inTxn = false;
+        if (queue.length > 0) {
+            const client = await this._pool.connect();
+            try {
+                await client.query("BEGIN");
+                for (const op of queue) {
+                    await client.query(op.sql, op.params);
+                }
+                await client.query("COMMIT");
+            }
+            catch (err) {
+                await client.query("ROLLBACK");
+                throw err;
+            }
+            finally {
+                client.release();
+            }
+        }
+        return result;
+    }
+    /**
+     * @deprecated Escape hatch for callers not yet ported to the Storage
+     * interface. Tracked for removal in #215a (PG branch).
+     */
+    pgPool() {
+        return this._pool;
+    }
+}
+//# sourceMappingURL=pg-storage.js.map

package/dist/core/storage/pg-storage.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"pg-storage.js","sourceRoot":"","sources":["../../../src/core/storage/pg-storage.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;GAUG;AAEH,OAAO,EAAE,IAAI,EAAE,MAAM,IAAI,CAAC;AAC1B,OAAO,EAAE,YAAY,EAAE,MAAM,SAAS,CAAC;AACvC,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAEjC,OAAO,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAC;AACjD,OAAO,EAAE,cAAc,EAAE,MAAM,uBAAuB,CAAC;AACvD,OAAO,EAAE,kBAAkB,EAAE,qBAAqB,EAAiB,MAAM,oBAAoB,CAAC;AAO9F,MAAM,OAAO,SAAS;IACX,KAAK,CAAc;IACnB,QAAQ,CAAiB;IACjB,KAAK,CAAO;IACZ,cAAc,CAAS;IACxC,kFAAkF;IAC1E,KAAK,GAAG,KAAK,CAAC;IAEtB,YAAoB,IAAU,EAAE,aAAqB;QACnD,IAAI,CAAC,KAAK,GAAG,IAAI,CAAC;QAClB,IAAI,CAAC,cAAc,GAAG,aAAa,CAAC;QACpC,IAAI,CAAC,KAAK,GAAG,IAAI,WAAW,CAAC,IAAI,CAAC,CAAC;QACnC,IAAI,CAAC,QAAQ,GAAG,IAAI,cAAc,CAAC,IAAI,CAAC,CAAC;IAC3C,CAAC;IAED,MAAM,CAAC,MAAM,CAAC,IAAsB;QAClC,MAAM,IAAI,GAAG,IAAI,IAAI,CAAC,EAAE,gBAAgB,EAAE,IAAI,CAAC,gBAAgB,EAAE,CAAC,CAAC;QACnE,OAAO,IAAI,SAAS,CAAC,IAAI,EAAE,IAAI,CAAC,aAAa,CAAC,CAAC;IACjD,CAAC;IAED,KAAK,CAAC,IAAI;QACR,MAAM,GAAG,GAAG,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,cAAc,EAAE,iBAAiB,CAAC,EAAE,MAAM,CAAC,CAAC;QAC/E,MAAM,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC;IAC9B,CAAC;IAED,KAAK,CAAC,KAAK;QACT,MAAM,IAAI,CAAC,KAAK,CAAC,GAAG,EAAE,CAAC;IACzB,CAAC;IAED,KAAK,CAAC,eAAe,CAAI,EAA8B;QACrD,IAAI,IAAI,CAAC,KAAK,EAAE,CAAC;YACf,MAAM,IAAI,KAAK,CAAC,oDAAoD,CAAC,CAAC;QACxE,CAAC;QACD,IAAI,CAAC,KAAK,GAAG,IAAI,CAAC;QAClB,MAAM,KAAK,GAAe,EAAE,CAAC;QAC7B,MAAM,OAAO,GAAG,IAAI,kBAAkB,CAAC,KAAK,CAAC,CAAC;QAC9C,MAAM,UAAU,GAAG,IAAI,qBAAqB,CAAC,KAAK,CAAC,CAAC;QACpD,MAAM,GAAG,GAAmB,EAAE,KAAK,EAAE,OAAO,EAAE,QAAQ,EAAE,UAAU,EAAE,CAAC;QACrE,IAAI,MAAS,CAAC;QACd,IAAI,CAAC;YACH,MAAM,GAAG,EAAE,CAAC,GAAG,CAAC,CAAC;QACnB,CAAC;QAAC,OAAO,GAAG,EAAE,CAAC;YACb,IAAI,CAAC,KAAK,GAAG,KAAK,CAAC;YACnB,MAAM,GAAG,CAAC;QACZ,CAAC;QACD,IAAI,CAAC,KAAK,GAAG,KAAK,CAAC;QACnB,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACrB,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,KAAK,CAAC,OAAO,EAAE,CAAC;YAC1C,IAAI,CAAC;gBACH,MAAM,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC;gBAC5B,KAAK,MAAM,EAAE,IAAI,KAAK,EAAE,CAAC;oBACvB,MAAM,MAAM,CAAC,KAAK,CAAC,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,MAAmB,CAAC,CAAC;gBACrD,CAAC;gBACD,MAAM,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC;YAC/B,CAAC;YAAC,OAAO,GAAG,EAAE,CAAC;gBACb,MAAM,MAAM,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC;gBAC/B,MAAM,GAAG,CAAC;YACZ,CAAC;oBAAS,CAAC;gBACT,MAAM,CAAC,OAAO,EAAE,CAAC;YACnB,CAAC;QACH,CAAC;QACD,OAAO,MAAO,CAAC;IACjB,CAAC;IAED;;;OAGG;IACH,MAAM;QACJ,OAAO,IAAI,CAAC,KAAK,CAAC;IACpB,CAAC;CACF"}

package/dist/core/storage/pg-tx-context.d.ts

@@ -0,0 +1,44 @@
+/**
+ * PgTxContext — write-queue for PgStorage.withTransaction.
+ *
+ * PgStorage.withTransaction requires a sync callback (port contract). PG
+ * transactions are async. Bridge: sync callback queues SQL ops; PgStorage
+ * flushes the queue in one BEGIN/COMMIT after the callback returns.
+ *
+ * Read methods throw — they cannot see uncommitted queue state. The
+ * FactStore/SessionStore contracts never read inside withTransaction.
+ */
+import type { FactListFilter, FactQuery, FactSemanticNeighbor, FactStore } from "../../ports/fact-store.js";
+import type { KeywordNeighbor, SemanticNeighbor, SessionFilter, SessionStore } from "../../ports/session-store.js";
+import type { Fact, FactHistoryChain, Session, SessionStatus } from "../../shared/types.js";
+export interface QueuedOp {
+    readonly sql: string;
+    readonly params: readonly unknown[];
+}
+export declare class PgTxBoundFactStore implements FactStore {
+    private readonly q;
+    constructor(q: QueuedOp[]);
+    insert(fact: Fact): Promise<void>;
+    insertMany(facts: ReadonlyArray<Fact>): Promise<void>;
+    markSuperseded(oldId: string, newId: string | null): Promise<void>;
+    ingestSessionFacts(sessionId: string, facts: ReadonlyArray<Fact>): Promise<void>;
+    upsertEmbedding(factId: string, vector: Float32Array): Promise<void>;
+    getById(_id: string): Promise<Fact | null>;
+    findCurrent(_s: string, _p: string): Promise<Fact | null>;
+    list(_q: FactQuery): Promise<ReadonlyArray<Fact>>;
+    listBySession(_id: string): Promise<ReadonlyArray<Fact>>;
+    listForRecall(_f: FactListFilter): Promise<ReadonlyArray<Fact>>;
+    semanticSearch(_v: Float32Array, _n: number): Promise<ReadonlyArray<FactSemanticNeighbor>>;
+    getHistory(_s: string, _p?: string): Promise<ReadonlyArray<FactHistoryChain>>;
+}
+export declare class PgTxBoundSessionStore implements SessionStore {
+    private readonly q;
+    constructor(q: QueuedOp[]);
+    updateStatus(sessionId: string, status: SessionStatus): Promise<void>;
+    markSuperseded(predecessorId: string, successorId: string): Promise<void>;
+    list(_filter?: SessionFilter): Promise<ReadonlyArray<Session>>;
+    getById(_id: string): Promise<Session | null>;
+    getByIds(_ids: ReadonlyArray<string>): Promise<ReadonlyArray<Session>>;
+    semanticSearch(_v: Float32Array, _n: number): Promise<ReadonlyArray<SemanticNeighbor>>;
+    keywordSearch(_q: string, _n: number): Promise<ReadonlyArray<KeywordNeighbor>>;
+}

package/dist/core/storage/pg-tx-context.js

@@ -0,0 +1,133 @@
+/**
+ * PgTxContext — write-queue for PgStorage.withTransaction.
+ *
+ * PgStorage.withTransaction requires a sync callback (port contract). PG
+ * transactions are async. Bridge: sync callback queues SQL ops; PgStorage
+ * flushes the queue in one BEGIN/COMMIT after the callback returns.
+ *
+ * Read methods throw — they cannot see uncommitted queue state. The
+ * FactStore/SessionStore contracts never read inside withTransaction.
+ */
+function noRead(method) {
+    throw new Error(`PgStorage.withTransaction: ${method} read not supported inside sync callback`);
+}
+export class PgTxBoundFactStore {
+    q;
+    constructor(q) {
+        this.q = q;
+    }
+    insert(fact) {
+        this.q.push(insertFactOp(fact));
+        return Promise.resolve();
+    }
+    insertMany(facts) {
+        for (const f of facts)
+            this.q.push(insertFactOp(f));
+        return Promise.resolve();
+    }
+    markSuperseded(oldId, newId) {
+        this.q.push({
+            sql: "UPDATE facts SET superseded_by = $1 WHERE id = $2",
+            params: [newId, oldId],
+        });
+        return Promise.resolve();
+    }
+    ingestSessionFacts(sessionId, facts) {
+        this.q.push({
+            sql: "DELETE FROM facts WHERE source_session_id = $1",
+            params: [sessionId],
+        });
+        for (const f of facts)
+            this.q.push(insertFactOp(f));
+        if (facts.length > 0) {
+            const values = facts
+                .map((_, i) => `($${i * 3 + 1}, $${i * 3 + 2}, $${i * 3 + 3})`)
+                .join(", ");
+            const params = [];
+            for (const f of facts)
+                params.push(f.subject, f.predicate, f.id);
+            this.q.push({
+                sql: `
+          UPDATE facts AS old
+          SET superseded_by = new_f.new_id
+          FROM (VALUES ${values}) AS new_f(subject, predicate, new_id)
+          WHERE old.subject = new_f.subject
+            AND old.predicate = new_f.predicate
+            AND old.superseded_by IS NULL
+            AND old.id != new_f.new_id
+        `,
+                params,
+            });
+        }
+        return Promise.resolve();
+    }
+    upsertEmbedding(factId, vector) {
+        this.q.push({
+            sql: `
+        INSERT INTO fact_embeddings (fact_id, embedding)
+        VALUES ($1, $2)
+        ON CONFLICT (fact_id) DO UPDATE SET embedding = EXCLUDED.embedding
+      `,
+            params: [factId, `[${Array.from(vector).join(",")}]`],
+        });
+        return Promise.resolve();
+    }
+    getById(_id) { return noRead("FactStore.getById"); }
+    findCurrent(_s, _p) { return noRead("FactStore.findCurrent"); }
+    list(_q) { return noRead("FactStore.list"); }
+    listBySession(_id) { return noRead("FactStore.listBySession"); }
+    listForRecall(_f) { return noRead("FactStore.listForRecall"); }
+    semanticSearch(_v, _n) { return noRead("FactStore.semanticSearch"); }
+    getHistory(_s, _p) { return noRead("FactStore.getHistory"); }
+}
+export class PgTxBoundSessionStore {
+    q;
+    constructor(q) {
+        this.q = q;
+    }
+    updateStatus(sessionId, status) {
+        if (status === "idle") {
+            throw new Error("Cannot persist derived status 'idle'");
+        }
+        this.q.push({
+            sql: "UPDATE sessions SET status = $1, updated_at = NOW() WHERE id = $2",
+            params: [status, sessionId],
+        });
+        return Promise.resolve();
+    }
+    markSuperseded(predecessorId, successorId) {
+        this.q.push({
+            sql: `
+        INSERT INTO session_edges (from_session, to_session, kind)
+        VALUES ($1, $2, 'supersedes')
+        ON CONFLICT DO NOTHING
+      `,
+            params: [successorId, predecessorId],
+        });
+        this.q.push({
+            sql: "UPDATE sessions SET status = 'superseded', updated_at = NOW() WHERE id = $1",
+            params: [predecessorId],
+        });
+        return Promise.resolve();
+    }
+    list(_filter) { return noRead("SessionStore.list"); }
+    getById(_id) { return noRead("SessionStore.getById"); }
+    getByIds(_ids) { return noRead("SessionStore.getByIds"); }
+    semanticSearch(_v, _n) { return noRead("SessionStore.semanticSearch"); }
+    keywordSearch(_q, _n) { return noRead("SessionStore.keywordSearch"); }
+}
+function insertFactOp(f) {
+    return {
+        sql: `
+      INSERT INTO facts (
+        id, kind, subject, predicate, value, source_session_id,
+        source_quote, created_at, superseded_by, confidence
+      ) VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10)
+    `,
+        params: [
+            f.id, f.kind, f.subject, f.predicate, f.value,
+            f.sourceSessionId, f.sourceQuote, f.createdAt, f.supersededBy, f.confidence,
+        ],
+    };
+}
+//# sourceMappingURL=pg-tx-context.js.map

package/dist/core/storage/pg-tx-context.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"pg-tx-context.js","sourceRoot":"","sources":["../../../src/core/storage/pg-tx-context.ts"],"names":[],"mappings":"AAAA;;;;;;;;;GASG;AAqBH,SAAS,MAAM,CAAC,MAAc;IAC5B,MAAM,IAAI,KAAK,CAAC,8BAA8B,MAAM,0CAA0C,CAAC,CAAC;AAClG,CAAC;AAED,MAAM,OAAO,kBAAkB;IACA;IAA7B,YAA6B,CAAa;QAAb,MAAC,GAAD,CAAC,CAAY;IAAG,CAAC;IAE9C,MAAM,CAAC,IAAU;QACf,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,IAAI,CAAC,CAAC,CAAC;QAChC,OAAO,OAAO,CAAC,OAAO,EAAE,CAAC;IAC3B,CAAC;IAED,UAAU,CAAC,KAA0B;QACnC,KAAK,MAAM,CAAC,IAAI,KAAK;YAAE,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC,CAAC;QACpD,OAAO,OAAO,CAAC,OAAO,EAAE,CAAC;IAC3B,CAAC;IAED,cAAc,CAAC,KAAa,EAAE,KAAoB;QAChD,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC;YACV,GAAG,EAAE,mDAAmD;YACxD,MAAM,EAAE,CAAC,KAAK,EAAE,KAAK,CAAC;SACvB,CAAC,CAAC;QACH,OAAO,OAAO,CAAC,OAAO,EAAE,CAAC;IAC3B,CAAC;IAED,kBAAkB,CAAC,SAAiB,EAAE,KAA0B;QAC9D,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC;YACV,GAAG,EAAE,gDAAgD;YACrD,MAAM,EAAE,CAAC,SAAS,CAAC;SACpB,CAAC,CAAC;QACH,KAAK,MAAM,CAAC,IAAI,KAAK;YAAE,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC,CAAC;QACpD,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACrB,MAAM,MAAM,GAAG,KAAK;iBACjB,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,KAAK,CAAC,GAAG,CAAC,GAAG,CAAC,MAAM,CAAC,GAAG,CAAC,GAAG,CAAC,MAAM,CAAC,GAAG,CAAC,GAAG,CAAC,GAAG,CAAC;iBAC9D,IAAI,CAAC,IAAI,CAAC,CAAC;YACd,MAAM,MAAM,GAAc,EAAE,CAAC;YAC7B,KAAK,MAAM,CAAC,IAAI,KAAK;gBAAE,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC,SAAS,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC;YACjE,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC;gBACV,GAAG,EAAE;;;yBAGY,MAAM;;;;;SAKtB;gBACD,MAAM;aACP,CAAC,CAAC;QACL,CAAC;QACD,OAAO,OAAO,CAAC,OAAO,EAAE,CAAC;IAC3B,CAAC;IAED,eAAe,CAAC,MAAc,EAAE,MAAoB;QAClD,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC;YACV,GAAG,EAAE;;;;OAIJ;YACD,MAAM,EAAE,CAAC,MAAM,EAAE,IAAI,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC;SACtD,CAAC,CAAC;QACH,OAAO,OAAO,CAAC,OAAO,EAAE,CAAC;IAC3B,CAAC;IAED,OAAO,CAAC,GAAW,IAA0B,OAAO,MAAM,CAAC,mBAAmB,CAAC,CAAC,CAAC,CAAC;IAClF,WAAW,CAAC,EAAU,EAAE,EAAU,IAA0B,OAAO,MAAM,CAAC,uBAAuB,CAAC,CAAC,CAAC,CAAC;IACrG,IAAI,CAAC,EAAa,IAAkC,OAAO,MAAM,CAAC,gBAAgB,CAAC,CAAC,CAAC,CAAC;IACtF,aAAa,CAAC,GAAW,IAAkC,OAAO,MAAM,CAAC,yBAAyB,CAAC,CAAC,CAAC,CAAC;IACtG,aAAa,CAAC,EAAkB,IAAkC,OAAO,MAAM,CAAC,yBAAyB,CAAC,CAAC,CAAC,CAAC;IAC7G,cAAc,CAAC,EAAgB,EAAE,EAAU,IAAkD,OAAO,MAAM,CAAC,0BAA0B,CAAC,CAAC,CAAC,CAAC;IACzI,UAAU,CAAC,EAAU,EAAE,EAAW,IAA8C,OAAO,MAAM,CAAC,sBAAsB,CAAC,CAAC,CAAC,CAAC;CACzH;AAED,MAAM,OAAO,qBAAqB;IACH;IAA7B,YAA6B,CAAa;QAAb,MAAC,GAAD,CAAC,CAAY;IAAG,CAAC;IAE9C,YAAY,CAAC,SAAiB,EAAE,MAAqB;QACnD,IAAI,MAAM,KAAK,MAAM,EAAE,CAAC;YACtB,MAAM,IAAI,KAAK,CAAC,sCAAsC,CAAC,CAAC;QAC1D,CAAC;QACD,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC;YACV,GAAG,EAAE,mEAAmE;YACxE,MAAM,EAAE,CAAC,MAAM,EAAE,SAAS,CAAC;SAC5B,CAAC,CAAC;QACH,OAAO,OAAO,CAAC,OAAO,EAAE,CAAC;IAC3B,CAAC;IAED,cAAc,CAAC,aAAqB,EAAE,WAAmB;QACvD,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC;YACV,GAAG,EAAE;;;;OAIJ;YACD,MAAM,EAAE,CAAC,WAAW,EAAE,aAAa,CAAC;SACrC,CAAC,CAAC;QACH,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC;YACV,GAAG,EAAE,6EAA6E;YAClF,MAAM,EAAE,CAAC,aAAa,CAAC;SACxB,CAAC,CAAC;QACH,OAAO,OAAO,CAAC,OAAO,EAAE,CAAC;IAC3B,CAAC;IAED,IAAI,CAAC,OAAuB,IAAqC,OAAO,MAAM,CAAC,mBAAmB,CAAC,CAAC,CAAC,CAAC;IACtG,OAAO,CAAC,GAAW,IAA6B,OAAO,MAAM,CAAC,sBAAsB,CAAC,CAAC,CAAC,CAAC;IACxF,QAAQ,CAAC,IAA2B,IAAqC,OAAO,MAAM,CAAC,uBAAuB,CAAC,CAAC,CAAC,CAAC;IAClH,cAAc,CAAC,EAAgB,EAAE,EAAU,IAA8C,OAAO,MAAM,CAAC,6BAA6B,CAAC,CAAC,CAAC,CAAC;IACxI,aAAa,CAAC,EAAU,EAAE,EAAU,IAA6C,OAAO,MAAM,CAAC,4BAA4B,CAAC,CAAC,CAAC,CAAC;CAChI;AAED,SAAS,YAAY,CAAC,CAAO;IAC3B,OAAO;QACL,GAAG,EAAE;;;;;KAKJ;QACD,MAAM,EAAE;YACN,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC,SAAS,EAAE,CAAC,CAAC,KAAK;YAC7C,CAAC,CAAC,eAAe,EAAE,CAAC,CAAC,WAAW,EAAE,CAAC,CAAC,SAAS,EAAE,CAAC,CAAC,YAAY,EAAE,CAAC,CAAC,UAAU;SAC5E;KACF,CAAC;AACJ,CAAC"}

package/dist/core/storage/sqlite-fact-store.d.ts

@@ -10,7 +10,7 @@
  *
  * Surface evolution:
  *   B.1 — insert, getById, findCurrent, list, listBySession, markSuperseded
- *   B.2 — insertManyInTxn (atomic session+facts ingest), embedding write helper
+ *   B.2: ingestSessionFacts (atomic session+facts ingest), embedding write helper
  *   B.3 — listForRecall (pre-filter for FactRecallService), semanticSearch,
  *         getHistory (supersedence chain inspection)
  *   B.4 — auto-supersedence on (subject, predicate) collision (deferred)
@@ -20,16 +20,21 @@ import type { FactListFilter, FactQuery, FactSemanticNeighbor, FactStore } from
 import type { Fact, FactHistoryChain } from "../../shared/types.js";
 export declare class SqliteFactStore implements FactStore {
     private readonly db;
+    /**
+     * @internal. Construct via SqliteStorage.create(...) instead. Direct
+     * construction is preserved for the SqliteStorage adapter only; all
+     * other callers should reach FactStore via storage.facts.
+     */
     constructor(db: Database.Database);
     insert(fact: Fact): Promise<void>;
     insertMany(facts: ReadonlyArray<Fact>): Promise<void>;
     /**
-     * Insert facts inside an already-open transaction (no own txn opened).
-     * Callable only from code that has already begun a transaction on the same
-     * connection — currently SqliteSessionStore.insertSession. Phase B.2: this
-     * is how session+facts ingest commits atomically (Section 5 of the plan).
+     * @internal. Sync row insert for use inside an already-open better-sqlite3
+     * transaction. Used only by SqliteSessionStore's inlined ingest blocks
+     * (which require sync execution inside the txn callback). External callers
+     * use insertMany() or ingestSessionFacts() via Storage.withTransaction.
      */
-    insertManyInTxn(facts: ReadonlyArray<Fact>): void;
+    insertRowInTxn(fact: Fact): void;
     getById(id: string): Promise<Fact | null>;
     findCurrent(subject: string, predicate: string): Promise<Fact | null>;
     list(query: FactQuery): Promise<ReadonlyArray<Fact>>;
@@ -42,8 +47,9 @@ export declare class SqliteFactStore implements FactStore {
      * trap embedder errors so an unreachable Ollama doesn't roll back ingest.
      * vec0 doesn't UPDATE, so this is a DELETE+INSERT pair.
      */
-    upsertEmbedding(factId: string, vector: Float32Array): void;
+    upsertEmbedding(factId: string, vector: Float32Array): Promise<void>;
     markSuperseded(oldId: string, newId: string | null): Promise<void>;
+    ingestSessionFacts(sessionId: string, facts: ReadonlyArray<Fact>): Promise<void>;
     private insertStmt;
     private toRow;
     private rowToFact;

package/dist/core/storage/sqlite-fact-store.js

@@ -10,13 +10,18 @@
  *
  * Surface evolution:
  *   B.1 — insert, getById, findCurrent, list, listBySession, markSuperseded
- *   B.2 — insertManyInTxn (atomic session+facts ingest), embedding write helper
+ *   B.2: ingestSessionFacts (atomic session+facts ingest), embedding write helper
  *   B.3 — listForRecall (pre-filter for FactRecallService), semanticSearch,
  *         getHistory (supersedence chain inspection)
  *   B.4 — auto-supersedence on (subject, predicate) collision (deferred)
  */
 export class SqliteFactStore {
     db;
+    /**
+     * @internal. Construct via SqliteStorage.create(...) instead. Direct
+     * construction is preserved for the SqliteStorage adapter only; all
+     * other callers should reach FactStore via storage.facts.
+     */
     constructor(db) {
         this.db = db;
     }
@@ -34,17 +39,13 @@ export class SqliteFactStore {
         txn(facts.map((f) => this.toRow(f)));
     }
     /**
-     * Insert facts inside an already-open transaction (no own txn opened).
-     * Callable only from code that has already begun a transaction on the same
-     * connection — currently SqliteSessionStore.insertSession. Phase B.2: this
-     * is how session+facts ingest commits atomically (Section 5 of the plan).
+     * @internal. Sync row insert for use inside an already-open better-sqlite3
+     * transaction. Used only by SqliteSessionStore's inlined ingest blocks
+     * (which require sync execution inside the txn callback). External callers
+     * use insertMany() or ingestSessionFacts() via Storage.withTransaction.
      */
-    insertManyInTxn(facts) {
-        if (facts.length === 0)
-            return;
-        const stmt = this.insertStmt();
-        for (const f of facts)
-            stmt.run(this.toRow(f));
+    insertRowInTxn(fact) {
+        this.insertStmt().run(this.toRow(fact));
     }
     async getById(id) {
         const row = this.db
@@ -183,7 +184,7 @@ export class SqliteFactStore {
      * trap embedder errors so an unreachable Ollama doesn't roll back ingest.
      * vec0 doesn't UPDATE, so this is a DELETE+INSERT pair.
      */
-    upsertEmbedding(factId, vector) {
+    async upsertEmbedding(factId, vector) {
         const blob = Buffer.from(vector.buffer, vector.byteOffset, vector.byteLength);
         this.db.prepare("DELETE FROM fact_embeddings WHERE fact_id = ?").run(factId);
         this.db
@@ -213,6 +214,31 @@ export class SqliteFactStore {
         });
         txn();
     }
+    async ingestSessionFacts(sessionId, facts) {
+        this.db.prepare("DELETE FROM facts WHERE source_session_id = ?").run(sessionId);
+        if (facts.length === 0)
+            return;
+        const insertStmt = this.insertStmt();
+        for (const f of facts)
+            insertStmt.run(this.toRow(f));
+        const findCollisionStmt = this.db.prepare(`
+      SELECT id
+      FROM facts
+      WHERE subject = ?
+        AND predicate = ?
+        AND superseded_by IS NULL
+        AND id != ?
+      ORDER BY created_at DESC
+      LIMIT 1
+    `);
+        const markSupersededStmt = this.db.prepare("UPDATE facts SET superseded_by = ? WHERE id = ?");
+        for (const f of facts) {
+            const collision = findCollisionStmt.get(f.subject, f.predicate, f.id);
+            if (collision && collision.id !== f.id) {
+                markSupersededStmt.run(f.id, collision.id);
+            }
+        }
+    }
     insertStmt() {
         return this.db.prepare(`
       INSERT INTO facts (

package/dist/core/storage/sqlite-fact-store.js.map

@@ -1 +1 @@
-{"version":3,"file":"sqlite-fact-store.js","sourceRoot":"","sources":["../../../src/core/storage/sqlite-fact-store.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;GAgBG;AA0BH,MAAM,OAAO,eAAe;IACG;IAA7B,YAA6B,EAAqB;QAArB,OAAE,GAAF,EAAE,CAAmB;IAAG,CAAC;IAEtD,KAAK,CAAC,MAAM,CAAC,IAAU;QACrB,IAAI,CAAC,UAAU,EAAE,CAAC,GAAG,CAAC,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC;IAC1C,CAAC;IAED,KAAK,CAAC,UAAU,CAAC,KAA0B;QACzC,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO;QAC/B,MAAM,IAAI,GAAG,IAAI,CAAC,UAAU,EAAE,CAAC;QAC/B,MAAM,GAAG,GAAG,IAAI,CAAC,EAAE,CAAC,WAAW,CAAC,CAAC,IAA4B,EAAE,EAAE;YAC/D,KAAK,MAAM,GAAG,IAAI,IAAI;gBAAE,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;QACxC,CAAC,CAAC,CAAC;QACH,GAAG,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;IACvC,CAAC;IAED;;;;;OAKG;IACH,eAAe,CAAC,KAA0B;QACxC,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO;QAC/B,MAAM,IAAI,GAAG,IAAI,CAAC,UAAU,EAAE,CAAC;QAC/B,KAAK,MAAM,CAAC,IAAI,KAAK;YAAE,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC;IACjD,CAAC;IAED,KAAK,CAAC,OAAO,CAAC,EAAU;QACtB,MAAM,GAAG,GAAG,IAAI,CAAC,EAAE;aAChB,OAAO,CACN;;iCAEyB,CAC1B;aACA,GAAG,CAAC,EAAE,CAAC,CAAC;QACX,OAAO,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;IAC1C,CAAC;IAED,KAAK,CAAC,WAAW,CAAC,OAAe,EAAE,SAAiB;QAClD,MAAM,GAAG,GAAG,IAAI,CAAC,EAAE;aAChB,OAAO,CACN;;;;;iBAKS,CACV;aACA,GAAG,CAAC,OAAO,EAAE,SAAS,CAAC,CAAC;QAC3B,OAAO,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;IAC1C,CAAC;IAED,KAAK,CAAC,IAAI,CAAC,KAAgB;QACzB,MAAM,KAAK,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,KAAK,IAAI,EAAE,CAAC,CAAC,CAAC;QACzD,MAAM,iBAAiB,GAAG,KAAK,CAAC,iBAAiB,KAAK,IAAI,CAAC;QAE3D,MAAM,KAAK,GAAa,CAAC,aAAa,CAAC,CAAC;QACxC,MAAM,MAAM,GAA2B,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC;QACvD,IAAI,KAAK,CAAC,SAAS,KAAK,SAAS,EAAE,CAAC;YAClC,KAAK,CAAC,IAAI,CAAC,eAAe,CAAC,CAAC;YAC5B,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC;QAC/B,CAAC;QACD,IAAI,CAAC,iBAAiB;YAAE,KAAK,CAAC,IAAI,CAAC,uBAAuB,CAAC,CAAC;QAC5D,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAEnB,MAAM,IAAI,GAAG,IAAI,CAAC,EAAE;aACjB,OAAO,CACN;;;iBAGS,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC;;iBAEnB,CACV;aACA,GAAG,CAAC,GAAG,MAAM,CAAC,CAAC;QAClB,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC;IAC5C,CAAC;IAED,KAAK,CAAC,aAAa,CAAC,SAAiB;QACnC,MAAM,IAAI,GAAG,IAAI,CAAC,EAAE;aACjB,OAAO,CACN;;;;iCAIyB,CAC1B;aACA,GAAG,CAAC,SAAS,CAAC,CAAC;QAClB,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC;IAC5C,CAAC;IAED,KAAK,CAAC,aAAa,CAAC,MAAsB;QACxC,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,MAAM,MAAM,GAA2B,EAAE,CAAC;QAC1C,IAAI,MAAM,CAAC,OAAO,KAAK,SAAS,EAAE,CAAC;YACjC,KAAK,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC;YAC1B,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC;QAC9B,CAAC;QACD,IAAI,MAAM,CAAC,SAAS,KAAK,SAAS,EAAE,CAAC;YACnC,KAAK,CAAC,IAAI,CAAC,eAAe,CAAC,CAAC;YAC5B,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC;QAChC,CAAC;QACD,IAAI,MAAM,CAAC,IAAI,KAAK,SAAS,EAAE,CAAC;YAC9B,KAAK,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;YACvB,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;QAC3B,CAAC;QACD,IAAI,MAAM,CAAC,aAAa,KAAK,SAAS,EAAE,CAAC;YACvC,KAAK,CAAC,IAAI,CAAC,iBAAiB,CAAC,CAAC;YAC9B,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,aAAa,CAAC,CAAC;QACpC,CAAC;QACD,IAAI,MAAM,CAAC,iBAAiB,KAAK,IAAI,EAAE,CAAC;YACtC,KAAK,CAAC,IAAI,CAAC,uBAAuB,CAAC,CAAC;QACtC,CAAC;QACD,MAAM,KAAK,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,IAAI,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,IAAI,GAAG,CAAC,CAAC,CAAC;QAC3D,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACnB,MAAM,GAAG,GAAG;;;;QAIR,KAAK,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,QAAQ,GAAG,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,EAAE;;;KAGzD,CAAC;QACF,MAAM,IAAI,GAAG,IAAI,CAAC,EAAE;aACjB,OAAO,CAAkC,GAAG,CAAC;aAC7C,GAAG,CAAC,GAAG,MAAM,CAAC,CAAC;QAClB,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC;IAC5C,CAAC;IAED,KAAK,CAAC,cAAc,CAClB,WAAyB,EACzB,KAAa;QAEb,MAAM,CAAC,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC;QACzC,MAAM,IAAI,GAAG,MAAM,CAAC,IAAI,CACtB,WAAW,CAAC,MAAM,EAClB,WAAW,CAAC,UAAU,EACtB,WAAW,CAAC,UAAU,CACvB,CAAC;QACF,MAAM,IAAI,GAAG,IAAI,CAAC,EAAE;aACjB,OAAO,CAAgC;;;;;;OAMvC,CAAC;aACD,GAAG,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;QAChB,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,MAAM,EAAE,CAAC,CAAC,OAAO,EAAE,QAAQ,EAAE,CAAC,CAAC,QAAQ,EAAE,CAAC,CAAC,CAAC;IACxE,CAAC;IAED,KAAK,CAAC,UAAU,CACd,OAAe,EACf,SAAkB;QAElB,MAAM,GAAG,GAAG,SAAS;YACnB,CAAC,CAAC;;;;iDAIyC;YAC3C,CAAC,CAAC;;;;iDAIyC,CAAC;QAC9C,MAAM,IAAI,GAAG,SAAS;YACpB,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,OAAO,CAA4B,GAAG,CAAC,CAAC,GAAG,CAAC,OAAO,EAAE,SAAS,CAAC;YACzE,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,OAAO,CAAoB,GAAG,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;QAEzD,MAAM,MAAM,GAAG,IAAI,GAAG,EAAkB,CAAC;QACzC,KAAK,MAAM,CAAC,IAAI,IAAI,EAAE,CAAC;YACrB,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;YAC/B,MAAM,MAAM,GAAG,MAAM,CAAC,GAAG,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;YAC1C,IAAI,MAAM;gBAAE,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;;gBACzB,MAAM,CAAC,GAAG,CAAC,IAAI,CAAC,SAAS,EAAE,CAAC,IAAI,CAAC,CAAC,CAAC;QAC1C,CAAC;QACD,MAAM,MAAM,GAAuB,EAAE,CAAC;QACtC,KAAK,MAAM,CAAC,IAAI,EAAE,OAAO,CAAC,IAAI,MAAM,CAAC,OAAO,EAAE,EAAE,CAAC;YAC/C,MAAM,CAAC,IAAI,CAAC,EAAE,OAAO,EAAE,SAAS,EAAE,IAAI,EAAE,OAAO,EAAE,CAAC,CAAC;QACrD,CAAC;QACD,OAAO,MAAM,CAAC;IAChB,CAAC;IAED;;;;OAIG;IACH,eAAe,CAAC,MAAc,EAAE,MAAoB;QAClD,MAAM,IAAI,GAAG,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,UAAU,EAAE,MAAM,CAAC,UAAU,CAAC,CAAC;QAC9E,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC,+CAA+C,CAAC,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;QAC7E,IAAI,CAAC,EAAE;aACJ,OAAO,CAAC,gEAAgE,CAAC;aACzE,GAAG,CAAC,MAAM,EAAE,IAAI,CAAC,CAAC;IACvB,CAAC;IAED,KAAK,CAAC,cAAc,CAAC,KAAa,EAAE,KAAoB;QACtD,IAAI,KAAK,KAAK,IAAI,IAAI,KAAK,KAAK,KAAK,EAAE,CAAC;YACtC,MAAM,IAAI,KAAK,CAAC,gCAAgC,CAAC,CAAC;QACpD,CAAC;QACD,MAAM,GAAG,GAAG,IAAI,CAAC,EAAE,CAAC,WAAW,CAAC,GAAG,EAAE;YACnC,MAAM,GAAG,GAAG,IAAI,CAAC,EAAE;iBAChB,OAAO,CAA2B,mCAAmC,CAAC;iBACtE,GAAG,CAAC,KAAK,CAAC,CAAC;YACd,IAAI,CAAC,GAAG;gBAAE,MAAM,IAAI,KAAK,CAAC,QAAQ,KAAK,YAAY,CAAC,CAAC;YACrD,IAAI,KAAK,KAAK,IAAI,EAAE,CAAC;gBACnB,MAAM,IAAI,GAAG,IAAI,CAAC,EAAE;qBACjB,OAAO,CAA2B,mCAAmC,CAAC;qBACtE,GAAG,CAAC,KAAK,CAAC,CAAC;gBACd,IAAI,CAAC,IAAI;oBAAE,MAAM,IAAI,KAAK,CAAC,QAAQ,KAAK,YAAY,CAAC,CAAC;YACxD,CAAC;YACD,IAAI,CAAC,EAAE;iBACJ,OAAO,CAAC,iDAAiD,CAAC;iBAC1D,GAAG,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACvB,CAAC,CAAC,CAAC;QACH,GAAG,EAAE,CAAC;IACR,CAAC;IAEO,UAAU;QAChB,OAAO,IAAI,CAAC,EAAE,CAAC,OAAO,CAAU;;;;;;;;KAQ/B,CAAC,CAAC;IACL,CAAC;IAEO,KAAK,CAAC,IAAU;QACtB,OAAO;YACL,EAAE,EAAE,IAAI,CAAC,EAAE;YACX,IAAI,EAAE,IAAI,CAAC,IAAI;YACf,OAAO,EAAE,IAAI,CAAC,OAAO;YACrB,SAAS,EAAE,IAAI,CAAC,SAAS;YACzB,KAAK,EAAE,IAAI,CAAC,KAAK;YACjB,iBAAiB,EAAE,IAAI,CAAC,eAAe;YACvC,YAAY,EAAE,IAAI,CAAC,WAAW;YAC9B,UAAU,EAAE,IAAI,CAAC,SAAS;YAC1B,aAAa,EAAE,IAAI,CAAC,YAAY;YAChC,UAAU,EAAE,IAAI,CAAC,UAAU;SAC5B,CAAC;IACJ,CAAC;IAEO,SAAS,CAAC,GAAY;QAC5B,OAAO;YACL,EAAE,EAAE,GAAG,CAAC,EAAE;YACV,IAAI,EAAE,GAAG,CAAC,IAAI;YACd,OAAO,EAAE,GAAG,CAAC,OAAO;YACpB,SAAS,EAAE,GAAG,CAAC,SAAS;YACxB,KAAK,EAAE,GAAG,CAAC,KAAK;YAChB,eAAe,EAAE,GAAG,CAAC,iBAAiB;YACtC,WAAW,EAAE,GAAG,CAAC,YAAY;YAC7B,SAAS,EAAE,GAAG,CAAC,UAAU;YACzB,YAAY,EAAE,GAAG,CAAC,aAAa;YAC/B,UAAU,EAAE,GAAG,CAAC,UAAU;SAC3B,CAAC;IACJ,CAAC;CACF"}
+{"version":3,"file":"sqlite-fact-store.js","sourceRoot":"","sources":["../../../src/core/storage/sqlite-fact-store.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;GAgBG;AA0BH,MAAM,OAAO,eAAe;IAMG;IAL7B;;;;OAIG;IACH,YAA6B,EAAqB;QAArB,OAAE,GAAF,EAAE,CAAmB;IAAG,CAAC;IAEtD,KAAK,CAAC,MAAM,CAAC,IAAU;QACrB,IAAI,CAAC,UAAU,EAAE,CAAC,GAAG,CAAC,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC;IAC1C,CAAC;IAED,KAAK,CAAC,UAAU,CAAC,KAA0B;QACzC,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO;QAC/B,MAAM,IAAI,GAAG,IAAI,CAAC,UAAU,EAAE,CAAC;QAC/B,MAAM,GAAG,GAAG,IAAI,CAAC,EAAE,CAAC,WAAW,CAAC,CAAC,IAA4B,EAAE,EAAE;YAC/D,KAAK,MAAM,GAAG,IAAI,IAAI;gBAAE,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;QACxC,CAAC,CAAC,CAAC;QACH,GAAG,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;IACvC,CAAC;IAED;;;;;OAKG;IACH,cAAc,CAAC,IAAU;QACvB,IAAI,CAAC,UAAU,EAAE,CAAC,GAAG,CAAC,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC;IAC1C,CAAC;IAED,KAAK,CAAC,OAAO,CAAC,EAAU;QACtB,MAAM,GAAG,GAAG,IAAI,CAAC,EAAE;aAChB,OAAO,CACN;;iCAEyB,CAC1B;aACA,GAAG,CAAC,EAAE,CAAC,CAAC;QACX,OAAO,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;IAC1C,CAAC;IAED,KAAK,CAAC,WAAW,CAAC,OAAe,EAAE,SAAiB;QAClD,MAAM,GAAG,GAAG,IAAI,CAAC,EAAE;aAChB,OAAO,CACN;;;;;iBAKS,CACV;aACA,GAAG,CAAC,OAAO,EAAE,SAAS,CAAC,CAAC;QAC3B,OAAO,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;IAC1C,CAAC;IAED,KAAK,CAAC,IAAI,CAAC,KAAgB;QACzB,MAAM,KAAK,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,KAAK,IAAI,EAAE,CAAC,CAAC,CAAC;QACzD,MAAM,iBAAiB,GAAG,KAAK,CAAC,iBAAiB,KAAK,IAAI,CAAC;QAE3D,MAAM,KAAK,GAAa,CAAC,aAAa,CAAC,CAAC;QACxC,MAAM,MAAM,GAA2B,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC;QACvD,IAAI,KAAK,CAAC,SAAS,KAAK,SAAS,EAAE,CAAC;YAClC,KAAK,CAAC,IAAI,CAAC,eAAe,CAAC,CAAC;YAC5B,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC;QAC/B,CAAC;QACD,IAAI,CAAC,iBAAiB;YAAE,KAAK,CAAC,IAAI,CAAC,uBAAuB,CAAC,CAAC;QAC5D,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAEnB,MAAM,IAAI,GAAG,IAAI,CAAC,EAAE;aACjB,OAAO,CACN;;;iBAGS,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC;;iBAEnB,CACV;aACA,GAAG,CAAC,GAAG,MAAM,CAAC,CAAC;QAClB,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC;IAC5C,CAAC;IAED,KAAK,CAAC,aAAa,CAAC,SAAiB;QACnC,MAAM,IAAI,GAAG,IAAI,CAAC,EAAE;aACjB,OAAO,CACN;;;;iCAIyB,CAC1B;aACA,GAAG,CAAC,SAAS,CAAC,CAAC;QAClB,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC;IAC5C,CAAC;IAED,KAAK,CAAC,aAAa,CAAC,MAAsB;QACxC,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,MAAM,MAAM,GAA2B,EAAE,CAAC;QAC1C,IAAI,MAAM,CAAC,OAAO,KAAK,SAAS,EAAE,CAAC;YACjC,KAAK,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC;YAC1B,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC;QAC9B,CAAC;QACD,IAAI,MAAM,CAAC,SAAS,KAAK,SAAS,EAAE,CAAC;YACnC,KAAK,CAAC,IAAI,CAAC,eAAe,CAAC,CAAC;YAC5B,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC;QAChC,CAAC;QACD,IAAI,MAAM,CAAC,IAAI,KAAK,SAAS,EAAE,CAAC;YAC9B,KAAK,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;YACvB,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;QAC3B,CAAC;QACD,IAAI,MAAM,CAAC,aAAa,KAAK,SAAS,EAAE,CAAC;YACvC,KAAK,CAAC,IAAI,CAAC,iBAAiB,CAAC,CAAC;YAC9B,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,aAAa,CAAC,CAAC;QACpC,CAAC;QACD,IAAI,MAAM,CAAC,iBAAiB,KAAK,IAAI,EAAE,CAAC;YACtC,KAAK,CAAC,IAAI,CAAC,uBAAuB,CAAC,CAAC;QACtC,CAAC;QACD,MAAM,KAAK,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,IAAI,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,IAAI,GAAG,CAAC,CAAC,CAAC;QAC3D,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACnB,MAAM,GAAG,GAAG;;;;QAIR,KAAK,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,QAAQ,GAAG,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,EAAE;;;KAGzD,CAAC;QACF,MAAM,IAAI,GAAG,IAAI,CAAC,EAAE;aACjB,OAAO,CAAkC,GAAG,CAAC;aAC7C,GAAG,CAAC,GAAG,MAAM,CAAC,CAAC;QAClB,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC;IAC5C,CAAC;IAED,KAAK,CAAC,cAAc,CAClB,WAAyB,EACzB,KAAa;QAEb,MAAM,CAAC,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC;QACzC,MAAM,IAAI,GAAG,MAAM,CAAC,IAAI,CACtB,WAAW,CAAC,MAAM,EAClB,WAAW,CAAC,UAAU,EACtB,WAAW,CAAC,UAAU,CACvB,CAAC;QACF,MAAM,IAAI,GAAG,IAAI,CAAC,EAAE;aACjB,OAAO,CAAgC;;;;;;OAMvC,CAAC;aACD,GAAG,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;QAChB,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,MAAM,EAAE,CAAC,CAAC,OAAO,EAAE,QAAQ,EAAE,CAAC,CAAC,QAAQ,EAAE,CAAC,CAAC,CAAC;IACxE,CAAC;IAED,KAAK,CAAC,UAAU,CACd,OAAe,EACf,SAAkB;QAElB,MAAM,GAAG,GAAG,SAAS;YACnB,CAAC,CAAC;;;;iDAIyC;YAC3C,CAAC,CAAC;;;;iDAIyC,CAAC;QAC9C,MAAM,IAAI,GAAG,SAAS;YACpB,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,OAAO,CAA4B,GAAG,CAAC,CAAC,GAAG,CAAC,OAAO,EAAE,SAAS,CAAC;YACzE,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,OAAO,CAAoB,GAAG,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;QAEzD,MAAM,MAAM,GAAG,IAAI,GAAG,EAAkB,CAAC;QACzC,KAAK,MAAM,CAAC,IAAI,IAAI,EAAE,CAAC;YACrB,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;YAC/B,MAAM,MAAM,GAAG,MAAM,CAAC,GAAG,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;YAC1C,IAAI,MAAM;gBAAE,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;;gBACzB,MAAM,CAAC,GAAG,CAAC,IAAI,CAAC,SAAS,EAAE,CAAC,IAAI,CAAC,CAAC,CAAC;QAC1C,CAAC;QACD,MAAM,MAAM,GAAuB,EAAE,CAAC;QACtC,KAAK,MAAM,CAAC,IAAI,EAAE,OAAO,CAAC,IAAI,MAAM,CAAC,OAAO,EAAE,EAAE,CAAC;YAC/C,MAAM,CAAC,IAAI,CAAC,EAAE,OAAO,EAAE,SAAS,EAAE,IAAI,EAAE,OAAO,EAAE,CAAC,CAAC;QACrD,CAAC;QACD,OAAO,MAAM,CAAC;IAChB,CAAC;IAED;;;;OAIG;IACH,KAAK,CAAC,eAAe,CAAC,MAAc,EAAE,MAAoB;QACxD,MAAM,IAAI,GAAG,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,UAAU,EAAE,MAAM,CAAC,UAAU,CAAC,CAAC;QAC9E,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC,+CAA+C,CAAC,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;QAC7E,IAAI,CAAC,EAAE;aACJ,OAAO,CAAC,gEAAgE,CAAC;aACzE,GAAG,CAAC,MAAM,EAAE,IAAI,CAAC,CAAC;IACvB,CAAC;IAED,KAAK,CAAC,cAAc,CAAC,KAAa,EAAE,KAAoB;QACtD,IAAI,KAAK,KAAK,IAAI,IAAI,KAAK,KAAK,KAAK,EAAE,CAAC;YACtC,MAAM,IAAI,KAAK,CAAC,gCAAgC,CAAC,CAAC;QACpD,CAAC;QACD,MAAM,GAAG,GAAG,IAAI,CAAC,EAAE,CAAC,WAAW,CAAC,GAAG,EAAE;YACnC,MAAM,GAAG,GAAG,IAAI,CAAC,EAAE;iBAChB,OAAO,CAA2B,mCAAmC,CAAC;iBACtE,GAAG,CAAC,KAAK,CAAC,CAAC;YACd,IAAI,CAAC,GAAG;gBAAE,MAAM,IAAI,KAAK,CAAC,QAAQ,KAAK,YAAY,CAAC,CAAC;YACrD,IAAI,KAAK,KAAK,IAAI,EAAE,CAAC;gBACnB,MAAM,IAAI,GAAG,IAAI,CAAC,EAAE;qBACjB,OAAO,CAA2B,mCAAmC,CAAC;qBACtE,GAAG,CAAC,KAAK,CAAC,CAAC;gBACd,IAAI,CAAC,IAAI;oBAAE,MAAM,IAAI,KAAK,CAAC,QAAQ,KAAK,YAAY,CAAC,CAAC;YACxD,CAAC;YACD,IAAI,CAAC,EAAE;iBACJ,OAAO,CAAC,iDAAiD,CAAC;iBAC1D,GAAG,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACvB,CAAC,CAAC,CAAC;QACH,GAAG,EAAE,CAAC;IACR,CAAC;IAED,KAAK,CAAC,kBAAkB,CACtB,SAAiB,EACjB,KAA0B;QAE1B,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC,+CAA+C,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;QAChF,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO;QAE/B,MAAM,UAAU,GAAG,IAAI,CAAC,UAAU,EAAE,CAAC;QACrC,KAAK,MAAM,CAAC,IAAI,KAAK;YAAE,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC;QAErD,MAAM,iBAAiB,GAAG,IAAI,CAAC,EAAE,CAAC,OAAO,CAGvC;;;;;;;;;KASD,CAAC,CAAC;QACH,MAAM,kBAAkB,GAAG,IAAI,CAAC,EAAE,CAAC,OAAO,CACxC,iDAAiD,CAClD,CAAC;QACF,KAAK,MAAM,CAAC,IAAI,KAAK,EAAE,CAAC;YACtB,MAAM,SAAS,GAAG,iBAAiB,CAAC,GAAG,CAAC,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC,SAAS,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC;YACtE,IAAI,SAAS,IAAI,SAAS,CAAC,EAAE,KAAK,CAAC,CAAC,EAAE,EAAE,CAAC;gBACvC,kBAAkB,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,SAAS,CAAC,EAAE,CAAC,CAAC;YAC7C,CAAC;QACH,CAAC;IACH,CAAC;IAEO,UAAU;QAChB,OAAO,IAAI,CAAC,EAAE,CAAC,OAAO,CAAU;;;;;;;;KAQ/B,CAAC,CAAC;IACL,CAAC;IAEO,KAAK,CAAC,IAAU;QACtB,OAAO;YACL,EAAE,EAAE,IAAI,CAAC,EAAE;YACX,IAAI,EAAE,IAAI,CAAC,IAAI;YACf,OAAO,EAAE,IAAI,CAAC,OAAO;YACrB,SAAS,EAAE,IAAI,CAAC,SAAS;YACzB,KAAK,EAAE,IAAI,CAAC,KAAK;YACjB,iBAAiB,EAAE,IAAI,CAAC,eAAe;YACvC,YAAY,EAAE,IAAI,CAAC,WAAW;YAC9B,UAAU,EAAE,IAAI,CAAC,SAAS;YAC1B,aAAa,EAAE,IAAI,CAAC,YAAY;YAChC,UAAU,EAAE,IAAI,CAAC,UAAU;SAC5B,CAAC;IACJ,CAAC;IAEO,SAAS,CAAC,GAAY;QAC5B,OAAO;YACL,EAAE,EAAE,GAAG,CAAC,EAAE;YACV,IAAI,EAAE,GAAG,CAAC,IAAI;YACd,OAAO,EAAE,GAAG,CAAC,OAAO;YACpB,SAAS,EAAE,GAAG,CAAC,SAAS;YACxB,KAAK,EAAE,GAAG,CAAC,KAAK;YAChB,eAAe,EAAE,GAAG,CAAC,iBAAiB;YACtC,WAAW,EAAE,GAAG,CAAC,YAAY;YAC7B,SAAS,EAAE,GAAG,CAAC,UAAU;YACzB,YAAY,EAAE,GAAG,CAAC,aAAa;YAC/B,UAAU,EAAE,GAAG,CAAC,UAAU;SAC3B,CAAC;IACJ,CAAC;CACF"}

package/dist/core/storage/sqlite-session-store.d.ts

@@ -57,6 +57,11 @@ export interface RecentMarker {
 }
 export declare class SqliteSessionStore implements SessionStore {
     private readonly db;
+    /**
+     * @internal. Construct via SqliteStorage.create(...) instead. Direct
+     * construction is preserved for the SqliteStorage adapter only; all
+     * other callers should reach SessionStore via storage.sessions.
+     */
     constructor(opts: SqliteSessionStoreOptions);
     close(): void;
     /**
@@ -102,22 +107,6 @@ export declare class SqliteSessionStore implements SessionStore {
      * internal helpers directly so session+facts commit together.
      */
     insertFactsForSession(sessionId: string, factStore: SqliteFactStore, facts: ReadonlyArray<Fact>, embedder?: import("../../ports/llm-client.js").LLMClient | null): Promise<void>;
-    /**
-     * Sync core of the fact-ingest block. Runs inside an EXISTING transaction
-     * — opens no txn of its own. Used by both `insertSession` (Phase B.2
-     * atomic ingest) and `insertFactsForSession` (Phase B.5 backfill).
-     *
-     * Behavior (mirrored across both callers):
-     *   1. DELETE prior facts attributed to this session (idempotent on
-     *      backfill, drops stale rows on re-ingest).
-     *   2. Insert all new facts atomically.
-     *   3. For each, mark the prior current (subject, predicate) fact as
-     *      superseded — Phase B.4 deterministic supersedence policy.
-     *
-     * Ordering: inserts before updates so the supersedence FK target exists.
-     * CASCADE-SET-NULL on `superseded_by` handles chain repair on re-ingest.
-     */
-    private applyFactsInTxn;
     /**
      * Best-effort per-fact embedding. Writes `${subject} ${predicate} ${value}`
      * embeddings to fact_embeddings via FactStore.upsertEmbedding. Per-fact
@@ -144,6 +133,7 @@ export declare class SqliteSessionStore implements SessionStore {
     keywordSearch(query: string, limit: number): Promise<ReadonlyArray<KeywordNeighbor>>;
     updateStatus(sessionId: string, status: SessionStatus): Promise<void>;
     markSuperseded(predecessorId: string, successorId: string): Promise<void>;
+    /** @internal test-only helper; production callers use insertSession(). */
     insertSessionForTest(session: Session): void;
     insertEdgeForTest(fromSession: string, toSession: string, kind?: "supersedes" | "continues"): void;
     insertEmbeddingForTest(sessionId: string, vector: Float32Array): void;

package/dist/core/storage/sqlite-session-store.js

@@ -22,6 +22,11 @@ import { tokenize } from "../recall/tokenize.js";
 import { chunkSessionText } from "../embedding/chunk-body.js";
 export class SqliteSessionStore {
     db;
+    /**
+     * @internal. Construct via SqliteStorage.create(...) instead. Direct
+     * construction is preserved for the SqliteStorage adapter only; all
+     * other callers should reach SessionStore via storage.sessions.
+     */
     constructor(opts) {
         const dbPath = resolve(opts.dbPath);
         const parent = dirname(dbPath);
@@ -158,7 +163,7 @@ export class SqliteSessionStore {
             // carries new provenance (new source_session_id) and is informative
             // history. See Section 2 of factstore-design.md.
             //
-            // Ordering note: insertManyInTxn FIRST so the new fact id exists in
+            // Ordering note: inserts FIRST so the new fact id exists in
             // facts(id) before any UPDATE sets superseded_by = newId (the FK
             // would reject otherwise). The DELETE above plus the CASCADE-SET-NULL
             // on superseded_by means re-ingest naturally repairs chains: if an
@@ -166,7 +171,30 @@ export class SqliteSessionStore {
             // session, deleting our prior fact unlinks the chain; the loop below
             // re-establishes it with the freshly-inserted row.
             if (factSink !== null) {
-                this.applyFactsInTxn(record.id, factSink.factStore, factSink.facts);
+                // Inlined ingest. See SqliteFactStore.ingestSessionFacts for the
+                // backend-agnostic version. SqliteSessionStore runs this synchronously
+                // inside the better-sqlite3 txn callback (which must be sync). The
+                // logic mirrors the port method exactly; if you change one, change
+                // the other. Tracked as a known duplication for the SQLite adapter.
+                const db = this.db;
+                db.prepare("DELETE FROM facts WHERE source_session_id = ?").run(record.id);
+                if (factSink.facts.length > 0) {
+                    const factStoreImpl = factSink.factStore;
+                    for (const f of factSink.facts)
+                        factStoreImpl.insertRowInTxn(f);
+                    const findCollisionStmt = db.prepare(`
+            SELECT id FROM facts
+            WHERE subject = ? AND predicate = ? AND superseded_by IS NULL AND id != ?
+            ORDER BY created_at DESC LIMIT 1
+          `);
+                    const markSupersededStmt = db.prepare("UPDATE facts SET superseded_by = ? WHERE id = ?");
+                    for (const f of factSink.facts) {
+                        const collision = findCollisionStmt.get(f.subject, f.predicate, f.id);
+                        if (collision && collision.id !== f.id) {
+                            markSupersededStmt.run(f.id, collision.id);
+                        }
+                    }
+                }
             }
         });
         txn();
@@ -239,51 +267,31 @@ export class SqliteSessionStore {
     async insertFactsForSession(sessionId, factStore, facts, embedder = null) {
         const db = this.db;
         const txn = db.transaction(() => {
-            this.applyFactsInTxn(sessionId, factStore, facts);
+            // Inlined ingest. Same logic as SqliteFactStore.ingestSessionFacts.
+            // Sync because better-sqlite3 txn callbacks must be sync.
+            db.prepare("DELETE FROM facts WHERE source_session_id = ?").run(sessionId);
+            if (facts.length > 0) {
+                for (const f of facts)
+                    factStore.insertRowInTxn(f);
+                const findCollisionStmt = db.prepare(`
+          SELECT id FROM facts
+          WHERE subject = ? AND predicate = ? AND superseded_by IS NULL AND id != ?
+          ORDER BY created_at DESC LIMIT 1
+        `);
+                const markSupersededStmt = db.prepare("UPDATE facts SET superseded_by = ? WHERE id = ?");
+                for (const f of facts) {
+                    const collision = findCollisionStmt.get(f.subject, f.predicate, f.id);
+                    if (collision && collision.id !== f.id) {
+                        markSupersededStmt.run(f.id, collision.id);
+                    }
+                }
+            }
         });
         txn();
         if (embedder) {
             await this.embedFacts(factStore, facts, embedder);
         }
     }
-    /**
-     * Sync core of the fact-ingest block. Runs inside an EXISTING transaction
-     * — opens no txn of its own. Used by both `insertSession` (Phase B.2
-     * atomic ingest) and `insertFactsForSession` (Phase B.5 backfill).
-     *
-     * Behavior (mirrored across both callers):
-     *   1. DELETE prior facts attributed to this session (idempotent on
-     *      backfill, drops stale rows on re-ingest).
-     *   2. Insert all new facts atomically.
-     *   3. For each, mark the prior current (subject, predicate) fact as
-     *      superseded — Phase B.4 deterministic supersedence policy.
-     *
-     * Ordering: inserts before updates so the supersedence FK target exists.
-     * CASCADE-SET-NULL on `superseded_by` handles chain repair on re-ingest.
-     */
-    applyFactsInTxn(sessionId, factStore, facts) {
-        const db = this.db;
-        db.prepare("DELETE FROM facts WHERE source_session_id = ?").run(sessionId);
-        factStore.insertManyInTxn(facts);
-        if (facts.length === 0)
-            return;
-        const findCollisionStmt = db.prepare(`
-      SELECT id
-      FROM facts
-      WHERE subject = ?
-        AND predicate = ?
-        AND superseded_by IS NULL
-        AND id != ?
-      ORDER BY created_at DESC
-      LIMIT 1
-    `);
-        const markSupersededStmt = db.prepare("UPDATE facts SET superseded_by = ? WHERE id = ?");
-        for (const fact of facts) {
-            const prior = findCollisionStmt.get(fact.subject, fact.predicate, fact.id);
-            if (prior)
-                markSupersededStmt.run(fact.id, prior.id);
-        }
-    }
     /**
      * Best-effort per-fact embedding. Writes `${subject} ${predicate} ${value}`
      * embeddings to fact_embeddings via FactStore.upsertEmbedding. Per-fact
@@ -296,7 +304,7 @@ export class SqliteSessionStore {
                 continue;
             try {
                 const { vector } = await embedder.embed(factText, "document");
-                factStore.upsertEmbedding(fact.id, vector);
+                await factStore.upsertEmbedding(fact.id, vector);
             }
             catch {
                 // Per-fact embedding failure must not abort embedding of subsequent
@@ -482,6 +490,7 @@ export class SqliteSessionStore {
         txn();
     }
     // ── insert helpers used by tests / future ingest path ─────────────────
+    /** @internal test-only helper; production callers use insertSession(). */
     insertSessionForTest(session) {
         const stmt = this.db.prepare(`
       INSERT INTO sessions (