nitrogen 0.29.8 → 0.30.1

package/src/syntax/swift/SwiftCxxBridgedType.ts

@@ -22,7 +22,6 @@ import { VariantType } from '../types/VariantType.js'
 import { getReferencedTypes } from '../getReferencedTypes.js'
 import {
   createSwiftCxxHelpers,
-  isPrimitivelyCopyable,
   type SwiftCxxHelper,
 } from './SwiftCxxTypeHelper.js'
 import { createSwiftEnumBridge } from './SwiftEnum.js'
@@ -33,6 +32,7 @@ import { NamedWrappingType } from '../types/NamedWrappingType.js'
 import { ErrorType } from '../types/ErrorType.js'
 import { createSwiftFunctionBridge } from './SwiftFunction.js'
 import type { Language } from '../../getPlatformSpecs.js'
+import { isPrimitivelyCopyable } from './isPrimitivelyCopyable.js'
 
 // TODO: Remove enum bridge once Swift fixes bidirectional enums crashing the `-Swift.h` header.
 
@@ -449,7 +449,10 @@ export class SwiftCxxBridgedType implements BridgedType<'swift', 'c++'> {
                 return `${cppParameterName}.has_value() ? ${cppParameterName}.pointee : nil`
               }
             }
-            if (!wrapping.needsSpecialHandling) {
+            // TODO: Remove this check for booleans once https://github.com/swiftlang/swift/issues/84848 is fixed.
+            const swiftBug84848Workaround =
+              optional.wrappingType.kind === 'boolean'
+            if (!wrapping.needsSpecialHandling && !swiftBug84848Workaround) {
               return `${cppParameterName}.value`
             }
             return `

package/src/syntax/swift/SwiftCxxTypeHelper.ts

@@ -19,6 +19,7 @@ import { VoidType } from '../types/VoidType.js'
 import { NamedWrappingType } from '../types/NamedWrappingType.js'
 import { ErrorType } from '../types/ErrorType.js'
 import { ResultWrappingType } from '../types/ResultWrappingType.js'
+import { isPrimitivelyCopyable } from './isPrimitivelyCopyable.js'
 
 export interface SwiftCxxHelper {
   cxxHeader: {
@@ -148,7 +149,7 @@ return ${cxxNamespace}::get_${internalName}(cppType);
  */
 using ${name} = ${actualType};
 ${actualType} create_${name}(void* NON_NULL swiftUnsafePointer) noexcept;
-void* NON_NULL get_${name}(${name} cppType) noexcept;
+void* NON_NULL get_${name}(${name} cppType);
     `.trim(),
       requiredIncludes: type.getRequiredImports('c++'),
     },
@@ -157,7 +158,7 @@ void* NON_NULL get_${name}(${name} cppType) noexcept;
 ${actualType} create_${name}(void* NON_NULL swiftUnsafePointer) noexcept {
   ${indent(createImplementation, '  ')}
 }
-void* NON_NULL get_${name}(${name} cppType) noexcept {
+void* NON_NULL get_${name}(${name} cppType) {
   ${indent(getImplementation, '  ')}
 }
     `.trim(),
@@ -260,11 +261,6 @@ inline ${wrappedBridge.getTypeCode('c++')} get_${name}(const ${actualType}& opti
   }
 }
 
-export function isPrimitivelyCopyable(type: Type): boolean {
-  const bridgedType = new SwiftCxxBridgedType(type, true)
-  return !bridgedType.needsSpecialHandling
-}
-
 /**
  * Creates a C++ `create_vector_T<T>(size)` function that can be called from Swift.
  */

package/src/syntax/swift/isPrimitivelyCopyable.ts

@@ -0,0 +1,20 @@
+import type { Type } from '../types/Type.js'
+
+/**
+ * Returns `true` if the given {@linkcode type} is a datatype that
+ * can be copied without running a copy constructor or special logic
+ * to copy the data over. In other words; it's _primitively copyable_.
+ */
+export function isPrimitivelyCopyable(type: Type): boolean {
+  switch (type.kind) {
+    case 'number':
+    case 'boolean':
+    case 'bigint':
+    case 'enum':
+    case 'null':
+    case 'void':
+      return true
+    default:
+      return false
+  }
+}