nitor 1.2.3 → 1.3.1

package/CHANGELOG.md

@@ -30,3 +30,11 @@ For a complete list of changes and discussion, see [Issue #1](https://github.com
 - Added time entry commands.
 
 - [Issue #5](https://github.com/codebynithin/nitor/issues/5)
+
+## [1.3.0] - 2025-11-29
+
+### New Features
+
+- Added support for task stats and get task commands.
+
+- [Issue #7](https://github.com/codebynithin/nitor/issues/7)

package/README.md

@@ -26,6 +26,9 @@ A CLI utility toolkit for automating and managing build, deploy, and status oper
 - Cleanup local git branches
 - Time entry management with Zoho integration
 - GitLab activity tracking
+- Task statistics with merge request details
+- Extract Zoho task IDs from GitLab issue descriptions
+- Merge request status tracking for active tasks
 
 ## Requirements
 
@@ -36,6 +39,7 @@ A CLI utility toolkit for automating and managing build, deploy, and status oper
   - `COOKIE` - Cookie for Gitlab (Copy from browser)
   - `GITLAB_URI` - GitLab API URL, eg: `https://gitlab.com/`
   - `GITLAB_TOKEN` - Gitlab token
+  - `GITLAB_DEFAULT_PROJECT_ID` - Default GitLab project ID for issue lookups
   - `MR_PROMPT` - Merge request prompt
   - `MR_LANG` - Merge request language
   - `AI_API_KEY` - AI API key
@@ -155,6 +159,26 @@ Once enabled, you can use Tab to autocomplete:
   ```bash
   nitor time-zoho
   ```
+- **Time Entry - GitLab Activities:**
+  ```bash
+  nitor time-gitlab -from <YYYY-MM-DD> -to <YYYY-MM-DD>
+  ```
+- **Time Entry - Merge Request Status:**
+  ```bash
+  nitor time-merge
+  ```
+- **Time Entry - Switch Project:**
+  ```bash
+  nitor time-switch
+  ```
+- **Task Stats:**
+  ```bash
+  nitor task-stats -task <task numbers with space>
+  ```
+- **Get Task (Extract Zoho Task IDs):**
+  ```bash
+  nitor get-task -task <task numbers with space>
+  ```
 
 ### Command Reference
 
@@ -178,6 +202,11 @@ Once enabled, you can use Tab to autocomplete:
 - `time-entries` : View time entries by date range
 - `time-stats` : View daily statistics of time entries
 - `time-zoho` : Sync time entries to Zoho
+- `time-gitlab` : Get GitLab activities for a date range
+- `time-merge` : View merge request status for active tasks
+- `time-switch` : Switch between default projects
+- `task-stats` : View task statistics with GitLab merge request details
+- `get-task` : Extract Zoho task IDs from GitLab issue descriptions
 
 ### Options
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nitor",
-  "version": "1.2.3",
+  "version": "1.3.1",
   "description": "A comprehensive CLI toolkit for automating GitLab operations, AI-powered code review, build/deploy automation, MongoDB backup/restore, and developer productivity tools",
   "main": "index.js",
   "author": "Nithin V <mails2nithin@gmail.com>",

package/services/enums/actions.enum.js

@@ -11,6 +11,8 @@ module.exports = {
     REFACTOR: 'refactor',
     REVIEW: 'review',
     VERSION: 'version',
+    TASK_STATS: 'task-stats',
+    GET_TASK: 'get-task',
 
     // Time entry commands
     TIME_INIT: 'time-init',

package/services/process-commands.js

@@ -11,13 +11,19 @@ const { merge } = require('./merge');
 const { cleanup } = require('./cleanup');
 
 // Time entry imports
-const { removeEmpty } = require('./time-entry/utils');
+const { removeEmpty, getSprints } = require('./time-entry/utils');
 const { getStatus, getTasksByDate } = require('./time-entry/get-report');
 const { logTaskHoursAndSync } = require('./time-entry/log-task-hours-and-sync');
 const { addNewTask } = require('./time-entry/add-task');
 const { updateTask, deleteTask } = require('./time-entry/update-delete-task');
 const { getGitlabActivities } = require('./time-entry/get-gitlab-activities');
 const { getZohoTasks } = require('./time-entry/get-zoho-tasks');
+const {
+  getTaskStats,
+  getGitIdStats,
+  getGitlabIssueMergeRequests,
+  getGitMergeRequestDetails,
+} = require('./task-stats');
 
 const processArgs = async (type, value) => {
   try {
@@ -280,6 +286,105 @@ ${cyan}${bold}╔═════════════════════
         break;
       }
 
+      case ACTIONS.TASK_STATS: {
+        if (value === '-help' || value === '--h') {
+          console.log(`usage: \tnu task-stats [-task <task number>]
+\tnu task-stats [-t <task number>]
+
+View task stats
+
+Options:
+  -t, --task <number>  task number`);
+
+          return;
+        }
+
+        if (values.sprint) {
+          const sprints = await getSprints({ params: {} });
+          const taskDetails = await getZohoTasks({
+            params: { sprint: sprints.find(({ label }) => label === values.sprint)?.value },
+          });
+
+          values.task = taskDetails.map(({ taskId }) => taskId);
+        } else {
+          values.task = values.task.split(' ');
+        }
+
+        // Process all tasks in parallel
+        const taskResults = await Promise.all(
+          values.task.map(async (task) => {
+            const taskDetail = await getTaskStats(task);
+
+            if (!taskDetail?.itemIds) {
+              return [];
+            }
+
+            const gitIdDetails = await getGitIdStats(taskDetail.itemIds);
+
+            if (!gitIdDetails?.length) {
+              return [];
+            }
+
+            const mrDetails = await getGitlabIssueMergeRequests(gitIdDetails);
+
+            return mrDetails.map((mrDetail) => ({
+              Task: task,
+              Owner: taskDetail.owner,
+              ...mrDetail,
+            }));
+          }),
+        );
+
+        // Flatten the results
+        const list = taskResults.flat();
+
+        console.table(list);
+
+        break;
+      }
+
+      case ACTIONS.GET_TASK: {
+        if (value === '-help' || value === '--h') {
+          console.log(`usage: \tnu get-task [-task <task numbers with space>]
+\tnu get-task [-t <task numbers with space>]
+
+Get task details
+
+Options:
+  -t, --task <numbers with space>  task numbers with space`);
+
+          return;
+        }
+
+        if (!values.task) {
+          console.log('Task number is required');
+
+          process.exit(1);
+        }
+
+        const tasks = {};
+
+        for (const task of values.task.split(' ')) {
+          const taskDetails = await getGitMergeRequestDetails(task);
+
+          if (taskDetails.error) {
+            console.log(`No merge requests found for task ${task}`);
+
+            continue;
+          }
+
+          for (const taskDetail of taskDetails) {
+            const zohoTaskMatch = taskDetail.description?.match(/itemdetails\/(I\d+)\)/);
+
+            tasks[task] = zohoTaskMatch ? zohoTaskMatch[1] : 'Not found';
+          }
+        }
+
+        console.log(tasks);
+
+        break;
+      }
+
       // Time entry commands
       case ACTIONS.TIME_ADD: {
         const timeValues = value ? removeEmpty(value?.split(' -')) : value;
@@ -409,9 +514,11 @@ Available commands:\n
   completion    : Setup shell autocomplete
   create-branch : Create git branch
   deploy        : Deploy specified components
+  get-task      : Get task details
   merge         : Merge source branch into target branch
   refactor      : Refactor the provided text for improved clarity, conciseness, and professional quality
   review        : AI Review specified merge request
+  task-stats    : View task statistics
   version       : Show version info
   help          : Show help
 
@@ -422,7 +529,7 @@ Time Entry commands:
   time-entries  : View time entries by date
   time-gitlab   : Get GitLab activities
   time-merge    : View merge request status for tasks
-  time-stats   : View daily status of time entries
+  time-stats    : View daily status of time entries
   time-switch   : Switch between default projects
   time-update   : Update existing time entry
   time-zoho     : Sync time entries to Zoho

package/services/review.js

@@ -7,6 +7,7 @@ const executeMergeRequestReview = async (values) => {
     maxBodyLength: Infinity,
     url: `${mrApiUri}/${projectIdMap[values.project]}/mergeid/${values.mergeId}`,
     headers: { 'Content-Type': 'application/json' },
+    timeout: 10 * 60 * 1000, // 10 minutes
     data: JSON.stringify({
       language: mrLang,
       gitlabToken: gitlabConfig.token,

package/services/task-stats.js

@@ -0,0 +1,196 @@
+const axios = require('axios');
+const { zohoConfig, gitlabConfig } = require('./utils');
+
+const getZohoUrl = (type, taskNumber) => {
+  switch (type) {
+    case 'task':
+      return `${zohoConfig.url}/zsapi/team/${zohoConfig.team}/projects/${zohoConfig.defaultProjectId}/item/no-${taskNumber}/?action=details`;
+
+    case 'gitId':
+      return `${zohoConfig.url}/zsapi/team/${zohoConfig.team}/projects/${zohoConfig.defaultProjectId}/item/${taskNumber}/scm/3/issuedetails/?action=scmissuedetails`;
+  }
+};
+
+const getZohoConfig = (type, taskNumber) => {
+  return {
+    method: 'get',
+    maxBodyLength: Infinity,
+    url: getZohoUrl(type, taskNumber),
+    headers: {
+      'User-Agent':
+        'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:145.0) Gecko/20100101 Firefox/145.0',
+      Accept: '*/*',
+      'Accept-Language': 'en-GB,en;q=0.5',
+      'Accept-Encoding': 'gzip, deflate, br, zstd',
+      Referer: `${zohoConfig.url}/workspace/4medica/client/wmoku`,
+      'X-ZA-REQSIZE': 'large',
+      'X-Requested-With': 'XMLHttpRequest',
+      'X-ZA-SOURCE': zohoConfig.source,
+      'X-ZA-UI-VERSION': 'v2',
+      'X-ZCSRF-TOKEN': zohoConfig.token,
+      'X-ZA-CLIENTPORTALID': zohoConfig.portalId,
+      'X-ZA-SESSIONID': zohoConfig.sessionId,
+      Connection: 'keep-alive',
+      Cookie: zohoConfig.cookie,
+      'Sec-Fetch-Dest': 'empty',
+      'Sec-Fetch-Mode': 'cors',
+      'Sec-Fetch-Site': 'same-origin',
+      Priority: 'u=0',
+      Pragma: 'no-cache',
+      'Cache-Control': 'no-cache',
+      TE: 'trailers',
+    },
+  };
+};
+
+const getGitlabConfig = (url) => {
+  return {
+    method: 'get',
+    maxBodyLength: Infinity,
+    url,
+    headers: {
+      'User-Agent':
+        'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:145.0) Gecko/20100101 Firefox/145.0',
+      Accept: 'application/json',
+      'Accept-Language': 'en-GB,en;q=0.5',
+      'Accept-Encoding': 'gzip, deflate, br, zstd',
+      'PRIVATE-TOKEN': gitlabConfig.token,
+      Connection: 'keep-alive',
+      Cookie: gitlabConfig.cookie,
+    },
+  };
+};
+
+const getTaskStats = async (task) => {
+  try {
+    const config = getZohoConfig('task', task);
+    const response = await axios.request(config);
+
+    return {
+      itemIds: response.data.itemIds,
+      owner: Object.values(response.data.userDisplayName).join(', '),
+    };
+  } catch (error) {
+    console.log(error);
+  }
+};
+
+const getGitIdStats = async (gitIds) => {
+  const gitIdStats = [];
+
+  for (const gitId of gitIds) {
+    try {
+      const config = getZohoConfig('gitId', gitId);
+      const response = await axios.request(config);
+
+      gitIdStats.push(response.data);
+    } catch (error) {}
+  }
+
+  return gitIdStats;
+};
+
+const getGitlabIssueDetails = async (projectId, issueIid) => {
+  try {
+    const config = getGitlabConfig(`${projectId}/issues/${issueIid}`);
+    const response = await axios.request(config);
+
+    return response.data;
+  } catch (error) {
+    console.error('Error fetching GitLab issue details:', error.message);
+    if (error.response) {
+      console.error('Response status:', error.response.status);
+      console.error('Response data:', error.response.data);
+    }
+    throw error;
+  }
+};
+
+const getGitMergeRequestDetails = async (issueIid, projectId) => {
+  try {
+    if (!projectId) {
+      projectId = `${gitlabConfig.url}/api/v4/projects/${gitlabConfig.defaultProjectId}`;
+    }
+
+    const config = getGitlabConfig(`${projectId}/issues/${issueIid}/related_merge_requests`);
+    const response = await axios.request(config);
+
+    return response.data;
+  } catch (error) {
+    return { error };
+  }
+};
+
+const getGitlabIssueMergeRequests = async (gitDetails) => {
+  for (const gitDetail of gitDetails) {
+    try {
+      const mergeRequests = await getGitMergeRequestDetails(
+        gitDetail.iid,
+        gitDetail._links.project,
+      );
+      const detailedMRs = await Promise.all(
+        mergeRequests.map(async (mr) => {
+          try {
+            const detailConfig = getGitlabConfig(
+              `${gitlabConfig.url}/api/v4/projects/${mr.project_id}/merge_requests/${mr.iid}`,
+            );
+            const detailResponse = await axios.request(detailConfig);
+            const mrData = detailResponse.data;
+
+            // Fetch approval details separately
+            try {
+              const approvalConfig = getGitlabConfig(
+                `${gitlabConfig.url}/api/v4/projects/${mr.project_id}/merge_requests/${mr.iid}/approvals`,
+              );
+              const approvalResponse = await axios.request(approvalConfig);
+              const approvalData = approvalResponse.data;
+
+              // Merge approval data with MR data
+              return {
+                IssueID: gitDetail.iid,
+                MRID: mrData.iid,
+                MRAssignedTo: mrData.assignee?.name,
+                MRPointedTo: mrData.target_branch,
+                Repo: mr.reference?.split('!')?.[0],
+                ApprovedBy:
+                  (approvalData.approved_by || [])
+                    .map((approvedBy) => approvedBy?.user?.name || '')
+                    ?.join(', ') || 'Not Approved',
+                ApprovedCount: approvalData.approved_by?.length || 0,
+                MergedBy: mrData.merged_by?.name || 'Not Merged',
+                MergedOn: mrData.merged_at?.split('T')?.[0] || 'Not Merged',
+              };
+            } catch (approvalError) {
+              console.error(`Error fetching approvals for MR ${mr.iid}:`, approvalError.message);
+              // Return MR data without approval details if approval fetch fails
+              return mrData;
+            }
+          } catch (error) {
+            console.error(`Error fetching details for MR ${mr.iid}:`, error.message);
+            // Return the basic MR data if detailed fetch fails
+            return mr;
+          }
+        }),
+      );
+
+      return detailedMRs;
+    } catch (error) {
+      console.error('Error fetching GitLab issue merge requests:', error.message);
+
+      if (error.response) {
+        console.error('Response status:', error.response.status);
+        console.error('Response data:', error.response.data);
+      }
+
+      throw error;
+    }
+  }
+};
+
+module.exports = {
+  getTaskStats,
+  getGitIdStats,
+  getGitlabIssueDetails,
+  getGitlabIssueMergeRequests,
+  getGitMergeRequestDetails,
+};

package/services/time-entry/get-gitlab-activities.js

@@ -2,25 +2,61 @@ const axios = require('axios');
 const cheerio = require('cheerio');
 const { gitlabConfig } = require('../utils');
 
+/**
+ * Fetches GitLab activities for a date range
+ * Defaults to last one week if no values are provided
+ * @param {Array} values - Optional array of filter values (e.g., ['-from 2024-11-21', '-to 2024-11-28'])
+ * @returns {Object} Object with dates as keys and activities grouped by action
+ */
 const getGitlabActivities = async (values) => {
   const resp = {};
+  const res = [];
   const filters = getFilters(values);
   const startDate = new Date(filters.from);
 
+  // Iterate through each date in the range
   while (startDate <= new Date(filters.to)) {
     const date = startDate.toISOString().split('T')[0];
     const activities = await getGitlabActivitiesByDate(date);
 
-    if (activities?.length) {
+    /* if (activities?.length) {
       resp[date] = arrayToObjectByKey(activities, 'action');
-    }
+    } */
+    res.push(...activities);
 
     startDate.setDate(startDate.getDate() + 1);
   }
 
-  console.log(resp);
+  // Format and display each entry in a single line with ellipses
+  const truncate = (str, maxLen = 50) => {
+    if (!str) return '';
+    return str.length > maxLen ? str.substring(0, maxLen - 3) + '...' : str;
+  };
+
+  console.log('\n📊 GitLab Activities (Last Week)\n');
+  console.log(
+    `\n${'index'.toString().padStart(8)} | ${'date'.toString().padStart(10)} ${'time'.toString().padEnd(8) || ''.padEnd(8)} | ${'action'.toString().padEnd(18)} | ${'text'.toString().padEnd(100)} | ${'project'.toString().padEnd(25)}`,
+  );
+  res.forEach((activity, index) => {
+    const { date, time, action, text, project } = activity;
+    const formattedText = truncate(text, 100);
+    const formattedAction = action?.padEnd(18) || ''.padEnd(18);
+    const formattedProject = truncate(project, 25);
+
+    console.log(
+      `${(index + 1).toString().padStart(8)} | ${date} ${time?.padEnd(8) || ''.padEnd(8)} | ${formattedAction} | ${formattedText.padEnd(100)} | ${formattedProject}`,
+    );
+  });
+  console.log(`\n✅ Total: ${res.length} activities\n`);
+
   return resp;
 };
+
+/**
+ * Parses filter values or sets default to last one week
+ * @param {Array} values - Array of filter strings
+ * @returns {Object} Object with 'from' and 'to' date strings
+ */
 const getFilters = (values) => {
   const filters = {};
   const keyMap = {
@@ -31,10 +67,12 @@ const getFilters = (values) => {
   };
 
   if (values?.length) {
+    // Parse provided filter values
     for (const item of values) {
       let [key, ...itemValues] = item.split(' ');
       const itemValue = itemValues.join(' ');
 
+      // Remove leading dash if present
       if (key.charAt(0) === '-') {
         key = key.substring(1);
       }
@@ -46,6 +84,7 @@ const getFilters = (values) => {
       }
     }
   } else {
+    // Default: last one week
     filters.from = new Date(new Date().setDate(new Date().getDate() - 7))
       .toISOString()
       .split('T')[0];
@@ -54,8 +93,13 @@ const getFilters = (values) => {
 
   return filters;
 };
+
+/**
+ * Fetches GitLab activities for a specific date
+ * @param {string} date - Date in YYYY-MM-DD format
+ * @returns {Array} Array of activity objects
+ */
 const getGitlabActivitiesByDate = async (date) => {
-  const { removeEmpty } = require('./utils');
   const gitlabUrl = `${gitlabConfig.url}/users/${gitlabConfig.userId}/calendar_activities?date=${date}`;
   const headers = {
     accept: 'application/json, text/plain, */*',
@@ -71,7 +115,6 @@ const getGitlabActivitiesByDate = async (date) => {
     'x-csrf-token': gitlabConfig.xCsrfToken,
     'x-requested-with': 'XMLHttpRequest',
   };
-  // let config = { method: 'get', maxBodyLength: Infinity, url: `${gitlabUrl}2024-5-10`, headers };
 
   try {
     const response = await axios.get(gitlabUrl, { headers });
@@ -79,45 +122,39 @@ const getGitlabActivitiesByDate = async (date) => {
     const $ = cheerio.load(response.data);
 
     // Initialize an empty array to store the JSON objects
-    let contributions = [];
+    const contributions = [];
 
     // Iterate over each list item
-    $('ul.bordered-list li').each((i, element) => {
+    $('.event-item').each((i, element) => {
       const $element = $(element);
-      const time = $element.find('span.js-localtime').text().trim();
-      const action = $element
-        .contents()
-        .filter(function () {
-          return this.nodeType === 3; // Text nodes
-        })
-        .text()
-        .trim()
-        .split(/\n/g)[0]
-        .trim();
-      const detailsArray = $element
-        .find('a')
-        .map((i, el) => {
-          return {
-            title: $(el).attr('title'),
-            href: $(el).attr('href').split(/\/-\//g)[1],
-            text: $(el).text().trim().replace(/!/g, ''),
-          };
-        })
-        .get();
-      const details = detailsArray.reduce((acc, item) => {
-        if (item.title === 'medica-portal-client') {
-          acc.repo = item.title;
-        } else {
-          acc = removeEmpty(item);
-        }
-
-        return acc;
-      }, {});
+      const time = $element.find('.event-item-timestamp').text()?.trim();
+      const action = $element.find('.event-title-block .event-type').text()?.trim();
+      const project = $element.find('.event-title-block .project-name').text()?.trim();
+      const $refLink = $element.find('.event-title-block a.ref-name');
+      const $targetLink = $element.find('.event-title-block a.event-target-link');
+
+      let href, text;
+
+      if ($refLink.length > 0) {
+        href = $refLink.attr('href');
+        text = $refLink.text()?.trim();
+      } else if ($targetLink.length > 0) {
+        href = $targetLink.attr('href');
+        text = $targetLink.text()?.trim();
+      } else {
+        const $eventTypeSpan = $element.find('.event-title-block .event-type');
+        const nextSpan = $eventTypeSpan.next('span');
+
+        text = nextSpan.text()?.trim();
+        href = undefined;
+      }
 
       contributions.push({
         time,
         action,
-        ...details,
+        text,
+        project,
+        date,
       });
     });
 
@@ -126,12 +163,5 @@ const getGitlabActivitiesByDate = async (date) => {
     console.log(error.message);
   }
 };
-const arrayToObjectByKey = (arr, key) => {
-  return arr.reduce((acc, obj) => {
-    acc[obj[key]] = obj;
-
-    return acc;
-  }, {});
-};
 
 module.exports = { getGitlabActivities };

package/services/time-entry/get-zoho-tasks.js

@@ -78,4 +78,4 @@ const checkSprintId = async (id, req) => {
   return sprints.some(({ value }) => value === id);
 };
 
-module.exports = { getZohoTasks };
+module.exports = { getZohoTasks, getTasksBySprint };

package/services/utils.js

@@ -17,6 +17,7 @@ const gitlabConfig = {
   xCsrfToken: process.env.GITLAB_XCSRF_TOKEN,
   userId: process.env.GITLAB_USERID,
   token: process.env.GITLAB_TOKEN,
+  defaultProjectId: process.env.GITLAB_DEFAULT_PROJECT_ID,
 };
 const zohoConfig = {
   cookie: process.env.ZOHO_COOKIE,
@@ -58,6 +59,8 @@ const keyMap = {
   ta: 'target',
   docker: 'docker',
   do: 'docker',
+  sprint: 'sprint',
+  s: 'sprint',
 };
 const projectMap = {
   portal: 'medica-portal',
@@ -299,26 +302,16 @@ const generateDeployConfigs = (values = {}) => {
   return { configs: removeEmpty(configs, true) };
 };
 const convertParamsToMap = async (item, type) => {
-  const itemsToSkipCheck = [
-    ACTIONS.CREATE_BRANCH,
-    ACTIONS.HELP,
-    ACTIONS.VERSION,
-    ACTIONS.REFACTOR,
-    ACTIONS.BACKUP,
+  const itemsToCheckLiveness = [
+    ACTIONS.BUILD_DEPLOY,
+    ACTIONS.BUILD,
+    ACTIONS.DEPLOY,
     ACTIONS.MERGE,
-    ACTIONS.TIME_ADD,
-    ACTIONS.TIME_UPDATE,
-    ACTIONS.TIME_DELETE,
-    ACTIONS.TIME_STATUS,
-    ACTIONS.TIME_ENTRIES,
-    ACTIONS.TIME_ZOHO,
-    ACTIONS.TIME_GITLAB,
-    ACTIONS.TIME_MERGE,
+    ACTIONS.REVIEW,
   ];
-  const skipCheck = itemsToSkipCheck.includes(type);
   let live = false;
 
-  if (!skipCheck) {
+  if (itemsToCheckLiveness.includes(type)) {
     if (!gitlabConfig.token) {
       console.log('Configurations are missing...!');
       return null;

package/services/time-entry/enums/actions.enum.js

@@ -1,16 +0,0 @@
-module.exports = {
-  ACTIONS: {
-    INIT: 'init',
-    SWITCH: 'switch',
-    ADD: 'add',
-    UPDATE: 'update',
-    DELETE: 'delete',
-    STATUS: 'status',
-    ENTRIES: 'entries',
-    ZOHO: 'zoho',
-    GITLAB: 'gitlab',
-    MERGE: 'merge',
-    VERSION: 'version',
-    HELP: 'help',
-  },
-};