nippotion 0.0.4 → 0.1.0

package/README.md

@@ -4,7 +4,7 @@ A CLI tool that delivers daily reports (diary entries) written in a Notion datab
 
 - Delivers **the previous business day's** entries on weekday mornings (weekends are skipped; set `"holidays": "jp"` to also skip Japanese holidays via [@holiday-jp/holiday_jp](https://github.com/holiday-jp/holiday_jp). Monday delivers entries dated Friday through Sunday)
 - Routes entries to multiple Slack channels based on their labels (multi-select)
-- Randomly picks one entry each time to feature as the "pickup" entry (chosen from all of the day's entries and shared by every channel, even ones whose labels don't match it)
+- Randomly picks one entry each time to feature as the "pickup" entry (shared by every channel, even ones whose labels don't match it). Unfilled template copies — entries still titled after a template that nobody edited between creation and delivery — are left out of the draw (`pickup.templateCopyMinEditGapMs`)
 - Timezone, holiday skipping, language (Japanese/English), and Slack message wording are all configurable (works for non-Japan offices and English-speaking workspaces too)
 
 ```bash
@@ -108,6 +108,9 @@ To verify it works, trigger it manually from the Actions tab with `debug_mode: t
   "timezone": "America/New_York",
   "language": "en",
   "holidays": "jp",
+  "pickup": {
+    "templateCopyMinEditGapMs": 10000
+  },
   "properties": {
     "title": "Name of the title property",
     "labels": "Name of the multi-select property",
@@ -137,6 +140,16 @@ To verify it works, trigger it manually from the Actions tab with `debug_mode: t
 - `language` sets the default Slack message wording and the log/error message language (`ja` / `en`; **defaults to `NIPPOTION_LANG`, or `en` if neither is set**). Set `"language": "ja"` to use it in Japanese
 - Setting `holidays` to a country code also excludes that country's holidays from business days (**weekends only if omitted**; currently only `jp` — Japanese holidays — is supported). Non-business days are not delivered, and are also skipped when computing "the previous business day" (entries from a holiday arrive together on the next business day)
 - `messages` lets you override individual pieces of Slack wording. All fields are optional (defaults follow `language`). `{database}` is replaced with a link to the database, and `{writer}` with the entry's author name
+- `pickup.templateCopyMinEditGapMs` drops an entry from the **pickup candidates** when **both** of the following hold (default: `10000`, i.e. 10 seconds). Such entries are still delivered to their channels as usual — only the "today's pick" draw skips them. Set `0` to disable the rule and keep every entry as a candidate
+  1. the entry's title matches one of the data source's **template names** exactly, and
+  2. the gap between its `created_time` and its `last_edited_time` is **below** this value — that is, nobody edited it between creation and delivery
+- Neither condition alone is usable: plenty of people leave the title as their template's name and still write a full report, and plenty of reports are composed elsewhere and submitted in a single write. Requiring both is what keeps those two groups in the draw
+- Every run logs the entries it skipped (URL, title, and the measured gap), so you can check what the setting is actually doing
+- **Known limits.** Please read these before turning the threshold up:
+  - A writer who keeps their template's name as the title **and** submits in one write is skipped. In the 3-day sample this rule was built from, that was 2 writers across 4 entries, one of whom was affected on every day of the sample
+  - A template copy whose title is not in the template list — because the template was renamed, or created after the run started — is **not** skipped
+  - If the template list cannot be fetched, **nothing is skipped**. Listing templates requires the data source to be shared with your integration, and the endpoint is documented against a newer `Notion-Version` than the Notion SDK sends by default. Rather than guess, nippotion logs the reason and leaves every entry in the draw
+- Notion is not documented to guarantee sub-second precision on these timestamps. Where it reports them at minute granularity the gap lands on multiples of 60000, and any threshold below a minute behaves as "created and last edited within the same minute" — the same intent, so no configuration change is needed
 
 ### Example: Japanese setup
 

package/dist/cli.js

@@ -27,6 +27,8 @@ Notion\u306E\u65E5\u5831\u30C7\u30FC\u30BF\u30D9\u30FC\u30B9\u304B\u3089\u524D\u
   config: {
     notObject: "\u8A2D\u5B9A\u306F\u30AA\u30D6\u30B8\u30A7\u30AF\u30C8\u3067\u3042\u308B\u5FC5\u8981\u304C\u3042\u308A\u307E\u3059",
     mustBeString: '\u8A2D\u5B9A\u306E "{{keyPath}}" \u306F\u6587\u5B57\u5217\u3067\u3042\u308B\u5FC5\u8981\u304C\u3042\u308A\u307E\u3059\uFF08\u5B9F\u969B\u306E\u578B: {{type}}\uFF09',
+    mustBeNumber: '\u8A2D\u5B9A\u306E "{{keyPath}}" \u306F\u6709\u9650\u306E\u6570\u5024\u3067\u3042\u308B\u5FC5\u8981\u304C\u3042\u308A\u307E\u3059\uFF08\u5B9F\u969B\u306E\u578B: {{type}}\uFF09',
+    mustBeNonNegativeInteger: '\u8A2D\u5B9A\u306E "{{keyPath}}" \u306F0\u4EE5\u4E0A\u306E\u6574\u6570\u3067\u3042\u308B\u5FC5\u8981\u304C\u3042\u308A\u307E\u3059',
     mustBeStringArray: '\u8A2D\u5B9A\u306E "{{keyPath}}" \u306F\u6587\u5B57\u5217\u306E\u914D\u5217\u3067\u3042\u308B\u5FC5\u8981\u304C\u3042\u308A\u307E\u3059',
     mustBeObject: '\u8A2D\u5B9A\u306E "{{keyPath}}" \u306F\u30AA\u30D6\u30B8\u30A7\u30AF\u30C8\u3067\u3042\u308B\u5FC5\u8981\u304C\u3042\u308A\u307E\u3059',
     mustBeArray: '\u8A2D\u5B9A\u306E "{{keyPath}}" \u306F\u914D\u5217\u3067\u3042\u308B\u5FC5\u8981\u304C\u3042\u308A\u307E\u3059',
@@ -40,7 +42,11 @@ Notion\u306E\u65E5\u5831\u30C7\u30FC\u30BF\u30D9\u30FC\u30B9\u304B\u3089\u524D\u
     missing: "\u5FC5\u9808\u74B0\u5883\u5909\u6570\u304C\u8A2D\u5B9A\u3055\u308C\u3066\u3044\u307E\u305B\u3093: {{vars}}"
   },
   notion: {
-    propertyNotFound: '\u30D7\u30ED\u30D1\u30C6\u30A3 "{{name}}" \u304C\u898B\u3064\u304B\u308A\u307E\u305B\u3093'
+    propertyNotFound: '\u30D7\u30ED\u30D1\u30C6\u30A3 "{{name}}" \u304C\u898B\u3064\u304B\u308A\u307E\u305B\u3093',
+    templateListFailed: "\u30C6\u30F3\u30D7\u30EC\u30FC\u30C8\u4E00\u89A7\u3092\u53D6\u5F97\u3067\u304D\u306A\u304B\u3063\u305F\u305F\u3081\u3001pickup\u5019\u88DC\u306E\u9664\u5916\u3092\u884C\u3044\u307E\u305B\u3093: {{message}}"
+  },
+  pickup: {
+    skipped: "pickup\u5019\u88DC\u304B\u3089\u9664\u5916\uFF08\u30BF\u30A4\u30C8\u30EB\u304C\u30C6\u30F3\u30D7\u30EC\u30FC\u30C8\u540D\u306E\u307E\u307E\u3001\u4F5C\u6210\u304B\u3089\u914D\u4FE1\u307E\u3067\u672A\u7DE8\u96C6\uFF09: {{count}}\u4EF6"
   },
   slack: {
     header: "\u524D\u55B6\u696D\u65E5\u306E{database}\u306F\u3053\u3061\u3089",
@@ -71,6 +77,8 @@ Environment variables:
   config: {
     notObject: "Config must be an object",
     mustBeString: 'Config "{{keyPath}}" must be a string (got: {{type}})',
+    mustBeNumber: 'Config "{{keyPath}}" must be a finite number (got: {{type}})',
+    mustBeNonNegativeInteger: 'Config "{{keyPath}}" must be an integer of 0 or greater',
     mustBeStringArray: 'Config "{{keyPath}}" must be an array of strings',
     mustBeObject: 'Config "{{keyPath}}" must be an object',
     mustBeArray: 'Config "{{keyPath}}" must be an array',
@@ -84,7 +92,11 @@ Environment variables:
     missing: "Required environment variables are not set: {{vars}}"
   },
   notion: {
-    propertyNotFound: 'Property "{{name}}" was not found in the data source'
+    propertyNotFound: 'Property "{{name}}" was not found in the data source',
+    templateListFailed: "Could not list the data source templates, so no entry is skipped from the pickup candidates: {{message}}"
+  },
+  pickup: {
+    skipped: "Skipped from pickup candidates (still titled after a template, never edited between creation and delivery): {{count}}"
   },
   slack: {
     header: "Here are the entries from {database} for the previous business day",
@@ -145,6 +157,7 @@ var getPreviousWorkday = (date, holidays) => {
 
 // src/config.ts
 var LANGUAGES = ["ja", "en"];
+var DEFAULT_TEMPLATE_COPY_MIN_EDIT_GAP_MS = 1e4;
 var isPlainObject = (value) => typeof value === "object" && value !== null && !Array.isArray(value);
 var requireString = (value, keyPath) => {
   if (typeof value !== "string") {
@@ -152,6 +165,12 @@ var requireString = (value, keyPath) => {
   }
   return value;
 };
+var requireNumber = (value, keyPath) => {
+  if (typeof value !== "number" || !Number.isFinite(value)) {
+    throw new Error(t("config.mustBeNumber", { keyPath, type: typeof value }));
+  }
+  return value;
+};
 var requireStringArray = (value, keyPath) => {
   if (!Array.isArray(value) || value.some((item) => typeof item !== "string")) {
     throw new Error(t("config.mustBeStringArray", { keyPath }));
@@ -191,6 +210,17 @@ var validateHolidays = (value, keyPath) => {
   }
   return country;
 };
+var validatePickup = (value, keyPath) => {
+  if (!isPlainObject(value)) {
+    throw new Error(t("config.mustBeObject", { keyPath }));
+  }
+  const gapPath = `${keyPath}.templateCopyMinEditGapMs`;
+  const templateCopyMinEditGapMs = requireNumber(value.templateCopyMinEditGapMs, gapPath);
+  if (!Number.isInteger(templateCopyMinEditGapMs) || templateCopyMinEditGapMs < 0) {
+    throw new Error(t("config.mustBeNonNegativeInteger", { keyPath: gapPath }));
+  }
+  return { templateCopyMinEditGapMs };
+};
 var validateLanguage = (value, keyPath) => {
   const language = requireString(value, keyPath);
   if (!LANGUAGES.includes(language)) {
@@ -249,6 +279,9 @@ var validateConfig = (data) => {
   if (data.timezone !== void 0) {
     config.timezone = validateTimezone(data.timezone, "timezone");
   }
+  if (data.pickup !== void 0) {
+    config.pickup = validatePickup(data.pickup, "pickup");
+  }
   return config;
 };
 var loadConfig = (filePath) => {
@@ -371,6 +404,31 @@ var getAllPages = async (client, dataSourceId, filter, filterProperties) => {
   );
   return results.filter(isFullPage);
 };
+var editGapMs = (page) => {
+  const gap = Date.parse(page.last_edited_time) - Date.parse(page.created_time);
+  return Number.isFinite(gap) ? Math.max(0, gap) : 0;
+};
+var fetchTemplateNames = async (client, dataSourceId) => {
+  const names = /* @__PURE__ */ new Set();
+  try {
+    let startCursor;
+    do {
+      const response = await withRetry(() => client.dataSources.listTemplates({
+        data_source_id: dataSourceId,
+        start_cursor: startCursor
+      }));
+      for (const template of response.templates) names.add(template.name);
+      startCursor = response.next_cursor ?? void 0;
+    } while (startCursor);
+  } catch (error) {
+    console.error(t("notion.templateListFailed", {
+      message: error instanceof Error ? error.message : String(error)
+    }));
+    return /* @__PURE__ */ new Set();
+  }
+  return names;
+};
+var isPickupCandidate = (entry, templateNames, minEditGapMs) => !(templateNames.has(entry.title) && entry.editGapMs < minEditGapMs);
 var getTitle = (page, titleProperty) => {
   const prop = page.properties[titleProperty];
   if (prop?.type !== "title") return "";
@@ -394,7 +452,8 @@ var toEntry = (page, properties) => {
     title,
     writerName: getWriterName(page, properties.author),
     labels: getLabels(page, properties.labels),
-    url: page.url
+    url: page.url,
+    editGapMs: editGapMs(page)
   };
 };
 
@@ -507,6 +566,10 @@ var checkRequiredEnvVars = (debug) => {
     process.exit(1);
   }
 };
+var selectPickup = (entries, templateNames, minEditGapMs, rng = Math.random) => {
+  const candidates = entries.filter((entry) => isPickupCandidate(entry, templateNames, minEditGapMs));
+  return candidates[Math.floor(rng() * candidates.length)] ?? null;
+};
 var main = async () => {
   const debug = process.env.NIPPOTION_DEBUG === "1";
   checkRequiredEnvVars(debug);
@@ -544,7 +607,17 @@ var main = async () => {
   const entries = pages.map((page) => toEntry(page, config.properties)).filter((entry) => entry !== null);
   console.log("entries:", JSON.stringify({ pages: pages.length, entries: entries.length }));
   if (entries.length === 0) return;
-  const pickup = entries[Math.floor(Math.random() * entries.length)] ?? null;
+  const minEditGapMs = config.pickup?.templateCopyMinEditGapMs ?? DEFAULT_TEMPLATE_COPY_MIN_EDIT_GAP_MS;
+  const templateNames = await fetchTemplateNames(client, config.dataSourceId);
+  const skipped = entries.filter((entry) => !isPickupCandidate(entry, templateNames, minEditGapMs));
+  if (skipped.length > 0) {
+    console.log(t("pickup.skipped", { count: skipped.length }), JSON.stringify(
+      skipped.map(({ url: url2, title: title2, editGapMs: editGapMs2 }) => ({ url: url2, title: title2, editGapMs: editGapMs2 })),
+      null,
+      2
+    ));
+  }
+  const pickup = selectPickup(entries, templateNames, minEditGapMs);
   const ctx = {
     slack,
     entries,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nippotion",
-  "version": "0.0.4",
+  "version": "0.1.0",
   "description": "Deliver daily reports written in Notion to Slack channels based on their labels",
   "type": "module",
   "scripts": {