ninja-terminals 2.4.1 → 2.4.2

package/README.md

@@ -14,6 +14,8 @@ Run the one-time setup command:
 npx --yes ninja-terminals --setup
 ```
 
+> **On Windows?** Run it inside WSL2 — see [WINDOWS-SETUP.md](WINDOWS-SETUP.md).
+
 ## Quick Start
 
 ### As MCP Server (Recommended)

package/mcp-server.js

@@ -43,7 +43,10 @@ const {
 const PREFERRED_HTTP_PORT = parseInt(process.env.HTTP_PORT || process.env.PORT || '3300', 10);
 let HTTP_PORT = PREFERRED_HTTP_PORT;
 const CLAUDE_CMD = process.env.CLAUDE_CMD || process.env.CLAUDE_CHROME_CMD || 'claude --chrome --model claude-opus-4-5-20251101';
-const SHELL = process.env.SHELL || '/bin/zsh';
+// Windows has no $SHELL / /bin/zsh — default to PowerShell (handles drive
+// changes via `cd` and emits clean ANSI for status detection).
+const IS_WIN = process.platform === 'win32';
+const SHELL = IS_WIN ? (process.env.NINJA_SHELL || 'powershell.exe') : (process.env.SHELL || '/bin/zsh');
 const PROJECT_DIR = __dirname;
 const INJECT_GUIDANCE = process.env.INJECT_GUIDANCE !== 'false';
 
@@ -155,15 +158,23 @@ function spawnTerminal(label, scope = [], cwd = null, tier = 'pro') {
       FORCE_COLOR: '1',
       CLICOLOR_FORCE: '1',
       HOME: os.homedir(),
-      PATH: `${os.homedir()}/.local/bin:/opt/homebrew/bin:${process.env.PATH || ''}`,
+      // On Windows, keep the native PATH untouched (mac/linux bin dirs would
+      // corrupt it via the ';' delimiter). On POSIX, prepend the usual bins.
+      PATH: IS_WIN
+        ? (process.env.PATH || '')
+        : [`${os.homedir()}/.local/bin`, '/opt/homebrew/bin', process.env.PATH || '']
+            .filter(Boolean).join(path.delimiter),
       SHELL_SESSIONS_DISABLE: '1',
       NINJA_TERMINAL_ID: String(id),
     },
   });
 
-  // Launch claude after shell starts
+  // Launch claude after shell starts. Two separate writes (cd, then command)
+  // instead of `&&` — works across bash/zsh/PowerShell/cmd, which disagree on
+  // command chaining (`&&` is unsupported in Windows PowerShell 5).
   setTimeout(() => {
-    ptyProcess.write(`cd "${workDir}" && ${CLAUDE_CMD}\r`);
+    ptyProcess.write(`cd "${workDir}"\r`);
+    setTimeout(() => ptyProcess.write(`${CLAUDE_CMD}\r`), 250);
   }, 500);
 
   const terminal = {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ninja-terminals",
-  "version": "2.4.1",
+  "version": "2.4.2",
   "description": "MCP server for multi-terminal Claude Code orchestration with DAG task management, parallel execution, and self-improvement",
   "main": "server.js",
   "bin": {

package/server.js

@@ -39,7 +39,10 @@ const PREFERRED_PORT = parseInt(process.env.PORT || process.env.HTTP_PORT || '33
 const BIND_HOST = process.env.NINJA_BIND_HOST || '127.0.0.1';
 const DEFAULT_TERMINALS = parseInt(process.env.DEFAULT_TERMINALS || '4', 10);
 const CLAUDE_CMD = process.env.CLAUDE_CMD || process.env.CLAUDE_CHROME_CMD || 'claude --chrome --model claude-opus-4-5-20251101';
-const SHELL = process.env.SHELL || '/bin/zsh';
+// Windows has no $SHELL / /bin/zsh — default to PowerShell (handles drive
+// changes via `cd` and emits clean ANSI for status detection).
+const IS_WIN = process.platform === 'win32';
+const SHELL = IS_WIN ? (process.env.NINJA_SHELL || 'powershell.exe') : (process.env.SHELL || '/bin/zsh');
 const PROJECT_DIR = __dirname;
 const DEFAULT_CWD = process.env.DEFAULT_CWD || null;  // Set to target project path to avoid cross-project prompts
 const INJECT_GUIDANCE = process.env.INJECT_GUIDANCE !== 'false';  // Default true, set INJECT_GUIDANCE=false to disable
@@ -194,7 +197,7 @@ function spawnTerminal(label, scope = [], cwd = null, tier = 'pro', agentType =
     }
   }
 
-  const ptyProcess = pty.spawn(SHELL, ['-l'], {
+  const ptyProcess = pty.spawn(SHELL, IS_WIN ? [] : ['-l'], {
     name: 'xterm-256color',
     cols,
     rows,
@@ -206,7 +209,12 @@ function spawnTerminal(label, scope = [], cwd = null, tier = 'pro', agentType =
       FORCE_COLOR: '1',
       CLICOLOR_FORCE: '1',
       HOME: require('os').homedir(),
-      PATH: `${require('os').homedir()}/.local/bin:/opt/homebrew/bin:${process.env.PATH || ''}`,
+      // On Windows, keep the native PATH untouched (mac/linux bin dirs would
+      // corrupt it via the ';' delimiter). On POSIX, prepend the usual bins.
+      PATH: IS_WIN
+        ? (process.env.PATH || '')
+        : [`${require('os').homedir()}/.local/bin`, '/opt/homebrew/bin', process.env.PATH || '']
+            .filter(Boolean).join(path.delimiter),
       SHELL_SESSIONS_DISABLE: '1',
       NINJA_TERMINAL_ID: String(id),
     },
@@ -214,11 +222,13 @@ function spawnTerminal(label, scope = [], cwd = null, tier = 'pro', agentType =
 
   // After shell starts, cd to work dir and launch agent (if not shell)
   const agentCmd = AGENT_COMMANDS[agentType] || null;
+  // Two separate writes (cd, then command) instead of `&&` — works across
+  // bash/zsh/PowerShell/cmd, which disagree on chaining (`&&` is unsupported
+  // in Windows PowerShell 5).
   setTimeout(() => {
+    ptyProcess.write(`cd "${workDir}"\r`);
     if (agentCmd) {
-      ptyProcess.write(`cd "${workDir}" && ${agentCmd}\r`);
-    } else {
-      ptyProcess.write(`cd "${workDir}"\r`);
+      setTimeout(() => ptyProcess.write(`${agentCmd}\r`), 250);
     }
   }, 500);