nightytidy 0.2.9 → 0.2.12

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nightytidy",
-  "version": "0.2.9",
+  "version": "0.2.12",
   "description": "Automated overnight codebase improvement through Claude Code",
   "license": "MIT",
   "author": "Dorian Spitz",

package/src/agent/cli-bridge.js

@@ -2,7 +2,7 @@ import { spawn } from 'node:child_process';
 import path from 'node:path';
 import { debug, warn, error as logError } from '../logger.js';
 
-const INIT_TIMEOUT_MS = 5 * 60_000;   // 5 minutes — init should never take this long
+const INIT_TIMEOUT_MS = 10 * 60_000;  // 10 minutes — generous but not infinite
 const FINISH_TIMEOUT_MS = 10 * 60_000; // 10 minutes — finish includes report generation
 
 export class CliBridge {

package/src/agent/index.js

@@ -378,6 +378,12 @@ export async function startAgent() {
 
       case 'cancel-queued': {
         runQueue.cancel(msg.runId);
+        // Also notify Firestore — the run may exist there even if not in local queue
+        // (e.g. orphaned after a timeout/crash where the agent already discarded it)
+        dispatchWithQueue('run_failed', {
+          projectId: msg.projectId || '',
+          run: { id: msg.runId },
+        }, []);
         wsServer.broadcast({ type: 'queue-updated', queue: runQueue.getQueue() });
         reply({ type: 'queue-updated', queue: runQueue.getQueue() });
         break;
@@ -527,6 +533,8 @@ export async function startAgent() {
         ? 'Initialization timed out — Claude Code may be unavailable. Restart the agent to retry.'
         : (initResult.parsed?.error || initResult.stderr || 'Unknown init error');
       info(`  ✗ Init failed: ${errorMsg}`);
+      if (initResult.stdout) debug(`  Init stdout: ${initResult.stdout.slice(-500)}`);
+      if (initResult.stderr) debug(`  Init stderr: ${initResult.stderr.slice(-500)}`);
       wsServer.broadcast({ type: 'run-failed', runId: run.id, error: errorMsg });
       dispatchWithQueue('run_failed', {
         project: project.name,
@@ -1080,22 +1088,35 @@ export async function startAgent() {
     const progress = interrupted.lastProgress || {};
     const completed = progress.completedCount || 0;
     const total = interrupted.steps?.length || 0;
-    info(`Found interrupted run: ${projName} (${completed}/${total} steps completed)`);
-    info(`  Run ID: ${interrupted.id}`);
-    info(`  Use the web app to Resume, Finish with Partial Results, or Discard`);
 
-    // Best-effort: notify Firestore that this run is interrupted
-    // (in case the shutdown webhook didn't make it)
-    if (proj) {
-      dispatchWithQueue('run_interrupted', {
-        projectId: proj.id,
-        run: {
-          id: interrupted.id,
-          completedSteps: completed,
-          failedSteps: progress.failedCount || 0,
-          totalCost: progress.totalCost || 0,
-        },
+    if (completed === 0) {
+      // Run never actually started (init timed out or crashed before any steps).
+      // Auto-discard — there's nothing to resume or finish, and blocking the
+      // queue for user action is pointless.
+      info(`Auto-discarding interrupted run with 0 completed steps: ${projName} (${interrupted.id})`);
+      runQueue.clearInterrupted();
+      dispatchWithQueue('run_failed', {
+        projectId: proj?.id || interrupted.projectId,
+        run: { id: interrupted.id },
       }, []);
+    } else {
+      info(`Found interrupted run: ${projName} (${completed}/${total} steps completed)`);
+      info(`  Run ID: ${interrupted.id}`);
+      info(`  Use the web app to Resume, Finish with Partial Results, or Discard`);
+
+      // Best-effort: notify Firestore that this run is interrupted
+      // (in case the shutdown webhook didn't make it)
+      if (proj) {
+        dispatchWithQueue('run_interrupted', {
+          projectId: proj.id,
+          run: {
+            id: interrupted.id,
+            completedSteps: completed,
+            failedSteps: progress.failedCount || 0,
+            totalCost: progress.totalCost || 0,
+          },
+        }, []);
+      }
     }
   }
 
@@ -1103,8 +1124,13 @@ export async function startAgent() {
   // (agent died without graceful shutdown, so markInterrupted was never called)
   const current = runQueue.getCurrent();
   if (current && current.status === 'running' && !activeBridge) {
-    info(`Found orphaned running run: ${current.id} — marking as interrupted`);
-    runQueue.markInterrupted({ completedCount: 0, failedCount: 0, totalCost: 0, stepList: [], currentStepNum: null });
+    // Orphaned run with no progress — auto-discard instead of blocking the queue
+    info(`Found orphaned running run: ${current.id} — auto-discarding (0 steps completed)`);
+    runQueue.completeCurrent({ success: false });
+    dispatchWithQueue('run_failed', {
+      projectId: current.projectId,
+      run: { id: current.id },
+    }, []);
   }
 
   // Process any queued runs left from a previous session

package/src/checks.js

@@ -203,18 +203,19 @@ async function checkClaudeAuthenticated() {
 async function getFreeBytesWindows(projectDir) {
   const driveLetter = projectDir.charAt(0).toUpperCase();
   // Try PowerShell first (wmic is deprecated on newer Windows)
+  // 10s timeout — PowerShell can hang on OneDrive/network drive systems
   const psResult = await runCommand('powershell', [
     '-NoProfile', '-Command',
     `(Get-PSDrive ${driveLetter}).Free`,
-  ]);
+  ], { timeoutMs: 10_000 });
   const psMatch = psResult.stdout.trim().match(/^(\d+)$/);
   if (psResult.code === 0 && psMatch) {
     return parseInt(psMatch[1], 10);
   }
-  // Fallback to wmic for older Windows
+  // Fallback to wmic for older Windows (also with timeout)
   const result = await runCommand('wmic', [
     'logicaldisk', 'where', `DeviceID='${driveLetter}:'`, 'get', 'FreeSpace',
-  ]);
+  ], { timeoutMs: 10_000 });
   const match = result.stdout.match(/(\d+)/);
   return match ? parseInt(match[1], 10) : null;
 }