niceeval 0.9.0 → 0.10.0

package/src/report/components/attempt-detail/validate.test.ts

@@ -0,0 +1,235 @@
+// cases: docs/engineering/unit-tests/reports/cases.md
+// "validate*Data 递归覆盖到嵌套字段" 行:attempt-detail 十一个叶子的 validate*Data 表驱动字段突变覆盖,重点是 AttemptConversationData
+// 的 AttemptConversationReply 判别联合(每个 kind 分支各自的必填字段)与其余嵌套结构
+// (AttemptIdentity / AssertionResult 判别联合 / TraceSpan / AttemptDiffFileEntry 的 net 枚举)。
+
+import { describe, expect, it } from "vitest";
+import {
+  validateAssertionsData,
+  validateConversationData,
+  validateDiagnosticsData,
+  validateDiffData,
+  validateErrorData,
+  validateSourceData,
+  validateSummaryData,
+  validateTimelineData,
+  validateTraceData,
+  validateUsageData,
+} from "./index.tsx";
+
+const validIdentity = { experimentId: "compare/codex", snapshotStartedAt: "2026-07-01T00:00:00Z", evalId: "q1", attempt: 0 };
+const validCapabilities = { source: true, execution: true, timing: false, diff: false };
+
+describe("validateSummaryData", () => {
+  const valid = {
+    locator: "@1abcdef2",
+    identity: validIdentity,
+    verdict: "passed",
+    durationMs: 1000,
+    costUSD: 0.01,
+    capabilities: validCapabilities,
+  };
+
+  it("合规 literal 通过", () => {
+    expect(validateSummaryData(valid)).toBeNull();
+  });
+
+  it("costUSD 为 null 合法(缺失不冒充 0)", () => {
+    expect(validateSummaryData({ ...valid, costUSD: null })).toBeNull();
+  });
+
+  it("identity 缺 snapshotStartedAt 报错定位到嵌套字段", () => {
+    const bad = { ...valid, identity: { experimentId: "compare/codex", evalId: "q1", attempt: 0 } };
+    expect(validateSummaryData(bad)).toMatch(/"identity\.snapshotStartedAt"/);
+  });
+
+  it("capabilities.timing 非布尔报错", () => {
+    const bad = { ...valid, capabilities: { ...validCapabilities, timing: "false" } };
+    expect(validateSummaryData(bad)).toMatch(/"capabilities\.timing"/);
+  });
+});
+
+describe("validateErrorData", () => {
+  const valid = { code: "unexpected-error", message: "boom", phase: "eval.run" };
+
+  it("合规 literal 通过", () => {
+    expect(validateErrorData(valid)).toBeNull();
+  });
+
+  it("缺 phase 报错", () => {
+    expect(validateErrorData({ code: "x", message: "boom" })).toMatch(/"phase"/);
+  });
+});
+
+describe("validateAssertionsData", () => {
+  const passed = { name: "eq", severity: "gate", outcome: "passed", score: 1 };
+  const unavailable = { name: "judge", severity: "soft", outcome: "unavailable", reason: "judge-model-unresolved" };
+
+  it("合规 literal 通过(含 unavailable 分支)", () => {
+    const valid = { attention: [unavailable], passedGroups: [{ group: "", items: [passed] }] };
+    expect(validateAssertionsData(valid)).toBeNull();
+  });
+
+  it("passed/failed 分支缺 score 报错", () => {
+    const bad = { attention: [{ name: "eq", severity: "gate", outcome: "passed" }], passedGroups: [] };
+    expect(validateAssertionsData(bad)).toMatch(/"attention\[0\]\.score"/);
+  });
+
+  it("unavailable 分支缺 reason 报错", () => {
+    const bad = { attention: [{ name: "judge", severity: "soft", outcome: "unavailable" }], passedGroups: [] };
+    expect(validateAssertionsData(bad)).toMatch(/"attention\[0\]\.reason"/);
+  });
+
+  it("outcome 不在判别集合内报错", () => {
+    const bad = { attention: [{ name: "eq", severity: "gate", outcome: "flaky", score: 1 }], passedGroups: [] };
+    expect(validateAssertionsData(bad)).toMatch(/"attention\[0\]\.outcome"/);
+  });
+
+  it("passedGroups[i].items 嵌套断言报错定位到分组内下标", () => {
+    const bad = { attention: [], passedGroups: [{ group: "setup", items: [{ name: "eq", severity: "gate" }] }] };
+    expect(validateAssertionsData(bad)).toMatch(/"passedGroups\[0\]\.items\[0\]\.outcome"/);
+  });
+});
+
+describe("validateSourceData", () => {
+  const validSummary = {
+    totalAssertions: 1,
+    mappedAssertions: 1,
+    unmappedAssertions: 0,
+    passed: 1,
+    failed: 0,
+    gate: 1,
+    soft: 0,
+    totalLines: 10,
+    annotatedLines: 1,
+  };
+  const valid = {
+    locator: "@1abcdef2",
+    sourcePath: "eval.ts",
+    lines: [{ line: 1, text: "t.send(...)", assertions: [], sends: [] }],
+    unmapped: [],
+    summary: validSummary,
+  };
+
+  it("合规 literal 通过", () => {
+    expect(validateSourceData(valid)).toBeNull();
+  });
+
+  it("summary 缺 totalLines 报错", () => {
+    const bad = { ...valid, summary: { ...validSummary, totalLines: undefined } };
+    expect(validateSourceData(bad)).toMatch(/"summary\.totalLines"/);
+  });
+
+  it("summary 缺 annotatedLines 报错", () => {
+    const bad = { ...valid, summary: { ...validSummary, annotatedLines: undefined } };
+    expect(validateSourceData(bad)).toMatch(/"summary\.annotatedLines"/);
+  });
+
+  it("lines[i].assertions 嵌套断言结构错误报错", () => {
+    const bad = { ...valid, lines: [{ line: 1, text: "x", assertions: [{ name: "eq" }], sends: [] }] };
+    expect(validateSourceData(bad)).toMatch(/"lines\[0\]\.assertions\[0\]\.severity"/);
+  });
+});
+
+describe("validateTimelineData", () => {
+  const valid = { locator: "@1abcdef2", phases: [{ name: "eval.run", durationMs: 500 }], trace: null };
+
+  it("合规 literal 通过(trace 为 null)", () => {
+    expect(validateTimelineData(valid)).toBeNull();
+  });
+
+  it("trace 为数组时逐项校验 TraceSpan", () => {
+    const bad = { ...valid, trace: [{ traceId: "t1", spanId: "s1", name: "turn", startMs: 0 }] };
+    expect(validateTimelineData(bad)).toMatch(/"trace\[0\]\.endMs"/);
+  });
+
+  it("phases[i] 缺 durationMs 报错", () => {
+    const bad = { ...valid, phases: [{ name: "eval.run" }] };
+    expect(validateTimelineData(bad)).toMatch(/"phases\[0\]\.durationMs"/);
+  });
+});
+
+describe("validateConversationData — AttemptConversationReply 判别联合", () => {
+  const valid = {
+    locator: "@1abcdef2",
+    rounds: [{ sentText: "go", replies: [{ kind: "assistant", text: "ok" }] }],
+  };
+
+  it("合规 literal 通过", () => {
+    expect(validateConversationData(valid)).toBeNull();
+  });
+
+  it.each([
+    ["assistant", { kind: "assistant" }, /"rounds\[0\]\.replies\[0\]\.text"/],
+    ["tool 缺 callId", { kind: "tool", name: "shell", input: "ls" }, /"rounds\[0\]\.replies\[0\]\.callId"/],
+    ["tool 缺 input", { kind: "tool", callId: "c1", name: "shell" }, /"rounds\[0\]\.replies\[0\]\.input"/],
+    ["skill 缺 skill", { kind: "skill" }, /"rounds\[0\]\.replies\[0\]\.skill"/],
+    ["subagent 缺 name", { kind: "subagent", callId: "c1" }, /"rounds\[0\]\.replies\[0\]\.name"/],
+    ["input 缺 request", { kind: "input" }, /"rounds\[0\]\.replies\[0\]\.request"/],
+    ["raw 缺 raw", { kind: "raw" }, /"rounds\[0\]\.replies\[0\]\.raw"/],
+    ["未知 kind", { kind: "unknown-future-kind" }, /"rounds\[0\]\.replies\[0\]\.kind"/],
+  ])("%s 报错定位到具体缺失字段", (_label, reply, expected) => {
+    const bad = { locator: "@1abcdef2", rounds: [{ sentText: "go", replies: [reply] }] };
+    expect(validateConversationData(bad)).toMatch(expected);
+  });
+
+  it("compaction 分支无必填字段,裸 { kind: 'compaction' } 合法", () => {
+    const ok = { locator: "@1abcdef2", rounds: [{ sentText: "go", replies: [{ kind: "compaction" }] }] };
+    expect(validateConversationData(ok)).toBeNull();
+  });
+
+  it("round.loc 存在时校验 SourceLoc 结构;省略 loc 合法(流首无位置信息的兜底轮)", () => {
+    expect(validateConversationData(valid)).toBeNull();
+    const withLoc = { locator: "@1abcdef2", rounds: [{ loc: { file: "eval.ts", line: 3 }, sentText: "go", replies: [] }] };
+    expect(validateConversationData(withLoc)).toBeNull();
+    const badLoc = { locator: "@1abcdef2", rounds: [{ loc: { file: "eval.ts" }, sentText: "go", replies: [] }] };
+    expect(validateConversationData(badLoc)).toMatch(/"rounds\[0\]\.loc\.line"/);
+  });
+});
+
+describe("validateDiagnosticsData", () => {
+  it("合规 literal 通过", () => {
+    const valid = { groups: [{ phase: "eval.run", items: [{ code: "x", level: "warning", message: "m", phase: "eval.run" }] }] };
+    expect(validateDiagnosticsData(valid)).toBeNull();
+  });
+
+  it("level 不在 warning/error 内报错", () => {
+    const bad = { groups: [{ phase: "eval.run", items: [{ code: "x", level: "info", message: "m", phase: "eval.run" }] }] };
+    expect(validateDiagnosticsData(bad)).toMatch(/"groups\[0\]\.items\[0\]\.level"/);
+  });
+});
+
+describe("validateUsageData", () => {
+  it("合规 literal 通过,costUSD 为 null 合法", () => {
+    expect(validateUsageData({ usage: { inputTokens: 1, outputTokens: 2 }, costUSD: null })).toBeNull();
+  });
+
+  it("usage 缺 outputTokens 报错", () => {
+    expect(validateUsageData({ usage: { inputTokens: 1 }, costUSD: null })).toMatch(/"usage\.outputTokens"/);
+  });
+});
+
+describe("validateTraceData", () => {
+  it("spans[i] 缺 spanId 报错", () => {
+    const bad = { locator: "@1abcdef2", spans: [{ traceId: "t1", name: "turn", startMs: 0, endMs: 1 }] };
+    expect(validateTraceData(bad)).toMatch(/"spans\[0\]\.spanId"/);
+  });
+});
+
+describe("validateDiffData", () => {
+  const valid = { locator: "@1abcdef2", files: [{ path: "a.ts", net: "modified", lines: { added: 1, deleted: 0 }, windows: ["s1/t1"] }] };
+
+  it("合规 literal 通过", () => {
+    expect(validateDiffData(valid)).toBeNull();
+  });
+
+  it("net 不在三态枚举内报错", () => {
+    const bad = { ...valid, files: [{ ...valid.files[0], net: "none" }] };
+    expect(validateDiffData(bad)).toMatch(/"files\[0\]\.net"/);
+  });
+
+  it("lines 结构错误报错", () => {
+    const bad = { ...valid, files: [{ ...valid.files[0], lines: { added: 1 } }] };
+    expect(validateDiffData(bad)).toMatch(/"files\[0\]\.lines"/);
+  });
+});

package/src/report/{react → components}/cell.tsx

@@ -3,18 +3,21 @@
 // 纯渲染、零 hooks;交互只有普通 <a>(下钻由使用者的 attemptHref 决定去处)。
 
 import type { ReactElement } from "react";
-import type { MetricCell } from "../types.ts";
+import type { MetricCell } from "../model/types.ts";
 import type { AttemptLocator } from "../../results/locator.ts";
-import { DEFAULT_REPORT_LOCALE, localeText, resolveLocalizedText, type ReportLocale } from "../locale.ts";
+import { DEFAULT_REPORT_LOCALE, localeText, resolveLocalizedText, type ReportLocale } from "../model/locale.ts";
 
 export function MetricCellView({
   cell,
   attemptHref,
   locale = DEFAULT_REPORT_LOCALE,
+  showCoverage = true,
 }: {
   cell: MetricCell;
   attemptHref?: (locator: AttemptLocator) => string;
   locale?: ReportLocale;
+  /** 默认用紧凑角标显示覆盖率；已有展开说明的摘要卡可关闭角标。 */
+  showCoverage?: boolean;
 }): ReactElement {
   // 全 null(没有任何有效样本)→ 缺数据文案,绝不画 0;total 仍如实入 title
   if (cell.value === null) {
@@ -35,7 +38,7 @@ export function MetricCellView({
         {resolveLocalizedText(cell.display, locale)}
       </span>
       {/* samples < total:有 attempt 测不了这个指标,覆盖率角标如实标出 */}
-      {cell.samples < cell.total && (
+      {showCoverage && cell.samples < cell.total && (
         <sup
           className="nre-coverage"
           title={localeText(locale, "cell.coverageTitle", { samples: cell.samples, total: cell.total })}