niahere 0.3.4 → 0.3.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "niahere",
-  "version": "0.3.4",
+  "version": "0.3.6",
   "description": "A personal AI assistant daemon — chat, scheduled jobs, persona system, extensible via skills.",
   "type": "module",
   "scripts": {

package/src/channels/slack.ts

@@ -430,10 +430,20 @@ class SlackChannel implements Channel {
           );
 
           const reply = result.trim();
-
-          // [NO_REPLY] or empty = agent chose not to respond (thread judgement)
-          if (!reply || cleanSentinel(reply) === "[NO_REPLY]") {
-            log.info({ channel: msg.channel, key }, "slack: agent chose not to reply");
+          const cleaned = cleanSentinel(reply);
+
+          // [NO_REPLY] anywhere in the reply suppresses the send. If it appeared
+          // alongside real content the model got confused — warn so we can spot it.
+          if (!reply || cleaned.includes("[NO_REPLY]")) {
+            const exact = !reply || cleaned === "[NO_REPLY]";
+            if (exact) {
+              log.info({ channel: msg.channel, key }, "slack: agent chose not to reply");
+            } else {
+              log.warn(
+                { channel: msg.channel, key, reply },
+                "slack: [NO_REPLY] sentinel mixed with content; suppressing send",
+              );
+            }
             if (messageId) await Message.updateDeliveryStatus(messageId, "sent").catch(() => {});
             return;
           }

package/src/chat/engine.ts

@@ -27,6 +27,7 @@ import { isRetryableApiError, sleep } from "../utils/retry";
 import { registerActiveHandle, unregisterActiveHandle } from "../core/active-handles";
 import { resolveJobPrompt } from "../core/job-prompt";
 import { getSdkSkillsSetting } from "../core/skills";
+import { getSdkHooks } from "../core/sdk-hooks";
 
 const IDLE_TIMEOUT = 10 * 60 * 1000; // 10 minutes
 const LONG_RUNNING_WARN = 30 * 60 * 1000; // 30 minutes
@@ -332,6 +333,7 @@ export async function createChatEngine(opts: EngineOptions): Promise<ChatEngine>
       includePartialMessages: true,
       settingSources: ["project", "user"],
       skills: getSdkSkillsSetting(),
+      hooks: getSdkHooks(),
     };
     const model = resolveSdkModel(contextModel);
     if (model) {

package/src/core/runner.ts

@@ -18,6 +18,7 @@ import { log } from "../utils/log";
 import { isRetryableApiError, sleep } from "../utils/retry";
 import { registerActiveHandle, unregisterActiveHandle } from "./active-handles";
 import { getSdkSkillsSetting } from "./skills";
+import { getSdkHooks } from "./sdk-hooks";
 
 export { buildWorkingMemory } from "./job-prompt";
 
@@ -121,6 +122,7 @@ export async function runJobWithClaude(
     permissionMode: "bypassPermissions",
     sessionId,
     skills: getSdkSkillsSetting(),
+    hooks: getSdkHooks(),
   };
 
   if (model && model !== "default") {

package/src/core/sdk-hooks.ts

@@ -0,0 +1,43 @@
+import type {
+  HookCallbackMatcher,
+  HookEvent,
+  HookJSONOutput,
+  PreToolUseHookInput,
+} from "@anthropic-ai/claude-agent-sdk";
+
+const GH_MERGE_PATTERN = /(?:^|[\s;&|(])gh\s+pr\s+merge(?:\s|$)/;
+
+const STAMP_WARNING_CONTEXT = [
+  "PreToolUse warning: this Bash command merges a GitHub PR.",
+  "If the user only wants to APPROVE the PR (LGTM), use the gh-stamp skill",
+  '(`gh pr comment <pr> --body "LGTM, Stamped ✅"`) instead of merging.',
+  "Confirm intent before proceeding.",
+].join(" ");
+
+const STAMP_WARNING_MESSAGE =
+  "Heads up: about to run `gh pr merge`. Did you mean to STAMP (LGTM approval) instead? See the gh-stamp skill.";
+
+const warnOnGhMerge: HookCallbackMatcher = {
+  matcher: "Bash",
+  hooks: [
+    async (input): Promise<HookJSONOutput> => {
+      if (input.hook_event_name !== "PreToolUse") return {};
+      const command = (input as PreToolUseHookInput).tool_input as { command?: unknown } | undefined;
+      const cmd = command?.command;
+      if (typeof cmd !== "string" || !GH_MERGE_PATTERN.test(cmd)) return {};
+      return {
+        systemMessage: STAMP_WARNING_MESSAGE,
+        hookSpecificOutput: {
+          hookEventName: "PreToolUse",
+          additionalContext: STAMP_WARNING_CONTEXT,
+        },
+      };
+    },
+  ],
+};
+
+export function getSdkHooks(): Partial<Record<HookEvent, HookCallbackMatcher[]>> {
+  return {
+    PreToolUse: [warnOnGhMerge],
+  };
+}