ng-mocks 13.4.1 → 13.5.0

package/README.md

@@ -39,7 +39,7 @@ The current version of the library **has been tested** and **can be used** with:
 
 - [chat on gitter](https://gitter.im/ng-mocks/community)
 - **[ask a question on Stackoverflow](https://stackoverflow.com/questions/ask?tags=ng-mocks%20angular%20testing%20mocking)**
-- [report an issue on GitHub](https://github.com/ike18t/ng-mocks/issues/new)
+- [report an issue on GitHub](https://github.com/ike18t/ng-mocks/issues)
 
 ## Very short introduction
 

package/examples/MockForms/test.spec.ts

@@ -31,12 +31,7 @@ class DependencyComponent implements ControlValueAccessor {
 
 @Component({
   selector: 'tested',
-  template: `
-    <app-child
-      [ngModel]="value"
-      (ngModelChange)="value = $event"
-    ></app-child>
-  `,
+  template: ` <app-child [(ngModel)]="value"></app-child> `,
 })
 class TestedComponent {
   public value: any;
@@ -67,9 +62,12 @@ describe('MockForms', () => {
     MockInstance(DependencyComponent, 'writeValue', writeValue);
 
     const fixture = MockRender(TestedComponent);
+    // FormsModule needs fixture.whenStable()
+    // right after MockRender to install all hooks.
+    await fixture.whenStable();
     const component = fixture.point.componentInstance;
 
-    // During initialization it should be called
+    // During initialization, it should be called
     // with null.
     expect(writeValue).toHaveBeenCalledWith(null);
 
@@ -77,12 +75,12 @@ describe('MockForms', () => {
     // and simulate its change, like a user does it.
     const mockControlEl = ngMocks.find(DependencyComponent);
     ngMocks.change(mockControlEl, 'foo');
-    await fixture.whenStable();
     expect(component.value).toBe('foo');
 
     // Let's check that change on existing value
     // causes calls of `writeValue` on the mock component.
     component.value = 'bar';
+    // Both below are needed to trigger writeValue.
     fixture.detectChanges();
     await fixture.whenStable();
     expect(writeValue).toHaveBeenCalledWith('bar');

package/examples/readme/builder.spec.ts

@@ -26,9 +26,9 @@ export const EMPTY = new Subject<any>();
 EMPTY.complete();
 
 interface User {
-  email: string;
-  firstName: string;
-  lastName: string;
+  email?: string | null;
+  firstName?: string | null;
+  lastName?: string | null;
 }
 
 @Injectable()
@@ -56,9 +56,9 @@ class StorageService {
 })
 class ProfileComponent implements OnInit {
   public readonly form = new FormGroup({
-    email: new FormControl(null, Validators.required),
-    firstName: new FormControl(null, Validators.required),
-    lastName: new FormControl(null, Validators.required),
+    email: new FormControl('', Validators.required),
+    firstName: new FormControl('', Validators.required),
+    lastName: new FormControl('', Validators.required),
   });
 
   @Input() public readonly profile: User | null = null;
@@ -67,7 +67,7 @@ class ProfileComponent implements OnInit {
 
   public ngOnInit(): void {
     if (this.profile) {
-      this.form.setValue(this.profile);
+      this.form.patchValue(this.profile);
     }
   }
 

package/examples/readme/classic.spec.ts

@@ -28,9 +28,9 @@ export const EMPTY = new Subject<any>();
 EMPTY.complete();
 
 interface User {
-  email: string;
-  firstName: string;
-  lastName: string;
+  email?: string | null;
+  firstName?: string | null;
+  lastName?: string | null;
 }
 
 @Injectable()
@@ -58,9 +58,9 @@ class StorageService {
 })
 class ProfileComponent implements OnInit {
   public readonly form = new FormGroup({
-    email: new FormControl(null, Validators.required),
-    firstName: new FormControl(null, Validators.required),
-    lastName: new FormControl(null, Validators.required),
+    email: new FormControl('', Validators.required),
+    firstName: new FormControl('', Validators.required),
+    lastName: new FormControl('', Validators.required),
   });
 
   @Input() public readonly profile: User | null = null;
@@ -69,7 +69,7 @@ class ProfileComponent implements OnInit {
 
   public ngOnInit(): void {
     if (this.profile) {
-      this.form.setValue(this.profile);
+      this.form.patchValue(this.profile);
     }
   }