next-issue 2.5.7 → 2.5.9

package/README.md

@@ -249,7 +249,9 @@ Three levels of console output:
   level and the extensions from your pi settings, except the `pi-next-issue`
   extension. The implementer and the fixer get the default tools of your pi
   settings, the `grep`, `find` and `ls` tools and the tools of your
-  extensions. The reviewer gets all of them except `edit` and `write`.
+  extensions. The reviewer gets all of them except `edit` and `write`. The
+  agents run with `GIT_OPTIONAL_LOCKS=0`, so a `git status` from an agent or
+  an extension does not hold the index lock while the harness commits.
 
 ## Configuration
 

package/dist/agents.mjs

@@ -17,6 +17,7 @@ export async function runAgent(recorder, request) {
     const runtime = request.runtime ?? {};
     const agentDir = runtime.agentDir ?? getAgentDir();
     const started = Date.now();
+    process.env.GIT_OPTIONAL_LOCKS = '0';
     log.event('agent.start', { model: request.model, timeoutMs: request.timeoutMs }, 'normal');
     const resourceLoader = new DefaultResourceLoader({
         cwd: request.cwd,

package/dist/github.mjs

@@ -62,7 +62,7 @@ export async function openIssues(repo, limit, labels) {
         ISSUE_FIELDS,
     ]);
     const parsed = JSON.parse(raw);
-    return parsed.map(toIssue).sort((a, b) => a.createdAt.localeCompare(b.createdAt));
+    return parsed.map(toIssue);
 }
 export async function viewIssue(repo, issue) {
     const raw = await gh(repo, ['issue', 'view', String(issue), '--json', `${ISSUE_FIELDS},state`]);
@@ -100,11 +100,25 @@ export function labelArgs(add, remove, current) {
     return args;
 }
 export async function setLabel(repo, kind, number, add, remove) {
-    await ensureLabel(repo, add);
+    await createUnknownLabel(repo, add);
     const current = await labelsOf(repo, kind, number);
-    await gh(repo, [kind, 'edit', String(number), ...labelArgs(add, remove, current)]);
+    const args = [kind, 'edit', String(number), ...labelArgs(add, remove, current)];
+    try {
+        await gh(repo, args);
+    }
+    catch (error) {
+        KNOWN_LABELS.delete(slug(repo));
+        const created = await createUnknownLabel(repo, add);
+        if (created === 'known') {
+            throw error;
+        }
+        if (created instanceof Error) {
+            throw created;
+        }
+        await gh(repo, args);
+    }
 }
-async function ensureLabel(repo, label) {
+async function createUnknownLabel(repo, label) {
     let known = KNOWN_LABELS.get(slug(repo));
     if (known === undefined) {
         const raw = await gh(repo, ['label', 'list', '--limit', '1000', '--json', 'name']);
@@ -112,14 +126,16 @@ async function ensureLabel(repo, label) {
         KNOWN_LABELS.set(slug(repo), known);
     }
     if (known.has(label)) {
-        return;
+        return 'known';
     }
-    const result = await run('gh', ['label', 'create', label, '--repo', slug(repo)], {
-        cwd: repo.root,
-    });
-    if (result.code === 0) {
-        known.add(label);
+    try {
+        await ghOnce(repo, ['label', 'create', label]);
+    }
+    catch (error) {
+        return error instanceof Error ? error : new Error(String(error));
     }
+    known.add(label);
+    return 'created';
 }
 export async function findPr(repo, branch) {
     const raw = await gh(repo, [

package/dist/protocol.mjs

@@ -0,0 +1,37 @@
+export function isNewer(candidate, current) {
+    const [leftCore = '', ...leftRest] = candidate.replace(/\+.*$/, '').split('-');
+    const [rightCore = '', ...rightRest] = current.replace(/\+.*$/, '').split('-');
+    const left = leftCore.split('.').map(Number);
+    const right = rightCore.split('.').map(Number);
+    for (let index = 0; index < Math.max(left.length, right.length); index += 1) {
+        const difference = (left[index] ?? 0) - (right[index] ?? 0);
+        if (difference !== 0) {
+            return difference > 0;
+        }
+    }
+    const leftPrerelease = leftRest.length > 0 ? leftRest.join('-').split('.') : [];
+    const rightPrerelease = rightRest.length > 0 ? rightRest.join('-').split('.') : [];
+    if (leftPrerelease.length === 0 || rightPrerelease.length === 0) {
+        return leftPrerelease.length === 0 && rightPrerelease.length > 0;
+    }
+    for (let index = 0; index < Math.max(leftPrerelease.length, rightPrerelease.length); index += 1) {
+        const leftPart = leftPrerelease[index];
+        const rightPart = rightPrerelease[index];
+        if (leftPart === undefined || rightPart === undefined) {
+            return rightPart === undefined;
+        }
+        if (leftPart === rightPart) {
+            continue;
+        }
+        const leftNumeric = /^\d+$/.test(leftPart);
+        const rightNumeric = /^\d+$/.test(rightPart);
+        if (leftNumeric && rightNumeric) {
+            return Number(leftPart) > Number(rightPart);
+        }
+        if (leftNumeric || rightNumeric) {
+            return rightNumeric;
+        }
+        return leftPart > rightPart;
+    }
+    return false;
+}

package/dist/serve.mjs

@@ -1,5 +1,5 @@
 import { rmSync } from 'node:fs';
-import { chmod, readFile, rm, writeFile } from 'node:fs/promises';
+import { readFile, rm, writeFile } from 'node:fs/promises';
 import { createServer } from 'node:http';
 import { join } from 'node:path';
 import { getAgentDir } from '@earendil-works/pi-coding-agent';
@@ -8,6 +8,7 @@ import { parseArgs } from './args.mjs';
 import { stopChildren } from './exec.mjs';
 import { message } from './observe.mjs';
 import { applyEvent, startProgress } from './progress.mjs';
+import { isNewer } from './protocol.mjs';
 import { runRepo } from './run.mjs';
 import { packageVersion } from './version.mjs';
 export function socketPaths(agentDir = getAgentDir()) {
@@ -16,17 +17,6 @@ export function socketPaths(agentDir = getAgentDir()) {
         lockPath: join(agentDir, 'next-issue.lock'),
     };
 }
-export function isNewer(candidate, current) {
-    const left = candidate.split('.').map(Number);
-    const right = current.split('.').map(Number);
-    for (let index = 0; index < Math.max(left.length, right.length); index += 1) {
-        const difference = (left[index] ?? 0) - (right[index] ?? 0);
-        if (difference !== 0) {
-            return difference > 0;
-        }
-    }
-    return false;
-}
 function alive(pid) {
     try {
         process.kill(pid, 0);
@@ -191,12 +181,17 @@ export async function startWorker(options) {
     });
     await new Promise((resolve, reject) => {
         server.once('error', reject);
-        server.listen(options.socketPath, () => {
-            server.off('error', reject);
-            resolve();
-        });
+        const umask = process.umask(0o177);
+        try {
+            server.listen(options.socketPath, () => {
+                server.off('error', reject);
+                resolve();
+            });
+        }
+        finally {
+            process.umask(umask);
+        }
     });
-    await chmod(options.socketPath, 0o600);
     return { closed, close };
 }
 export async function serve() {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "next-issue",
-  "version": "2.5.7",
+  "version": "2.5.9",
   "description": "Autonomous issue harness driven by the pi SDK",
   "keywords": [
     "github",