next-issue 2.4.6 → 2.4.8

package/README.md

@@ -51,7 +51,10 @@ and exits with code 1. For each issue:
    while no check failed counts as such a read, not as a red build. A repository that reports no
    check keeps asking for `checkGraceSeconds`, because a new pull request often
    shows no check yet, and only then goes straight to the review. The later
-   gates of the same issue ask once.
+   gates of the same issue ask once. GitHub runs no check on a pull request
+   that conflicts with its base, so no check and a conflict hand the issue to
+   a person. While GitHub still works out whether the pull request can merge,
+   the run asks again until `checkTimeoutMinutes`.
 7. On a red build, give the failed job logs to the fixer agent, then go to step
    6 again. The budget is `maxCiFixes`.
 8. Let the reviewer agent judge the diff, at most `diffMaxChars` of it. The
@@ -97,7 +100,8 @@ and exits with code 1. For each issue:
 ## Stops for a loop
 
 The harness hands the issue to a person, with the `status:needs-human` label,
-when:
+and comments the reason on the pull request, or on the issue when there is no
+pull request yet, when:
 
 - the check budget or the review budget runs out;
 - a fixer round adds no commit and gives no reason, so there is no progress;
@@ -132,8 +136,8 @@ when:
 - the setup command fails, or does not finish in `setupTimeoutMinutes`;
 - a step of the run fails with an error. A `gh` call that is safe to repeat,
   such as a read or a label edit, is tried up to three times first when the
-  network fails. A `gh pr create` or `gh pr comment` is tried once, so a lost
-  reply never makes a duplicate.
+  network fails. A `gh pr create`, `gh pr comment` or `gh issue comment` is
+  tried once, so a lost reply never makes a duplicate.
 
 The fixer sees the findings of all earlier rounds, not only the last one, with
 its own disputes next to them. From round two, the reviewer judges only the

package/dist/github.mjs

@@ -330,6 +330,17 @@ export async function mergePr(repo, pr) {
     const result = await run('gh', ['pr', 'merge', String(pr), '--squash', '--delete-branch', '--repo', slug(repo)], { cwd: repo.root });
     return result.code === 0;
 }
+export async function prConflicts(repo, pr, options, clock = REAL_CLOCK) {
+    const deadline = clock.now() + options.timeoutMs;
+    for (;;) {
+        const mergeable = (await gh(repo, ['pr', 'view', String(pr), '--json', 'mergeable', '--jq', '.mergeable'])).trim();
+        const rest = deadline - clock.now();
+        if (mergeable !== 'UNKNOWN' || rest <= 0) {
+            return mergeable === 'CONFLICTING';
+        }
+        await clock.sleep(Math.min(options.intervalSeconds * 1000, rest));
+    }
+}
 export async function prMerged(repo, pr) {
     return ((await gh(repo, ['pr', 'view', String(pr), '--json', 'state', '--jq', '.state'])).trim() ===
         'MERGED');
@@ -352,6 +363,9 @@ export async function mergeCommit(repo, pr, options, clock = REAL_CLOCK) {
 export async function reopenIssue(repo, issue) {
     await gh(repo, ['issue', 'reopen', String(issue)]);
 }
+export async function commentOnIssue(repo, issue, body) {
+    await ghOnce(repo, ['issue', 'comment', String(issue), '--body-file', '-'], body);
+}
 export async function commentOnPr(repo, pr, body) {
     await ghOnce(repo, ['pr', 'comment', String(pr), '--body-file', '-'], body);
 }

package/dist/pipeline.mjs

@@ -2,7 +2,7 @@ import { CODING, REVIEWING, runAgent } from './agents.mjs';
 import { managedLabels } from './config.mjs';
 import { run } from './exec.mjs';
 import { addWorktree, branchName, commitAll, deleteBranch, diff, discardChanges, disputeBranches, findWorktree, HookError, isDirty, push, removeWorktree, resetToBase, revision, setAside, } from './git.mjs';
-import { commentOnPr, createPr, failedBaseLogs, failedCheckLogs, findPr, issueComments, markPrReady, mergeCommit, mergePr, openBlockers, openIssues, prMerged, reopenIssue, setLabel, viewIssue, waitForBaseChecks, waitForChecks, } from './github.mjs';
+import { commentOnIssue, commentOnPr, createPr, failedBaseLogs, failedCheckLogs, findPr, issueComments, markPrReady, mergeCommit, mergePr, openBlockers, openIssues, prConflicts, prMerged, reopenIssue, setLabel, viewIssue, waitForBaseChecks, waitForChecks, } from './github.mjs';
 import { message } from './observe.mjs';
 import { capDiff, fixPrompt, hookPrompt, implementPrompt, parseCommitSubject, parseUnrelated, reviewPrompt, } from './prompts.mjs';
 import { detectSetupCommand } from './setup.mjs';
@@ -10,6 +10,7 @@ import { dropState, readState, resetState, savedIssues, writeState, } from './st
 import { blockingFindings, fingerprint, formatFindings, formatVerdict, openFindings, readVerdict, VERDICT_SCHEMA, } from './verdict.mjs';
 export const PORTS = {
     addWorktree,
+    commentOnIssue,
     commentOnPr,
     commitAll,
     createPr,
@@ -29,6 +30,7 @@ export const PORTS = {
     mergePr,
     openBlockers,
     openIssues,
+    prConflicts,
     prMerged,
     push,
     removeWorktree,
@@ -292,6 +294,14 @@ async function checkGate(job) {
         await escalate(job, 'The checks did not finish in time.');
         return { done: true, report: await finish(job, 'needs-human', 'checks timeout') };
     }
+    if (checks === 'none' &&
+        (await ports.prConflicts(repo, state.pr, {
+            intervalSeconds: config.checkIntervalSeconds,
+            timeoutMs: config.checkTimeoutMinutes * 60_000,
+        }))) {
+        await escalate(job, 'The pull request conflicts with its base, so no checks ran.');
+        return { done: true, report: await finish(job, 'needs-human', 'merge conflict') };
+    }
     if (checks !== 'fail') {
         return { done: false, fixed: false };
     }
@@ -607,8 +617,12 @@ async function handOver(context, log, issue, state, reason) {
     log.event('hand-over', { reason }, 'quiet');
     await writeState(context.repo, state);
     await setStatus(context, issue, state.pr, context.config.labels.needsHuman);
-    if (state.pr !== undefined) {
-        await context.ports.commentOnPr(context.repo, state.pr, `next-issue needs help: ${reason}`);
+    const body = `next-issue needs help: ${reason}`;
+    if (state.pr === undefined) {
+        await context.ports.commentOnIssue(context.repo, issue, body);
+    }
+    else {
+        await context.ports.commentOnPr(context.repo, state.pr, body);
     }
 }
 async function setStatus(context, issue, pr, label) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "next-issue",
-  "version": "2.4.6",
+  "version": "2.4.8",
   "description": "Autonomous issue harness driven by the pi SDK",
   "keywords": [
     "github",