next-issue 0.7.0 → 0.8.0

package/README.md

@@ -50,6 +50,10 @@ when:
 
 - the check budget or the review budget runs out;
 - a fixer round adds no commit, so there is no progress;
+- the fixer reports that the checks fail for a reason the change did not cause,
+   such as a test already broken on the base branch or one that fails only under
+   load. It changes nothing and the reason reaches the pull request, rather than
+   the fixer spending its whole budget on a failure it cannot fix;
 - the reviewer repeats a finding set from an earlier round, which shows a
    ping-pong between the fixer and the reviewer;
 - the reviewer gives no verdict, or the checks do not finish in time;

package/dist/pipeline.mjs

@@ -4,7 +4,7 @@ import { run } from "./exec.mjs";
 import { addWorktree, branchName, commitAll, diff, hasWorktree, push, removeWorktree, worktreePath, } from "./git.mjs";
 import { assignIssue, commentOnPr, createPr, failedCheckLogs, findPr, issueComments, markPrReady, setLabel, waitForChecks, } from "./github.mjs";
 import { message } from "./observe.mjs";
-import { capDiff, fixPrompt, implementPrompt, parseCommitSubject, reviewPrompt } from "./prompts.mjs";
+import { capDiff, fixPrompt, implementPrompt, parseCommitSubject, parseUnrelated, reviewPrompt, } from "./prompts.mjs";
 import { readState, writeState } from "./state.mjs";
 import { blockingFindings, fingerprint, formatFindings, formatVerdict, isApproved, readVerdict, VERDICT_SCHEMA, } from "./verdict.mjs";
 export const PORTS = {
@@ -172,10 +172,16 @@ async function work(context, issue, log, state) {
         await writeState(repo, state);
         const logs = await ports.failedCheckLogs(repo, branch, config.logMaxChars);
         log.event("checks.logs", { chars: logs.length });
-        const committed = await fixRound(job, "The continuous integration checks failed.", logs, history(state.reviewLog));
-        if (!committed) {
-            await escalate("The fixer added no commit for the failed checks.");
-            return { done: true, report: await finish("needs-human", "no fix commit") };
+        const fix = await fixRound(job, "The continuous integration checks failed.", logs, history(state.reviewLog), "checks");
+        if (!fix.committed) {
+            const note = fix.unrelated;
+            await escalate(note === undefined
+                ? "The fixer added no commit for the failed checks."
+                : `The checks fail for a reason this change did not cause: ${note}`);
+            return {
+                done: true,
+                report: await finish("needs-human", note === undefined ? "no fix commit" : "unrelated failure"),
+            };
         }
         return { done: false, fixed: true };
     };
@@ -248,32 +254,37 @@ async function work(context, issue, log, state) {
         const earlier = history(state.reviewLog);
         state.reviewLog.push({ round: state.reviewRounds, fingerprint: mark, findings: formatFindings(blocking) });
         await writeState(repo, state);
-        const committed = await fixRound(job, "The reviewer requested changes.", formatFindings(blocking), earlier);
-        if (!committed) {
+        const fix = await fixRound(job, "The reviewer requested changes.", formatFindings(blocking), earlier, "review");
+        if (!fix.committed) {
             await escalate("The fixer added no commit for the review findings.");
             return finish("needs-human", "no fix commit");
         }
     }
 }
-async function fixRound(job, reason, detail, earlier) {
+async function fixRound(job, reason, detail, earlier, kind) {
     const { context, issue, log, worktree, branch } = job;
     const { ports } = context;
     const result = await log.step("fix", { reason }, () => ports.runAgent(log, {
         name: "fixer",
         cwd: worktree,
-        prompt: fixPrompt(issue, reason, detail, earlier),
+        prompt: fixPrompt(issue, reason, detail, earlier, kind),
         profile: CODING,
         model: context.config.models.fixer,
         timeoutMs: context.config.agentTimeoutMinutes * 60_000,
     }));
+    const unrelated = parseUnrelated(result.text);
+    if (unrelated !== undefined) {
+        log.event("fix.unrelated", { reason, note: unrelated }, "quiet");
+        return { committed: false, unrelated };
+    }
     const subject = parseCommitSubject(result.text, `fix: address feedback on issue #${issue.number}`);
     if (!(await ports.commitAll(worktree, `${subject}\n\nRefs #${issue.number}`))) {
         log.event("commit.empty", { reason }, "quiet");
-        return false;
+        return { committed: false };
     }
     log.event("commit", { subject });
     await ports.push(worktree, context.config.remote, branch);
-    return true;
+    return { committed: true };
 }
 async function cleanUp(context, log, issue) {
     const path = worktreePath(context.repo, issue);

package/dist/prompts.mjs

@@ -49,7 +49,12 @@ export function reviewPrompt(issue, comments, diff, round, earlier) {
         "Give the result as the structured output: the verdict, a short summary and one entry per finding.",
     ].join("\n\n");
 }
-export function fixPrompt(issue, reason, detail, earlier) {
+const UNRELATED_RULE = [
+    "The checks can fail for a reason this change did not cause: a test that is already broken on the base branch, one that exercises code the diff does not touch, or one that fails only under load.",
+    "Establish that before you fix anything. If the failure is not yours, change nothing and end your final message with one line in the form `unrelated: <one sentence on what fails and why it is not this change>`.",
+    "A person then reads it. Do not weaken, skip or re-record a test to make the checks pass.",
+].join("\n");
+export function fixPrompt(issue, reason, detail, earlier, kind) {
     return [
         `You are the fixer. Correct the work for issue #${issue.number}: ${issue.title}.`,
         `## Reason\n${reason}`,
@@ -63,11 +68,17 @@ export function fixPrompt(issue, reason, detail, earlier) {
             : "",
         "## Rules",
         "Fix the cause, not the symptom. Keep the change minimal.",
+        kind === "checks" ? UNRELATED_RULE : "",
         COMMIT_RULES,
     ]
         .filter((part) => part.length > 0)
         .join("\n\n");
 }
+export function parseUnrelated(text) {
+    const match = /^unrelated:\s*(.+)$/im.exec(text);
+    const note = match?.[1]?.trim();
+    return note !== undefined && note.length > 0 ? note : undefined;
+}
 export function parseCommitSubject(text, fallback) {
     const match = /^commit:\s*(.+)$/im.exec(text);
     const subject = match?.[1]?.trim();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "next-issue",
-  "version": "0.7.0",
+  "version": "0.8.0",
   "description": "Autonomous issue harness driven by the Claude Agent SDK",
   "keywords": [
     "github",