next-issue 0.12.0 → 0.12.2

package/README.md

@@ -43,8 +43,11 @@ For each open issue, oldest first:
    reviewer reads files and runs commands in the worktree, so it can prove a
    finding with the tests or the type check. The harness then throws away every
    change that the reviewer left, so no such change can reach a later commit.
-   The reviewer returns a structured verdict that rates each finding `blocking`
-   or `minor`. The harness puts the result on the pull request.
+   The reviewer returns a structured verdict: a summary and one entry per
+   finding, each rated `blocking` or `minor`. The findings are the only ground
+   truth. The reviewer gives no approve or reject field, because such a field
+   can contradict the findings. The harness puts the result on the pull
+   request.
 9. An open finding is any finding, blocking or minor, while a review round is
    left. In the last round, only a blocking finding stays open: a minor finding
    there goes on the pull request but starts no fix, because a fix in the last
@@ -52,8 +55,9 @@ For each open issue, oldest first:
    finding.
 10. No open finding means approval: mark the pull request ready for review and
     set `status:done`. The merge stays with you. The worktree, the local branch
-    and the state file go away. The remote branch stays. An open finding always
-    stops the approval, even when the reviewer also says approve.
+    and the state file go away. The remote branch stays. A problem that the
+    reviewer leaves out of the findings thus gets an approval: only the findings
+    count.
 11. With an open finding, run the fixer agent and go to step 6 again. The
     budget is `maxReviewRounds`.
 
@@ -85,9 +89,10 @@ only between two issues, finishes the issue that it holds, deletes the file and
 then writes the summary as usual. A file from an earlier run is dropped at the
 start, so it stops nothing.
 
-`Ctrl-C` is different: the terminal signals every child too, so the run dies in
-the middle of a step. The saved state lets the next run continue the issue, but
-the issue keeps `status:in-progress` and the run writes no summary.
+`Ctrl-C` is different: the harness passes the signal on to the command that runs
+and to every child of it, so the run dies in the middle of a step. The saved
+state lets the next run continue the issue, but the issue keeps
+`status:in-progress` and the run writes no summary.
 
 Every status label that the harness puts on the issue goes on the pull request
 too, from the first review round. Thus a draft pull request shows work that the

package/dist/exec.mjs

@@ -2,6 +2,41 @@ import { spawn } from "node:child_process";
 let observer;
 let defaultTimeoutMs = 10 * 60_000;
 const STDERR_TAIL = 200_000;
+const groups = new Set();
+function forward(signal) {
+    for (const pid of groups) {
+        try {
+            process.kill(-pid, signal);
+        }
+        catch { }
+    }
+    groups.clear();
+    process.off("SIGINT", onInterrupt);
+    process.off("SIGTERM", onTerminate);
+    process.kill(process.pid, signal);
+}
+const onInterrupt = () => forward("SIGINT");
+const onTerminate = () => forward("SIGTERM");
+function watch(pid) {
+    if (pid === undefined) {
+        return;
+    }
+    if (groups.size === 0) {
+        process.on("SIGINT", onInterrupt);
+        process.on("SIGTERM", onTerminate);
+    }
+    groups.add(pid);
+}
+function unwatch(pid) {
+    if (pid === undefined) {
+        return;
+    }
+    groups.delete(pid);
+    if (groups.size === 0) {
+        process.off("SIGINT", onInterrupt);
+        process.off("SIGTERM", onTerminate);
+    }
+}
 export function setCommandObserver(next) {
     observer = next;
 }
@@ -14,12 +49,15 @@ export function run(command, args, options = {}) {
     return new Promise((resolve, reject) => {
         const child = spawn(command, args, {
             cwd: options.cwd,
+            detached: true,
             stdio: [
                 options.input === undefined ? "ignore" : "pipe",
                 options.show === true ? 2 : "pipe",
                 "pipe",
             ],
         });
+        const pid = child.pid;
+        watch(pid);
         let stdout = "";
         let stderr = "";
         let timedOut = false;
@@ -40,11 +78,21 @@ export function run(command, args, options = {}) {
         });
         const timer = setTimeout(() => {
             timedOut = true;
-            child.kill("SIGKILL");
+            if (pid === undefined) {
+                child.kill("SIGKILL");
+                return;
+            }
+            try {
+                process.kill(-pid, "SIGKILL");
+            }
+            catch {
+                child.kill("SIGKILL");
+            }
         }, limit);
         let done = false;
         const settle = (code) => {
             clearTimeout(timer);
+            unwatch(pid);
             if (done) {
                 return;
             }
@@ -63,6 +111,7 @@ export function run(command, args, options = {}) {
         };
         child.on("error", (error) => {
             clearTimeout(timer);
+            unwatch(pid);
             done = true;
             reject(error);
         });

package/dist/pipeline.mjs

@@ -245,7 +245,6 @@ async function work(context, issue, log, state) {
         const open = openFindings(verdict, state.reviewRounds >= config.maxReviewRounds);
         log.event("verdict", {
             round: state.reviewRounds,
-            verdict: verdict.verdict,
             blocking: blocking.length,
             minor: verdict.findings.length - blocking.length,
             open: open.length,

package/dist/prompts.mjs

@@ -48,7 +48,7 @@ export function reviewPrompt(issue, comments, diff, earlier) {
         "The harness discards each change that you make, so a change is only lost work.",
         scope,
         "Mark a finding blocking only for a wrong result, a missing part of the issue, a regression or a broken convention.",
-        "Give the result as the structured output: the verdict, a short summary and one entry per finding.",
+        "Give the result as the structured output: a short summary and one entry per finding. The findings decide the outcome, so a problem that you leave out counts as no problem.",
     ].join("\n\n");
 }
 const UNRELATED_RULE = [

package/dist/verdict.mjs

@@ -1,11 +1,6 @@
 export const VERDICT_SCHEMA = {
     type: "object",
     properties: {
-        verdict: {
-            type: "string",
-            enum: ["approve", "request_changes"],
-            description: "approve when no blocking problem is left",
-        },
         summary: { type: "string", description: "Short summary of the review" },
         findings: {
             type: "array",
@@ -24,18 +19,14 @@ export const VERDICT_SCHEMA = {
             },
         },
     },
-    required: ["verdict", "summary", "findings"],
+    required: ["summary", "findings"],
 };
 const SEVERITIES = ["blocking", "minor"];
-const VERDICTS = ["approve", "request_changes"];
 export function readVerdict(value) {
     if (typeof value !== "object" || value === null) {
         return undefined;
     }
-    const { verdict, summary, findings } = value;
-    if (typeof verdict !== "string" || !VERDICTS.includes(verdict)) {
-        return undefined;
-    }
+    const { summary, findings } = value;
     if (typeof summary !== "string" || !Array.isArray(findings)) {
         return undefined;
     }
@@ -50,7 +41,7 @@ export function readVerdict(value) {
         }
         checked.push({ severity: severity, detail });
     }
-    return { verdict: verdict, summary, findings: checked };
+    return { summary, findings: checked };
 }
 export function blockingFindings(verdict) {
     return verdict.findings.filter((finding) => finding.severity === "blocking");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "next-issue",
-  "version": "0.12.0",
+  "version": "0.12.2",
   "description": "Autonomous issue harness driven by the Claude Agent SDK",
   "keywords": [
     "github",